Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Owen Leonard	8220aa14f9	Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	9cb89b4639	Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 This patch updates the version of Bootstrap in the OPAC from 2.3.1 to 4.5.0. The Bootstrap JavaScript files have been replaced with custom builds of the 4.5.0 JavaScript source files. The Bootstrap CSS is now built into the OPAC CSS by loading the required Bootstrap 4.5.0 SCSS files in node_modules. OPAC SCSS now starts with Bootstrap customizations: /* Bootstrap variable customizations / $headings-color: #727272; ... Followed by loading the necessary Bootstrap SCSS files: / Bootstrap imports */ @import "../../../../../node_modules/bootstrap/scss/functions"; @import "../../../../../node_modules/bootstrap/scss/variables"; ... Followed by our CSS. The build process for generating compiled CSS now creates a file which bundles Bootstrap CSS and ours. Removed from the Koha source: Bootstrap CSS files, Bootstrap "glyphicons" images. The upgrade to Bootstrap 4 involved a lot of markup changes to conform with new Bootstrap classes, especially in classes related to the grid. Besides duplicating the grid we used before, this upgrade adds some new features made possible by Bootstrap 4.5's use of flexbox as a layout tool. This includes custom ordering of columns based on class names: https://getbootstrap.com/docs/4.5/layout/grid/#order-classes. Other areas where the most changes have been made: Navigation menus, breadcrumb menus, buttons, dropdowns. Bootstrap's JavaScript file is now "bootstrap.bundle.min.js" to reflect the fact that a required JavaScript asset is now distributed separately in Bootstrap 4. The "bundle" version includes Popper.js. Unrelated changes: Indentation corrections, removal of invalid "//<![CDATA[" markers, removal of invalid script type attributes. To test, apply the patch and run 'yarn install' to install Bootstrap as an npm module. Run 'yarn build --view opac' to regenerate the OPAC CSS. Test as many aspect of the OPAC as possible, viewing pages at various browser widths to confirm that everything adjusts well. Test with various OPAC interface system preferences enabled and disabled. Test self checkout and self checkin. Known issues: RTL support has not been updated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	5d69ae18b5	Bug 26004: Remove unused jQuery plugin jquery.hoverIntent.minified.js from the OPAC The jQuery plugin jquery.hoverIntent.minified.js hasn't been used in Koha in long time. This patch removes it from the OPAC. To test, apply the patch and search for instances of "hoverIntent." There should be none. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	7c100a7fd2	Bug 26011: Remove unused jQuery plugin jquery.metadata.min.js from the OPAC The jQuery plugin jquery.metadata.min.js hasn't been used in Koha in long time. This patch removes it from the OPAC. To test, apply the patch and search for instances of "jquery.metadata." There should be none. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Agustin Moyano	d298ab457e	Bug 24455: Add moment-timezone library in opac This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js in order to use the moment library with timezones (https://momentjs.com/timezone/) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Agustin Moyano	e762264835	Bug 24455: Add moment library in opac This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use the moment library (https://momentjs.com/) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Owen Leonard	de75e9a91c	Bug 23903: Font Awesome upgrade The switch to Font Awesome for more icons in the OPAC doesn't require a Font Awesome upgrade but this is a good chance to do it. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martin Renvoize	182e64b864	Bug 14862: (follow-up) Add minified version of jQuery 3.4.1 This patch updates the file 'jquery-3.4.1.min.js' so that it is indeed minified. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Owen Leonard	8b1fb387ac	Bug 14862: Upgrade jQuery from 1.7 to 3.4.1 in OPAC This patch upgrades jQuery to 3.4.1, jQuery-UI to 1.12.1, and adds the jQuery-migrate plugin to ensure backwards-compatibility with existing jQuery plugins and code. An updated of jquery-ui-rtl.css has been created by converting the new version of jquery-ui.css. All jQuery assets are now include the version number in the file name just as we now do in the staff client. Besides updating file names in the templates, there was only one change made: opac-results.tt had a typo which has been corrected. To test, apply the patch and test as many different pages in the OPAC as possible, including self-checkout and self checkin. Keep the browser console open and watch for JavaScript errors. All JavaScript-driven behavior should work correctly. For instance: - Tabs - Datepickers - Select all/none operations - Cart and lists popups - Search result highlighting Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Owen Leonard	ef248b82d7	Bug 10659: Upgrade jQuery star ratings plugin This patch replaces our current jQuery star ratings plugin with a newer plugin which will be compatible with newer versions of jQuery: http://antenna.io/demo/jquery-bar-rating/examples/ To test you should have one or more records in your catalog with star ratings. - Apply the patch and set the OpacStarRatings system preference to "results and details" - Perform a search in the catalog which will return one or more titles which have ratings. - Confirm that the ratings appear correctly and the ratings are read-only. - Open the "normal" detail page for that record. - Confirm that the star rating appears correctly. - Test setting and re-setting your star rating. Confirm that it is saved. - Confirm that the "cancel rating" link appears when you have a rating set, and that it disappears after you click it. - Test that the "only details" and disabled options of the OpacStarRatings preference work as they should. - Confirm that information about the plugin appears on the About page in the staff client, replacing the old star ratings plugin information. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Owen Leonard	2497ef5f0a	Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Kyle Hall	3e153d46ee	Bug 13696: Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Juhani Seppälä	ab1fd8a556	Bug 5685: Validation of email address field This patch adds server-side & client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, "Library use", "Alternate address", "Alternative contact"). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard <oleonard@myacpl.org> I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	10 years ago
simith	793d243dfa	Bug 13307: Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
simith	f94d4526e5	Bug 13307: Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	2e4b574074	Bug 5844: Avoid strings cut on unhighlighing If a user is searching for several words and that one is contained in another ( "mag ma" ), some characters are cut (removed from the DOM!). To reproduce: 1/ search for "mag ma m" 2/ The result page contains "Magazine" 3/ "Mag" is highlighted 4/ Click on the "Unhighlight" link 5/ The "Magazine" words become "azine", "Mag" has been cut. There is no way to show these characters again. Test plan: 1/ Confirm the bad behavior without this patch 2/ Apply this patch 3/ search for "mag ma m" 4/ The result page contains "Magazine" 5/ "Mag" is highlighted 6/ Click on the "Unhighlight" link 7/ strings are unhighlighted and still in the DOM :) Note that the Highlight link won't work very well (only "a" will be highlighted, but considered as minor since this did not work before the patch neither). Followed test plan. Strings are no longer cut when unhiglighted. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Owen Leonard	d3c565f12c	Bug 11743 - Remove unused DataTables plugin from OPAC theme directories The Bootstrap and CCSR theme directories contain older copies of the DataTables plugin which is no longer in use. This patch removes them both. To test, apply the patch and confirm that DataTables still work on the following pages in both the Bootstrap and CCSR OPAC themes: - The Cart. Add items to the Cart, open it and confirm that the table is sorted correctly. - The detail page: View the detail page for a title (opac-detail.pl) with multiple items and confirm that the table of items is sorted correctly. - A subscription's "full history" page: Navigate to the detail page of a subscription in your catalog which has received multiple issues. From the subscriptions tab click the "More details" link, then the "Full history" link. Confirm that the table of issues is sorted correctly. - Search history: Enable the EnableOpacSearchHistory system preference. Perform a few searches so that your current session will record them. View the search history page and confirm that the tables of current and past searches are sorted correctly. - Suggestions (enable 'suggestion' system pref if necessary) - Tags (enable TagsEnabled if necessary) - Most popular (enable OpacTopissue if necessary) - User summary (opac-user.pl): Checkouts, overdues, and holds tables should all sort correctly. - Self checkout: Enable WebBasedSelfCheck if necessary. Check out as a patron who has multiple existing checkouts. Confirm that the table is sorted correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Existing uses of datatables.min.js don't point to the theme directory. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Jonathan Druart	166720982e	Bug 11616: remove jQuery tablesorter plugin DataTables has replaced the tablesorter plugin for client-side sorting of tables in Koha. There is no table using this plugin, so this patch removes it and remaining references to it. REVISED TEST PLAN ----------------- 1) Apply the patch 2) Home -> Koha administration -> Authorized values 3) Change the 'Show category:' drop down value, and play with the sorting of columns. -- should sort as expected. 4) Search the catalogue -> look for a biblio with high circulation 5) Click one of the name links. 6) Click the Items tab on the left. 7) Scroll down and click the (View item's checkout history) link in the History area. -- There was no sorting prior to the patch, so afterwards it should display the same. 8) git grep -i tablesorter -- Only a reference in staff-global.css and release texts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	9d7d3085ec	Bug 11060: (Bootstrap theme) fix incorrect rendering for right to left languages The right-to-left CSS copied over from the prog theme does is not relevant to the redesigned templates. This patch updates the OPAC's right-to-left CSS and adds a couple of other right-to-left CSS files to override the default Bootstrap and jQueryUI CSS. To my eye this looks correct, but I don't speak Arabic. To test you must have a set of right-to-left templates, like ar-Arab, installed for the Bootstrap theme. At this time it is necessary to download the po file to your misc/translator/po directory. Again using ar-Arab as an example: http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po Install the translation. Open the OPAC, switch to that right-to-left language, and reload to refresh the changed CSS. Confirm that it looks like right-to-left is working. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> As far as I can tell it looks very well. No koha-qa errors 1) Downloaded arabic bootstrap PO 2) Installed ar-Arab language, enabled on OPAC 3) Tested as anonymous user and logged in one, all pages look well: cart, advanced search, user tabs. I sent an email to Karam Qubsi asking his opinion. But for me it's ok Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I was testing this at the same time as Bernardo, so I will Pass QA on it, instead of signing it off Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	eb92d94be1	Bug 10309 - New OPAC theme based on Bootstrap The goal of this theme is to provide a fully-responsive OPAC which offers a high level of functionality across multiple devices with varied viewport sizes. Its style is based on the CCSR theme, with elements of the Bootstrap framework providing default styling of buttons, menus, modals, etc. The Bootstrap grid is used everywhere, but Bootstrap's default responsive breakpoints have been expanded to allow for better flexibility for our needs. All non-translation-depended files are in the root directory of this new theme: css, images, itemtypeimg, js, less, and lib. Languages.pm has been modified to ignore the new directories when parsing the theme language directories. This theme introduces the use of LESS (http://lesscss.org/) to build CSS. Three LESS files can be found in the "less" directory: mixins.less, opac.less, and responsive.less. These three files are compiled into one CSS file for production: opac.css. "Base" theme styles are found in opac.less. A few "mixins" (http://lesscss.org/#-mixins) are found in mixins.less. Any CSS which is conditional on specific media queries is found in responsive.less. At the template level some general sturctural changes have been made. For the most part JavaScript is now at the end of each template as is recommended for performance reasons. JavaScript formerly in doc-head-close.inc is now in opac-bottom.inc. In order to be able to maintain this structure and accommodate page-specific scripts at the same time the use of BLOCK and PROCESS are added. By default opac-bottom.inc will PROCESS a "jsinclude" block: [% PROCESS jsinclude %] Each page template in the theme must contain this block, even if it is empty: [% BLOCK jsinclude %][% END %] Pages which require that page-specific JavaScript be inserted can add it to the jsinclude block and it will appear correctly at the bottom of the rendered page. The same is true for page-specific CSS. Each page contains a cssinclude block: [% BLOCK cssinclude %][% END %] ...which is processed in doc-head-close.inc: [% PROCESS cssinclude %] Using these methods helps us maintain a strict separation of CSS links and blocks (at the top of each page) and JavaScript (at the bottom). A few exceptions are made for some JavaScript which must be processed sooner: respond.js (https://github.com/scottjehl/Respond, conditionally applied to Internet Explorer versions < 9 to allow for layout responsiveness), the _() function required for JS translatability, and Modernizr (http://modernizr.com/, a script which detects browser features and allows us to conditionally load JavaScript based on available features--or lack thereof). Another new JavaScript dependency in this theme is enquire.js (http://wicky.nillia.ms/enquire.js/), which lets us trigger JavaScript events based on viewport size. I have made an effort to re-indent the templates in a sane way, eliminating trailing spaces and tabs. However, I have not wrapped lines at a specific line length. In order to improve template legibility I have also tried to insert comments indicating the origin of closing tags like <div> or template directives like [% END %]: </div> <!-- / .container-fluid --> [% END # / IF ( OpacBrowseResults && busc ) %] TESTING Proper testing of this theme is no easy task: Every template has been touched. Each page should work reasonable well at a variety of screen dimensions. Pages should be tested under many conditions which are controlled by toggling OPAC system preferences on and off. A variety of devices, platforms, and browsers should be tested. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago

20 Commits (62848497033c601ea928890f903acf32c72d08d2)