Commit graph

5634 commits

Author SHA1 Message Date
Nicole C. Engard
62a23201c3 Bug 7936: 3.8 Help Files
These are the three help files that do not belong in any
specific directory. Links updated to the 3.8 manual.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-04-13 16:12:23 +02:00
468995e4b3 Bug 5345 [FOLLOW-UP] DataTables in Koha
Adding missing images: The "disabled" version of the next,
previous, first, and last buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-13 15:44:24 +02:00
Katrin Fischer
3e82127fb8 Bug 2034: Removing unused scripts billig.pl/billing.tt
- Scripts are currently not linked from anywhere in the templates
- Functionality can also be achieved with a custom report
- There are unresolved problems with the sql in the existig scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-12 18:09:54 +02:00
430f0ea6ba Bug 7940 - Placing a hold on a single item from the staff cart causes errors
This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.

When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.

In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).

There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
   switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )

This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertised. Good catch!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-12 17:58:49 +02:00
Katrin Fischer
d55cde8ae5 Bug 7834: order search at the top of acq does nothing
Entering a search term for 'title' or 'vendor' at the top search
form in acq (tab 'Orders search') did redirect to the advanced
search form, but didn't start the search.

After applying the patch the search will bring back results immediately
or redirect to the form, when there are no results.

To test:
- Check all searches still work as expected by searching for title,
vendor, order name and invoice number
- Check advanced search still has the search terms prepopulated
- Check searches with and without results are ok

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-12 17:14:52 +02:00
Paul Poulain
5d4d33b22d Merge remote-tracking branch 'origin/new/bug_2780' 2012-04-11 09:34:48 +02:00
93ccaaf690 Bug 2780 [FOLLOW-UP] Capitalize strings consistently
Changes to the case of some hidden input values prevented
the user from being able to save a new SQL report.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, can now save sql reports.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-11 09:34:27 +02:00
Paul Poulain
61d9d098e9 Updating euskara and french translation teams 2012-04-10 16:13:37 +02:00
Katrin Fischer
47fac215af Bug 7935: Introduce sys pref to control 'browse results' in OPAC
Patch introduces a new system preference "OpacBrowseResults" to control
the feature for browsing and paging through results shown on top of the
left menu on detail pages in OPAC.

Preference is activated by default and can be deactivated using the
system preference.

To test:
 - Check database update works correctly
 - Check that browsing and paging still works with after database update
 - Deactivate the feature by setting 'OpacBrowseResults' to 'Disable'
 - Check the feature does no longer show up in OPAC
 - Check that a new installation also has the system preference with correct default

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-04-10 15:26:37 +02:00
Paul Poulain
d8bac226cc Bug 5668 follow-up: removing empty lines in opac.pref
Those lines where introduced by this patch
2012-04-10 14:58:32 +02:00
7eef4c8c70 Bug 5668 - Star ratings in the opac
patch applied to commit eb3dc448d2

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 14:40:49 +02:00
Katrin Fischer
bd52531d69 Bug 7900: Link to vendor from subscription detail is broken
To test:
- Add a serial subscription with a link to a vendor
- Check the subscription detail page for the name and link to the vendor
- Check that the link works correctly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:35:18 +02:00
Katrin Fischer
bdf3453512 Bug 2780 - Capitalize strings consistently (home, about, login)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:10:02 +02:00
Paul Poulain
0ffd765824 Merge remote-tracking branch 'origin/new/bug_2780' 2012-04-10 10:32:48 +02:00
Katrin Fischer
3213b34082 [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some strings:
* itemcallnumber => item call number
* Profile marcfields=> Profile MARC fields
2012-04-10 10:18:54 +02:00
Katrin Fischer
db4af00ce1 [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some vocabulary replacing "shelf" by "list"
2012-04-10 10:16:41 +02:00
Katrin Fischer
55756fc0fb [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 10:16:05 +02:00
Katrin Fischer
189c0875c1 [SIGNED-OFF]Bug 2780: Capitalize strings consistently
Fixes some more strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 10:13:20 +02:00
Katrin Fischer
b89da29e01 [SIGNED-OFF]Bug 2780: Capitalize strings consistently
Some missing strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 10:12:37 +02:00
Paul Poulain
8e9fc9b385 Merge remote-tracking branch 'origin/new/bug_2780' 2012-04-10 10:04:51 +02:00
Katrin Fischer
0e5b3f3df3 Bug 2780 - Capitalize strings consistently - various
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:16 +02:00
Katrin Fischer
07eeb4b187 Bug 2780 - Capitalize strings consistently (serials)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:15 +02:00
Katrin Fischer
12e4651746 Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:13 +02:00
Katrin Fischer
892d64aa6c Bug 2780 - Capitalize strings consistently (patron cards)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:12 +02:00
Katrin Fischer
968d2b4954 Bug 2780 - Capitalize strings consistently (offline circulation)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:11 +02:00
Katrin Fischer
bae9aacb3f Bug 2780 - Capitalize strings consistently (members)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:09 +02:00
Katrin Fischer
2caaf07450 Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:08 +02:00
Katrin Fischer
4de45e4309 Bug 2780 - Follow up - Capitalize strings consistently (Admin pages)
Fixes some missed strings.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:06 +02:00
643c80663d Bug 2780 - Capitalize strings consistently (Labels templates)
Correcting capitalization in Labels templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:53 +02:00
151d57330c Bug 2780 - Capitalize strings consistently (Labels help)
Correcting capitalization in Labels help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:52 +02:00
651e81e677 Bug 2780 - Capitalize strings consistently (Misc. help pages)
Correcting capitalization in various help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:50 +02:00
da51d835cb Bug 2780 - Capitalize strings consistently (Circulation help)
Correcting capitalization in Circulation help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:48 +02:00
95fe4e8453 Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help)
Correcting capitalization in Authorities and Cataloging help pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:46 +02:00
f2da059165 Bug 2780 - Capitalize strings consistently (Admin help)
Correcting capitalization in Administration help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:37 +02:00
a32ca9d525 Bug 2780 - Capitalize strings consistently (Acqui help)
Correcting capitalization in Acquisitions help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:35 +02:00
c0401d62aa Bug 2780 - Capitalize strings consistently (Installer)
Correcting capitalization in Installer templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:33 +02:00
f38ae56b8f Bug 2780 - Capitalize strings consistently (Error pages)
Correcting capitalization in staff client error pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:32 +02:00
00a13c5725 Bug 2780 - Capitalize strings consistently (Circulation)
Correcting capitalization in Circulation templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:30 +02:00
c9f5ba7e8c Bug 2780 - Capitalize strings consistently (Cataloging pages)
Correcting capitalization in Cataloging templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:29 +02:00
08f4f94801 Bug 2780 - Capitalize strings consistently (Cataloging plugins)
Correcting capitalization in Cataloging plugins. Also
correcting some instances of invalid HTML.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:27 +02:00
7e9533870c Bug 2780 - Capitalize strings consistently (Catalog pages)
Correcting capitalization in the staff client catalog pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:26 +02:00
10f29a1dae Bug 2780 - Capitalize strings consistently (Staff client cart)
Correcting capitalization in the staff client's cart templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:24 +02:00
addb9ed527 Bug 2780 - Capitalize strings consistently (Authorities pages)
Correcting capitalization in Authorities templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:23 +02:00
f3a3d7a42d Bug 2780 - Capitalize strings consistently (Admin pages)
Correcting capitalization in Administration templates.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:21 +02:00
f87085e65e Bug 2733 - Can't print patron account
Changing "print page" link to "print summary." I hope this will
alleviate the suggstion that the option prints the current page.

- Changed "Quick slip" to "Print quick slip" to make it consistent
  with the other options in the menu

- Corrected the case of other text strings as required by
  Bug 2780.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 18:30:35 +02:00
Dobrica Pavlinusic
621d96d668 Bug 6701 - login timeout is in seconds
I checked in C4/Auth and we are using perl time() for comparison with this value.

I also added description of specifying timeout in days which is available in code.

Robin Sheat suggested to document just lowercase d for days option, to reduce
confusion although uppercase D works as days specifier as well.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 18:23:22 +02:00
Paul Poulain
fcfe9b253a Merge remote-tracking branch 'origin/new/bug_7781' 2012-04-06 18:22:19 +02:00
08cee791a7 Bug 7758 - Koha allowing LOST items to check out without alert
Adds a confirmation alert when issuing an item that has
been marked as lost.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertiesd

Tested:
- checking out an item that is marked lost performs all usual lost operations
- checking out an item that is marked lost prompts for confirmation

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 18:08:17 +02:00
Jonathan Druart
9980aa7369 Bug 7897: Move the SocialNetworks syspref to the Opac tab
Original bug is Bug 7470

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 17:52:21 +02:00
d1dc3c0c2e Bug 7641 - Add ability to suspend reserves - Followup
* Switch from C4::Dates to $KohaDates
  * Fix 'Resume All Suspended All Requests'
  * Change button text to follow capitalization rules
  * Change 'requests' to 'holds'

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 17:23:10 +02:00