Commit graph

1867 commits

Author SHA1 Message Date
dafb678b0b Bug 12768: (follow-up) DBRev 17.06.00.019
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-25 16:51:28 -03:00
96a3ee5e06 Bug 19038: DBRev 17.06.00.022
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-25 16:50:34 -03:00
3bf15a5f04 Bug 17381: DBRev 17.06.00.021
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-25 12:14:42 -03:00
c2b9b3f831 Bug 19028: DBRev 17.06.00.020
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-25 12:14:42 -03:00
208500193e Bug 12768: DBRev 17.06.00.019
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-23 12:36:23 -03:00
d637acd08c Bug 12768: DBRev 17.06.00.018
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-20 17:14:35 -03:00
3b04f401b9 Bug 14826: DBRev 17.06.00.017
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-20 17:14:33 -03:00
9416fdca36 Bug 18298: DBRev 17.06.00.016
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-16 09:57:26 -03:00
e078ae12be Bug 19186: DBRev 17.06.00.015
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-13 13:58:20 -03:00
1dba61e933 Bug 15685: DBRev 17.06.00.014
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-11 13:10:32 -03:00
4e872cec54 Bug 16401: DBRev 17.06.00.013
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-11 13:05:36 -03:00
a18b12ea7f Bug 19043: DBRev 17.06.00.012
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-09 16:15:48 -03:00
799293c40f Bug 13766: DBRev 17.06.00.011
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-10-09 16:11:16 -03:00
995fb8c14f Bug 13912: DBRev 17.05.00.010
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-29 17:12:16 -03:00
1c328f3394 Bug 19344: DBRev 17.05.00.009
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-29 16:49:47 -03:00
4270d24338 Bug 6758: DBRev 17.05.00.008
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-19 14:15:23 -03:00
0f9dce409f Bug 10132: DBRev 17.05.00.007
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-19 11:47:31 -03:00
dc60c34476 Bug 18811: DBRev 17.05.00.006
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-12 12:07:43 -03:00
ccac8ba6d3 Bug 18718: DBRev 17.05.00.005
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-01 12:59:58 -03:00
f54a0f902a Bug 16892: DBRev 17.05.00.004
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-08-25 10:58:55 -03:00
83e4adf0ab Bug 18801: DBRev 17.05.00.003 2017-07-06 14:29:03 -03:00
520d1acac8 Bug 18228: DBRev 17.05.00.002
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-07-06 14:28:55 -03:00
6e40ced5c2 Bug 8612: DBRev 17.06.00.001
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-06-05 12:36:13 -03:00
fe22e9d99c Koha 17.06 - unstable (start of a new dev cycle) 2017-06-05 11:35:37 -03:00
5d94ff7513 DBRev 17.05.00.000 2017-05-30 03:14:40 +00:00
2764251be3 Bug 18600 - DBRev 16.12.00.039
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-28 22:21:16 -04:00
1d7ecebfd2 Bug 18663 - DBRev 16.12.00.038
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-28 22:05:48 -04:00
24313d2b8a Bug 17762 - (follow-up) DBRev 16.12.00.033 2017-05-15 14:43:33 -03:00
b8b5989292 Bug 18314 - DBRev 16.12.00.037
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-12 10:59:15 -04:00
e7a197a5e8 Bug 17465 - DBRev 16.12.00.036
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:20:40 +00:00
c6367282da Bug 15705 - DBRev 16.12.00.035
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:16:05 +00:00
115d4f7d2f Bug 15582 - DBRev 16.12.00.034
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:08:06 +00:00
66ec5909ed Bug 17762 - DBRev 16.12.00.033
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 21:01:40 +00:00
7130d55458 Bug 12063 - DBRev 16.12.00.032
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-09 09:16:49 -04:00
ffa361c241 Bug 15108 - DBRev 16.12.00.031
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-08 09:29:38 -04:00
8c1b551b38 Bug 16344 - DBRev 16.12.00.030
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-28 09:28:33 -04:00
b492182b69 Bug 14224 - DBRev 16.12.00.029
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-27 19:10:59 +00:00
e3d8fb0b84 Bug 18110 - DBRev 16.12.00.028
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-28 08:53:00 -04:00
368670cda7 Bug 12461 - DBRev 16.12.00.027
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-27 18:47:25 +00:00
d0a37bb8bf Bug 18427 - DBRev 16.12.00.026
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-21 14:03:42 -04:00
ccd42eee5b Bug 17669 - DBRev 16.12.00.025
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-21 13:59:52 -04:00
d26b0668af Bug 14537 - DBRev 16.12.00.024
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-13 09:14:24 -04:00
b5fa491955 Bug 9988 - DBRev 16.12.00.023
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-12 19:43:20 +00:00
87d1d42f52 Bug 18121: Replace opac_news.new with opac_news.content in notices templates
Bug 17960 replaces opac_news.new with opac_news.content, we can replace
the content of the notices' templates automatically.

Test plan:
Checkout a commit prior to bug 17960. Install a new DB with sample data.
You should have notices with <<opac_news.new>>

Switch to a branch with this patch, on top of master

Execute the updatedatabase.pl sript
=> The notices with opac_news.new should have been replaced with
opac_news.content

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-13 08:24:14 -04:00
a7f2c450de Bug 17866: [QA Follow-up] Change wording of db revision
As Katrin noted on the report, we should not limit the db rev message to
the serial claims only. Applies to acquisision claims too.
Note: Strictly speaking, we could also mention the new ACQORDER notice,
but this will not yet be widely used.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-03 09:50:23 +00:00
Marc Véron
e410967acf Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl
Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl
Missing line:  SetVersion( $DBversion )

This patch inserts the line as appropriate.

To test:
- Apply patch
- Verify code change makes sense
- Verify that upgrade smoothly runs through

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-03 09:13:38 +00:00
0a0fcd31e0 Bug 17866 - DBRev 16.12.00.022
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 13:22:37 +00:00
c77316db40 Bug 17708 - DBRev 16.12.00.021
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 12:38:21 +00:00
767ede853b Bug 17560 - DBRev 16.12.00.020
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 12:12:21 +00:00
6831dd5977 Bug 18173 - DBRev 16.12.00.019
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 11:23:43 +00:00
0fcfc561ad Bug 15498 - DBRev 16.12.00.018
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 11:19:50 +00:00
b7adcf6947 Bug 14146 - DBRev 16.12.00.017
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 10:18:35 +00:00
3db855b872 Bug 13757 - DBRev 16.12.00.016
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-24 18:49:15 +00:00
6fe4de7f5c Fix updatedatabase.pl syntax error 2017-03-23 13:16:24 -03:00
Brendan A Gallagher
eee0020f4a DBREV for Bug 18066 - Hea - Version 2
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2017-03-23 00:18:10 +00:00
Brendan A Gallagher
39f3ed3f10 DBREV for Bug 8010 - Search history can be added to the wrong patron
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2017-03-22 22:16:10 +00:00
5e7a78475a Bug 16530 - DBRev 16.12.00.013
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-03 18:36:55 +00:00
d9069b5b60 Bug 14764 - DBRev 16.12.00.012
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-03 18:30:01 +00:00
50c5708fe8 Bug 17260 - DBRev 16.12.00.011
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-03 16:45:22 +00:00
Blou
77337a2ab5 Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns
The loading of file admin/searchengine/elasticsearch/mappings.yaml
specifies 'type' as empty, which fails with Mysql 5.7+ which is more
stringent.

Also, forcing an empty value into a boolean also fails.

Both issues arise when updatedatabase.pl hit 3.23.00.050.

NOTE: both issues could also be resolved by actually setting values in
      the load file. This doesn't make this solution incorrect, though.

To Test/reproduce:
-1) Happens with Mysql 5.7.4.  Maybe earlier, but certainly at
    that point. Use a Xenial kohadevbox to more easily test.
0) Find a database on 3.22 or earlier, save it.
    a) place
           sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
       into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf
    b) restart you mysql server
    c) drop the db and recreate it
    d) checkout the 3.22.x branch
    e) do a web install
    f) remove the added sql_mode
    g) restart the mysql server
1) Set your code base to master
2) run updatedatabase.pl
3) See the errors on 3.23.00.050
4) Apply the patch
5) Reload the 3.22 db.
   a) repeat steps 0(a)-0(g)
   b) don't forget the caching issues
6) succeed with updatedatabase.pl
7) drop the db and recreate it
8) run the web installer
9) notice no issues either.
10) run koha qa test tools

NOTE: This bug only solved the upgrade portion.
      I added the kohastructure.sql change as well.
      I confirmed that all the code changes were
      triggered with this test plan.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Mehdi Hamidi <mehdi.hamidi@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-03 16:43:00 +00:00
11bae489bc Bug 17216: Fix SQL statement to setting marc_subfield_structure.authorised_value to NULL
We want to update it if it's empty, not equal to ';'
nopaste vim mode is to blame

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-27 11:03:18 +00:00
9a172ac2ef Bug 16034: (followup) Fix DB update and schema files
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-26 16:39:17 +00:00
e9d0337f32 Bug 16034 - DBRev 16.12.00.010
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-21 20:01:17 +00:00
d64e4707ff Bug 17453 - DBRev 16.12.00.009
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-17 17:17:12 +00:00
1d2001803c Bug 15503 - DBRev 16.12.00.008
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-14 15:01:24 +00:00
6abf904bff Bug 17960 - DBRev 16.12.00.007
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-02-06 17:43:47 +00:00
9fe4f3b2ba Bug 17813 - DBRev 16.12.00.006
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-20 14:00:47 +00:00
07626b3b6e Bug 17913 - DBRev 16.12.00.005
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-20 13:58:52 +00:00
2b303129b8 Bug 17914: Do not try and add the updated_on columns to the borrowers and deletedborrowers table
Bug 10459 has been backported and the DB entry (add borrowers.updated_on and
deletedborrower.updated_on) is now played in
  - 16.06.00.027
  - 16.05.00.002
  - 3.22.08.001

This will raise a MySQL warning if the column already exists.
  DBD::mysql::db do failed: Duplicate column name 'updated_on'

Since bug 17234 we have now a subroutine (C4::Installer::column_exists) to test
if a column exists.
When a DB entry modifying the DB structure is backported, it HAS TO check if the
column, constraint or table exists before executing the query.

Test plan:
git checkout 3.22.x (16.05.x or 16.11.x)
install Koha
git checkout master
execute the installer
=> Without this patch you will get a warning when adding borrowers.updated_on)
=> With this patch, you should not get it

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-18 15:22:03 +00:00
c5a758d9a0 Bug 17196 - DBRev 16.12.00.004
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-13 14:00:55 +00:00
46085442e0 Bug 17486 - DBRev 16.12.00.003
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-13 12:35:11 +00:00
a2afebe115 Bug 14187 - DBRev 16.12.00.002
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-13 12:24:39 +00:00
05fdd855c8 Bug 17234: Need to separate KEY and FOREIGN KEY checks
In the previous patch we use the constraint_exists subroutine to verify
if an index or a foreign key exists.
But the `SHOW INDEX` query does not return foreign keys (as its name
suggests!).
We need another subroutine foreign_key_exists to check the FK existence.

I have found that because t/db_dependent/TestBuilder.t fails on
oai_sets_biblios, because oai_sets_biblios_ibfk_1 has not been removed.

Test plan:
0/ Do not apply this patch
1/ Use a 3.20 DB
2/ update the DB
3/ SHOW CREATE TABLE oai_sets_biblios
will display oai_sets_biblios_ibfk_1

Apply the patch and repeat 1, 2, 3
=> Will not display oai_sets_biblios_ibfk_1
It has been removed as expected.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-12 12:43:10 +00:00
0b15c5e2cc Bug 17234: Move new subroutines to C4::Installer
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-11 10:52:10 +00:00
c08922180e Bug 17234: Add constraint_exists and column_exists to updatedatabase.pl
These 2 subroutines will help us deal with the absense of ALTER IGNORE
TABLE

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-11 10:52:10 +00:00
Mark Tompsett
4ea484677e Bug 17234: Follow up to handle new problems
Bug 16276 added two more ALTER IGNORES. This removes them.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-11 10:52:09 +00:00
Blou
acf425bbbc Bug 17234 - updatedatabase.pl's ALTER IGNORE break with mysql 5.7.4+
The doc says: "As of MySQL 5.7.4, the IGNORE clause for ALTER TABLE is removed and its use produces an error."
This fix replaces ALTER IGNORE with ALTER in updatedatabase.pl

To TEST, try an upgrade from 3.18 to 3.22 after installing the latest mysql (at least 5.7.4, by the doc).
Some will fail with error

DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE aqbasket
            ADD KEY authorisedby (authorisedby)' at line 1 [for Statement "
        ALTER IGNORE TABLE aqbasket
            ADD KEY authorisedby (authorisedby)
    "] at ./installer/data/mysql/updatedatabase.pl line 10563.

0) Find a database on 3.18, save it.
1) Set your code base to 3.22(or master)
2) run updatedatabase.pl
3) See the errors.
4) Apply the patch
5) Reload the 3.18 database
6) succeed with updatedatabase.pl

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-11 10:52:09 +00:00
28d81cb7bb Bug 17767 - DBRev 16.12.00.001
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-12-28 13:59:03 +00:00
c9e95aa22e Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp"
This reverts commit 7ac1bc3537.

On a kohadevbox:
Error flock (1) on
'/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl':
No locks available at installer/data/mysql/updatedatabase.pl line 13637.

This is because Path::Tiny->slurp[_utf8] uses flocks which does not work
with NFS

Test plan:
Execute a .perl atomic update file on a kohadevbox
=> Without this patch you should get the flock error
=> With this patch the update should work fine

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-12-16 11:14:49 +00:00
6f4cbc8dad Bug 17676: Update default COLLATE of marc_subfield_structure
(This issue has been raised on bug 17216 comments 93-103)
On bug 11944 (3.19.00.006) we updated the default COLLATE for all our tables to
utf8_unicode_ci but not the marc_subfield_structure table.
Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and uppercase
of the same letter for subfields).
We should have set the default collate to utf8_unicode_ci for further changes.

This patch updates the DB entry 3.19.00.006 to set the default COLLATE to this
table (for people upgrading from prior to 3.19.00.006) and set this
default COLLATE on 16.06.00.033 (for people upgrading from after 3.19.00.006).

The error is:
DBD::mysql::db do failed: Can't create table `koha_kohadev`.`#sql-306_9f9` (errno: 150 "Foreign key constraint is incorrectly formed") [for Statement "
            ALTER TABLE marc_subfield_structure
            MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
            ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL;
            "] at installer/data/mysql/updatedatabase.pl line 13175.
Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized value categories)

Test plan:
1/ git checkout v3.18.00
2/ Do an install
3/ git checkout master;
4/ perl installer/data/mysql/updatedatabase.pl
=> Without this patch, you get the error
=> With this patch applied you will not get it and the default COLLATE for
marc_subfield_structure will be correctly set. Make sure tagsubfield is
still utf8_bin

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Will put some notes on the Bugzilla report.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-29 17:41:34 +00:00
5485f10ed2 DBRev 16.12.00.000 - the road goes ever on
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-29 17:38:30 +00:00
3c9d916641 Bug 17292 Follow-up, fix typos
- wrong assignation
- reference to 'serials' table rather than 'serial'

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-28 11:54:46 +00:00
7636c68d76 DBRev 16.11.00.000
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-22 17:48:00 +00:00
312783f8fc Bug 8835 - DBRev 16.06.00.050 2016-11-22 17:45:35 +00:00
0fee84690e Bug 8835: Drop issn_idx for completeness
When dbrev 3.15.00.049 failed, the still existing issn_idx must have
been the cause.
This patch only adjusts the old db rev.
Still thinking if we also need a new db rev to fix isbn and issn for
those installs where 3.15.00.049 failed too. (In that case the fields
may not have been changed to mediumtext and no indexes were added.)

Test plan:
Ideally, run an upgrade from something older than 3.15.00.49.
But running the added sql command from the command line might convince
you too.

Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
2016-11-22 17:45:21 +00:00
141538fb51 Bug 17391 - DBRev 16.06.00.049
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-22 11:38:26 +00:00
d9be9950b3 Bug 17663 - DBRev 16.06.00.048
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-21 16:34:46 +00:00
674d3875c8 Bug 17518 - DBRev 16.06.00.047
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-02 11:02:09 +00:00
e67c202609 Bug 15581 - DBRev 16.06.00.046
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-02 10:53:35 +00:00
10b3bb8f46 Bug 17443 - DBRev 16.06.00.045
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 16:51:58 +00:00
ade5362586 Bug 17397 - DBRev 16.06.00.044
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 15:43:20 +00:00
3f7098a02f Bug 17356: Add atomic update .perl skeleton file
To show devs how it should be written.

Test plan:
% cp installer/data/mysql/atomicupdate/skeleton.perl
installer/data/mysql/atomicupdate/bug_XXXXX.perl
% perl installer/data/mysql/updatedatabase.pl

You should see:
DEV atomic update: bug_xxxxx.perl
Upgrade to 16.06.00.XXX done (Bug XXXXX - description)

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Very good. I'll submit a patch for the readme to make the instructions better.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 14:47:04 +00:00
25adf52334 Bug 13323 - DBRev 16.06.00.043
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 14:28:40 +00:00
9beffec5aa Bug 13321 - DBRev 16.06.00.042
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 14:23:24 +00:00
c7bc14cead Bug 14629 - DBRev 16.06.00.041
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:59:55 +00:00
2354e41b61 Bug 5260 - DBRev 16.06.00.040
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:54:58 +00:00
5d5a1509d1 Bug 14598 - DBRev 16.06.00.039
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:30:38 +00:00
3660c451a3 Bug 14598: [QA Follow-up] Small changes
[1] Renames the dbrev version to XXX; adding a my for $sth, although
    not strictly necessary it feels better.
[2] Circulation.t stumbles over:
    Undefined subroutine &C4::Circulation::GetItem called at ... line 1283.
    Somehow this is related to use_ok instead of a regular use.
    Worked around this by require_ok and adding a regular use.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:29:59 +00:00
Tomas Cohen Arazi
3fa514133b Bug 14598: (QA followup) use deleted{items|biblioitems} during upgrade
If the 'statistics' table contains circulation information about items
that are no longer on the DB it will raise a warning. This patch
makes the updatedatabase.pl script use the deleteditems and deletedbiblioitems
tables to get information for those items on the statistics table.

To reproduce:
- Have your sample DB contain some circulation data on the statistics table
- Make sure some of them have NULL itemtype:
> UPDATE statistics SET itemtype = NULL WHERE type='return';
- Check the upgrade query catches them:
> SELECT s.itemnumber, i.itype, b.itemtype FROM  ( SELECT DISTINCT itemnumber    FROM statistics    WHERE ( type = "return" OR type = "localuse" ) AND itemtype IS NULL ) s  LEFT JOIN  ( SELECT itemnumber,biblionumber, itype      FROM items    UNION    SELECT itemnumber,biblionumber, itype      FROM deleteditems ) i  ON (s.itemnumber=i.itemnumber)  LEFT JOIN  ( SELECT biblionumber, itemtype      FROM biblioitems    UNION    SELECT biblionumber, itemtype      FROM deletedbiblioitems ) b  ON (i.biblionumber=b.biblionumber);
+------------+-------+----------+
| itemnumber | itype | itemtype |
+------------+-------+----------+
|        732 | BK    | BK       |
|        731 | BK    | BK       |
+------------+-------+----------+
2 rows in set (0.00 sec)

- Delete the items, and some biblio too.
- Re-run the query
=> SUCCESS: Same results
- Go reset to NULL the itemtypes
> UPDATE statistics SET itemtype = NULL WHERE type='return';
- Run the updatedatabase.pl script:
 $ sudo koha-shell koahdev ; cd kohaclone
 $ perl installer/data/mysql/updatedatabase.pl
=> SUCCESS: No warnings

Note: It is possible that on production sites, if the sysadmin is cleaning the
deleted{items|biblioitems|biblio} tables, there will be warnings. This is expected
as they need to know some data lacks information.

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:29:59 +00:00
c042307db3 Bug 14598 [QA Followup] - Update localuse statistics also
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:29:58 +00:00
2cdec7ff91 Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows
This patch introduces an updatedatabase.pl entry that takes care of
updating existing statistics rows.

It does so by looping on the statistics rows, collecting itemnumber occurences
that are have NULL itemtypes.
It then chooses the right itemtype following what is proposed on bug 14651, and
then updates the rows in statistics using the calculated itemtype.

Regards

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-28 11:29:57 +00:00
239b81c1dd Bug 14874 - DBRev 16.06.00.038
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-27 14:02:19 +00:00
33ff591731 Bug 14610 - DBRev 16.06.00.037
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-26 12:22:37 +00:00
2578d8cd96 Bug 5670 - DBRev 16.06.00.036
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-21 18:20:44 +00:00
8b570a8808 Bug 15131 - DBRev 16.06.00.035
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-21 17:28:42 +00:00
35101c9127 Bug 10455 - DBRev 16.06.00.034
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-10-21 14:37:46 +00:00
Brendan Gallagher
3fe925ee19 UPdating the DBREv for Bug 17216 - Add a new table to store authorized
value categories
2016-10-11 11:18:50 +00:00
Brendan Gallagher
442734b438 Uping DBRev. Bug 17357 - WTHDRAWN is still used in installer files
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-10-11 04:52:13 +00:00
df3df9cf71 Bug 17372: Standardize Elasticsearch paths
What we currently have:
Koha/ElasticSearch.pm
Koha/ElasticSearch/Indexer.pm
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
Koha/SearchEngine/Elasticsearch/Search.pm

What we want:
Koha/SearchEngine/Elasticsearch.pm
Koha/SearchEngine/Elasticsearch/Indexer.pm
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
Koha/SearchEngine/Elasticsearch/Search.pm

Test plan:
  % git grep -i Koha::ElasticSearch
  % git grep ElasticSearch|grep -v Catmandu::Store::ElasticSearch
should not return any result

Do a full reindex and search for records

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-10-11 01:07:03 +00:00
a36b643019 Bug 16838: ES - install mappings for new installs
The yaml file is not used to populate ES mapping tables (search_field,
search_marc_map and search_marc_to_field) when doing a fresh install.

We need to insert them, otherwise ES will be unusable.

Test plan:
Create a new install and confirm that the ES tables (search_field,
search_marc_map and search_marc_to_field) are correctly populated.

Bonus points: Use an older DB (prior to 3.23.00.050), execute the
updatedatabase.pl script and confirm that the ES table are correctly
populated

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-10-11 01:01:52 +00:00
Mark Tompsett
6ff836ab31 Bug 17292: Follow up - tweak to make it pass cleaner
remove a 'my'
next if not defined subscriptions.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-10-10 10:20:56 +00:00
f11f07a703 Bug 17292 - Use of DBIx in updatedatabase.pl broke upgrade
A recent change in the 'subscription' table structure highlighted a
problem in a DBRev upgrade (3.23.00.006). As it adds a new column, when
upgrading from (say) 3.20.00.000 the code/schema (correctly) expects the
subscription.itemtype column to exist. But it is not created until DBRev
16.06.00.025.

To reproduce:
- Have a clean 3.20.00 DB loaded into kohadevbox
- Checkout current master
- Run:
  $ perl installer/data/mysql/updatedatabase.pl
  => FAIL: The upgrade procedure fails due to missing colum.

  The solution: rewrite the updatedatabase.pl entry using plain DBI

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-10-10 10:20:56 +00:00
Mark Tompsett
0599ab0076 Bug 17324: Deal with branchcode NULL issue
In a database update we alter the letter table, making a column
(branchcode) not be able to contain NULL values.
However if it already does, this SQL fails. So before changing the
column we change the NULL values

[Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed:
Invalid use of NULL value [for Statement "
[Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY
COLUMN branchcode varchar(10) NOT NULL DEFAULT ''
[Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at
/home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line
12638.

Reproduce:
on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha
development environment.
...
git checkout -b my_3.18.x origin/3.18.x
drop database koha_library;
create database koha_library;
quit;
web install all sample data
(ignore some issues with sample data, and one with mandatory)

git checkout -b bug_17234 origin/master
git bz apply 17292
git bz apply 17320
git bz apply 17260
git bz apply 17234
web install
Two warning messages are expected output from upgrade process, but
the above message is not.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Did not follow the test plan, but the changes make sense

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-10-10 10:16:04 +00:00
5eb4b06f5b Bug 16273 - DBRev 16.06.00.031
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-25 15:53:57 +00:00
82af4da811 Bug 16552 - DBRev 16.06.00.030
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-25 15:45:25 +00:00
7cb3a607d8 Bug 14707 - DBRev 16.06.00.029
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-25 14:02:13 +00:00
0254fd7a1f Bug 17135 - DBRev 16.06.00.028
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-16 10:50:33 +00:00
89bae5f368 Bug 16276 - DBRev 16.06.00.027
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-13 17:30:41 +00:00
8a74bb24f5 Bug 16274 - DBRev 16.06.00.026
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-12 15:38:46 +00:00
8ff8e0b8dd Bug 7677 - DBRev 16.06.00.025
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-12 09:15:38 +00:00
1da2bceb85 Bug 16311 - Fix DBRev description
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-12 09:09:59 +00:00
5eaa1cb2ab Bug 16311 - DBRev 16.06.00.024
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-12 09:08:27 +00:00
cc1c82edb6 Bug 17187 - DBRev 16.06.00.023
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 14:06:17 +00:00
1b43b3d7ac Bug 16978 - DBRev 16.06.00.022
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 13:26:20 +00:00
7ac1bc3537 Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp
Path::Tiny::slurp is considered better to use than File::Slurp.

RM Note: The package version in wheezy is too old, the package version
         in jessie is just fine and should be added to the community
         repo if wheezy will be supported for the coming release.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 12:53:07 +00:00
954ed80534 Bug 16685 - Use eval instead of do for .perl atomicupdates
If we use eval instead of do for our .perl atomic update files, it will
allow developers to put in the exact code that should go into
updatedatabase.pl. The problem with do is that none of the variables
defined in updatadatabase.pl are available, whereas with eval they are.

Test Plan:
1) Apply this patch
2) Create a .perl file in atomicupdates with the following in it:
say "DBversion: $DBversion";
3) Run updatadatabase.pl
4) Note the output
5) Add a syntax error to your atomic update
6) Run updatedatabase.pl
7) Note the error is displayed

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 12:52:57 +00:00
b8046995ee Bug 16275 - DBRev 16.06.00.021
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 12:04:50 +00:00
884954f977 Bug 16272 - DBRev 16.06.00.020
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 11:53:32 +00:00
d6fba2e2f3 Bug 15839 - DBRev 16.06.00.019
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 10:38:43 +00:00
d331b6de45 Bug 7045 - Fix DBRev 16.06.00.016
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 09:06:51 +00:00
7523ef878d Bug 14695 - DBRev 16.06.00.018
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-08 12:47:25 +00:00
c4a0be0a68 Bug 10848 - Fix DBRev description
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-02 16:18:38 +00:00
aef77798a9 Bug 7045 - DBRev 16.06.00.017
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-02 16:09:43 +00:00
33557a2847 Bug 7045 - DBRev 16.06.00.016
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-02 16:04:09 +00:00
090c0fc6c4 Bug 14642 - DBRev 16.06.00.015
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-08-17 18:43:19 +00:00
0caed05779 Bug 16829 - DBRev 16.06.00.014
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-08-17 18:09:38 +00:00
e16019f27b Bug 7741 - DBRev 16.06.00.013 - Add IGNORE to insert in case of backporting
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-08-10 14:20:06 +00:00
01e041ca40 Bug 7441 - DBRev 16.06.00.013
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-08-10 13:28:20 +00:00
e8b54cb3be Bug 16573 - DBRev 16.06.00.012
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-08-01 09:54:30 +00:00
44785935bd Bug 16573: Define virtualshelves.created_on as datetime for existing installs
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-08-01 09:39:15 +00:00
6ac4b20d3a Bug 11606 - DBRev 16.06.00.011
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-22 17:21:42 +00:00
d951ba620c Bug 15128 - DBRev 15128
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-08 14:11:42 +00:00
f65cf574d0 Bug 14902 - Fix issues with updatedatabase.pl
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-08 14:01:41 +00:00
80921b10f5 Bug 14902 - DBRev 16.06.00.009
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-08 13:59:37 +00:00
46b7d5e4c6 Bug 6906 - DBRev 16.06.00.008
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-08 13:40:42 +00:00
6398d1b242 Bug 3534 - DBRev 16.06.00.007
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-07 18:37:13 +00:00
Jesse Weaver
0fda22b824 Bug 14048: (RM followup) DB version 16.06.00.006
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
2016-07-07 11:02:53 -06:00
40598f8e4f Bug 16768 - DBRev 16.06.00.005
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-06-24 14:03:41 +00:00
54451b66a1 Bug 15485 - DBRev 16.06.00.004
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-06-24 13:32:35 +00:00
e5bb0fac3f Bug 16731: Use INSERT IGNORE when inserting a syspref
IGNORE should be used to allow backporting (and local patch)

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-06-24 12:03:17 +00:00
2279a2fea0 Bug 11490 - DBRev 16.06.00.003
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-06-24 11:53:02 +00:00
f17897fb10 Bug 10459 - DBRev 16.06.00.002
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-06-10 17:15:21 +00:00
Jacek Ablewicz
113adf68e5 Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses
It seems that if subscription_numberpatterns.numberingmethod contains parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade snippet, with the following error:

[Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by <-- HERE in m/ ( <-- HERE / at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498.

Steps to reproduce:
1/ Have a Koha DB version<3.23.00.006
2/ Create a subscription numbering with parentheses in it:
   ie "Vol. (Month, Year)" with pattern
       Vol. {X} ({Y}, {Z})
3/ Add some serials using that numbering method so that serialseq is filled in DB:
   ie  "Vol. 16 (February, 2015)"
4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller
5/ The error is produced

To test:
1/ apply patch
2/ try to reproduce this issue once again, should be fixed now
3/ have a look at the code, make sure the changes are consistent

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note: I have not tested the patch, but the diff looks good.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-06-10 16:39:26 +00:00
Brendan Gallagher
bae0eb9ab7 DBRev up for Bug 16200 - 'Hold waiting too long' fee has a translation
problem

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-05-31 08:56:42 +00:00
Liz
3311ab44cf Bug 16619 - installer stuck in infinite loop
To test: run the web installer on master, it should not get stuck in an infinite loop.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-05-31 08:47:30 +00:00
Brendan Gallagher
b99731e2e0 Updating the DBrev for a new dev track (unstable).
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-05-30 10:02:31 +00:00
Brendan Gallagher
6d3396ab25 Final DBRev for the 3.23 dev to 16.05
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-05-26 03:14:05 +00:00
e07a68a6e7 Bug 15086 - DBRev 3.23.00.064
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-05-16 17:39:40 +00:00
7b8bb85d5e Bug 16288: (QA followup) Remove the syspref INSERT line
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-05-16 17:14:57 +00:00
85410cc9bc Bug 16402 - DBRev 3.23.00.063
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-05-16 17:09:53 +00:00
Brendan Gallagher
b18f3eddf6 DBRev Bug 16414 - aqorders.budgetgroup_id has never been used and can be
removed

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-05-06 04:06:56 +00:00
e7eac39e96 Bug 16170 - DBRev 3.23.00.061
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-05-03 15:04:20 +00:00
7922ff0368 Bug 12528 - DBRev 3.23.00.060
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 17:58:30 +00:00
db1e5db285 Bug 15533 - DBRev - Fix typo
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 15:25:03 +00:00
0aa787615a Bug 15533 - DBRev - Change INSERT to INSERT IGNORE for new syspref
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 14:13:10 +00:00
bed7eb4762 Bug 16041 - DBRev - Fix print line
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 14:04:57 +00:00
1b6a3d85a9 Bug 16167 - DBRev 3.23.00.059
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 14:02:52 +00:00
c22934c3e6 Bug 16041 - DBRev 3.23.00.058
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 13:51:29 +00:00
3615c7b34b Bug 15531 - DBRev 3.23.00.057
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 13:14:50 +00:00
df5b1b70aa Bug 14577 - DBRev 3.23.00.056
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 11:58:29 +00:00
1a0ca2874f Bug 15533 - DBRev 3.23.00.055
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-29 10:31:19 +00:00
e27bca77c7 Bug 15532 - DBRev 3.23.00.054 2016-04-29 10:23:47 +00:00
Brendan Gallagher
68235527aa DBRev Bug 16217 - Notice' names may have diverged
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-29 02:26:46 +00:00
6d52cd63f3 Bug 12752: FIX letter names in 3.15.00.041
3.15.00.041 was wrong, the name of the letter should not always been the
name of the first HOLD notice.
PREDUE_PHONE should be updated with the first name of the PREDUE notice,
same for OVERDUE_PHONE and OVERDUE

Signed-off-by: Chris Cormack <chrisc@catalyst.net.z>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-28 23:27:36 +00:00
a63a51381b Bug 14686 - DBRev fix - add missing call to SetVersion
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-27 17:00:22 +00:00
Brendan Gallagher
19d2dfb733 DBRev for Bug 14686 - New menu option and permission for file uploading
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
2016-04-27 16:24:18 +00:00
Bernardo Gonzalez Kriegel
a25bfbfc57 Bug 16361: Installer syntax error
Bug 16354 introduces a syntax error on updatedatabase.pl
see comment #5 there

To test
1) Check error on update 3.23.00.051
2) Apply the patch
3) run updatedabase again (perhaps changing 051 to XXX)

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
happy again!

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-04-27 12:55:45 +00:00
Brendan Gallagher
4e6baf6185 Forgot extra $dbh
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-27 02:38:35 +00:00
Brendan Gallagher
ee652b07ca DBREv Bug 16354 - Fix FK constraints for edifact_messages table
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 23:14:02 +00:00
Brendan Gallagher
ca405ec114 Bug 12478: (RM followup) fix syntax error in updatedatabase.pl
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
2016-04-26 15:03:26 -06:00
Brendan Gallagher
f24dd95e5d DBRev for Bug 12478 - Elasticsearch support for Koha
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 20:55:25 +00:00
Chris
bc21573db4 Bug 12478 : Remove the rest of the references to the old mapping tables
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 20:20:13 +00:00
Chris
2e18cca19f Bug 12478 : Remove reference to deprecated table elasticsearch_mapping.sql
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 20:20:12 +00:00
7d10460156 Bug 14899: DB changes
This patch applies several changes to the DB structure introduced by
the previous ES patch set:

1/ Add a search_field.label column
=> It will be easier to understand what the search_field does.
Indeed, some are not user friendly: acqdate, an, pl, ff8-23, ln, etc.
TODO later: Update the labels with correct values (at the moment
label=name)

2/ Update the foreign key search_marc_to_field.search_marc_map_id with
on delete cascase. This will permit to automatically remove the entries
in search_marc_to_field when they are deleted in search_marc_map.

3/ Remove the index_name_2 unique constraint on the search_marc_map table.
I don't understand how this could be useful, it was defined like (index_name,
marc_type, marc_field), so it means a mapping cannot be defined twice with
different values for facet, suggestible and sort.
This limitation does not seem to make sense.
Robin, please correct me if I am wrong :)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 20:20:10 +00:00
Robin Sheat
0b9483a691 Bug 12478: fix some issues on rebase
There were rebase conflicts that it was just easier to postpone until
afterwards.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 20:20:09 +00:00
Robin Sheat
1d22202fb1 Bug 12478 - set up database tables for elasticsearch
This sets up the database changes needed to run ES. This isn't intended
to be ready for upstreaming, just to make testing easier.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-26 20:20:03 +00:00
Brendan Gallagher
c1270d5c72 Missed $ in commit...
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-22 23:42:47 +00:00
Brendan Gallagher
9e350eee19 DBREV Bug 12267 - Allow password option in Patron Attribute non functional 2016-04-22 16:27:13 -07:00
Brendan Gallagher
b7d36141fb DBRev update - Bug 5979 - Add separate OPACISBD system preference 2016-04-22 03:19:56 +00:00
Brendan Gallagher
e126fc0a19 DBRev for Bug 15008 - Add custom HTML areas to circulation and reports home pages
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
2016-04-07 05:45:42 +00:00
Brendan A Gallagher
b14c46c942 DBRev fix - "" was wrong smartquotes. fixed
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-04-05 16:21:03 +00:00
Brendan A Gallagher
c84fe12d5e DBrev adding in the missing update DBversion = "3.23.00.046";
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-04-05 15:57:05 +00:00
Brendan A Gallagher
9f9e0ea002 DBRev Bug 7736 - Edifact QUOTE and ORDER functionality
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-04-01 20:54:09 +00:00
Brendan A Gallagher
7a3c9951bb DBRev Bug 10988 - Allow login via Google OAuth2 (OpenID Connect)
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-04-01 19:46:47 +00:00
Brendan A Gallagher
79fa6ec68a DBrev Bug 16070 - Empty (undef) system preferences may cause some issues
in combination with memcache

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-31 19:56:00 +00:00
Brendan A Gallagher
7661629e98 fixing DBrev Bug 16103
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-31 17:54:46 +00:00
Brendan A Gallagher
18644009c6 DBrev Bug 16004 - Replace items.new with items.new_status
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-31 17:06:26 +00:00
Brendan A Gallagher
b1f4707165 DBrev updates for Bug 16007 - Correction of 'Remove columns branchcode,
categorytype from table overduerules_transport_types'

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-31 15:08:02 +00:00
Brendan Gallagher
b129de0355 DBREV for Bug 16019 - Remove unused blue.css
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
2016-03-22 01:03:03 +00:00
3b96bf7516 Bug 16019: Add a warning in the update DB process if intranetcolorstylesheet=blue.css
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
2016-03-22 01:01:24 +00:00