Commit graph

26 commits

Author SHA1 Message Date
ef58c445d3 removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 23:30:48 -04:00
65540255d8 Fix for Bug 4138, Adding or deleting suggestions in the OPAC does not properly refresh the page
- Using redirect() and adding URL parameter to enable the display of
  messages on the screen confirming the action.
- Also correcting for JavaScript error in form validation routine.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 21:05:02 -05:00
a8564dbcf1 Fix for Bug 4093, OPAC Suggestions List has extra column
- This code was added to opac-suggestions.pl at one point by
  Garry Collum and was subsequently removed. Adding it back.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:37:05 -05:00
d56db2e972 Fix for Bug 4092, suggestion date missing from manage suggestions
Date was missing because of incorrect variable name in opac-suggestions.pl
Thanks to HDL for the fix.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:42:42 -05:00
Garry Collum
7f021e4711 Bug 3890: Nothing in Type Pull Down on Purchase Suggestions.
This patch adds a description of the itype next to the image that i suppose to appear in the selection list.

Fixed the path of the image in opac-suggestions.pl, but I'm not sure if you can actually display an image in a <SELECT> list option.

Also removed an extra </label> closing tag.
2009-12-20 14:31:39 +01:00
Henri-Damien LAURENT
73de4a2e3f Date management update Suggestions 2009-11-17 16:27:14 +01:00
Henri-Damien LAURENT
3ab463fc34 suggestion.pl has to be updated on C4/Budgets 2009-09-30 11:30:29 +02:00
Paul Poulain
03d9a79878 suggestions changes (probably useless)
and incompatible with hdl stuff
2009-09-30 11:30:22 +02:00
Henri-Damien LAURENT
8802bbf5fe Editing C4::Suggestions.pm
Enhancing C4::SearchSuggestion
And changing its API
Changing C4::Suggestions API taking a hashref for NewSuggestion and ModSuggestion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:23 +02:00
Garry Collum
b904347142 Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.
Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:05:22 -04:00
Garry Collum
3a058fcc9d Bug 1607: Fixes the delete checkboxes in purchase suggestions.
If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed

Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 22:34:26 -04:00
Galen Charlton
bc3b7a4af3 bug 2505: turn on warnings in two scripts
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:27:52 -06:00
Galen Charlton
7c59177092 bugfix: reenable listing suggestions by anyone
Change in parameter name in template not reflected
in script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 14:28:25 -05:00
Henri-Damien LAURENT
aa2f3486f5 Displaying branchnames rather than branchcodes
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 14:08:11 -05:00
Galen Charlton
4bf76c2d77 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:05:08 -05:00
Joshua Ferraro
60368d1049 From HDL:
I agree that opac-suggestions.tmpl modification is Not required any longer.
But still, the modification in opac-suggestions.pl is really necessary.
If you donot do that, ppl are presented with ALL suggestions and not
their suggestions by default, which is not what My Suggestions suggests.
2008-05-30 13:56:17 -05:00
0f1825d055 Changes to allow highlighting of current tab on user pages.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:17 -05:00
Joshua Ferraro
7bfd9507ae fix for bug 1352: 'Suggestions Link Should Force Patron Login'
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:27:31 -06:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output.
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
2007-04-24 13:54:28 +00:00
tipaul
fc1342f73d rel_3_0 moved to HEAD 2007-03-09 15:12:54 +00:00
toins
1696f62652 Sub renamed & GPL Licence added. 2006-07-07 09:00:12 +00:00
toins
cc9524a875 Head & rel_2_2 merged 2006-07-04 14:36:51 +00:00
tipaul
64cd740d2b synch'ing 2.2 and head 2005-05-04 08:58:30 +00:00
tipaul
3cef08d33b minor fixes (to get less warning during translation) 2004-08-12 14:50:29 +00:00
tipaul
f29ce59691 Acquisition & Suggestion :
* acquisition rewritte : create a aqbasket table to deal with "bookseller order header".
* add "close basket" feature : a closed basket can't be modified
* suggestion feature : manage suggestions in acquisition (after suggestion filled in OPAC)
2004-07-15 09:41:03 +00:00
tipaul
e651ebf89f adding suggestions in OPAC 2004-05-28 08:28:22 +00:00