Commit graph

76 commits

Author SHA1 Message Date
Janusz Kaczmarek
86096350a9 Bug 6463 - Authorities browsing error when using auth. plugins
[2011.06.05] I confirm the solution. On my test UNIMARC installation, I haven't
an error 500 but I have a wrong result pages navigation bar which doesn't limit
search result on the selected authority type.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-06-10 11:01:37 +12:00
ecf4bb9a51 Bug 6232: Impossible to link authorities to bibliographic records
Another fix for TT.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-22 07:24:52 +12:00
36e3bed7b1 Bug 5791 - Robust handling of deleted/non-existent biblios and authority records
Patch reworked for master using Template::Toolkit.

To+

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-20 12:03:59 +12:00
55984a1610 Fix for Bug 6192 - Path to theme directory scoped incorrectly
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-15 10:32:43 +12:00
Chris Cormack
5884fb1000 Bug 5917 : Swapping templates over 2011-04-10 20:38:30 +12:00
db6ab6a6fd Fix for bug 5498, Standardize markup and style of pagination menus
Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-09 19:25:36 +12:00
Henri-Damien LAURENT
21404359d4 Bug 5923 : Authorities list :removing link on Summary
removing the link to authority details on authority List directly from summary
And adding a generic link to details

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-07 16:25:18 +12:00
Alex Arnaud
99f49c1108 Bug 5941 : (MT4425) Replace search 'an' by 'an, phr' in searchresultlist.tmpl
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-06 17:05:23 +12:00
6b3e4f19f4 Bug 4838 Allow to choose which authority heading to copy into biblio record
With this patch, in biblio record data entry form, when ... is clicked for an
authority controlled field, it's possible to select which heading repetion to
copy if the authority has repeated headings.

When there is just one authority repetition, the first one is displayed to
choose, as previously.

This patch is REQUIRED by French libraries following SUDOC UNIMARC format, and
cataloguing multilingual materials ie all Higher Educational and Research
libraries.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-21 16:50:45 +13:00
399e22e87f Fix for Bug 5093 - JavaScript error in IE8 when choosing authority record
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:34:58 -04:00
4e6a664fb0 Fix for Bug 4868 - Improve controls for cloning and deleting MARC subfields
Changes "+" and "-" controls to actively linked images giving
better feedback about their clickability and an increased click
target area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:23:26 -04:00
Katrin Fischer
a18bdb0bfe BUG 4883: Staff - remove \n from strings for translation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:09:09 -04:00
Henri-Damien LAURENT
208b835310 MT3499 : cataloguing authid not reported
authid would not be correctly updated in bibliorecord.
Biblio record would not receive the correct authid in subfield 9
but some erroneous data

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:47 -04:00
Garry Collum
f02e460671 Bug 3860: Can't expand authorities.
Adds a link to the Authority tag to expand the fields if advancedMARCeditor is in "Don't display" mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 05:59:50 -05:00
Henri-Damien LAURENT
a4662fd614 Bug Fix MT2104 : Edit authorities problem on multiple field
When editing a field 500 linked to an authority, when duplicate
field, all the 500 fields were replaced.
2009-10-27 23:50:05 +01:00
Henri-Damien LAURENT
ecd99dc57e Fixing page numbering in searchresultlist-auth.tmpl
a closing > was coming too fast
2009-09-30 11:30:40 +02:00
Nahuel ANGELINETTI
1bbc0324c4 (bug #3411) escape authorities values
The values are not escaped in javascript, so if there is double quotes, the authority cannot be imported because of javascript error. This patch fix this.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:04 +02:00
Garry Collum
2c7d5b369d Bug 2889: Adds table highlighting to the Authority search results.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:13 -04:00
Garry Collum
1f0e6ec1fe Bug 3338: Fix for missing closing brackets in authorities/detail.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-19 06:01:30 -05:00
Galen Charlton
84c4c269b6 bug 3170 followup
* tags >= 010, not just > 010, can have subfields
* fixed so that mandatory fields are checked
  regardless of whether a new one is created
  or an existing one modified

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 08:09:11 -05:00
Nahuel ANGELINETTI
c885a150c5 (bug #3170) do not check fields < 010
This patch add a if, to disallow the check of fields < 010, because they could have no subfields, and are mandatory.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 15:08:30 -05:00
Nahuel ANGELINETTI
927d3e6982 (bug #3170) check if mandatory fields are not empty
This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 15:06:25 -05:00
Joe Atzberger
843c5b5b2d Bug 3127 - Stub function prevents undefined reference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 19:49:08 -05:00
Joe Atzberger
f3b5014449 Bug 3128 - followup and correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:34 -05:00
Joe Atzberger
173556364d Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:28 -05:00
Nahuel ANGELINETTI
72563b0449 (bug #2933) change popup names containing space chars
This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:37:30 -06:00
Nahuel Angelinetti
a41acfe435 Do not show the language chooser
This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 10:29:28 -06:00
0a33d4554b Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 13:34:36 -05:00
paul
bd23670eaf BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:51:42 -05:00
Joe Atzberger
3a2f776875 Validation fix, include required "type" in link tag.
This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 18:19:06 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
Galen Charlton
bddafff54a bug 2496: add 'edit' link to authority search results
When search for an authority record from the bib
record editor, a new link is added to each
authority result to edit the authority record.  This
allows a cataloger to do the following:

1. Start editing a bib record
2. Click on the '...' to select an authorized heading
   for an authority-controlled field.
3. Look at the results in the pop-up window and
   see that an authority record needs correction.
4. Click on the 'edit authority' link.  This allows
   the authority to be revised.  Note that this
   takes place in the popup window, not the originally
   bib editing window.
5. Save the authority record, then close the popup
   window and redo the heading search.

For various reasons, this not a perfect workflow; this
patch is designed to satisfy an immediate requirement
but needs to be reworked in 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:35:09 -05:00
Joe Atzberger
adbb25b52b auth_finder - HTML validation fixes
Missing </tr> and extra </select>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:28 -05:00
Galen Charlton
c48da8131d bug 1909: add delete field/subfield button to MARC editor
A button to delete (non-mandatory) subfields and fields
is added to the bib and authority MARC editors.  This button,
which displays as a hypen or minus sign after the plus sign
to clone a field, acts as follows:

[1] When deleting a whole MARC field, if at least
    one other repeat of that field exists, deletes
    the field from the editor page.  If the field
    to be deleted is the last instance of that tag,
    the contents of the field are cleared, not removed.
    This allows one to delete all 650 tags, then
    add a new one without having to reload the
    record in the editor.

[2] When deleting a subfield, if at least one other
    repeat of that subfield and its tag occurs
    *anywhere else in the record, not necessarily in the same tag*,
    deletes the subfield.
    Otherwise, if the subfield is the last occurrence
    of that tag/subfield combination, clears the input
    form instead.

Documentation note: new screenshots for MARC editor, plus
description of the '-' button.

Credit to MJ Ray for introducing the '-' button
and the UnCloneField JavaScript function.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-08 12:31:30 -05:00
Galen Charlton
d57ce0380d bug 2278 - fix results pagination in auth_finder
Fix same as for 2205 - the orderby parameter is
currently required for authority searches.

Also set default results per page to 20 instead of
19.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-26 16:20:06 -05:00
Galen Charlton
7ac682c859 bug 2265: fix problem when cloning MARC field
Correctly set indicators when cloning a field
in the MARC editor.  Prior this fix, a cloned
field would not be saved.  Bug introduced in
patch for bug 2207.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 09:41:00 -05:00
5697bef959 Removing redundant column. Fixes Bug 2202, "No need for View Column on Authority Search"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:58 -05:00
691bcc631c Markup corrections to cataloging pages; Fixes for Bugs 2166 (" Book Jackets Not Showing on My Summary"), 2194 ("No results for Authority Search Shows blank record"), and 2196 ("Extra comma being added to record display")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:09 -05:00
Galen Charlton
ee49d6d372 kohabug 2207 - improve indicator input in MARC editor
Instead of having one input field for both indicators
of a variable field, the bib and authority MARC editor
now has an input field for each indicator.  This has
two main advantages:

* it is easier to tell what the indicator values are,
  even when the first indicator is a space
* it is easier to set the first indicator to blank
  and the second indicator to non-blank.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-12 11:17:35 -05:00
eb09aac059 Authorities detail page was missing toolbar, breadcrumbs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:53 -05:00
bab8beb59a Updates to go along with jquery tabs plugin update
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-11 06:18:50 -05:00
d63f3fbcea Updating loading mask js and adding opacity setting.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-04 04:47:48 -06:00
6deddfb7bd Using YUI plugin to do "Loading" mask on addbiblio.pl and authorities.pl. Previous version wasn't compatible with Internet Explorer.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-29 17:30:02 -06:00
Joshua Ferraro
aabea3417b WARNING: Updates to Index Defs for Authorities
This commit is a partial fix to authority control for MARC21,
and better authority handling in general (for UNIMARC too).
Before this patch, authority searching, editing, saving, was
not functioning, or was extremely buggy.

WARNING: You will need to re-index your authority database after
applying this commit.

The following changes have been made:

  * Normalizing record.abs index names (in both MARC21 and UNIMARC)
  * Synching authorities/bib1.att, ccl.properties, AuthoritiesMarc.pm
    with new indexes (UNIMARC too)
  * Clean up biblios/bib1.att (remove duplicate att defs)
  * Clean up authorities-* templates to conform to new styles
  * Fixed search failure when using Default framework (now searches
    All)

Also included are several fixes to the built-in SRU server for
Authority and Biblio, it's recommended that you update your
koha-conf.xml file:

  * adding explain-authorities.xml and explain-biblios.xml
  * adding necessary info to koha-conf.xml to enable SRU/W
  * adding several example XSLT stylesheets, that can be used
    for SRU on-the-fly transformations (to MODS, DC, RDF, etc.)

Still remaining for 3.0 are the following tasks:

  * update MARC21 frameworks (authority and cross-reference bib)
  * update display code/templates in authority results list
  * update search code/templates to utilize index points
  * implement 'grouping' of authtypes for searching (Name, Title, Subject)
  * repair utility to import auths and perform matching
  * repair bibliographic import to match auths and warn if no match

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 00:28:40 -06:00
Joshua Ferraro
da8a4ca991 BIG COMMIT: minimal fix to authorities search
This is a minimal fix -- pname authorities work propertly, but nothing
else has been tested yet

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 20:23:16 -06:00
Paul POULAIN
318b75d1cd removing some useless parenthesis in the template
with (), the look was not nice when you've defined () in the name of your authority.

Like
subject (common name)
subject (personnal name)
...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:16:56 -06:00
Paul POULAIN
0e7412c802 for authorities too: everybody, says 100 times : "It's forbidden to put TMPL_IF inside a html tag"
The translator become crazy :
<anything <!-- TMPL_IF -->nanana<!-- /TMPL_IF -->> is ILLEGAL in Koha

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 17:11:49 -06:00
Joshua Ferraro
8d726bf96c nomenclature improvements for translation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:18:25 -06:00
Galen Charlton
fa480ea4f3 various authorities fixes
* improve generation of summaries for MARC21 authorities
* fix search syntax for link to display bibs linked to a given authority
* in addbiblio.pl's BiblioAddAuthorities, check all headings, not just the first of each tag

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-12 18:32:22 -06:00
Joshua Ferraro
20055da807 Fixing nomenclature and tmpl_process3.pl bugs
tmpl_process3.pl still throws some multi-byte warnings
but no markup errors

There are still quite a few places we could normalize
to reduce the size of the translation file

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:37:01 -06:00