Commit graph

304 commits

Author SHA1 Message Date
Chris Cormack
b06a289173 Merge remote branch 'kc/master' into new/bug_3013 2011-03-08 08:28:42 +13:00
Salvador Zaragoza Rubio
519cb622db Bug 3013 - Value builder for 006 and 008 need choices for all format types
Modification of the intranet cataloguing plugin for 006/008 fields to allow
select a type of material and change the positions available to enter the data.
Data are hard stored in xml files to allow easy translation and processing through
Javascript and JQuery-AJAX.

Bug 3013 - Fix selection of combo and trailing whitespace

Bug 3013 - Fix selection of combo

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-08 08:28:32 +13:00
Chris Cormack
3f35705ddc Merge remote branch 'kc/new/enh/bug_2170' into kcmaster 2011-02-15 15:55:54 +13:00
173d3cbb2d Follow-up fix for Bug 2170 - Adding 'edititems' user-permission
Save button and duplicate confirmation redirects must respect
the edititems permission: Users without permission to edit items
should not be redirected to the edit items screen.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-15 10:31:22 +13:00
Colin Campbell
ea2ace41a4 Bug 4263: Fix subfield ordering broken by earlier patch
Restores alpha sorting of item subfields in add/edit screen

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-14 09:05:33 +13:00
Paul Poulain
d22001b1c4 adding some copyright BibLibre statements
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-09 14:08:44 +13:00
Paul Poulain
d251585f71 Bug 5718 : fix permission of moveitem = edit_items needed
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-09 09:33:36 +13:00
Paul Poulain
14422c8ed9 Bug 5700: MT4004 : additem.pl Some Status were not defaulted to the correct value Status 0 was lost because test was done on value and not on the fact that a value was defined or not. when value is 0 then it was not used as default value for
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-07 22:17:36 +13:00
Paul Poulain
60e0a76fc0 Bug 5699: don't discard $3 when building a record (UNIMARC specific)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-07 21:30:02 +13:00
Chris Cormack
a4cc394508 Bug 5691 - Delete all items respects independentbranches system preferences
Squashed commit of the following:

commit 66cdb8804136803a3f626d183c8f192f61f3c7b1
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:55:10 2011 +1300

    Bug 5691: Updating copyright statement

commit 79ef6c269afc9c644c51709a7657542a0fc6d7d6
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:52:13 2011 +1300

    Bug 5691 - Fixing a syntax error and tidying up some formatting

commit a66485dba113c05ed51a3b4ff19f788e335aa1f6
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Tue Oct 5 17:23:55 2010 +0200

    (MT #1365) Delete all items

    Using DelItemCheck in cataloguing/additem.pl
    when deleting all items

commit fe845fd48ab22ff82ad6d8971c468c327b49f3c4
Author: Christophe Croullebois <christophe.croullebois@biblibre.com>
Date:   Wed Sep 22 11:39:28 2010 +0200

    (MT #1365) Delete all items

    Now if IndependantBranches is on and a user try to delete all items, only the items of his branch will be deleted.
    A message explain this fact.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Followup: (MT #1365) Fixing up the English idiom
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-05 07:41:29 +13:00
Chris Cormack
aa398ed055 Bug: 4263 - Repeatable subfields in items
Squashed commit of the following:

commit f441094d5095d165eab18340c983a831cce8f6e0
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Mon Jul 5 20:33:23 2010 +0200

    bug4263 followup : Can't blank subfields

    Previous bug4263 reintroduced bug 2466: fix clearing item field
    This keeps bug4263 followup to be assigned (donot blank dateaccessioned)
    But also allow to blank item subfields.

commit 92889b766c41b48bdd0e3a33ca4b183b1e259805
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Apr 23 13:54:30 2010 +0200

    (bug #4263) dateaccessionned is cleaned on item modification

    Every item modification, date accessionned is cleaned, if there is no modification made, we must'nt reset to "undef" the value.

commit 5abb2db16b2564d32e84b7cc680acbc301d73179
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Mar 2 09:57:33 2010 +0100

    (bug #4263) fix the edition of items with repeatable subfields

    The subfield management in item level is broken, fields are concatenated in one field, and if the librarian edit it, the values are not selected.
    This big patch fix three things:
     1) saving fields that are stocked in SQL(using koha2marc mapping) are now well cut and separated in _REAL_ subfields
     2) loading records with repeatable subfields are now well returned
     3) Editing items with repeatable fields works well

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Bug 4263 Removing extranious block of code
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-03 16:08:08 +13:00
76338220dd Bug 5374 (update transaction date when saving biblio) RESENT with small fix
Currently, the plugin marc21_field_005 and its unimarc opponent fill field 005
when this field gets focus. This implies that updating a record without
touching this field does not update 005.
At the same time, a user could accidentally delete a character in the 005 when
having focus. This mutilated field value will be saved however.

I would suggest to add a few lines to ModBiblioMarc in Biblio.pm to ascertain
that adding or updating a record always updates 005 in marc21 as well as
unimarc.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-05 08:42:47 +13:00
240ce5a31c Fix for Bug 2122, Grayed out Fields not always visible
- Adding "readonly" class to readonly fields to guarantee
  that readonly state is indicated visually
- Adding "locked" icon to the background of readonly
  fields for additional visual feedback

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-17 21:21:29 +13:00
20be558069 bug 4866 follow-up - minor code formatting cleanup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-15 21:33:56 +13:00
baee3e5c9b Bug 4866 for master (Enable Change event for item plugins)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-15 21:33:54 +13:00
Andrew Elwell
efa66f1f55 Bug 5385: POD Cleanups (part 2)
More podchecker cleanups to eliminate warnings / errors

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:56 +13:00
Andrew Elwell
9fa574f609 Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:55 +13:00
07cfc5d69c Bug 5372 (v2) Existing value can be replace by default value
The way an existing value was tested was wrong. 0 is a valid value but a
false value for Perl.

=> replace privious proposal.

[3.2] Should also apply.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-08 09:24:22 +13:00
29432ee42c bug 5190: link to MARC21/UNIMARC online doc in the bib editor
Patch from  Tomás Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-02 14:55:18 +13:00
f987d35a22 Fix for Bug 5254 - no need to scroll left to right on acq z search
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
  line breaks, improving table width and horizontal scrolling.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-26 08:48:15 -04:00
424127ae40 bug 3597: "delete all items" no longer deletes checked out or waiting items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-21 22:56:04 -04:00
Katrin Fischer
d7b6d43a2e Bug 5092: No results when searching by LC Call Number: in Z39.50 Server
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:32:47 -04:00
57b171a3f5 Fix for Bug 2947, value_builder scripts using authnotrequired
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 08:20:23 -04:00
e1952c8ad7 Merge remote branch 'koha-fbc/k_bug_5215' into master
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 07:12:30 -04:00
Colin Campbell
c0e773c6e6 Bug 2664: Add item should preselect logged in branch
An earlier fix to stop branch values being overwritten in
edit items was causing the branch value to be unset when adding items

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:18:58 -04:00
Chris Nighswonger
01247f2fc0 Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl
The barcode field is not cleared/incremented properly when using the "Add and
Duplicate" option. Rather it is pre-populated with the previously used barcode
which causes additem.pl to return a duplicate barcode error if the cataloger
does not catch the mistake.

The problem is caused by the fact that the current item record is simply
duplicated and re-loaded into the form.

The solution is to add code which either pre-populates with the next barcode
number if the incremental pattern is set or clears the p subfield if one of the
various patterns using the javascript plugin is selected.

In reality C4::Barcodes should be implimented here along with all necessary changes elsewhere.
2010-09-10 15:28:08 -04:00
573ac9488f remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 10:57:08 -04:00
Henri-Damien LAURENT
39d70cf05b MT2938 : Adds a permission for editing items
This patch adds a permission on edit_items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 21:04:01 -04:00
ad1047dce7 Fix for Bug 3081, Url's contain spaces
My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:59:31 -04:00
ef58c445d3 removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 23:30:48 -04:00
b1ed3af633 bug 4311: respect OPACXSLTResultsDisplay
Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.

In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 11:22:47 -04:00
a2ad21ac9e removed unconditional warn introduced in previous patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 11:15:18 -04:00
Nahuel ANGELINETTI
b33e8739de (bug #4487) permit - and . in callnumber plugin
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 11:14:33 -04:00
Nahuel ANGELINETTI
3fac59ba6b (bug #4522) fix plugin unimarc 210$c
This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 09:14:34 -04:00
22eb0cfa1c fix two more instances of old FSF address
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 20:29:22 -04:00
4d50b4f4f0 Fix for Bug 4271, Offer choice of destination for save biblio operation
A follow-up to the fix for Bug 4121, the user should be able to control whether
the action of saving a bibliographic record takes them to the add item screen
or the detail screen, independently of whether they are adding or modifying the
record.

The addition of a "split button" would leave the default action in place if the
user clicked the "main" part of the button. Clicking on the menu would give the
user specific choices.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:39:10 -04:00
Donovan Jones
f394170ebc Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory 2010-04-21 20:27:05 +12:00
Lars Wirzenius
4523a2df0d Fix file permissions: if it is not a script, it should not be executable.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 00:40:34 -04:00
2dd58a4369 Fix for Bug 4121, Cataloging record modification should obey IntranetBiblioDefaultView pref
- Re-used redirect logic found in search.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 00:00:58 -04:00
Matthias Meusburger
e5d9c507d7 MT2663 : Adds an itemcallnumber plugin
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 13:12:31 -04:00
Paul Poulain
dd3d172b81 MT2502 : Reports Editor's 200$b to biblio's 210$c within unimarc_field_210c plugin
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 13:12:28 -04:00
Kyle M Hall
4791ee4ed3 Added plugin to automatically add brackets around the value in marc21 field 245h
This plugin will automatically add brackets around the value typed in at the time the field's focus is removed ( onblur ).
If the text in the field is already enclosed in brackets, it will do nothing.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 13:12:26 -04:00
Lars Wirzenius
5c42b6512e Fix FSF address in directory cataloguing/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:55 -04:00
Lars Wirzenius
6d749a6e9c Fix copyright license statements to use the right old address for the FSF.
Looks like someone has done some search/replace on character codes with
patterns that match the address. Oops.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:49 -04:00
Matthias Meusburger
59f31b9836 BZ4116: results from cataloging search is different from advanced search results
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-11 06:31:57 -05:00
Magnus Enger
8c62c84ac2 Fixes a typo in marc21_field_008.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 08:55:31 -05:00
Jean-André Santoni
664a538cb6 [MT2049] Stocknumber value builder 2010-01-28 15:11:54 +01:00
Matthias Meusburger
2f274f01a1 BZ4026 : Fix record's leader when merging records 2010-01-07 16:43:47 +01:00
Liz Rea
bae21b7fd5 Removed tab indexes in additem.pl to enable tabbing to buttons in order. Previously, tabbing through this form would skip the submit buttons. 2009-12-20 14:31:37 +01:00
Henri-Damien LAURENT
aaebd7e138 Bug Fixing additem : branchcode unwilling changes
branchcode was unconditionnally changed to user branch when editing an item
2009-11-26 21:55:10 +01:00