Commit graph

8404 commits

Author SHA1 Message Date
Joe Atzberger
75c0bef66f Remove bad use of map in void context, exclusively for side effects!
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:20 -05:00
Joe Atzberger
b687919fd1 Add Debug for warns and remove unnecessary middleman variables from returns.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:19 -05:00
Joe Atzberger
0855e8ef29 Show copy/volume info on STAFF detail page.
This change helps the staff side catch up w/ the OPAC display and be
more useful to librarians dealing with serials.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:17 -05:00
Joe Atzberger
797c1d5502 Bugfix is_approved() to handle the 3-state nature of approval.
That is, a term is either approved, or rejected, or neither.
Without an external dictionary, most terms will fall into the
latter category.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:41:40 -05:00
Paul POULAIN
df07dac1a9 minor changes in french translation
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:27 -05:00
Paul POULAIN
1d5616b1f6 french translation updated
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:25 -05:00
Paul POULAIN
40c67eef33 re fixing opac-suggestion < misplaced
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:21 -05:00
Paul POULAIN
11a61ee6df html fix (detected by translator)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:20 -05:00
Paul POULAIN
568d34354e small fixes in french translation
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:17 -05:00
Paul POULAIN
f3458d9577 fix to have the branch search on OPAC being really a branch search, not kw
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:15 -05:00
Paul POULAIN
6fc3c7cd9d display itemnote on check-out (added, was not here) & check-in (red-ed, was already here)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:14 -05:00
Ryan Higgins
938f053cbb Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:51 -05:00
Ryan Higgins
fad67f6ef2 add single-transaction flag to mysqldump in example backup script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:49 -05:00
Joe Atzberger
37c25f55b2 Restrict OPAC tags display to approved=>1.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:47 -05:00
Joe Atzberger
1d6078adea Correction to: Comment out confirmation popups (on successful events).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:46 -05:00
Joe Atzberger
47fa74d68f Comment out confirmation popups (on successful events).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:45 -05:00
Galen Charlton
fe202cdc94 kohabug 2078 - settle on application/xml Content-type for feeds
Required by IE6 to at least get a feed to display as XML
in the browser instead of being downloaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:55 -05:00
Galen Charlton
8fc6b927df kohabug 2078 - send correct Content-type for search feeds
OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.

As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type.  If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:54 -05:00
Galen Charlton
1a41d12a96 kohabug 2078 - removed ersatz ESCAPE="html" added in prior patch
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:50 -05:00
Galen Charlton
765c645536 kohabug 2078 - fixed channel links in Atom and RSS
query_cgi already includes the "q=" bit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:48 -05:00
Galen Charlton
fe65447e5b OPACBaseURL - do not tack on :443 if using SSL
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:47 -05:00
Galen Charlton
d177975239 kohabug 2078 - fix feed validation errors
Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:10 -05:00
Galen Charlton
5e5ce6b7f9 calculate OPACBaseURL instead of using syspref
Calculate OPACBaseURL from the
CGI environment variables instead of using the
system preference.  As a result of this patch,
it should be possible to change the hostname,
protocol, or port of the OPAC without having to
reset a system preference.

Also added a FIXME to opac/unapi - the URL of
the SRU/W server has no necessary relationship
to the URL of the OPAC.

Once this patch is confirmed, the syspref can
be removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:08 -05:00
Galen Charlton
28fb7a6c19 kohabug 2180 - improve display when fines block checkouts
If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:37 -05:00
Ryan Higgins
e613ef5a8c Apply item-level_itypes syspref to MARC export.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:36 -05:00
Ryan Higgins
34b4e77507 Independent-branchify MARC export. Add option to remove all holdings except your own, and force that behavior for independent branches. Also add accession date limit to export.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:35 -05:00
Ryan Higgins
fc98d228c2 Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:33 -05:00
Ryan Higgins
a5eb233c0c Remove commented deprecated code and a useless query on items.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:32 -05:00
Ryan Higgins
d8c4a8190e Remove a couple of warns.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:31 -05:00
3cb28152bb Items from Bug 2167 ("URL handling in staff client inconsistent"): Removing display of URL from moredetail.pl. URLs are now displayed on detail.pl just as they are in the OPAC. Also removing display of biblio-level call number. Item level call number is displayed already.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:53 -05:00
ffbb7fb0d0 Fix for bug 2183, "Account tab needs spacing between description and stadard text" Please note that this is a band-aid for a larger issue, described in Bug 2188
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:52 -05:00
Joe Atzberger
b7baaaa3ab Bugfix 1979 - display hold numbers. Note that hold priorities are still buggy.
But that is a separate bug from whether they display or not.
Also added basic error handling if biblionumber is not received, or
if biblionumber is bad, since that otherwise crashes the page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:50 -05:00
Joe Atzberger
b5c584993f Addresses Bug 2073, clarifying OpacCloud's limitations.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:48 -05:00
Joe Atzberger
ff604d4a8a Printers code paring, related to bug 2045. This does not resolve the bug,
but it converts the template to using loop_context_var, and removes unused
variables from the script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:46 -05:00
Joe Atzberger
cf89f763f5 Fix typo in field name, apply branchcode selector logic from fines-ll.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:39 -05:00
Joe Atzberger
97659a73ca FIXME added to note discrepancy.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:38 -05:00
Joe Atzberger
4073b27c50 Wrap up Tags integration - add sysprefs for new installs.
Note that when the user is not logged in, the Tags input box/button will not display.
The user will see a message telling them to log in to add tags.  However, in order to
keep the results display clean, the message will display only once, utilizing the loop
context variable "__first__".  Useful stuff!

I also threw OPACShelfBrowser sysprefs.sql, but it still needs added to updatedatabase.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:12 -05:00
Galen Charlton
57fb7e45b7 kohabug 2186 - improve display of empty import batches
[1] Display the "No records have been staged" message only
    if no import batches exist.
[2] When displaying a batch that has no bibs in it, display
    a "There are no records in this batch to import".  Also,
    do not display the "import record into catalogue" button
    for an empty batch.
[3] Add CSS class "problem" to both messages.

Documentation changes: minor; only required if screenshots
exist of the manage staged MARC records page that has no
import batches on it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:03 -05:00
Paul POULAIN
7ff55f6c40 BUGFIX issuingrules : total for all itemtype was not properly calculated
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 14:01:11 -05:00
Henri-Damien LAURENT
ee1674c9bd Adding orderby parameter : Fixes changing page in auth_finder.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 13:57:55 -05:00
Joshua Ferraro
60368d1049 From HDL:
I agree that opac-suggestions.tmpl modification is Not required any longer.
But still, the modification in opac-suggestions.pl is really necessary.
If you donot do that, ppl are presented with ALL suggestions and not
their suggestions by default, which is not what My Suggestions suggests.
2008-05-30 13:56:17 -05:00
Henri-Damien LAURENT
6f45077848 Adding search on ISSN for z3950_search.pl
seems that search on ISSN was not taken into account adding @or @attr 1=8

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 13:52:14 -05:00
Henri-Damien LAURENT
7e2e894bb3 removing autotruncate for authors.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 13:52:13 -05:00
NCE
34c08cf80c Fixing typo in DB update
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 12:32:07 -05:00
Paul POULAIN
7979f28cc0 add borrower note to check-in
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 12:00:16 -05:00
Paul POULAIN
df050c4c58 enhance the patron note on check-out (was not enough visible, now is red)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 12:00:07 -05:00
Paul POULAIN
7c1312a13f If the catalogue contains a value that is not in authorised values and it should, display the code
very usefull for us (UNIMARC) to find languages that are in the database but not in the auth values.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:57:38 -05:00
Paul POULAIN
39eb269d01 Displaying branchcode and notes fields in full serials issue table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:57:35 -05:00
Paul POULAIN
67ffed7fec Respect BiblioDefaultView when search returns only 1 result & jump directly to the detail
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:57:34 -05:00
Paul POULAIN
c01d0d65a1 small (UNIMARC) fix, error in regexp writing
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:49:37 -05:00