Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
13439 commits 35 branches 616 tags 1.8 GiB
Commit graph

435 commits

Author SHA1 Message Date
Galen Charlton
958b5a097c new C4::Auth::get_session for single place to get CGI::Session object 
Refactoring to provide single place to get CGI::Session ojbject;
fixes bug for DB storage method other than 'mysql'.

This refactoring is also part of the patch series for
handling large input files for staging and processing
MARC records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-25 16:43:26 -06:00
Ryan Higgins
cb1ec158c0 Adding calendar widget to circulation/stickyduedate 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-20 16:27:25 -06:00
Ryan Higgins
88e913046a fixing pending reserves to use dates specified 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-16 07:12:08 -06:00
Joshua Ferraro
687c83370e fixes to date handling 2007-11-13 20:41:46 -06:00
Chris Cormack
d8d27ab898 Missing AND in the SQL in pendingreserves.pl only if independentbranches was turned on 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-13 18:05:07 -06:00
Ryan Higgins
9c2d58a470 update item-at-wrong-branch error message to show homebranch. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-13 12:46:45 -06:00
Chris Cormack
5342904792 We were calling get biblioitemdata when we should have been calling get bibliodata 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-13 11:19:26 -06:00
Chris Cormack
5fa4703ee0 Fix for 404 error when clicking on a reserve in circulations 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-12 17:40:23 -06:00
Ryan Higgins
3967fa9c79 further mods to change from ccode to itype at item-level itypes. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-11 18:40:20 -06:00
Chris Cormack
24af640015 Rest of the fix for 1402 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-07 08:05:20 -06:00
Joshua Ferraro
58d3b163d0 merge mason's fix to circulation 2007-11-06 06:19:17 -06:00
Mason James
275e3eb8b1 undeclared @issued_itemtypes_count_loop; 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:18:15 -06:00
Joshua Ferraro
9e8dc6b021 adding back my @issued_itemtypes_count_loop; 2007-11-05 08:41:11 -06:00
Ryan Higgins
371efb047b adding item-level itypes: based on systempref: item-level_itypes, we use items.ccode as the circ code rather than biblioitems.itemtype. This is initial commit -- still requiring interface changes basic loanlength, maxissues should be by ccode now. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:37:53 -06:00
Ryan Higgins
d6eea9c622 fixed redefined itemtype_count variable . 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:37:38 -06:00
Owen Leonard
b453d173ae Standardizing information shown in sidebar when patron-related pages are displayed (making sure address, phone, email variables are available to all templates). Adding tabs to account-related pages as means of section navigation. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:31:32 -06:00
Owen Leonard
4a9745dbb0 More interface changes for circulation: Further tweaking of circ warning dialog, formatting patron selection form, adding 'focus' class to patron selection select list. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:31:02 -06:00
Ryan Higgins
dac69bc799 Couple of minor changes to staff client view on patron. 
item-level_itypes still need display changes in both opac and staff.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:27:59 -06:00
Chris Cormack
ff179bb1d4 Fix for bug 1518 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-29 16:21:46 -05:00
Paul POULAIN
8b7085a8ab removing useless code 
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-24 17:03:38 -05:00
Frédéric DEMIANS
b6e604c80e patch 
See attached file. Thanks.

>From 1c3021f31675193ad2e9b91a95191f9ae0caeff2 Mon Sep 17 00:00:00 2001
From: Frederic Demians <f.demians@tamil.fr>
Date: Wed, 24 Oct 2007 11:50:08 +0200
Subject: [PATCH] Borrower name autocompletion improvement
 Autocompletion is selected by syspref directly in circ-search.inc.
 This way it could be activated elsewhere just by adding CircAutocompl
 param into page using circ-search.inc.
 Done for example in circ/branchtransfers.pl. Must be done in all other
 circ/*.pl pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-24 17:01:41 -05:00
Chris Cormack
53be8065d1 Fix for bug 1456 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-22 19:58:14 -05:00
Chris Cormack
c3c520b385 Working on a fix for bug 1456 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-21 21:55:57 -05:00
Frederic Demians
701d6ef020 Circulation borrower name autocompletion 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-20 16:17:08 -05:00
Joe Atzberger
6f15e48f65 circulation.pl cleaned up. I think you'll like the difference. Less 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-18 21:21:31 -05:00
Chris Cormack
606ecb532a Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-18 16:27:04 -05:00
Owen Leonard
b4d14e4558 Adding new circulation-home, what we ultimately hope to be a "dashboard" interface for circulation functions. circulation-home.pl was created by copy-and-paste, so it should be reviewed. Circulation sub-pages' breadcrumb links have been updated to point to circulation-home. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-18 16:26:04 -05:00
Henri-Damien LAURENT
d1c03deb7e Reintroducing overdue filters. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-11 15:56:02 -05:00
paul
a5bd240321 FIX for Date calculation 
Rule :
- always format_date() before sending date to template
- always format_date_in_iso immediatly after reading a date coming from a parameter
- deal internally only with dates in iso

Note that :
- I could not test things related to issues stats due to the my DB -issues.issuedate not filled, see commit about 3.00.00.006
- acquisitions_stats does not work when you filter on date

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-11 11:51:12 -05:00
Paul POULAIN
47321d0068 Adding dates for display to circulation.pl Minor bug fixes. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-09 18:44:46 -05:00
Chris Cormack
ee56e731ab Fix for bug 1436, changing to use issuedate, not timestamp for sorting issues 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-30 20:45:46 -05:00
Owen Leonard
34b67109d1 A couple more tweaks to member entry form. Still unfinished: inline CSS will have to be generalized and moved to external stylesheet. Trying some changes to circ page, including moving patron info into sidebar, consolidating messages and warnings. Also unfinished! 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-25 14:47:02 -05:00
Owen Leonard
a37daca905 More efforts with toolbars, nothing solved. Also corrections, and modifications to resident search to place focus on displayed form field. 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-25 14:46:56 -05:00
Paul POULAIN
c4d4b6ecf2 Bug fixing : 1396 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-24 15:31:40 -05:00
Paul POULAIN
3568e20644 bug fixing on 1396 : 
Conflicts:

	circ/circulation.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-24 15:29:42 -05:00
Chris Cormack
1a4fc157bf Applying the fix for bug 1416 from paul 
Had to edit the patch as it was corrupt
 2007-09-20 17:39:43 -05:00
Paul POULAIN
e809eff05f BUGFIX : branch CPL was hardcoded 
What is the branch CPL ?

Anyway, this was buggy and reseted the branch to empty
which was a bug ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-18 15:06:47 -05:00
Chris Cormack
f12fc20e1d Fix to get selectbranchandprinter working fine with the Session 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-06 20:48:13 -05:00
Paul POULAIN
497bbd84b0 show the departure date if close or past 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-08-14 21:32:22 -05:00
Joshua Ferraro
cefeb583ad fixing permissions on scripts 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-08-13 12:22:30 -05:00
Joshua Ferraro
e9ae8c0686 patches from paul 2007-08-08 07:41:19 -05:00
Chris Cormack
2e4a11773c Merge branch 'master' of /home/jmf/repos/koha-rm-root.git/ 2007-08-08 07:36:43 -05:00
Paul POULAIN
19aa1c7a5a formatting date 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-08-08 07:25:09 -05:00
kados
40af15d8e6 changing permissions on templates and scripts 2007-08-07 13:20:51 -05:00
jmf@arwen.metavore.com
c0d85e87b4 From 0751ba130288bc69e9e563473e7fc25551edc40e Mon Sep 17 00:00:00 2001 
From: kados <jmf@arwen.metavore.com>
Date: Sat, 4 Aug 2007 20:10:51 -0500
Subject: [PATCH] fixing permissions on all scripts

Signed-off-by: Chris Cormack <crc@arwen.metavore.com>
 2007-08-04 22:41:41 -05:00
toins
ee5c4c303c display enhancement. 2007-07-24 14:17:07 +00:00
toins
cae655f928 removing a compilation warn. 2007-06-05 09:48:31 +00:00
toins
738d04c2ca chmod +x 
using output_html_with_http_headers instead of a print "..."
 2007-06-05 09:48:06 +00:00
tipaul
577a7bf094 some (minor, functionnaly speaking) bugfixes 2007-06-05 08:54:17 +00:00
tipaul
a04f92a30a some minor bugfixes, templates improvements & zebra default config file changes 2007-05-29 16:36:11 +00:00
tipaul
5ff7fcffa4 Bugfixes & improvements (various and minor) : 
- updating templates to have tmpl_process3.pl running without any errors
- adding a drupal-like css for prog templates (with 3 small images)
- fixing some bugs in circulation & other scripts
- updating french translation
- fixing some typos in templates
 2007-05-22 09:13:54 +00:00
hdl
286930bdc7 Changing GetMarcStructure signature. 
Deleting first parameter $dbh
 2007-05-22 08:50:47 +00:00
alaurin
5c4a2c3e4b bugfixing for circulation. 2007-05-04 10:18:00 +00:00
hdl
097fef712a Removing $dbh from GetMarcFromKohaField (dbh is not used in this function.) 2007-04-27 14:00:48 +00:00
hdl
a171035f1d GetBorrowerIssues is deleted from C4::Circulation 
Use GetPendingIssues from C4::Members instead.
 2007-04-25 14:07:34 +00:00
tipaul
fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
tipaul
ee40bfb5c6 removing reserve.pl (moved to pendingreserves.pl) 2007-04-24 16:09:11 +00:00
hdl
b642e687d2 Still Code Cleaning. 
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
 2007-04-24 15:41:27 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output. 
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
 2007-04-24 13:54:28 +00:00
tipaul
4dea4d29b3 moving dotransfer to Biblio.pm::ModItemTransfer + some CheckReserves fixes 2007-04-24 09:07:53 +00:00
tipaul
0c020dd8bf renaming reserves & branchreserves to pendingreserves and waitingreserves 2007-04-23 16:42:59 +00:00
tipaul
9f42b8ad49 renaming currenttransfers to transferstoreceive 2007-04-23 15:21:17 +00:00
tipaul
3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl
0b66bd800d Code Cleaning Members. 
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
 2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
5af8ae975b removing "department" and replacing by items.location 2007-04-18 14:20:54 +00:00
tipaul
43ad7fb4df circulation cleaning continued: working on branchtransfers.pl (unfinished, but at least it compiles... 2007-04-17 16:24:59 +00:00
tipaul
b71839d85c circulation cleaning continued: bufixing 2007-04-17 08:44:49 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation. 
some stuff to do, i'll write a mail on koha-devel NOW !
 2007-04-04 16:46:22 +00:00
alaurin
d23c6c9955 bugfixing of warnings in current transfers and waitingreservestranfers 
same bugfixing as branchreserves
 2007-04-03 15:41:36 +00:00
alaurin
6f84890152 bugfixing for displaying the maxpicking delays for reservations, now the method of date works is using 
Add_Delta_Days and not delta year and month
now the system working
 2007-04-03 15:04:30 +00:00
tipaul
987ceb8ce7 using C4::Date instead of C4::Circulation::Date 2007-03-30 11:58:48 +00:00
kados
b4d72b977f fix for bug 1276: Cannot search for patron wtih apostrophe in their name 2007-03-18 04:13:21 +00:00
kados
d126742c41 finish fixing spelling error on department 2007-03-10 06:28:06 +00:00
kados
9f4bf0d7f5 fix spelling department 
improve English grammar in template
 2007-03-10 06:22:52 +00:00
tipaul
f8e9fb6445 rel_3_0 moved to HEAD (introducing new files) 2007-03-09 15:34:17 +00:00
tipaul
70501283b3 rel_3_0 moved to HEAD 2007-03-09 14:41:32 +00:00
tipaul
2ffd5b7228 rel_3_0 moved to HEAD 2007-03-09 14:28:54 +00:00
tgarip1957
4843e0ee78 Resynching Savannah 2006-11-15 01:41:51 +00:00
tgarip1957
04b2e6112f Finalized XML version for intranet 2006-09-27 21:19:21 +00:00
tgarip1957
7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
toins
3c6410111b subs renamed according to coding guidelines. 2006-07-21 10:10:29 +00:00
toins
cc9524a875 Head & rel_2_2 merged 2006-07-04 14:36:51 +00:00
rangi
f30b030af8 Code to allow the associated borrowers to work 2006-06-20 22:35:47 +00:00
alaurin
193e22714f Add a new system preference 'AutomaticItemReturn' : 
if this prefence is switched on: the document returned in another library than homebranch, the system automaticly transfer the document to his homebranch (with notification for librarian in returns.tmpl) .

switch off : the document stay in the holdingbranch ...

correcting bugs :
- comment C4::acquisition (not using in request.pl).
- correcting date in request.pl
-add the new call of function getbranches in request.pl
 2006-06-08 15:36:31 +00:00
bob_lyon
975030608c merging katipo changes... 
allow the getting of only issuing branches only
 2006-06-07 04:43:48 +00:00
bob_lyon
3e64f4abd4 merging katipo changes... 
adding in new set_transit sub
 2006-06-07 04:39:37 +00:00
bob_lyon
9161eba4bd merging katipo changes... 
Adding flag for being in credit vs being in debt and added checks to see if
one can renew before trying to renew
 2006-06-07 04:13:22 +00:00
bob_lyon
92d88b35a7 merging katipo changes... 
frbranchcd was being passed tobranch info from transferbook
 2006-06-07 03:29:19 +00:00
alaurin
46c9e24e9d new fonctions for returns.pl : 
- the system check if we don't have another reserv for the document returned, we return the document to his homebranch, ......
- improvement of returns,  adapt item reservation , loan rules, and transfer rules ....
 2006-06-06 12:46:52 +00:00
alaurin
3ca97f8c15 new color alerts for the differents kind of reserves (available,on transfer, on loan ......) + warning color .... 
+ minor changes of templates
 2006-06-06 12:30:43 +00:00
alaurin
0f00577a9e bug fix : for item reservation, now the system don't keep the reserve if the document is returned, works fine !!!! 2006-06-06 12:26:57 +00:00
alaurin
795fffef13 Improvements for reserves infos in circulation.pl 
new infos displayed :

 -Waiting position of borrower on document reserve .
 -Follow the document he's in transfert 	.
 -more infos of document are displayed in a specific cell ....

N.B : the old display of reserves infos are only commented, will be removed, if new display is ok for everybody ...
 2006-06-01 10:03:08 +00:00
rangi
c1c08d65b1 Allows a person to choose an associated borrower (orgranisation) when Issuing. 
This is to allow a person who is associated with many organisations to choose the one he/she is borrowing an item for

No changes to the issuing code, or the issues table, the associated borrower number is stored in the statistics table
 2006-06-01 01:44:16 +00:00
alaurin
f3fd911dc8 bugfixing of the itemtypes infos in branchreserves,currenttransfers,waitingreservestransfers 2006-05-30 12:03:54 +00:00
alaurin
c98bae12bb new dev : create 3 new program for circulation : 
branchreserves : to see reserves for one library (with the branchip selection or librarian preferences)

currenttransfers : show all the transfers are waiting in the library

waitingreservetransfers: show all the book the librarian have to transfer to an another library .

"actions" are bugged, will be corrected .
 2006-05-19 17:01:02 +00:00
plg
dc986ecac5 bug fixed: the issue timestamp had not the same format as the today's date 
to which it was compared. The comparison separate issues on display between
today issues and older issues.
 2006-03-31 15:31:44 +00:00
tipaul
d5938493d7 synch'ing head and rel_2_2 (from 2.2.5, including npl templates) 
Seems not to break too many things, but i'm probably wrong here.
at least, new features/bugfixes from 2.2.5 are here (tested on some features on my head local copy)

- removing useless directories (koha-html and koha-plucene)
 2006-01-06 16:39:37 +00:00
tipaul
b38997925f big commit, still breaking things... 
* synch with rel_2_2. Probably the last non manual synch, as rel_2_2 should not be modified deeply.
* code cleaning (cleaning warnings from perl -w) continued
 2005-10-26 09:11:02 +00:00
tipaul
e82eca42c9 see mail on koha-devel : code cleaning on Search.pm + normalizing API + use of biblionumber everywhere (instead of bn, biblio, ...) 2005-09-22 10:01:45 +00:00
genjimoto
f9d2fa784c modified script to enable circulation system to show picture of borrower for verification purposes. 2005-08-22 12:53:48 +00:00
oleonard
98687d85ad Synch with rel_2_2: Fixing section that was supposed to allow for alternating table row colors 2005-07-19 18:52:37 +00:00
tipaul
4dea4ae494 synch'ing 2.2 and head 2005-05-04 08:50:48 +00:00
tipaul
93ff09d081 merging 2.2 branch with head. Sorry for not making it before, many many commits done here 2005-03-01 13:40:35 +00:00
oleonard
cb2dc1d759 Adding 'flagged' variable to help control display in the template 2005-02-16 22:25:17 +00:00
oleonard
ea39d8bd8f Adding email address to list of returned variables 2005-02-10 17:27:32 +00:00
tipaul
52a123a1a4 fix for : 
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=858

* added a button to cancel issue
* adding checkbox to cancel reserve on the book (checked by default)
* the cancelation reserve is done on reserves done for a given item or for any item

Nelsonville, pls test & confirm it's OK
 2004-12-15 10:47:09 +00:00
oleonard
000a96fb4b Fix from Joshua for Bug 851: stripping out comma and apostrophe from search terms 2004-12-13 17:54:15 +00:00
rangi
1ce34b32b3 Fix for bug 865 
Allows a librarian to tell Koha you want to start issuing to a new borrower
by entering no data. Essentiall by just hitting the enter  key
 2004-11-28 08:32:36 +00:00
tipaul
1424addcc2 fix for bug 858 (no warning when issuing a reserved book) 2004-11-18 10:32:39 +00:00
oleonard
935db49ba8 Re-adding patrontable subroutine so that borrower flags and waiting item information can be displayed 2004-11-03 22:40:14 +00:00
tipaul
9aec896627 * Showing the borrowernotes in issues (was shown only in issues before) 2004-10-04 20:29:07 +00:00
tipaul
f927e8eb36 bugfix for manually fixed duedate on issue. 2004-09-15 16:27:18 +00:00
tipaul
ab39e57393 fixes in circulation module 2004-08-18 15:52:14 +00:00
oleonard
00fc740011 Adding overduecount, issuecount, and finetotal variables to template 2004-07-12 20:44:48 +00:00
tipaul
cc5e837309 bugfixes in circulation 2004-06-17 08:17:39 +00:00
tipaul
b56f035183 bugfixes 2004-05-03 16:36:53 +00:00
tipaul
040bcdf92b CIRCULATION : the big rewrite... 
This 1st commit reorders deeply the circulation module.
The goal is to :
* have something 100% templated/translatable.
* have something easy to read & modify, to say to customers/users : you can define your circulation rules as you want if you accept to look in C4/Circ/Circ2.pm

The circulation now works :
1=> ask for the borrower barcode (as previously)
2=> ask for the item barcode.
3=> check "canbookbeissued". This new sub returns 2 arrays :
- IMPOSSIBLE : if something is here, then the issue is not possible and is not done.
- TOBECONFIRMED : if something is here, then the issue can be donc if the user confirms it.
4=> if TOBECONFIRMED is set : ask for confirmation, loop. if neither  are set or confirmation flag is set (2nd pass of the loop), then issue.

The IMPOSSIBLE & TOBECONFIRMED hashs contains :
* the reason of the line. always in capitals, with words separated by _ : BARCODE_UNKNOWN, DEBTS ... as key of the hash
* more information, as value of the hash ( TOBECONFIRMED{ALREADY_ISSUED} = "previous_borrower_name", for example)

This commit :
* compiles
* works on certain situations, not on other
* does NOT issue (the line is # )
* does not check issuing rules depending of # of books allowed / already issued

The next step is :
- check issuing rule.
- extend issuing rule to have a 3D array : for each branch / itemtype / borrowertype = issuing number and issuing length.
 2004-05-03 09:10:51 +00:00
tipaul
21a379acda CIRCULATION : the big rewrite... 
This 1st commit reorders deeply the circulation module.
The goal is to :
* have something 100% templated/translatable.
* have something easy to read & modify, to say to customers/users : you can define your circulation rules as you want if you accept to look in C4/Circ/Circ2.pm

The circulation now works :
1=> ask for the borrower barcode (as previously)
2=> ask for the item barcode.
3=> check "canbookbeissued". This new sub returns 2 arrays :
- IMPOSSIBLE : if something is here, then the issue is not possible and is not done.
- TOBECONFIRMED : if something is here, then the issue can be donc if the user confirms it.
4=> if TOBECONFIRMED is set : ask for confirmation, loop. if neither  are set or confirmation flag is set (2nd pass of the loop), then issue.

The IMPOSSIBLE & TOBECONFIRMED hashs contains :
* the reason of the line. always in capitals, with words separated by _ : BARCODE_UNKNOWN, DEBTS ... as key of the hash
* more information, as value of the hash ( TOBECONFIRMED{ALREADY_ISSUED} = "previous_borrower_name", for example)

This commit :
* compiles
* works on certain situations, not on other
* does NOT issue (the line is # )
* does not check issuing rules depending of # of books allowed / already issued

The next step is :
- check issuing rule.
- extend issuing rule to have a 3D array : for each branch / itemtype / borrowertype = issuing number and issuing length.
 2004-05-03 09:02:12 +00:00
rangi
9ab6c09048 Passing thru the borrowernumber with the charges data, so can create a link 
to the payment window
 2004-03-15 23:41:20 +00:00
rangi
1d2a764626 fix for bug 606, 
seems to be an error in the tmpl still but the functionality seems to be working again
 2004-02-25 21:44:40 +00:00
oleonard
e0d4eee48f Small changes to help fix Bug 436 2004-02-25 18:09:29 +00:00
oleonard
7a2a0fe018 Adding item information variable declarations to 'Waiting' section already present in 'Reserved' section 2004-02-18 16:51:20 +00:00
oleonard
84b3a7b984 Adding variable declarations so that 'waiting' screen shows same information 'reserved' screen does, adding more address info 2004-02-17 22:15:33 +00:00
tipaul
af08d677c5 synch'ing 2.0.0 branch (RC4 tag) and head 2004-02-11 08:42:01 +00:00
oleonard
0f8e6bfb73 Added variables available to template: streetaddress, city, phone, cardnumber. Added FIXME comments to sections where HTML should be moved to template 2004-01-26 19:32:36 +00:00
rangi
cf67d8bb8f Bug 605 fixed 2004-01-21 20:49:54 +00:00
rangi
9c998cda51 Fix for bug 535, and adding the classification column to the variables 
available to the template
 2003-11-04 19:48:50 +00:00
rangi
d187195a75 Fix for bug 592 
Re-issuing book does not renew correctly
 2003-10-31 21:02:16 +00:00
rangi
5a808e96ef Fix for bug 621, 
Returns not marking reserves waiting
 2003-10-28 19:34:05 +00:00
rangi
8576e81ea9 moving more html out of the script 2003-10-22 20:01:28 +00:00
rangi
68067f6400 Fix for bug 436, thanks to Pierre 2003-10-16 20:36:25 +00:00
rangi
985af48c45 Fixing bug 619 2003-09-25 09:11:24 +00:00
rangi
80ab9dee1d Fix for returns error message always displaying 2003-08-04 21:47:23 +00:00
rangi
4fe953202a fix for bug 535 2003-07-24 08:33:35 +00:00
rangi
44ee726663 Fixing the internal server error bug 2003-07-10 09:39:12 +00:00
tipaul
c101d517bb *** empty log message *** 2003-07-07 14:46:55 +00:00
plugz
a0de7c08fd Added allowborrow to the template parameters to check if a borrower can borrow books or not according to the "borrow" flag. 2003-07-01 11:22:48 +00:00
rangi
f8d250abfa Fixing the sticky due date problem reported by jerome 2003-06-26 09:31:39 +00:00
tipaul
a72d9621ae removing searchborrower from circ2.pm. 
Already exists in Search.pm
this fixes bug #439 and improve consistency.
 2003-06-05 17:03:31 +00:00
rangi
02196feed9 Shifted the todays issues and previous issues html out into the template 
And fixed a bug that was causing the enter a borrowers card or surname box
to show. Even if you were currently issuing to a borrower
 2003-05-30 20:37:09 +00:00
wolfpac444
d9ebc9a714 Fixed bug #169 2003-05-08 13:04:15 +00:00
wolfpac444
be884f5b62 *** empty log message *** 2003-05-08 11:19:49 +00:00
tonnesen
f34f75ebd7 circulation.pl also has to set the branch and printer cookies. 2003-05-05 21:22:24 +00:00
tonnesen
f457e68515 Script was not setting cookies for branch and printer. 2003-05-05 20:57:56 +00:00
tipaul
22567447ce *** empty log message *** 2003-04-29 16:51:15 +00:00
tipaul
0435cd1e25 last commits before 1.9.1 2003-04-04 08:44:39 +00:00
tipaul
9b2028ab72 some fixes, and links to themelang/images 2003-03-11 15:13:18 +00:00
tipaul
edf5485626 templating circulation.pl 
works poorly for instance
 2003-03-10 15:16:29 +00:00
acli
bf5fb01d32 Make sure flagsrequired is *circulate* not parameters 2003-02-06 05:10:54 +00:00
acli
993c57941b Fixed bug 202, the branch menu-building code has spurious checks for CU and 
IS fields, which does not exist, resulting in no branches being added

For selectbranchprinter:
Noted correct tab size
Handle non-latin1 charsets

For branchtransfers:
Use getbranch and getprinter
Removed spurious checkauth call and associated unused variables
 2003-02-05 09:07:09 +00:00
acli
4d7c1a0ca3 Missing "use" statement 
Noted correct tab size
 2003-02-05 08:04:00 +00:00
acli
c965f345cd Fixed bug 200; a "last" was placed in the wrong place 
The file does not use 4-character tabs, nor 8-character tabs, it uses both
(!); updated comments.

Catch more $code's; is this (and the change to Circ2.pm) what was intended?
 2003-02-05 07:57:56 +00:00
acli
f475af255f Implemented fixes for bug 170 
1. Circ2::returnbook will throw an exception if $branch is undef
2. branch/printer-getting code is modularized into getbranch and getprinter
   with correct logic from circulation.pl (temporarily put into Circ2.pm)
3. circulation.pl and returns.pl modified to use above functions

Noted correct tab sizes for the files; returns.pl partially reformatted to
conform to the dominant correct tab size

Handle non-latin1 charsets for returns.pl
 2003-02-05 06:28:56 +00:00
acli
52a5fd4bbd Moved C4/Charset.pm to C4/Interface/CGI/Output.pm 
Create output_html_with_http_headers function to contain the "print $query
->header(-type => guesstype...),..." call. This is in preparation for
non-HTML output (e.g., text/xml) and charset conversion before output in
the future.

Created C4/Interface/CGI/Template.pm to hold convenience functions specific
to the CGI interface using HTML::Template

Modified moremembers.pl to make the "sex" field localizable for languages
where M and F doesn't make sense
 2003-02-02 07:18:37 +00:00
hdl
a0f2bc96a3 Templating : returns.pl 2003-01-29 22:45:07 +00:00
hdl
38ca2b91a2 Adding variable declarations 2003-01-28 00:49:55 +00:00
hdl
6bff70151f Templating branchtransfers.pl 2003-01-28 00:48:36 +00:00
hdl
1f36d6776a Templating : selectbranchprinter.pl 2003-01-23 11:29:13 +00:00
rangi
12c6a26124 Fixing typo, thanks ambrose for spotting this 2003-01-15 03:47:46 +00:00
tonnesen
7aeb26593b Merging changes from rel-1-2 into trunk (circulation module only) 2002-10-24 18:30:17 +00:00
arensb
5aa0fca7fa Removed trailing whitespace. 2002-10-13 10:43:54 +00:00
arensb
eb57e3b92a (bug workaround): Commented out some code that removes everything from 
the list of branches the user can select.
Added some FIXME comments.
 2002-10-12 18:57:41 +00:00
arensb
4e79364d43 Added some FIXME comments. 2002-10-09 14:29:39 +00:00
arensb
f76faf6f02 (bug fix?) What looks like possibly a line left over from debugging 
was giving me an empty branch list, so transfers didn't work.
 2002-10-09 14:28:51 +00:00
arensb
dbca39823f Merged with arensb-context branch: use C4::Context->dbh instead of 
&C4Connect, and generally prefer C4::Context over C4::Database.
 2002-10-05 09:44:27 +00:00
arensb
80a4896fd4 Added a wishlist FIXME comment. 2002-09-28 04:59:19 +00:00
rangi
a68e85669b fixes for the ordering of the issues table in issues, and also on the 
printed slip
 2002-09-14 00:57:27 +00:00
finlayt
4867288671 changed the way Waiting items are transfered from returns.pl to Circ2.pm 2002-09-05 00:16:39 +00:00
finlayt
01d6f11543 Changed so that when a Waiting item is returned the holding branch is updated. 2002-09-05 00:06:30 +00:00
finlayt
0883b382b9 Fixed bug in flags display 2002-08-29 00:00:45 +00:00
finlayt
d8e359ce2f added another link on the "Reserve Found" flag. 2002-08-22 04:20:33 +00:00
finlayt
bb97d5133a fixed bug caused by last commit 2002-08-21 04:35:13 +00:00
finlayt
26957b08de turned of the branchtransfer when an item is set to "waiting". 2002-08-21 04:29:03 +00:00
finlayt
4b1f369036 Fixed up some of the messaging stuff. 2002-08-21 03:54:39 +00:00
finlayt
236e3babd1 Fixed a little bug so that flags get recalculated after an item is issued. 2002-08-21 01:40:47 +00:00
tonnesen
bac842beda Removed '_' between issues, returns, and transfers graphics 2002-08-16 20:46:40 +00:00
finlayt
0f4b30b89c Changed the wording of the reserves print slip slightly. 2002-08-15 22:26:34 +00:00
finlayt
13e3a38889 changed the color to red and size to +2 for the Issuing Question.... 2002-08-15 03:13:44 +00:00
tonnesen
1e67687742 Added copyright statement to all .pl and .pm files 2002-08-14 18:12:50 +00:00
finlayt
0f93387146 all items are listed in the returned items list, regardless of whether they were issued or not. 
Changed some messageing stuff as well, but will be back to fix that up some more.
 2002-08-14 05:35:53 +00:00
finlayt
7d440c782f changed the previous issues to be listed in order of due date 2002-08-09 04:14:56 +00:00
finlayt
67e285299d fixed up the todays issues and previous issues tables so that they are both listed in reverse order by issue date. 2002-08-09 04:03:43 +00:00
finlayt
ba793f7604 added the itemtype code to the printed slip that goes in a reserved book. 2002-07-26 02:27:16 +00:00
finlayt
3e5a9b644e added the book title and author to the reserve messages. 2002-07-26 01:09:55 +00:00
finlayt
52e5f54401 removed warn statement 2002-07-24 05:11:07 +00:00
finlayt
51e0e140c2 Fixed up the Print module. Added a function printslip that takes a string as an argument. It is easier to prepare the slip and then call the print function. 
in circulation.pl I have moved some javascript out to the circulation-top.inc
 2002-07-24 03:16:21 +00:00
finlayt
ee16dd23ff fixed up the reserves. Can view the printed slip before it is printed! 2002-07-24 03:14:04 +00:00
finlayt
c78de2bcb8 changed the behaviour when a reserved book is returned according to the wishes of HLT. 2002-07-23 03:28:36 +00:00
finlayt
ae3d808003 fixed up some little bugs around the big buttons that change between issues, returns and transfers 2002-07-23 01:28:42 +00:00
finlayt
6e9129444f these files were old versions that are not currently used. 2002-07-22 22:40:32 +00:00
finlayt
a1afd5ab09 changed the wording of two messages. see http://bugzilla.katipo.co.nz/show_bug.cgi?id=1390 2002-07-19 03:33:52 +00:00
rangi
c4d0d2f54e Regex to change the javascript to make cursor start in barcode box 2002-06-28 23:43:16 +00:00
rangi
c509c3d633 pop up pay window is working again 2002-06-19 01:32:37 +00:00
rangi
d8b356d441 Fixing issues which i broke just before ... perhaps one more commit today. 
Issues used to pop up a payment window when a borrower had finished issuing
and had money to pay.
We seem to have lost that, ill try and get it back
 2002-06-19 01:04:47 +00:00
rangi
78c976aa0f issues printing issue slips again 2002-06-18 22:46:59 +00:00
rangi
1e9225fd51 Fix to get sticky due date working 2002-06-13 03:17:18 +00:00
rangi
49e2b90a8b Fix to get list of overdue items showing correctly 2002-06-13 03:16:55 +00:00
finlayt
2bb0991120 fixed minor bugs 2002-06-06 02:51:38 +00:00
finlayt
e6099545cc Most everything is fixed now in returns, including the way it displays (a little). 2002-05-30 01:32:29 +00:00
finlayt
e9bfecc3a4 Fixed up the reserves code to use the new Reserves2.pm methods. 2002-05-29 05:50:52 +00:00
finlayt
da147ed714 Added the reserves functionality. Now calls a bunch of routines from Reserves2.pm 2002-05-29 04:33:42 +00:00
finlayt
3f876641ca Changed the wording of error message from: 
"Cannot transfer item to branch it is already at"
to: "Item already at destination branch"
 2002-05-18 05:38:57 +00:00
finlayt
d06de68d9e fixed a little bug with cookies and setting the branch and printer settings. 2002-05-18 05:37:26 +00:00
finlayt
73706c24f7 improoved layout and branch and printer settings are displayed 2002-05-18 05:07:26 +00:00
finlayt
4a54639472 Completely new. This file handles the issues, and sets branch and printer 
cookie.
 2002-05-18 05:05:53 +00:00
finlayt
65b3df77cc fixed the branch and printer setting mechanism 
changed layout slightly
 2002-05-18 05:04:43 +00:00
finlayt
efee891bca script for changing the branch and printer settings, taken from circulation.pl 2002-05-18 05:02:25 +00:00
finlayt
2131829c6b changed the destination branch dropdown to only show branches that have 
categorycode == CU, ie can be current branch.
 2002-05-07 04:36:00 +00:00
finlayt
277f3490be Changes to circulations: 
added returns.pl  ->  deals with the returns only
moved old circulation.pl to circulationold.pl which still deals with issues.
fixed up branchtransfers.pl
moved circulation2.pl to circulation.pl

Note more changes coming next week
 2002-05-02 00:06:28 +00:00
finlayt
cf973f53bb Changed heading to look like the rest of Koha 2002-03-14 01:51:16 +00:00
finlayt
6c91f693a5 Added a heading to be consistent with rest of Koha 2002-03-14 01:50:17 +00:00
finlayt
b9ee6194bf This is the begining of a process of dividing up circulation.pl 
This script deals with the branch and printer selection stuff
 2002-03-14 01:04:00 +00:00
finlayt
501da7db0d Fixed a small problem in the <form>, not hidden inputs are getting passed 
correctly.
 2002-03-13 21:07:41 +00:00
finlayt
9d891b5f41 Branchtransfers.pl provides a form for entering barcodes and selecting a 
destination branch.

New rows are entered into the branchtransfers table for each item
"transfered".
 2002-03-12 21:04:32 +00:00
rangi
be16259a1b Changed the sorting of the hash of items on issue. To sort numerically, (so 
10 comes after 2) Just a quick fix to get the items showing in date_due order
 2001-08-17 07:54:38 +00:00
rangi
a28629608b Quick bodge to restrict the number of returned books showing to 8. 
(Request from the librarians here to speed up the screen reload)
Needs to be tidied up
 2001-04-20 00:31:02 +00:00
rangi
b2c9dabcf1 Making a change to the way charges are handled, the system originally worked such that if a borrower owed more than $5 issues werent allowed. This worked fine except that often borrowers wish to borrows say 3 pay videos at $2 each, then 2 books say. The three pay videos rack up charges of $6 and then they cant issue the books until that is paid. 
Reworked so that it cares about previous charges, not the ones accrued during current issue process.
 2001-04-03 21:32:37 +00:00
rangi
3604bdd166 Adding in javscript code to open a new window for payments 2001-03-28 03:00:56 +00:00
rangi
fe1fab2ab5 Reworked layout of issues section. 2001-03-28 02:23:03 +00:00
rangi
c2a70e1811 Changes made by Glen to allow the circulation module to work with a 
ASCII-wand, or CueCat (weird encoded) input equally well.

Do not bother installing the CueCat driver or any other software - it's not
needed.
 2001-03-22 22:20:29 +00:00
rangi
cc578cfd59 Rejigged printing issues, to print out everything on issue to the borrower 2001-02-21 22:33:48 +00:00
rangi
3271ec126d A bodgy hack so that hitting enter in issues (with no barcode) prints out the borrowers issue slip and starts a new borrower 2001-02-14 02:41:43 +00:00
rangi
aab933707f The Horowhenua libraries wanted less patron and item information displaying at returns 
So Added some if statements to not display patron addresses, and to only display the title of the item
These presumably would be changed to suit individual libraries wants
 2001-02-14 00:29:17 +00:00
tonnesen
ad16590c11 Fixed backgroundimage in circulation module. Background image now displays 
only in header lines.
 2001-02-05 17:24:13 +00:00
rangi
3b07c5bf30 Fixing printing error, now is printing all of the days issues for borrower 2001-02-04 22:25:42 +00:00
rangi
866118ff98 Made sure the printer queue value was being set before calling print 2001-02-01 04:09:11 +00:00
rangi
cf3086c7da Attempting to get issues slip to print when borrower is finished with 2001-02-01 02:08:34 +00:00
rangi
dea0fd150d Added a line to Ouput.pm to enable circulation to use its own includes 
Changed the look of circulation.pl to the green/yellow colours

Note: Steve, i added another variable $backgroundimage that sets the background image for the main tables, so it should be straightforward to change the look back to the colours you had if you want to
 2001-01-31 21:38:43 +00:00
tonnesen
e371a7114f Mostly just look changes, got rid of table borders, alternating colors on 
table rows.  Some fixes to returned items in returns module.
 2001-01-31 18:14:34 +00:00
tonnesen
ee5ba729f3 Returns module lists recently returned items, cookies used to store branch 
and printer preferences.
 2001-01-26 00:17:00 +00:00
tonnesen
d389b68e6d Refined Returns module. 
Added ability to select branch and printer.
Fixed charges for rental items.
 2001-01-25 00:01:34 +00:00
tonnesen
eaa9677292 Changes to web circulation module: rudimentary returns module, arbitrary 
due date for issues, flag info displayed, overdue books are displayed in
red.
 2001-01-23 23:48:54 +00:00
tonnesen
3186e690ce Fixed a bug in issuing reserved books. Was calling non-existent 
printreserve subroutine
 2001-01-23 00:12:49 +00:00
tonnesen
7c52cda9d6 Started work on a web-based circulation interface. 2001-01-22 23:48:41 +00:00