Commit graph

7382 commits

Author SHA1 Message Date
Henri-Damien LAURENT
1391105a7c Bug Fixing : Could not add new undefined tag if searchfield>0
For instance, search for tag 290
cannot find.
Click on addTag
Save
Then wouldnot add tag 290 because used UPDATE.
Now, if tag is not found then Add tag is done.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:19 -06:00
Chris Nighswonger
3fdd6a17cf Second installment on Patron Images fixes
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:01 -06:00
Galen Charlton
6eba80e5f5 temp bugfix -- restore file upload functionality
CGI->new() should not be used in any C4 module -
it has a side-effect that breaks the AJAX
file upload script.  Specifically, any file upload
field is slurped when a new CGI object is created, and
is not available to a second object created by CGI->new().

Consequently, C4::Debug should not be instantiating
a CGI object in its BEGIN block.  It can use other CGI::* modules
to parse QUERY_STRING to get the value of the debug
parameter (note that this means that the debug param
can be reliably set only in a GET, not as part of a
form submission).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:58 -06:00
Galen Charlton
60a98d258a IMPORTANT - refactor MARC character set handling
* IsStringUTF8ish - determine if scalar contains a string in UTF8
* MarcToUTF8Record - convert MARC blob or MARC::Record to UTF8
* SetMarcUnicodeFlag - set appropriate MARC21 or UNIMARC field to
  indicate that record is in UTF-8.

Design points of this module include:

* No dependencies on other C4 modules, making it easier to add
  more test cases
* All character conversion code in one place
* Single entry point for doing a character conversion on a
  MARC record
* Capture of errors and warnings produced by Text::Iconv
  and MARC::Charset
* Start of support for guessing the source character set of
  a MARC record.

Several functions were moved from other scripts
or modules to C4::Charset:

* C4::Koha->FixEncoding (expanded and renamed
  MarcToUTF8Record)
* C4::Koha->char_decode5426
* fMARC8ToUTF8 from bulkmarcimport.pl (renamed
  _marc_marc8_to_utf8)

Several batch jobs were adjusted to use MarcToUTF8Record instead of
FixEncoding.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:56 -06:00
0f0699f2c2 Markup correction, formatting for translator
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:51 -06:00
Chris Nighswonger
a0b51ee25f Correcting DEBUG var
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:46 -06:00
Chris
80d4bd222f Bugfix for Bug 1618: First Installment
This corrects the major template issues once files are uploaded.
The changes need dressing up a bit still.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:41 -06:00
Chris
dc72b21a3f Removing extra warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:37 -06:00
381e21e999 Quick fix to bug 1809
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:35 -06:00
39e12f17a0 Fix a bug in authorised values admin
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:31 -06:00
38490915a0 Previous change hid global search on results page too, fixing.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:03 -06:00
04bb614e52 Removing some unused include files; Correcting nomenclature for cart; hiding quick search form on advanced search page; Styling user menu links as sidebar tabs.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:59 -06:00
a8ed713e60 Minor style tweak to lists menu; Trying to show public lists to non-logged-in users. Calling for help from atz.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:52 -06:00
96fc7824c5 Markup tweak for login; Link correction for facets.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:42 -06:00
Paul POULAIN
baceb1e0f1 french translation updated
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:36 -06:00
Galen Charlton
718ff8b339 staged MARC import: handle non-ASCII characters in items
The problem occured during the population of
import_items.marcxml -- the MARC::Record object
created to store the item did not have the Leader/09
set to 'a', which means that MARC::File::XML
tried to transcode code the item from MARC-8 to UTF-8, which
breaks since the MARC data is already in UTF-8 at that point.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:21 -06:00
Galen Charlton
f9f246cb1e authorities: changed extension of authority-zebra-indexdefs.xml
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:12 -06:00
Galen Charlton
cf8c3a84ca authorities: start of work on reindexing
Currently, MARC authorities are indexed (assuming Zebra
is used) with Zebra's GRS-1 module.  However, it does
not appear to be possible to index phrases that cross
subfield boundaries using the GRS-1 module's records.abs
config file's melm, elm, and xelm directives.

Since it is necessary to be able to efficiently search
an entire authority heading (e.g., to see if a given
bib heading is authorized), I'm proposing a switch
to Zebra's DOM XML filter module, which uses XSLT
to generate the words and phrases to be indexed from the
original MARC XML (or ISO2709) record.

The file authority-zebra-indexdefs.xml is an XSLT stylesheet
to implement the new indexing regime.  It is based on the
MARC21 authority record.abs with the following changes:

  * addition of 148/448/548
  * changed name of "see" indexes to "see-from"
  * changed name of "see-also" indexes to "see-also-from"
  * added index on the subject thesaurus based on
    the 008/11 and 040$f
  * added indexes on the full heading

authority-zebra-indexdefs.xml was generated from
authority-koha-indexdefs.xml via the XSL transform
koha-indexdefs-to-zebra.xsl.  authority-koha-indexdefs.xml
is the actual master version of the indexing definitions,
and was created to provide a much more compact syntax
over the raw XSLT that is to be passed to Zebra.

An experimental schema for Koha indexing definitions is
under way; my aim is to propose a simple format that can
be readily worked with, and perhaps even generated as
a serialization of indexing definitions that are set up
via administration settings in the Koha database itself.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:22:06 -06:00
fd92aeb0d8 Working version of cart and lists buttons, with some style changes to cart and lists popups. Bug: cart contents indicator conflicts with button-style js. Also adding new default button style.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 10:58:37 -06:00
b562c4875c More button tweaks
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 10:58:35 -06:00
ea8b8aa9b3 More unfinished button style testing
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 10:58:34 -06:00
b728761e09 More button style tests
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 10:58:32 -06:00
Chris
c4c2a8d698 Bugfix for Bug 1790 - Correcting sysprefs opacthemes explanation to reflect current functionality
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 07:51:44 -06:00
8d7c8419a3 Fix for bug #1806
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 07:51:42 -06:00
Chris
7c7dbf9a68 Bugfix for Bug 1790: Theme defaults to prog if other themes fail.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-30 07:51:04 -06:00
0833c346a3 A couple of minor style tweaks.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-29 07:58:59 -06:00
0fcad14059 Changing the way items are added to the cart and and lists from the searchresults page: Users now check items and choose from an 'add to...' dropdown which is populated with the logged-in user's lists. The add-to-shelf popup has been modified to accept a shelfnumber so that a users can add straight to the selected list.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-29 07:58:58 -06:00
Chris Cormack
8252e698e9 Making the images show at admin/itemtype.spl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-29 07:58:48 -06:00
Galen Charlton
e59f7d7382 OPAC bug fix: use correct index to limit by format
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-29 07:58:34 -06:00
Henri-Damien LAURENT
3ee97ddacc bug fixing : encoding with texts in opac-sendbasket.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-29 07:58:22 -06:00
Ryan Higgins
895d729233 remove hardcoded link to opacsmallimage
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 15:06:14 -06:00
dc62af2554 Fixes for cart functionality, including additions to update cart toolip window
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 14:34:52 -06:00
07e4359b52 Fixing "check all" function in search results; Using javascript to generate book bag and list buttons, since those functions depend on javascript being enabled.Also adding help.css, missing from yesterday's help file commits.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 14:34:50 -06:00
Chris Cormack
5ccfb0963c Bugfix to correct C4:Koha behavior which caused admin/itemtypes.pl to try to
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 14:34:48 -06:00
Chris Cormack
c6086ad8bc Fix for bug in updatedatabase (extra comma) (fixed by Chris Nighswonger)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 14:34:43 -06:00
Ryan Higgins
e6859a3f81 minor db update changes for 2.2->3.0 script
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 14:34:42 -06:00
Ryan Higgins
c87666215d syspref update to update22to30 script
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-27 14:34:41 -06:00
Henri-Damien LAURENT
fc0ac9ea1b Adding manual datedue for renewals on moremember pages.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:18 -06:00
Henri-Damien LAURENT
4cc49c9914 Displaying functions for UNIMARC authors instead of function code
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:16 -06:00
Henri-Damien LAURENT
f91a41970d Adding OpacHighlightedWords system preference
Disable or Enable the display of query terms in the biblio.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:15 -06:00
a67714128a Button styling in masthead.inc is still conflicting with the js load() functions and the menu popup, so buttons are unstyled at the moment. Still need to integrate cart (basket/bookbag) functions.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:13 -06:00
6fb17caf84 More incremental changes to the OPAC masthead
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:12 -06:00
0c53e2087f Updating yui/button.css to latest version, adding back in changes that eliminate the "body class="yui-skin-sam"" requirement
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:11 -06:00
c9baf7441f Styling facets; correcting markup error in search results; removing language picker from opac-main (is now in the footer); continuing unfinished work on cart/lists buttons
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:10 -06:00
f0626368d3 Enabling replacement of Koha logo with another image via opacsmallimage system pref; Adding some YUI files required by menus and popups
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:08 -06:00
ba001f10b1 Working on the language-picker menu in the footer
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:07 -06:00
bf48a19c70 Unfinished: enabling language chooser in footer
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:06 -06:00
caaf69c551 Unstable changes to cart/list button interface in the OPAC
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:05 -06:00
95ddcd6801 Experimenting with styles for OPAC cart and lists button. Unfinished.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:02 -06:00
5f6120785c Beginning some design changes to the OPAC: put login info at the top, move cart and list buttons alongside main search form. Putting alternate search methods below the search form. These changes will eliminate the left-hand column from most OPAC screens.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-25 16:52:01 -06:00