Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	b05cbc415d	Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Marc Véron	9cb1fe10d7	Bug 14013 - Use name of a saved report as part of the file name for download This patch propoeses the name of a saved report as part of the download file name. To test: - Apply patch - Got to Home > Reports > Guided reports wizard > Saved reports (or create a new report from sql) - Run a saved report - Download the report (as csv, tab, ods) Result: The downlaod file name proposed should be prepended by the report name, separated with a - - Bonus test: Try to downlaod saved reports which have special character in their name. NOTE: Used "ñ/â is N/A" as a report name. The /'s were translated to underscored, but the letters were as expected. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	cc119bd856	Bug 13372: Sort is done by DataTables This patch removes the order by filter on the items lost report. The sort can now be done by DataTables. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	a7d4d05a7c	Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, good improvement. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	fe986573dd	Bug 13578: Make sure the 'public' parameter is passed to the last step If no caching system is up ($usecache == 0), the public parameter is lost on the step 3. The hash passed to the template looks like: 'cache_expiry', 300, 'cache_expiry_units', 'public', 1 So the template receives cache_expiry = 300, cache_expiry_units = 'public' and 1 = undef. This patch fixes the problem passing the cache_expiry* parameters only if the usecache is set. Test plan: 0/ Disable any caching system 1/ Create a new public report and go up to the 6th step, save the report and verify the report is created as public 2/ Enable a caching system 2/ Create a public report with a cache expiry value, save it and verify the report is created as public and the cache expiry value is correct. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	1db6f0d332	Bug 11944: Remove bad FIXME in guided_report Bug 11679 introduced a FIXME for this but it is wrong. The strings have to be encoded before generating the ods file. However, it is useless to decode column names. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	3d59fc384d	Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with utf-8 char and search for it Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	55107741a2	Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Katrin Fischer	865996d097	Bug 12567: Make catalog statistics wizard publication year work for MARC21 Publication year was useless for MARC21, as it was using the biblioitems.publicationyear (UNIMARC) instead of biblio.copyrightdate (MARC21). This patch tries to fix the search options to work for both MARC flavours. To test: In Reports > Statistics wizards > Catalog: - Test the publication year search options on a UNIMARC and a MARC21 installation. - Make sure search results make sense for both. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The changes are fine with me, but this script is certainly not bug free. Also note that all its SQL should be moved out according to our coding guidelines. When doing so, a rewrite would be appropriate. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Mark Tompsett	82c65678bf	Bug 13141: Add ability for biblio_framework to be a dropdown in Guided Reports By tweaking the GetReservedAuthorisedValues function in C4::Reports::Guided, biblio_framework can be added as a dropdown list into the guided reports parameters. The change in C4/Reports/Guided.pm required a test, which is found in t/db_dependent/ReportsGuided.t Code was then added to reports/guided_reports.pl to build the appropriate hash to trigger the proper dropdown list. TEST PLAN --------- 1) Apply patch 2) prove -v t/db_dependent/ReportsGuided.t -- all should pass, this confirms that both C4/Reports/Guided.pm and this test file work. 3) Log into staff client 4) Reports 5) Create from SQL 6) Enter appropriate information like: Report name: Test 13141 -- no need to change Report group or Report is public or Notes or Type SQL: SELECT CONCAT('<a href=\"/cgi-bin/koha/catalogue/detail.pl?biblionumber=', biblio.biblionumber,'\">',biblio.biblionumber,'</a>') AS BiblioNumbers, title, author, frameworkcode FROM biblio WHERE frameworkcode=<<Enter the frameworkcode\|biblio_framework>> 7) Save report 8) Run report -- The parameter entry page should have a drop down of framework codes. 9) Select a framework code, and click Run the report -- The displayed SQL should have a "frameworkcode=" portion matching the selected framework. 10) Run the koha qa test tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan followed successfully. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	3f2dda2f33	Bug 11672: Untranslatable dropdown on Guided Reports and dictionary This patch removes hardcoded descriptions and sets them in the templates using the variable content as id. To test, create a new guided report and verify the 'module to report on' dropdown shows as usual [1]. Functionality shouldn't get changed. The patch also changes the dictionary pages where 'area' should be displayed/selectable with the same strings as the guided reports. Try all the possible disctionary pages. The last page when creating a dictionary now shows the 'area description' instead of the code. The same happens to the dictionary list once you have dictionaries saved. [1] The following texts get changed: Catalogue -> Catalog Acquisition -> Acquisitions Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	bfb20c9a7e	Bug 12587 - Improve output of filter information on patrons with the most checkouts report This patch makes some changes to the way filter information is displayed after running the patrons with the most checkouts report. Before this patch several untranslatable English strings would be displayed, and library and item type codes would be shown instead of descriptions. To test, go to Reports -> Patrons checking out the most. Enter values for all the filter options: - Checkout date from - Checkout date to - Checkin date from - Checkin date to - Library - Item type - Patron category When you submit the form and view the results you should see your date submissions formatted according to your selected dateformat system preference. The library name and item type names should be shown instead of codes. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves translatability of the filters output after running the report and the readability of them (removing codes). Note: it would be nice if the read-only would be removed from the date fields, as forcing people to use the date widget is a known accessibility issue. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	9626daa220	Bug 12707: Remove CGI::scrolling_list from some Reports This patch removes similar instances on 5 files, same code. Also removes a commented one, changed in case some plan to resurrect the code. This bug depends on Bug 12696. In all cases but the commented one, what was replaced is a pulldown with one value, 'CSV' To test: 1. Apply patch for Bug 12696 2. Apply this patch Check for the pulldown 'Into an application' 3. Go to Reports > Statistics wizard > Borrowers 4. Go to Reports > Statistics wizard > Circulation 5. Go to Reports > Statistics wizard > Holds 6. Go to Reports > Top lists > Most-circulated items 7. Go to Reports > Inactive > Patrons who haven't checked out 8. There is also a commented code on catalogue_stats, no fuctional changes. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	5a9786eea8	Bug 12706: Remove CGI::scrolling_list from serial_stats.pl This patch depends on Bug 12696 Removed one instance in this file. Pulldown with one value, 'CSV' To test: 1. Apply the patch for Bug 12696 2. Apply this patch 3. Go to Reports > Statistics wizard > Serial 4. Check 'Into an application' pulldown, with value 'CSV' 5. Search for regressions Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, works as described. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	0e936ce220	Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. Signed-off-by: Robert Higgins <robert.higgins@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the reported problem, passes all tests and QA script. Added the sign-off line for Robert. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	2323957250	Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	82e8a7a155	Bug 12151: Remove uses of smartmatch operator in report scripts This patch removes the use of smartmatch operators in report scripts. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Acquisition and Patron statistics wizard tested, no regressions found. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Galen Charlton	effb64f7f2	Bug 11715: require authentication for various staff scripts To test: [1] Verify that item record creating and editing during the acquisitions process continues to work. [2] Verify that calling services/itemrecorddisplay.pl without a valid user session fails. [3] Verify that authentication is required for making a new order from a suggestion, transferring an order, doing a Z39.50 search from acquisitions, displaying the record card view in the staff interface, and running the till reconciliation report (/cgi-bin/koha/reports/stats.screen.pl) Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified all changed scripts are not accessible witout a valid user session, but are with one. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Pasi Kallinen	0625685f7c	Bug 12214: display SQL errors in reports to users When a user runs a report containing an SQL error, no error is shown to the user. This patch fixes this. To test: 1) Run a report with known good SQL. 2) No error is shown. 3) Run a report with bad SQL (eg. a typo in field name) 4) No error is shown. 5) Apply patch 6) Repeat 1-4. For the bad SQL report, the database error should be shown. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Jonathan Druart	7e8f5f52c0	Bug 11679: Add ODS as an export format for reports This patch adds the ability to export the data generated by a report into an Open Document spreadsheet file. Test plan: 1/ Install the new dependency 2/ Verify you are able to generate an ods file from a report result. Tested with several reports and downloaded them as Open Document Spreadsheet. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Verified tab and comma separated export still works correctly. Verifid new ODS export works nicely. Tested with data containing Arabic characters and German umlauts. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	d6c40ebe5a	Bug 11718 - Use new DataTables include in reports templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all circ-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Reports -> Guided reports -> Use saved (reports/guided_reports.pl?phase=Use saved): "Creation date" sorting has been reconfigured to use the title-string method for sorting on an unformatted date. C4:Reports::Guided.pm has been modified to pass an unformatted date to the template. Sorting should work correctly for all settings of the dateformat system pref. - Reports -> Catalog by item type (reports/manager.pl?report_name=itemtypes) - Reports -> Serials statistics wizard (reports/serials_stats.pl): The subscription begin and subscription end columns have been modified to use the title-string filter for sorting. An unformatted date is now passed from reports/serials_stats.pl to the template, where the KohaDates filter is used for formatting. Sorting is based on the unformatted date. Sorting should work correctly for all settings of the dateformat system pref. - Sorting of titles should now exclude article from sorting. - Minor template improvements: - Vendor name now links to vendor details. - Subscription title now links to subscription details. - Library name is now shown instead of branchcode. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Checked all pages, no regressions or Javascript errors detected. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Fridolyn SOMERS	ec09fe092e	Bug 10718: fix items with no checkouts report Bug 8124 has commented the option to download results items with no checkouts report into a file. But the perl code of this page uses the export into a file has default behavior since the input "output" is no more present. The consequence is that there are never results in page. This patch removes the code concerning file output from template and perl. Such a feature exists in guided reports. Test plan : Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results Bug 10718 - select user branch as default In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in. Test plan : - Log into intranet with a normal user - Got to "Items with no checkouts" reports => Your branch is selected - Run report => You see "Filtered on : Branch = <your branch>" - Come back to report - Select "Any library" - Run report => You do not see "Filtered on : Branch" Bug 10718 - items with no checkouts report permission is execute_reports This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports. Test plan : Test you can access and run this report with only execute_reports subpermission into reports permission. Bug 10718 - redefine limit input In reports/catalogue_out.pl form, the limit input is by defaut none. So by default the report queries all the catalogue. This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge. This patch modifies limit input to removes the "none" option. Also reduces the number of options (same options as guided reports results per page). Test plan: - Go to reports/catalogue_out.pl => first value "10" is selected - Launch report => You see "Filtered on: limit = 10" Bug 10718 - perltidy on reports/catalogue_out.pl Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested all of these things, all ok - squashed patch for neatness. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Fixed a tab in one of the comments. Improves script, but more work needed. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	300918e488	Bug 3134: add ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Functional tests pass, template tests pass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	537c664038	Bug 9508: Standardize the dateformat value from C4::Auth - the dateformat value is send to all templates (from C4::Auth::get_template_and_user) - remove all assignment of dateformat in all .pl files - Remove "all" occurrences (those I found!) of dateformat_* From now the only way to get the date format is a string comparaison (dateformat == "metric") Checked with the command: git grep "$dateformat_us\\|dateformat_metric\\|dateformat_iso$" \| grep -v translator Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Tested all the datepickers I could find, looks good. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Kyle Hall	020b8a66bc	Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely now. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Galen Charlton	a7eb34f2c8	Revert "Bug 6554 - make Koha internally utf-8 clean" This reverts commit `d542740ab8`. Rolling back bug 6554 work until we have more comprehensive tests. Conflicts: opac/opac-search.pl	11 years ago
Marcel de Rooy	d050e557f4	Bug 10110: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine. http://bugs.koha-community.org/show_bug.cgi?id=10110 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Copying test plan from bug report: Example SQL: select branchname as "Bibliothek (üöä)", branchname "Bibiothek (üäa)", branchname from branches where branchcode = <<Bibliothekskürzel\|branches>> 1) Create report with given example SQL or your own including some diacritics in the columnnames 2) Save the report and run it 3) Verify column names are broken before patch, but fixed after.. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Tomás Cohen Arazi	cdc5e11159	Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports A user might create a SQL report that relies on non-existent authorised value categories. Because of a typo, or just because they copy&pasted the report from the Wiki. Use cases are: - The user creates a report from SQL a) Uses bad authorised values b) Clicks 'Save Report' c) Koha lists the problematic authorised values d) The user decides to e-1) Save it anyway, it gets saved e-2) Edit the report, it gets back to where it chose 'Save Report' - The user edits an already saved report (Update SQL) a) Uses bad authorised values b) Clicks 'Update SQL' c) Koha lists the problematic authorised values d) The user decides to e-1) Save it anyway, it gets saved e-2) Edit the report, it gets back to where it chose 'Update SQL' - The user tries to run a saved report that contains bad authorised values, Koha advertises the problem and provides the user with a button 'Edit SQL' to fix things. To test, just create a report from SQL using invalid authorised values like this (misspelled 'branch'): SELECT * FROM itemtypes WHERE hola=<<Test branch1\|branchee>> AND hola2=<<Test branch2\|brancha>> Regards To+ Notes: - I added several comments on the code. - Fixed an annoying warning of uninitialised variable also (refactored some tiny bits to do it). - Added the following methods - C4::Reports::Guided::GetReservedAuthorisedValues - C4::Reports::Guided::GetParametersFromSQL - C4::Reports::Guided::IsAuthorisedValueValid - C4::Reports::Guided::ValidateSQLParameters - C4::Koha::IsAuthorisedValueCategory - Those methods could have been used to refactor this guided reports code as its a bit messy. I chose to do it in a new bug of course :-D. - Fixed some trivial perlcritic -5 errors - Removed some debugging stuff left by mistake - Fixed some POD problems - Optimal SQL-driven IsAuthorisedValueCategory method - Thanks to Owen and Jared for their patience heh. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No koha-qa errors. Test: Tried with examples (from help and test plan) reports, correctly identifies invalid authorized values, and no problem with authorized ones. NOTE: Online help for this does not states that partial values need to be between '%' in a SQLish way. Perhaps this could be addressed inserting % in values or adding a checkbox (partial\|exact). Or changing help. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Katrin Fischer	8e222dcdcc	Bug 8068: Standardize terms used on acquisitions statistics branch > library budget > fund bookseller, supplier > vendor and capitalization To test: 1) Go to Reports > Acquisitions statistics 2) Check the labels and options of the form for correctness. 3) Run a few test searches to make sure functionality is unchanged. Unfortunately, some strings are from the .pl file, so a follow up moving those to the templates is needed. To make the changes consistent I have changed them in the .pl file. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Dobrica Pavlinusic	d542740ab8	Bug 6554 - make Koha internally utf-8 clean In current implementation (mostly commented out in this patch) uses heuristic to guess which strings need decoding from utf-8 to binary representation and doesn't support utf-8 characters in templates and has problems with utf-8 data from database. With this changes, Koha perl code always uses utf-8 encoding correctly. All incomming data from database is allready correctly marked as utf-8, and decoding of utf8 is required only from Zebra and XSLT transfers which don't set utf-8 flag correctly. For output, standard perl :encoding(utf8) handler is used so it also removes various "wide character" warnings as side-effect. Test scenario: 1. make sure that you have utf-8 characters in your biblio records, patrons, categories etc. 2. try to search records on intranet and opac which contain utf-8 characters 3. install language which has utf-8 characters, e.g. uk-UA dpavlin@koha-dev:/srv/koha/misc/translator(bug_6554) $ PERL5LIB=/srv/koha/ perl translate install uk-UA 4. switch language to uk-UA and verify that templates display correctly 5. test search and Z39.50 search and verify that caracters are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> I followed the test plan, adding utf-8 characters to library names, patron categories, titles, and authorized values. I tried the uk-UA translation and everything looked good. When performing Z39.50 searches for titles containing utf-8 characters I got results which were still occasionally contaminated with dummy characters [?] but I assume this is Z39.50's fault not the patch's. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Already signed, add mine. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	1e92b9c15e	Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Bernardo Gonzalez Kriegel	3209941f3f	Bug 9457 - Followup - Ordering branches should be case independent (2) This follow up reinstates or add check for undef returned by C4::Context->userenv, only where previous patch touch code. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Bernardo Gonzalez Kriegel	2d9f5fc69e	Bug 9457: [ENH] Ordering branches should be case independent (2) This patch replace use of CGI::scroll_list() to show list of branches. In two files, marc21_linking_section.pl and unimarc_field_4XX.pl, the scrolling list is created but not used in the template file, so the code is removed. Also minor renaming/normalizing of variables. To test: 1) Install with some branches, records and patrons 2.1) Select a record, click 'Place hold', select user, there is a library pull-down next to 'Pickup at:', list is ordered case sensitive 2.2) Go to Reports > Average loan time, next to Library is a pull-down, list without order 2.3) Go to Reports > Catalog by item type, next to 'Select a library' is a pull-down, list is ordered case sensitive 2.4) This is tricky, go to Reports home, change last part of URL 'reports-home.pl' with 'manager.pl?report_name=issues_by_borrower_category' (can't find a direct link), next to 'Select a library' is a library pull-down, list without order 2.5) Edit/Add a patron, on section 'Library management' there is a library pull-down, case sensitive 2.6) OPAC, as logged user, make a suggestion or hold, there is library pull-down, correct order 3) Apply the patch 4.1) Repeat 2.1), correctly ordered list 4.2) Repeat 2.2), correctly ordered list 4.3) Repeat 2.3), correctly ordered list 4.4) Repeat 2.4), correctly ordered list 4.5) This is a bit more work There are 3 possible situations to test: A) No branches, must show a message that are no libraries defined B) New patron, must show a correctly ordered list of branches, current branch selected C) Edit patron, must show a correctly ordered list of branches, patron branch selected 4.6) Small changes on variable names, so retest 2.6) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	0131b9e697	Bug 9417 - Allow number of results per page to be selectable for guided reports This patch adds the ability to select the number of row to show per page while retaining the default rows per page as 20. Test Plan: 1) Apply patch 2) Run a guided report that will have many resultant rows 3) Try the various rows per page options 4) Verify the rows per page selected is retained when paging through results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jared Camins-Esakov	651e8a3fad	Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	1642dbe0e8	Bug 7678: Adds extended patron attributes in patron reports Fix bug that prevented zero values to be shown in the results. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the problem with differentiating 0 and NULL values. Passes all tests. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	a08c09884e	Bug 7678: follow-up to pass QA Check input parameters to avoid SQL injection Rewrite a for loop for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, perlcritic is unchanged. Test plan - Verify ExtendedPatronAttributes hides/shows new patron attribute search criteria - Verify patron attribute show up correctly - pull down list for attributes linked to authorized values - input field for other attributes - Verify search works correctly Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Matthias Meusburger	56878f1453	Bug 7678: Adds extended patron attributes in patron reports This patch allows to choose row and column amongst extended patron attributes and to filter on them in reports/borrower_stats.pl Signed-off-by: Marc Veron <veron@veron.ch> Great, I was looking for such a feature. Patch works as expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	a469663d7b	Bug 9108: Followup: send the dateformat value from C4::Auth - the dateformat value is send to all templates (from C4::Auth::get_template_and_user) - remove all assignment of dateformat in all .pl files - the DHTMLcalendar_dateformat variable is unused Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed conflicts: - opac/sco/sco-main.pl - reports/acquisitions_stats.pl - tools/cleanborrowers.pl All tests pass, perlcritic problems appeared in some files before and after these patches were applied. Checked sorting in following pages: - acqui/addorderiso2709.tt - list of staged imports in acq - acqui/histsearch.tt - sorting of dates in acq search result list - acqui/invoices.tt - billing date in list of invoices in acq - acqui/lateorders.tt - list of late orders in acq - acqui/ordered.tt - ordered titles and estimated costs for a fund - acqui/parcels.tt - receive shipment page - acqui/spent.tt - received titles and actual costs for a fund ... - serials-search.tt - subscription search result list ... - opac/sco/sco-main.tt - due dates in list of checked out items - reports/acquisitions-stats.tt - date searches, display of dates - tools/cleanborrowers.tt - tools.holidays.tt - different views of dates library is closed, adding dates Checked dates display according to system preference everywhere and searching, entering dates etc. still worked as expected. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	3fe43df7f5	Bug 7896: follow-up: Allow translation of strings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	ae549864b0	Bug 7896: Acq statistics wizard: add filters and cell values - Possibility to select for line and column: items.homebranch and items.ccode - Possibility to filter on these fields - Possibility to count unique biblios (count(distinct biblionumber)), ordered amount and spent amount (based on aqorders.datereceived) Filtering on item homebranch and ccode works only on items that were created at ordering or receiving (ie items are linked to an order) Some refactoring is done, mainly replacing switch-like if statements by given/when Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	c39380ed4e	Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the "closed" tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status "stopped" everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the "Include expired subscriptions" checkbox. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of "disabled" serials Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Owen Leonard	82eb16325f	Bug 6602 - Reports dictionary doesn't properly recognize text columns Reports dictionary won't let you set a comparison for MEDIUMTEXT columns. To test, choose a MEDIUMTEXT column like borrowers.surname in Step 3 of adding a new dictionary definition. Before the patch, in Step 4 you would not see any kind of form field for entering a comparison. After patching Step 4 will offer you a field labeled "Search string matches." Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. Test plan: 1) Reports > Reports dictionary > New definition 2) Step 1: Some name 3) Step 2: Patrons 4) Step 3: First name (mediumtext) 5) Step 4: Verify 'Search string matches' is offered. For both, surname (mediumtext) and first name (text) the program should offer you "Search string matches" on step 4. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Owen Leonard	1749d1da56	Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested creating reports and was able to run them after saving. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Srdjan	42acfbf75b	Bug 7993: Save reports with Group/Subgroup hierarchy This should make saved reports more manageable. Group/Subgroup hierarchy is stored in authorised_values, categories REPORT_GROUP and REPORT_SUBGROUP, connected by REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value Database changes: * authorised_values: expanded category to 16 chars * created default set of REPORT_GROUP authorised values to match hardcoded report areas * reports_dictionary: replaced area int with report_area text, converted values * saved_sql: added report_area, report_group and report_subgroup; report_area is not currently used, saved for the record C4/Reports/Guided.pm: * Replaced Area numeric values with the mnemonic codes * get_report_areas(): returns hardcoded areas list * created get_report_areas(): returns full hierarchy (groups with belonging subgroups) * save_report(): changed iterface, accepts fields hashref as input * update_sql(): changed iterface, accepts id and fields hashref as input * get_saved_reports():] - join to authorised_values to pick group and subgroup name - accept group and subgroup filter params * get_saved_report(): - changed iterface, return record hashref - join to authorised_values to pick group and subgroup name * build_authorised_value_list(): new sub, moved code from reports/guided_reports.pl * Updated interfaces in: cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report() reports/dictionary.pl: get_report_areas() reports/guided_reports.pl reports/guided_reports_start.tt: * Reports list: - added group/subgroup filter - display area/group/subgroup for the reports * Create report wizard: - carry area to the end - select group and subgroup when saving the report; group defaults to area, useful when report groups match areas * Update report and Create from SQL: added group/subgroup * Amended reports/guided_reports.pl accordingly Conflicts: C4/Reports/Guided.pm admin/authorised_values.pl installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl misc/cronjobs/runreport.pl reports/dictionary.pl reports/guided_reports.pl Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Paul Poulain	8449b14dcb	Revert "Bug 8089: Use Koha::Cache for all caching" This reverts commit `215abc8024`. The 3 patches for bug 8089 have been reverted, because they break jenkins & Koha. A follow-up has been provided, but it does not solve the problem on my test server, it just changes the error message. After a discussion with jared, Dobrica should work on another patch, so the best option is to revert.	12 years ago
Jared Camins-Esakov	215abc8024	Bug 8089: Use Koha::Cache for all caching 1. Replace all instances of memoize_memcached with appropriate calls into Koha::Cache: * reports/guided_reports.pl * C4::Biblio::GetMarcStructure * C4::Languages::getFrameworkLanguages * C4::Languages::getAllLanguages * C4::SQLHelper::GetPrimaryKeys * C4::SQLHelper::_get_columns 2. Replace all references to memcached with the appropriate calls into Koha::Cache in C4::Context. Test plan : * have DEBUG env set to 1 * reach addbiblio page to test the patch in Biblio.pm, or setup more than 1 language * you should see in the logs that you're reading and writing from cache * run the test suite twice both with and without the following environment variables set: export MEMCACHED_SERVERS=127.0.0.1:11211 export MEMCACHED_NAMESPACE=KOHA export CACHING_SYSTEM=memcached Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I'm unsure about some of the caching times 10000 is a long long time, but other than that, works fine.	12 years ago

1 2 3 4 5 ...

302 Commits (709488b8b68bdf544c484572b6028a53b03b6878)