* GetItemsInfo now includes a notforloan_per_itemtype key
with the value of the item type's notforloan setting, correctly
set based on the value of the item-level_itypes syspref
* Adjusted OPAC details item status display to use that
notforloan_per_itemtype key
NOTE: one of the assumptions of item-level_itypes is that
you can have either bib-level item types or item-level
item types, but not both in the same database. In particular,
it does not establish a hierarchy where Koha checks the
item-level itemtype first, then the bib-level.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
As part of preparing to work on bug 4396 (item level item types not
working correctly when biblioitem-level item type is not for loan),
moving the item status template logic to a separate include to make
it easier to work with.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Some tags weren't displayed propertly:
505 If there is no indicator 1, content label is not displayed and
then repeated 505 tags are also incorrecly displayed. This patch
add a default label.
502 Wasn't displayed at all. Added in this patch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
When using XSLT stylesheets for display, show MARC21 fields 780 and 785 on the OPAC details page only when ind1=0, as specified by the standard.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
If a 111/711 uses a subfield n (Number of part/section/meeting), XSLT wasn't displaying it which made for an incomplete display.
e.g., International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
instead of 10th International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
I've added it to show before subfield a if present. I've also removed the period that XSLT puts in the results and display after the last occurrence of a 110/710. It's fairly standard practice for these entries to have a period in the MARC record, so the XSLT display was showing a double period.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Not a fix for a submit button problem, but for a problem with
TMPL_IFs nested inside tags, a practice which will break the
translation script.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Print button was hidden by CSS for some reason (git blame me)
- Print formatting was off because of column mismatch
- Table style modified in print view for clarity
- Redirect from print view corrected by adding missing bib_list
and verbose parameters
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Removing DOM creation of tag and hold links: if the Cart is working,
the user must have JavaScript enabled. Therefore we can assume
tagging and holds will work
- Conditionally displaying some JavaScript based on whether tagging
or placing holds is allowed
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Simplifying finish button on SCO screen: it was a long sentence with a button saying "click here if you're done". Changed to "Finish". Changed the help accordingly.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Copy Search button to top of screen, rearrange order of indexes in search
pulldown list (to Keyword, Title, Subject, then Author & the rest)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
[MT2306_2271] ILS-DI Message codes consistence
The services now returns ILSDI error codes in a <code> tag, plus details in a <message> tag.
Exemple:
<LookupPatron>
<code>MissingParameter</code>
<message>The required parameter patron_id is missing.</message>
</LookupPatron>
[MT2306_2271] Minor changes in HTML
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Duplicates gmcharlt's earlier change to Auth.pm to add a check for SSL-enabled.
Modifies the various template calls to Syndetics and Library things to use an
https URL if SSL is in use.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Consider ISO language codes like 'Hebr' as well as 2-letter MARC codes like '2(' when checking trailing '/r' in linkage field.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This fixes the opac results - non xsl transformed - and the intranet result lists.
Also fixes opac-detail which was showing all items 'on hold' if there was a bib level request, whether items were on the hold shelf or not.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixes the opac results (opac-search.pl), if using xsl to transform data. I have no way to test UNIMARC results, if someone could test it for me.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This is a much improved re-implementation of the reserves updates from dev_week.
Less new code has been added, and more existing functions are used instead of adding new ones.
The 'Lock Hold' function has been removed due to it not working as intended.
[RM note for documentation: this adds the following features:
* ability to specify an expiration date for a hold request
when placing it via the staff interface or OPAC
* daily batch job to cancel expired holds
* nice interface to change the priority of hold
requests for a bib in the staff interface]
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.
(cherry picked from commit f87b755228)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Using redirect() and adding URL parameter to enable the display of
messages on the screen confirming the action.
- Also correcting for JavaScript error in form validation routine.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record. However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc. This patch turns off the other instances of
fine columns/displays if the syspref is off.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Add two syspref:
- OPACXSLTResultsDisplay
- OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds the id back in <body>. Renames the id in <div>.
The only reference to this id was in sanop.css, to which opac-detail.tmpl does not link.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Enables warnings and fixes the resulting warnings in opac-readingrecord.pl. The "description" variable in opac-readingrecord.tmpl was pulling a value from another source, probably an included template. Change the name to 'itypedescription' to resolve the conflict.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds the missing 402.tmpl.
Fixes the <h4> element in 400, 401, 403, and 500, all of which displayed 404.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Also adds some missing conditionals for including javascript
- Also Removes an instance of TMPL_IF EXPR
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
If a 245 has a subfield f (or any of the displayed fgknps subfields after a, b,
or h) there is no spacing and the display runs together. This happens in both
the XSLT results list and the XSLT individual title display. I've added a
space between the a, b, h displays and the beginning of the fgknps set.
There is a </td> tag which is outside of the block of code which defines checks to see if SMS is enabled. If SMS is disabled it causes several extra </td> tags.
In the current OPAC, there is no easy way to search a particular library.
By default, a user searches all libraries, or with SearcMyLibraryFirst turn on,
the user's home library. In dev_week, a library pulldown menu existed in the search masthead.
This commit adds the option to bring that pulldown menu back
by turning on the system preference OpacAddMastheadLibraryPulldown
- Formatting links to different subscription views as tabs like the links to MARC view, ISBD, etc.
- Styling display of brief subscription view for better clarity
- Moving filter form on full subscription view to sidebar
- jQuery-fying some full subscription view scripts
- Adding branch name to output of full subscription information
- Styling year links for visibility and clarity (I'm not styling them as standard tabs because
they wouldn't wrap well with many many years' worth of subscriptions)
- Markup corrections
- Removing TMPL EXPR
- Converting delete link to FORM ("destructive" actions shouldn't be links)
- Adding "search history" link to logged-in user's sidebar menu
The "search history" link and the "delete history" link are now correctly displayed after the first search.
Moreover, an additional "delete history" link as been added on the "search history" page itself.
- improving behavior for users with no javascript
- style improvements to list "toolbar"
- adding new toolbar icons
- adding display of subtitle to lists
Bug 4009: New list w/out title fails silently
Fixed so Title is required when adding a list
Bug 4010: Purchase Suggestions Should Require Title
Fixed text so that it indicates that title is required
Added check to make sure Title is filled in
For both bugs I added a required style to the CSS
The shelf js was trying to access a variable set by the Cart-related js. With
the cart disabled, the variable was missing. The patch sets this variable
for cases when the Cart is turned off.
White space in table cells can often break the javascript tablesorter.
The previous patch to tie the js tablesorter to the shelf sort
parameters should work now.
This patch adds a description of the itype next to the image that i suppose to appear in the selection list.
Fixed the path of the image in opac-suggestions.pl, but I'm not sure if you can actually display an image in a <SELECT> list option.
Also removed an extra </label> closing tag.
In Opac :
Print lists
Carts looks more like lists
Carts "More Details" And "Brief Display" toolbar looks more alike
In Admin :
Search results toolbar now have a "Add To" button for adding to a selected list with a confirmation pop-up, like in OPAC
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Added a syspref to decide what should be displayed by default (holdings
or serial collections)
Added filters for full subscription history (by branchcode and by
subscription)
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.
It also removed the messaging options from the patron
details and leaves them on the messaging tab.
Finally it adds in address fields that were missing
previously on the update patron form.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Tag cloud fixes :
* ordering cloud by tag name, not by weight
* improve behaviour : either display everyone cloud or my cloud only. When clicquing on "Tag cloud" on the top, will display by default everyone cloud. when clicquing on "My tag" (left tab when logged in), the page will display only my tags and my tags only
This fix the user ability to cancel holds in OPAC.
At the moment, a user can cancel all his holds, but in fact, only items that are not in transfert or waiting to be checked out can be cancelled by the user.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Enhancing C4::SearchSuggestion
And changing its API
Changing C4::Suggestions API taking a hashref for NewSuggestion and ModSuggestion
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Enables ppl to store their search history and delete the whole history
Adding Storable required by Opac-Search-History
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The XSLT results list (MARC21slim2OPACResults.xsl) did not have any separators between multiple 246 fields, so additional titles all ran together. I added the standard semicolon or period as in other repeating fields.
The display for personal and corporate authors was also confusing. The period after the last personal author (100/700) is very hard to see, so the display looked like the first corporate author only belonged to/was associated with the last personal author, rather than being a separate author entry. I've added a dash at the beginning of any 110/710 entries to set off the corporate authors a bit in the display.
I added the same code to insert a dash before any 111/711 (Meeting author) as well.
This patch also adds missing text labels for text_list_bullets.png
(bibliography) and remote.png (available online).
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch implements the suggestions about the new and old message system made by Owen Leonard.
Includes type fix pointed out by Owen.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Improved the error messages displayed to users
by web-based self-checkout when a problem with
a loan occurs.
This changed was sponsored by the Plano Independent
School District.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
[1] Change the default sort order of checked out
items to have the most recent loans displayed
first.
[2] Add the ability (via jQuery tablesorter) for
the user to sort the list of loans.
Also fixed the formatting of the due date.
This change was sponsored by the Plano Independent School
District.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds a new system preference, ShowPatronImageInWebBasedSelfCheck;
if this preference is ON, a patron's image is displayed
if available when using web-based self-check.
Note: a patch for updatedatabase.pl will be made when this
change is ready to push.
This change is sponsored by the Plano Independent School
District.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This system is indended to replace the old opacnotes
and borrowernotes fields in the borrowers table.
This system allows an unlimited number of Libraran and OPAC notes to be
attached to a borrower. Each note has a message, a message type,
the data it was created, and which library created it.
Each message can only be deleted by the library that created it unless the syspref
AllowAllMessageDeletion has been set.
This system may be used simultaneously with the old notes system and does not affect it in any way.
A new database table (messages) was added for this feature.
The System also allows for pre-defined notes for Borrower records
To use these, just create authorised values with the category BOR_NOTES
where the Authorized Value is the short description shown in the pulldown,
and the description is the text that should be in the note.
Original Author: PTFS Contractor <dbavousett@ptfs.com>
This work co-sponsered by Middletown Township Public Library, Middletown, NJ, USA
and East Brunswick Public Library, East Brunswick, NJ, USA
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
The MARC21slim2OPACDetail.xsl and MARC21slim2OPACResults.xsl XSLT
stylesheets do not obey any of the OPAC sysprefs, OPACURLOpenInNewWindow,
URLLinkText, or a new one added for Bug 3545, DisplayOPACiconsXSLT.
Modified C4/XSLT.pm based on code written by Fréric Demians (thanks!) to
pass the values of the sysprefs to the .xsl files. Modified the .xsl
files to implement them. If the respective sysprefs are set, the OPAC
results and display pages will/will not display the format/material
type/audience icons, will/will not open URLs in new browser windows,
and will/will not use the text entered in URLLinkText as generic link
text when there is no value in the 856 subfield y, 3, or z. (Note that
if subfields y, 3, or z do contain text, the first match is what will be displayed.)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.
It also removed the messaging options from the patron
details and leaves them on the messaging tab.
Finally it adds in address fields that were missing
previously on the update patron form.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This preference allows library staff to decide whether to show
the fines tab in the OPAC for logged in patrons.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page. The same goes if virtualshelves
is turned OFF.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- added altcontactcountry and B_address2 to tables borrowers and deletedborrowers so that all addresses offer the same fields
- changed B_country and country to work with syspref BorrowerMandatoryField
- changed display of Alternate Address on borrower detail page, added labels, lines and edit button to match the other sections
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Improve UNIMARC XSL for result and detail page:
* Add fields
* Consolidation
* Support RTL language display using $7 UNIMARC standard
for Arabic and Hebrew
* Fix bug #2773 via XSL at field level, removing NSB and
NSE characters in biblio records, and avoiding to do
it at application level in C4::Output.pm
Note for RM: There will be some tweaking coming next week.
If I see you don't push this patch, I will resubmit a
completed version later.
Sponsored by BULAC, www.bulac.fr
This preference allows librarians to control which links appear
in the 'More Searches' box on the opac detail page. If the
preference is left blank the 'More Searches' menu will not apear
on the opac detail page at all.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.
This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box. It would not retain its value on subsequent pages if 'no Limit' was selected as an option.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This adds to the interface and code the ability to set the reserve date when
requesting a hold.
Resubmit. Sorry, I formatted it from the wrong branch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl. Also enables zebra striping in opac-serial-issues.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Addendum to bug 3466. opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
