Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Mark Tompsett	7aec3a9aa4	Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should NOT fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, leaves actual data unchanged. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	ab0d9ae516	Bug 12675: Add unit test to GetFrameworksLoop to test: 1. Apply the patch 2. Run the test, prove t/db_dependent/Koha.t 3. Check that it pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Galen Charlton	a0b042b8a2	Bug 10078: (follow-up) add regression test Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	f8484348d1	Bug 10656: add regression test This patch adds regression tests to verify the sort order when fetching authorised values in either staff or OPAC mode. This patch also wraps the Koha.t tests in a transaction, and better handles skipping tests if Test::Deep is not installed. To test: [1] Verify that prove -v t/db_dependent/Koha.t passes Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass with all patches applied. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	c6f903198c	Bug 10666: (follow-up) really fix the daily quotes test Koha::DateUtils::dt_from_string() and DateTime->now() are not equivalent -- they don't handle timezones in the same way. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Fridolyn SOMERS	b874f7d638	Bug 10666: avoid random failures of Daily quotes tests In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is failing : $prove t/db_dependent/Koha.t : t/db_dependent/Koha.t .. 1/6 # Failed test 'Got a quote based on today's date.' # at t/db_dependent/Koha.t line 126. # Compared $data->{"source"} # got : 'Herbert Hoover' # expect : 'Abraham Lincoln' # Be sure to run this test on a clean install of sample data. # Looks like you failed 1 test of 4. Looks like the wrong quote is returned by GetDailyQuote(). I'm using a databased created with the English sample SQL datas. I think I found the cause : The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes the quote timestamp to now. When then testing GetDailyQuote(), this quote (which may not be the one created by test) is the most recent quote. This patch moves the "Got a random quote." test after "Got a quote based on today's date" to solve the problem. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Julian Maurice	8eae0c2a67	Bug 9117: Add imageurl to the list of parameters of AddAuthorisedValue and add unit test in t/db_dependant/Koha.t Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Jared Camins-Esakov	066848a8f0	Bug 9174: Fix itemtype image display in OPAC lists Prior to this patch, C4::VirtualShelves::Page did not make sure that the itemtype images that it chose when displaying itemtype images for biblio-level itemtypes were for the correct interface, so even on the OPAC the Intranet icons were requested. On standard installations, intranet-tmpl is not available to the OPAC. To test: 1) Set noItemTypeImages to "Show" and item-level_items to "biblio record" 2) Create a list and add an item with the default item type (942$c in MARC21) set to something with an itemtype image associated with it. 3) View the list in the OPAC. 4) If you are an a standard install, the itemtype image will be a broken link. If on a dev install, you can confirm with Firebug or the like that the image is pulled from /intranet-tmpl. 5) Apply patch. 6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the routine used to retrieve the image URL is correct. (Note that you must have an item type with the code 'BK') 7) Refresh the list, noting that the display is now correct/the image is pulled from opac-tmpl. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It works as expected. All tests in Koha.t passed. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Mason James	5bad52eef2	added date and ISBN tests to Koha.t modified: Koha.t $ prove -v ./Koha.t 1..5 ok 1 - use C4::Koha; ok 2 - use C4::Members; 1..6 ok 1 - Insert data in database ok 2 - GetAuthorisedValueByCode ok 3 - GetKohaImageurlFromAuthorisedValues ok 4 - lost and paid works ok 5 - Child area works ok 6 - Withdrawn works ok 3 - Authorized Values Tests 1..4 ok 1 - C4::Koha->can('GetDailyQuote') ok 2 - Got a quote based on id. ok 3 - Got a random quote. ok 4 - Got a quote based on today's date. ok 4 - Daily Quotes Test 1..7 ok 1 - slashifyDate ok 2 - xml_escape() returns empty string on undef input ok 3 - xml_escape() works as expected ok 4 - ... and does not change input in place ok 5 - _isbn_cleanup removes hyphens ok 6 - _isbn_cleanup removes parenthetical ok 7 - _isbn_cleanup converts ISBN-13 to ISBN-10 ok 5 - Date and ISBN tests ok All tests successful. Files=1, Tests=5, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.48 cusr 0.06 csys = 0.57 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=5327	12 years ago
Chris Nighswonger	ef064dca6d	Bug 7977: Adding Daily Quotes Tests to Koha.t test suite; also fixing sort order on quote selection SQL Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Mason James <mtj@kohaaloha.com>	12 years ago
Srdjan Jankovic	18b8991cf1	bug_6253: Unified member Search() Removed SearchMembers() and replaced with more generic Search() Amended Search() to try cardnumber first Replaced SearchMembers() calls with Search() Replaced SELECT with Search() where appropriate C4::SQLHelper: - added support for '' key for search filter. - when passing an array to filter, join with OR (rather than AND) - added support for key => [val1, val2] in filter - did not document - there was no input documentation to start with, and SQLHelper should be replaced with something better anyway Signed-off-by: Liz Rea <lrea@nekls.org> (again - testing merge issue) The functionality of the patch seems to be maintained with Biblibre's changes. I tested the following: Extended attribute searching: works 3 part name searching: works 2 part name searching: works 1 part name searching: works From: mainpage.pl members-home.pl Patron search limited by branch: Works Patron search limited by patron category: works Ordering by cardnumber instead of surname: works The "Check Out" field in the masthead. Circ Autocomplete is not reliably functional at this time, but the problem appears to predate this patch. Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Julian Maurice	b1e3b6753e	Follow up for bug 5880: Improved unit test The unit test Koha.t now skip tests of the two subroutines if the insert query failed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Julian Maurice	1eb9d9e581	Follow up for bug 5880: Added unit tests for the two new subroutines Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago

13 Commits (74640683f0d7f4b9734a69763424b33977f66cfd)