Commit graph

12140 commits

Author SHA1 Message Date
Henri-Damien LAURENT
92b076f0df MT3438 : faulty subscription-add branch selection
branch selection could lead to two branches selected
this patch removes the faulty line

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:49 -04:00
Henri-Damien LAURENT
208b835310 MT3499 : cataloguing authid not reported
authid would not be correctly updated in bibliorecord.
Biblio record would not receive the correct authid in subfield 9
but some erroneous data

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:47 -04:00
Paul Poulain
8f56c04998 MT3448 : searchauthorities problems
Problems with searching authorities :
The same index was always used

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:45 -04:00
Matthias Meusburger
e4a6abbf1a MT3440: Display only borrower's messages in borrower's profile
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:11:44 -04:00
Garry Collum
d85f607a6a Bug 4428: fixes minor XHTML errors in shelves.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-01 09:06:46 -04:00
3691a134e6 Fix for Bug 4409, I18N/L10N tab not highlighted
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 17:05:43 -04:00
23b52df1d7 Markup corrections to fix for Bug 4248
- Missing "=" in attribute
- TMPL_IF nested in HTML tag, which breaks translation script

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 17:05:41 -04:00
d114ebe80a bug 4256: fix patron replication when using LDAP with auth_by_bind
Patch compiled from diffs created by Dobrica Pavlinušić <dpavlin@rot13.org> to:

* enable patron replication when using LDAP with auth_by_bind
* not scribble over extended patron attributes
* fix failure logging in to OPAC if patron has no extended attributes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 17:05:38 -04:00
1cd4f42ae4 bug 1532: ensure that empty hold request expiration is represented as NULL
Fixes bug reported by Colin Campbell where reserves.expiratedate
was defaulting to '0000-00-00' instead of NULL.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 09:51:16 -04:00
e8291a15e0 fix typo in DBrev - should be 3.01.00.129
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 09:51:09 -04:00
Ian Walls
5b5cbd246f Bug 4334: Fixes double quotes error on ODUE line of sample_notices in all languages but French. The error was preventing sample_notices, and any foreign key dependent tables, from loading. This blocked enhancement message preference editing.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 08:36:49 -04:00
Chris Cormack
6c75d21f23 Bug 3785 - Fixing a bug that was stopping holds if no maximum number was set
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 08:19:37 -04:00
Kyle M Hall
a1336175fd Bugfix 4123 - CanBookBeRenewed fixed.
In Circulation::CanBookBeRenewed categorycode and itemtype were not being checked for * wildcard
if a specific code was not given.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 08:08:41 -04:00
Matthias Meusburger
b0cd6429b0 Adds missing hint for upload-type syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 06:50:26 -04:00
Sébastien Hinderer
343cc42eea Fix typo admin/in brnaches template.
The branch notes were not displayed because the variable was called
branchnotesl rather than branchnotes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 06:47:46 -04:00
Mason James
79ce374fa4 Enhancment [3.4] Bug 4288: Hide circular 'Log in to Your Account' link in opac-auth.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 06:05:17 -04:00
Ian Walls
aef52b8585 Fixes bug 4201: Holds priority listings assigning large numbers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 06:00:47 -04:00
Nahuel ANGELINETTI
ad01b57bcc (bug #3798) fix changing request branch
a variable was wrong in template.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 05:54:04 -04:00
59a6072c77 bug 4333 followup - fix an uninitialized value warning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 05:50:45 -04:00
Colin Campbell
7604bf89f5 Bug 4333 Fix erroneous message re Active Currency
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 05:42:05 -04:00
Nicole Engard
50375be1f2 BUG 3715 added state to label
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 00:15:31 -04:00
Nahuel ANGELINETTI
5d268a83a0 (bug #4295) fix overduerules edition
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:57:18 -04:00
Nicole Engard
f316cdc28f bug 3981 follow up change GST to 'Tax Rate' in EN-US
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:53:19 -04:00
Nicole Engard
8172699831 bug 4170 updated overdue rules
I added a note that this tool should not be used for
advanced notices. The fact that the Delay is required
is actually true based on the tests we did - which
is another bug.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:51:46 -04:00
Jean-André Santoni
a5273d7ebb Added "ordered" column in acqui-home budget display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:47:31 -04:00
668581b720 Improve detail page MARC21 XSL file for 505 and 520 tags
Some tags weren't displayed propertly:

505  If there is no indicator 1, content label is not displayed and
     then repeated 505 tags are also incorrecly displayed. This patch
     add a default label.
502  Wasn't displayed at all. Added in this patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:36:24 -04:00
Paul Poulain
4ebf32b970 MT2588: minor changes in column order & display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:32:40 -04:00
Nahuel ANGELINETTI
759b485158 (bug #4287) add enrolment period update in 22 to 30 script
this fix the upgrade script, to upgrade the enrolment period, that is no more in years, but in month unity.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:30:53 -04:00
Matthias Meusburger
1da207acf6 MT2345 : Changes on contracts
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:26:55 -04:00
Jean-André Santoni
06bd4fcae5 Hide basket actions if no basket
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:26:52 -04:00
Jean-André Santoni
5546383f70 New contract button
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:25:25 -04:00
Ian Walls
2f4f4bdff6 Fixes bug 4326: Items marked as returned yesterday
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:16:31 -04:00
J. David Bavousett
e2da272840 Bug 3619 - C4::Letters::_send_message_by_email does not obey AutoEmailPrimaryAddress
This enhancement would cause C4::Letters::_send_message_by_email to obey the
syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:10:15 -04:00
04cafc1427 Improve OAI Server MARC21 and UNIMARC XSL
Dublin Core schema name space was repeated for each field
as attribute rather than at <oai_dc:dc> level. This reduces
significantly the size of OAI server responses.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:09:04 -04:00
David Birmingham
816dbb2420 Fix to ORDER BY SQL in lists feature
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:07:40 -04:00
Sébastien Hinderer
3b39195500 Perl documentation fixup in C4/Items.pm.
The documentation of the DelItem function did not menton the $dbh.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:06:22 -04:00
Henri-Damien LAURENT
47805da9ac Fixing members order when string searched
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:59:02 -04:00
Garry Collum
8fd9eed2fc Bug 4285: Intranet bib display links to opac-search.pl, instead of catalogue/search.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:46:34 -04:00
Kyle M Hall
db8bda86ea Search Patrons - Make patron search more forgiving.
Patron search has only been searching fields for names
that either match or begin with the given search terms.

This is too strict a search.
For example, take the name "Billie Jo Robinson", "Billie Jo"
being the firstname, and "Robinson" being the last name. If one
were to search for "Billie Jo", this patron would not appear in
the search results.

 To remedy this, the search
type has been changed from 'begins_with' to 'contain'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:45:29 -04:00
Kyle M Hall
9a989c9e58 Circulation - Disable Barcode Field If Item Needs Confirmation
When issuing items, if a confirmation screen comes up,
another item can still be scanned into the barcode field.

If a librarian does not notice the confirmation dialog,
he or she may continue scanning items without confirming
the issue and thus give a patron an item without it actually
being issued to the patron.

This patch disables the barcode field until the confirmation
question is answered.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:44:49 -04:00
Matthias Meusburger
6532f712b7 MT2621 : Fix simple barcodes display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:42:10 -04:00
4d50b4f4f0 Fix for Bug 4271, Offer choice of destination for save biblio operation
A follow-up to the fix for Bug 4121, the user should be able to control whether
the action of saving a bibliographic record takes them to the add item screen
or the detail screen, independently of whether they are adding or modifying the
record.

The addition of a "split button" would leave the default action in place if the
user clicked the "main" part of the button. Clicking on the menu would give the
user specific choices.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:39:10 -04:00
J. David Bavousett
55492a640f Bug 4257: Make advance notices actually go out by avoiding null selects
The wrong variable was used to select the number of days-until-due; this fixes it to use
the borrower's preference setting.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:36:38 -04:00
Henri-Damien LAURENT
09d0a978a7 Fixing Tests on SQLHelper
one test was failing for want of correct parameters
An other one was not correctly described

test on search with a simple string fails because was done with branchcode and start_with includes NULL branches
Removing branchcode from filtercolumns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:35:28 -04:00
Jared CAMINS-ESAKOV
a326217179 Bug 4371: Display MARC21 field 773 w/XSLT
Display MARC21 field 773 in the OPAC detail view when XSLT is enabled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:32:24 -04:00
Jared CAMINS-ESAKOV
4f11c2e728 Bug 4370: Fix ind1 semantics for MARC21 780/785
When using XSLT stylesheets for display, show MARC21 fields 780 and 785 on the OPAC details page only when ind1=0, as specified by the standard.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:32:23 -04:00
Matthias Meusburger
99a84a6ee0 MT 2553 : Adds a Cancel button
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:30:07 -04:00
Katrin Fischer
ac037be307 Bug 4404: Untranslated strings in staff search result page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:23:49 -04:00
Colin Campbell
e7bdbd0583 Bug 4248 Rework Cities dropdown for members entry
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the concatenation and removed the CGI::Popup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:20:36 -04:00
066850a13a Revert "Bug 4248: Fixes zip code in cities town pull down list."
This reverts commit 2eac2e7242.
2010-04-29 22:20:12 -04:00