Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jenny Way	3f6a7933b8	Bug 19992: use Modern::Perl in Admin perl scripts Test plan: Check use warnings; use strict doesn't exist and use Modern::Perl is written instead in the following files: admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Stefan Weil	3f3a29f796	Bug 14383: admin: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	331ca7df3e	Bug 11675: check allocated total correctly when editing a fund that has a parent fund The sth was created before the query. The query was modified after the sth creation and an error was raised. Test plan: 0/ Don't apply the patch 1/ Create a budget A (amount=1000) 2/ Create a fund A1 (amount=1000) 3/ Create a child fund A11 (amount=1000) 4/ Edit A11 and change the amount to 2000 You are able to do it, an error appears in the Koha log: "check_parent_total.pl: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed" 5/ Apply the patch, edit A11 and save. You get an error 6/ Edit A11 and change the amount to <=1000 7/ Verify that there is no regression on adding/removing/editing budgets and funds. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described, no regressions found. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Galen Charlton	7efc10542b	Bug 11644: (follow-up) add FIXME Arithmetic with monetary amounts is a hard problem -- or if not hard, at least super-fiddly, particularly since in theory a Koha database could have to deal with dozens of currencies if used by a large research library. This patch adds a FIXME implicitly commenting on the poor state of affairs of available monetary calculation modules on CPAN. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Kyle Hall	ba689152e4	Bug 11644: fix occasional failure to update fund amount due to floating-point math When attempting to update a fund, if the amount unalloccated for the fund is equal to the total, you can be prevented from saving. This is due to imprecise floating point number comparison in check_parent_total.pl Test Plan: 1) Create a fund where the amount unallocated is equal to the amount unallocated for the budget period 2) Edit the fund, attempt to change the name of the fund 3) Note you recieve an error and cannot save 4) Apply this patch 5) Repeat step 2 6) Note you can now update the fund Signed-off-by: Sean McGarvey <smcgarvey@pascocountyfl.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Henri-Damien LAURENT	3e297c6cb8	bug4438/MT5496 budget Exceeds total allocation This is a followup : When editing a budget, the check for the total allocation would take into account the budget itself. Showing an improper error message The problem was solved when adding a child budget but not when editing the same budget. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago
Henri-Damien LAURENT	9bf9e2d9b4	Bug 4438: incorrect "Budget total exceeds period allocation" error when editing fund The process in check_parent_total for period allocation was not good. It took all the children of a period. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Andrew Elwell	9fa574f609	Bug 5385: POD Cleanups (part 1) working through the master branch to eliminate all podchecker warnings/errors Actual improvement to the quality of the POD will come later (hopefully with assistance of others) Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com> Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Donovan Jones	bce3e2e619	Bug 2505 - Add commented use warnings where missing in the admin/ directory	14 years ago
Lars Wirzenius	2c67656108	Fix FSF address in directory admin/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Nahuel ANGELINETTI	d399ff3494	[biblibre-newacq](bug #3611 ) fix user interface and others This big patch, fix xhtml code, and user interface. It Delete the term of budget period and use it as "Root Budget". It add improvment on UI, adding tooltip, and table tree.	15 years ago
Paul Poulain	4ec7a86abe	Budget management * budget period management * budget management (budgets lines are defined for a given budget period) budget_owner_search is the popup to select a librarian as budget owner	15 years ago

15 Commits (781c90b3f76619a307ba6ecce39ee5e3b43ab5cb)