After executing Z39.50 search, the result table is not populated
with publication dates. This is the result of code refactoring
made by Bug 30813. The removed function _add_rowdata treated
in special way the publication date putting it in $row in under
special, non MARC variant dependent key 'date'--since
the z3950_search.tt looks under breeding_loo.date.
Same effect (no data in the result table) with edition statement.
Reason: editionstatement coming from TransformMarcToKoha vs edition
expected by z3950_search.tt.
Test plan:
==========
1. Have a Koha instance with some Z39.50 servers defined.
2. In Cataloging, perform a Z39.50 search for any term.
3. In the result table you would not get the publication dates nor
edition statement (if present in the record).
4. Apply the patch.
5. Repeat the search.
6. You should see the publication dates (according to the current
mapping, i.e. for MARC 21 coming from 260 $c or 264 $c subfield)
and edition statements from the records found.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the HTML customizations template to replace tab
markup with the use of WRAPPERs.
- Apply the patch and go to Tools -> HTML customizations.
- Create or edit an entry.
- You should see tabs for each available language, for example
Default, English, French.
- Test adding content to each language to confirm that the correct
information is saved under the correct tab.
Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates various templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.
To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:
- Cataloging -> Quick spine label creator
- Patrons -> Patron details -> Files
- Patrons -> Patron details -> Housebound
- Circulation -> Upload offline circulation file
- Tools -> Patron card creator -> Manage -> Images
- Point of sale -> Transaction history -> "Older transactions" form
Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch makes a small change to the display of the note
"No EDIFACT configuration for..." on the basket group page to
only display if the system preference EDIFACT is set to "Enable".
To Test:
1. apply patch
2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor
3. create a basket group (doesn't have to have any baskets, an empty one will do)
4. close the basket group
5. set system preference "EDIFACT" to "Enable"
6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have
an EDI account configured
7. navigate to your vendor's closed basket groups
over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed"
8. you should see a message "No EDIFACT configuration for (name of vendor)" in the
Action column
9. set system preference "EDIFACT" to "Disable"
10. go back to your vendor's closed basket groups
11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)"
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
It must be removed, we don't need it since bug 22417
Test plan :
Play with batch record modification and check there is no JS error
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Since Bug 30718, date due uses flatpickr.
The JavaScript code setting due date via on-site checkout checkbox needs to be adapted.
Sort of like Bug 30717.
This patch renames the variable sent to template
'today_due_date_and_time' to avoid confusion with variable 'todaysdate'
used in other templates.
Test plan :
1) Enable system preference 'OnSiteCheckouts'
2) Go to a patron circulation page /cgi-bin/koha/circ/circulation.pl
3) Click on settings icon inside barcode input
=> Check due date input is empty
4) Click on 'On-site checkout'
=> Check due date input is filled with today date at 23:59
5) Fill barcode input and do check-out
6) Check due date is correct
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
To test:
1. Go to any record
2. Hit the edit button on an item in the holdings table
3. Modify the URL so that the query param for the itemnumber is either
3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=
3.2 an itemnumber that doesn't exist:
/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999
3.3 whatever else you come up with..
4. Check the same thing for the dupe option (op=dupeitem)
5. Sign off
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Check whether the current op is edititem or dupeitem and if so check
whether the itemnumber supplied as a query param actually exists.
If it doesn't, redirect to the additem op and hide all UI elements except
for a dialog that gives options to add a new item to the record or to
view the records holdings.
This behaviour was adapted from the addbiblio view, as suggested by
Fridolin.
To test:
1. Go to any record
2. Hit the edit button on an item in the holdings table
3. Modify the URL so that the query param for the itemnumber is either
3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=
3.2 an itemnumber that doesn't exist:
/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999
3.3 whatever else you come up with..
4. Check the same thing for the dupe option (op=dupeitem)
5. Sign off
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the lists template so that it uses the new WRAPPER
directive to build tabbed navigation.
To test, apply the patch and go to the lists page in the staff
interface.
- Confirm that the two tabs, "Your lists" and "Public lists" look
correct and work correctly.
- Test that the correct tab is selected when you add the "public" or
"private" parameter to the url:
/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1
/cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0
Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the checkout history template so that it uses the new
WRAPPER directive to build tabbed navigation.
In order to make the template logic a little easier to parse I moved the
table of checkouts into its own BLOCK to be used when on-site checkouts
are enabled or disabled.
To test, apply the patch and locate a patron who has a checkout history.
- If you have on-site checkouts enabled you will see three tabs: All,
Checkouts, and On-site checkouts.
- Each tab should work correctly: The checkouts tab showing only regular
checkouts, the on-site checkouts tab showing only on-site checkouts.
- If you have on-site checkouts disabled there should be no tabs, the
table of checkouts should be displayed inside a "page-section" div
instead.
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the holds template so that it uses the new WRAPPER
directive to build tabbed navigation.
Note: this patch includes indentation changes, so check the diff
accordingly.
To test, apply the patch and locate a bibliographic record which
can be placed on hold.
- Start the process of placing a hold.
- If you have any patron clubs defined, there should be two tabs:
Patrons and Clubs. Both should look correct and work correctly.
- If you have no patron clubs you should see only the Patrons tab.
Works as advertised.
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the search history and advanced search templates in
the staff interface so that they use the new WRAPPER directive for
building tabs.
The patch also makes a minor change to CSS in order to accommodate the
different markup.
To test, apply the patch and rebuild the staff interface CSS.
- Go to the catalog's advanced search page. You should see tabs for each
of the selections defined in the AdvancedSearchTypes system
preference.
- The tabs should look correct and work correctly.
- If necessary, enable the EnableSearchHistory system preference.
- Click the logged-in user name in the header menu and choose "Search
history."
- On this page you should see two tabs, catalog and authority. Both tabs
should look correct and work correctly.
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the MARC detail views of bibliographic and authority
records so that they use the new WRAPPER directives to build tabs.
To test, apply the patch and locate a bibliographic record in the
catalog.
- Click the "MARC" menu item in the left-hand sidebar.
- Confirm that all tabs work correctly.
Perform the same test by going to Authorities and doing a search for
authorities. Clicking one of the results should take you to a
tabbed MARC view.
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label.
With new interface ENABLED is yellow, this looks weird.
Also I bet this is bad for accessibility.
I propose to move this info to a dedicated column.
I use bootstrap classes bg-success and bg-warning like in about.pl
Test plan:
1) Install some plugins
2) Go to Administration > Manage plugins
3) Check you see table with column status
4) Disable a plugin
5) Check you see 'Disabled' in status
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates templates which have already been updated to use the
new tab WRAPPER system for generating tab markup. Templates are changed
so that tab label strings are wrapped in <span> to make them
translatable.
The html_helpers include file is also updated so that the example code
in comments shows the right pattern (the breadcrumb example is similarly
corrected).
To test apply the patch and run the translation script to update the .po
files, e.g.
perl misc/translator/translate update fr-FR
Check the updated .po files for some of the lines modified in the patch:
- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31
- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69
- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330
- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141
- koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118
- koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259
- koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455
- koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
With the new wrappers we will translate every part of the
breadcrumb as a separate string and only once. So single words
like 'new' can be problematic in translation.
This changes:
* New > New identity provider
* Edit > Edit identity provider
* (Item search fields) <name of search field> > Edit <name of search field>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
Administration ->
- Library EANs (list, new, edit, confirm delete)
- Identity providers (list, new, edit)
- Manage domains (list, new, edit)
- Item circulation alerts
- Item search fields (list, new, edit)
- Item types (list, new, edit, delete confirm)
- Koha to MARC mapping
- Library groups
- MARC frameworks ->
-> Actions -> MARC structure (list, new, edit, delete confirm)
-> View, edit, and delete confirm
- Record matching rules (list, new, edit, delete confirm)
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch uses the cities administration page as a proof-of-concept for
using the [% t() %] construction to wrap translatable string in template
<title> tags. This should result in a significant improvement in
translatability.
To test, apply the patch and run the translation script to update the
.po files, e.g.
perl misc/translator/translate update fr-FR
Check the updated .po files:
- In fr-FR-staff-prog.po you should no longer see a reference to
cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6"
- In fr-FR-messages.po you should see several strings which have been
pulled individually from the <title> tag:
- cities.tt:9, msgid "Modify city"
- cities.tt:11, msgid "New city"
- cities.tt:15, msgid "Confirm deletion of city"
- cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha",
and msgid "Administration"
Translate the strings in fr-FR-messages.po and install the updated
translation:
perl misc/translator/translate install fr-FR
Swith to the update language in the staff interface and confirm that the
Cities page title is translated correctly.
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=33005
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Acquisitions ->
- Late orders,
- moddeliverydate.tt
- modordernotes.tt
-- These two templates aren't linked to from anywhere, but
you can navigate directly to:
http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and
http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1
- Order search, order search results
- Invoice search,
- Invoice details,
- Invoice files
- Vendor -> Basket -> Add to basket ->
- From a new (empty) record
- From existing orders (copy)
- From a subscription
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=33005
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
When editing a vendor the last part of the breadcrumbs read:
Update: <vendor>
This is very unusual, so updated to the standard wording:
Modify <vendor>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Acquisitions ->
-> All available funds table
-> Ordered
-> Spent
-> Vendor
-> Vendor details
-> Uncertain prices
-> Receive shipments (must have at least one open basket)
-> If necessary, receive a new shipment. Or click an
invoice number to reach the "receive orders" page.
-> Click "Receive" in the table listing baskets.
-> Basket -> Add to basket
-> From a suggestion
-> From an external source
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates patron club templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Tools ->
- Patron clubs
- New club template
- Edit club template
- New club
- Edit club
- Club enrollments (from the "Actions" menu in the list of clubs)
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Circulation ->
- Article requests -> Article request detail
- Check in
- Hold ratios
- Transfers to send
- Transfers to receive
- Holds queue
- Holds awaiting pickup
- Set library
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Circulation
- Check out
- Check out to patron
- Curbside pickups
- Built-in offline circulation
- Pending on-site checkouts
- Overdues
- Holds to pull
- Renew
Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.
Note: this patch includes indentation changes, so check the diff
accordingly.
To test, apply the patch and check the updated pages:
- Administration -> Budgets
- Administration -> Search engine configuration
On both pages tabs should look correct and work correctly.
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
To test:
1. Reviece a serial
2. Notice the unstyled links:
* Serial collection #1
* Subscription #1
* Show biblio
3. Apply pacth
4. The links should now be styled.
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
To test:
* Add a subscription
* Receive some issues
* Go to the subscription detail page, issues tab
* Verify the dates there display as YYYY-MM-DD
* Change DateFormat system preference setting, nothing changes.
* Apply patch
* Date should now be formatted in the way specified in the DateFormat system preference
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Since Bug 30718, dates are displayed in ISO format in orders by fund.
It removed dates formating in perl, this must be added in template.
Test plan :
1) Create some fresh orders on a fund F1
2) Go to Acquisitions > Orders by fund
3) Select fund F1 and 'To screen into the browser'
4) Submit
5) Check you see a formatted date in 'Entry date' column
6) Recieve some order from fund F1
Repeat 2 to 4
7) Check you see formatted date in 'Date received' column
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.
Note: The patch includes indentation changes, so ignore whitespace
when viewing the diff.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
Administration ->
- Authorized values
- New category
- View category
- Add authorized value
- Edit authorized value
- Authority types
- New authority type
- Edit authority type
- Confirm deletion of authority type
- Manage jobs
- Details of job
- MARC bibliographic framework
- New framework
- Edit framework
- Confirm deletion of framework
- Library transfer limits
- Libraries
- New library
- Edit library
- Confirm deletion of library
- Cash registers
- New cash register
- Edit cash register
- Patron categories
- New category
- Edit category
- Confirm deletion of category
- MARC bibliographic framework test
- Classification configuration
- Modify classification source
- Add classification source
- Modify filing rule
- Add filing rule
- Modify splitting rule
- Add splitting rule
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>
This patch also modifies some of the templates to simplify
the logic controlling how different elements of the breadcrumbs are
shown or not.
This patch also modifies another problematic set of strings in
auth_tag_structure.tt outside the breadcrumbs.
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.
Note: The patch includes indentation changes, so ignore whitespace
when viewing the diff.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
Administration
-> Administration home page
- Under "Additional parameters"
-> Additional fields
-> View, create, edit
-> Advanced editor shortcuts
-> Audio alerts
- Under "Acquisition parameters"
-> Budgets
-> Add fund
-> Close fund
-> Budget details
-> Planning
-> Create, edit, duplicate
- Under "Catalog"
-> Authority types -> MARC structure
-> New, edit, delete
-> "Actions" -> Subfields
-> Edit, delete
Acquisitions -> Vendor -> Contracts
- View, edit, delete
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Authorities home page
- Authority search results
- Authority detail
- Authority add/edit
- Authority merge
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
added)
- Checkout history
- Item search
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Catalog search results
- Search history (from the user menu in the header)
- Bibliographic detail page -> Rota (must have StockRotation enabled).
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates templates in the tools directory so that they use
the new WRAPPER directive to build tabbed navigation.
To test, apply the patch and test each page to confirm that tabs still
work as before:
- Cataloging -> Export
- This page by default will have two tabs, "Export bibliographic
records" and "Export authority records." You can edit koha-conf.xml
to enable two additional options: backup_db_via_tools and
backup_conf_via_tools
- Tools -> Batch patron modification
- "By card number" and "By borrowernumber," and "By patron list" if
you have any patron lists defined.
- Tools -> Overdue notice/status triggers
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates the saved SQL reports template so that it uses the
new WRAPPER directive to build tab markup.
To test, apply the patch and go to Reports -> Use saved. In order to
properly test the patch you should have multiple reports defined with
multiple categories ("Accounts", "Acquisitions", "Catalog", etc.).
Clicking each tab should filter the table of reports correctly.
After navigating away from the page and back to it, your selected tab
should be remembered.
Signed-off-by: Alexandra Speer <alexandra.speer@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several course reserves templates so that they use
the new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Course reserves
- New course
- Edit course
- Batch remove reserves
- Course details
- Add reserves (step one and two)
- Batch add reserves
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates label creator templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Cataloging ->
- Barcode image generator
- Quick spine label creator
- Label creator ->
- Label creator home
- New ->
- Label batch
- Layout
- Label template
- Printer profile
- Barcode range
- Manage ->
- Label batches
- Edit batch
- Layouts
- Edit layout
- Label templates
- Edit template
- Printer profiles
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several patron templates so that they use the new
WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Patron details ->
- Accounting -> Transactions
- Transaction details
- Check the details of a debit and a credit
- More ->
- Manage API keys (must have RESTOAuth2ClientCredentials preference
enabled)
- Delete (with a patron who has checkouts)
- Discharge
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Patron details ->
- Files (EnableBorrowerFiles must be enabled)
- Holds history
- Housebound (HouseboundModule must be enabled)
- Ill requests history (ILLModule must be enabled)
- Staff interface home page -> Discharge requests pending
- Must have useDischarge preference enabled
- Must log into the OPAC and request a discharge using a patron
account which has no checkouts.
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Patrons home page
- Patron detail page ->
- Change password
- Set permissions
- Accounting ->
- Create manual invoice
- Create manual credit
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Patrons ->
- Patron details ->
(Patron with charges) ->
- Accounting ->
- Pay
- Circulation history
- Routing lists
- Statistics
- Purchase suggestions
- More -> Manage two-factor authentication (must have
TwoFactorAuthentication enabled)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several patron lists templates so that they use the
new WRAPPER for displaying breadcrumbs.
Unrelated minor change: I added <span> around a few other strings in
add-modify.tt in order to improve translatability.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Tools ->
- Patron lists
- Main page
- Patron list contents view
- Add patron list
- Edit patron list
Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This patch updates several patron card creator templates so that they
use the new WRAPPER for displaying breadcrumbs.
Unrelated minor change: I added <span> around a few other strings in
edit-profile.tt and edit-template.tt in order to improve
translatability.
To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.
- Tools ->
- Patron card creator
- New ->
- Card batch
- Image
- Layout
- Card template
- Printer profile
- Manage ->
- Card batches
- Images
- Layouts
- Card templates
- Printer profiles
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 8976 introduced a way to sort subfields on a MARC/Auth framework using drag and drop. But there's no visible hint alerting the user the feature exists.
Test plan :
1) Go to Admistration > MARC bibliographic framework
2) Choose a framework and click on Actions > MARC structure
3) Choose a field and click on Actions > Edit subfields
4) Check you see the hint
5) Go to Admistration > Authority types
6) Choose a type and click on Actions > MARC structure
7) Choose a field and click on Actions > Subfields
8) Click on Edit subfields
9) Check you see the hint
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
