Commit graph

274 commits

Author SHA1 Message Date
Chris Cormack
7934f95494 Adding a system preference to choose whether a homebranch or a holdingbranch is used to check against for independentbranches
Changing GanBookBeIssued to use this systempreference
Set to homebranch by default Paul and others you might want to switch this to holdingbranch to get the behaviour you are used to

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 15:30:38 -06:00
Chris Cormack
4c34e354df Shifting other variables, no need to have the same code twice just more chance for a typo :)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:43:29 -06:00
Chris Cormack
6515251152 Fix for variable scoping problem
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:43:08 -06:00
fa18d24cb7 Enabling yuipath system preference for choosing local or Yahoo-hosted YUI js library includes. Removing yui-toolbars.inc include.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 18:06:43 -06:00
Galen Charlton
8c899d89d4 bugfix: prevent multiple addition of the same authorised value in a category
Also put the prev/next page buttons in the same place relative to the
action links

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 18:02:39 -06:00
fe64096e69 Lots of work to standardize elements like Save/Cancel buttons and delete confirmations. A couple of changes to auth_subfields_structure.pl in order to enable display of tagfield and tagsubfield without outputting hidden form field at the same time (for breadcrumbs).
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 17:53:01 -06:00
Paul POULAIN
04f1f36a77 small fix for a variable out of scope
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 17:52:47 -06:00
Paul POULAIN
5b4d5b6a0e #1546 REPLACE statements (continued)
- biblio framework
- marc tag
- auth tag

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 17:50:12 -06:00
Galen Charlton
b2df12a11d moved kohaspsuggest preference to OPAC features tab
Was in 'Catalogue', but this feature is not related to
cataloguing but OPAC search logging.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-08 17:16:14 -06:00
Galen Charlton
df69fcd17a fixed typo that caused DefaultClassificationSource pref to not be a drop-down
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:24:23 -06:00
Paul POULAIN
1161d6e2a0 #1546 fix (removing REPLACE)
+ reindenting the code
+ SQL follow coding guidelines

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-07 08:18:23 -06:00
Mason James
7a438ffb34 fixed bookfund modify code
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-01 17:27:53 -05:00
Paul POULAIN
134f50e6d2 #1492 MARC subfields structure: can't switch to tab with label "@"
replacing the @ by _ in the template, wich is valid.

I also have changed a little the behaviour : the New button appears only
for >010 fields (<10 have only the data, no real subfield)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:41:08 -05:00
Ryan Higgins
289d65efb7 fixes for auth_val interface:
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:14:21 -05:00
Paul POULAIN
8b7085a8ab removing useless code
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:38 -05:00
Joshua Ferraro
44996f90f4 adding missing systempreferences to en
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-23 18:23:58 -05:00
Paul POULAIN
fe18100ef3 moving some systemprefs to their correct tab
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:21:05 -05:00
Galen Charlton
a2c245c77d call number work part 2 -- added framework for call number filing routines
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 22:11:37 -05:00
Galen Charlton
43d3efe391 classification sources part 1 - system preferences
Database schema definitions and system preferences support
for defining classification sources and filing rules.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 22:11:32 -05:00
Ryan Higgins
70f46147a6 Extending branch categories : adding search domains. partial commit.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 19:18:36 -05:00
701d6ef020 Circulation borrower name autocompletion
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 16:17:08 -05:00
Galen Charlton
9578340d77 fix for bug 1501 - removed reference to marc_biblio from framework test
Also added results of two subtests missing from the template.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:20:33 -05:00
Joe Atzberger
c08afe45e2 admin/stopwords.pl -- More cleanup
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 19:42:42 -05:00
Joe Atzberger
082b2ffe89 admin/printers - basic cleanup
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 19:42:25 -05:00
f35745d40e Formatting admin entry forms, improving breadcrumb navigation.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:25:47 -05:00
Paul POULAIN
917c1ab46c fines management (bugfixes & minor improvement)
- pay.pl fixed, the librarian can see patron fines & mark them paid
- fines2.pl fixed, the script now calculate the fines correctly from the finerules :
  * itemtype / patron category if it exist
  * itemtype / default if needed
- renamed misc/fines.pl as fines-sanop.pl
- added 2 systempreferences:
  * MaxFine: the max amount a patron can be charged for an item
  * NoReturnSetLost: how many days of late before a non returned item is marked lost & the patron charged for the full cost of replacement
(those values where hardcoded in fines2.pl
- C4/Circulation/Fines.pm has been removed (unused duplicate of C4/Overdues)

Note that SANOP feature about notify levels have NOT been ported here. I think they are too specific now, and the code is poorly written
I've renammed fines.pl to fines-sanop.pl to point that it is specific.
Thus, all notify_id related features are not used by anything (and always 0)
Can be interesting to reintroduce them, but that will probably be a large work...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:25:00 -05:00
Paul POULAIN
4794cec244 #1485 (issuing rules improvement) continued
updating fines rules management :
- replacing '*' by default
- removing bottom line (*) that means nothing
- dealing correctly with .0000 fine values
- fixing fine storage

still fines.pl to do

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:40 -05:00
Paul POULAIN
ef27099d90 #1485 (issuing rules improvement) continued
issuing rules are working as expeced with this commit.
working on finesrules now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:37 -05:00
Paul POULAIN
28257e7a98 #1485 (issuing rules improvement) continued
IMPORTANT NOTE : all existing test database for 3.0 must manually delete ALL constraints on issuingrules table
(the update22to30.pl don't contain the constraints anymore, as kohastructure.sql, so are concerned only the existing 3.0 tests databases)

Filling issuingrules table :
- the issuingrules table can't have a constraint on categorycode, as we have a '*' categorycode (=default issuingrule)
- reintroducing the "default" issuingrule column
- changing some text ('*' replaced by something more explanatory)
- handling correctly the '0' (that is different from 'undefined'

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:12 -05:00
Paul POULAIN
94a441f57e #1485 saving issuingrules
lot of bugs to fix...
- a foreign key on patron category is stupid as we have a wildcard
- having a wildcard on itemtype is useless, removing it in template
- reindenting & removing some commented lines
- fixing some SQL bugs (insert/update lines)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 11:56:10 -05:00
4662ba0958 Refining navigation in MARC Framework pages; Fixing unfinished YUI-based toolbar on catalogue detail page: functional now, with some tweaks yet to be done.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 19:12:33 -05:00
Paul POULAIN
c0c11a87c1 #1444: Porting marcEditor to authorities (tab management)
+ reindenting some code

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 19:01:59 -05:00
Joshua Ferraro
464b0e25e7 Revert "#1485 saving issuingrules"
This reverts commit 31eaffcb04.
2007-10-08 16:20:47 -05:00
Paul POULAIN
31eaffcb04 #1485 saving issuingrules
lot of bugs to fix...
- a foreign key on patron category is stupid as we have a wildcard
- having a wildcard on itemtype is useless, removing it in template
- reindenting & removing some commented lines
- fixing some SQL bugs (insert/update lines)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-08 15:52:52 -05:00
Paul POULAIN
3f58590a40 commenting a warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 19:53:46 -05:00
Joshua Ferraro
57408637b9 improvements to the system preferences
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 03:05:47 -05:00
Chris Cormack
a682c0aa74 Fixing logic error that was busting templates.
DO NOT create an empty array by going my @array='';

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-29 19:56:22 -05:00
Mason James
6bd75d133f adding debuglevel to admin tab
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-27 20:25:00 -05:00
Paul POULAIN
a3a4bfc5e6 IMPROVEMENT : reintroducing stopwords management
Zebra (and NoZebra) doesn't deal with stopwords.
It search the exact string the user types.
This commit :
- reintroduces stopword management script that was in 2.2
- add stopword management to Zebra & NoZebra searches.

PS : fortunatly, the stopwords table was not removed by updatedatabase, so nothing to do here.
(& the table is in kohastructure.sql)

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:32:06 -05:00
Chris Cormack
1a4fc157bf Applying the fix for bug 1416 from paul
Had to edit the patch as it was corrupt
2007-09-20 17:39:43 -05:00
Paul POULAIN
1450fd180e FIX for #1375
marc_subfield_structure.hidden lost on create new framework

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-18 15:05:51 -05:00
a453c16632 Finishing cleanup of Admin templates: - Corrected markup generated by scripts. - Added standard or custom resident search form on all pages. - Add breadcrumb navigation to all pages
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-14 17:47:17 -05:00
737730e4a6 Continuing to add resident search form and breakcrumbs. Markup cleanup all around.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:50 -05:00
Joshua Ferraro
cefeb583ad fixing permissions on scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-08-13 12:22:30 -05:00
Joshua Ferraro
e9ae8c0686 patches from paul 2007-08-08 07:41:19 -05:00
Paul POULAIN
f197e25ad9 wrong redirect link fixed
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-08 07:23:51 -05:00
kados
40af15d8e6 changing permissions on templates and scripts 2007-08-07 13:20:51 -05:00
jmf@arwen.metavore.com
c0d85e87b4 From 0751ba130288bc69e9e563473e7fc25551edc40e Mon Sep 17 00:00:00 2001
From: kados <jmf@arwen.metavore.com>
Date: Sat, 4 Aug 2007 20:10:51 -0500
Subject: [PATCH] fixing permissions on all scripts

Signed-off-by: Chris Cormack <crc@arwen.metavore.com>
2007-08-04 22:41:41 -05:00
toins
5cce74881a re indenting 2007-07-12 15:26:22 +00:00
tipaul
24b5fab833 do not use REPLACE in SQL statements : it is not standard SQL, and don't work with integrity contraints : it's a delete/insert, not an UPDATE if the row exist. fixes the problem for borrower categories 2007-07-03 08:48:14 +00:00