Commit graph

688 commits

Author SHA1 Message Date
ce5e2429db fixing various links to point to *.koha-community.org
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-21 22:08:24 -04:00
b2b74a22ed bug 3164: fix OPAC holds in SingleBranchMode
Account for case where no branch is explicitly supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-17 13:17:06 -04:00
Jean-André Santoni
2fb3f22f62 [MT3696] Fixed ILSDI GetAvailability call
(cherry picked from commit 96552d64727dc6fc2525cc9c0c6ece0c718b999d)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-13 10:39:38 -04:00
552a648648 removed AddToShelfFromBiblio from C4::VirtualShelves
Back in the day, lists could contain item records instead or in addition
to bibs, but that hasn't been the case for a while.  Therefore, removed
AddToShelfFromBiblio, which does exactly the same thing that AddToShelf does.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 10:39:36 -04:00
Henri-Damien LAURENT
6e0c124c9c error 500 when record cannot be loaded
On a basket or a basket download, or csv export, if Koha cannot get a biblio, then it failed with error 500.
This patch fixes that behaviour skipping the faulty record in order to present the user with the biblios which are not causing trouble.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-07 12:38:26 -04:00
Nahuel ANGELINETTI
3807dd7b19 (bug #3772) show place hold button in isbd view
This fix the isbd view to show the "place hold" button.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-07 12:24:27 -04:00
573ac9488f remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-07-02 10:57:08 -04:00
f24750f5ba Fix for Bug 4886, missing 404 redirection on wrong biblionumber for MARC and ISBD details
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-23 22:50:19 -04:00
6f14921479 Fix for Bug 4884, opac-showmarc.pl can't find compact.xsl
This patch implements Fridolyn SOMERS' suggested change
to the .xsl file path but copies compact.xsl from the
intranet template dir and points to that instead.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-23 22:46:58 -04:00
ef58c445d3 removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 23:30:48 -04:00
b1ed3af633 bug 4311: respect OPACXSLTResultsDisplay
Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.

In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 11:22:47 -04:00
Jane Wagner
dc0b98eb9e Bug 3093 add syspref to turn off multiholds button
Having the place multiple holds button at the top of the OPAC and staff search results has caused problems for some sites with tight holds policies; this syspref allows those sites to turn off the button.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 07:44:17 -04:00
f3dd19f2f7 Fix for Bug 4400, BIBTEX export from OPAC results in empty file
opac-export.pl tries to get two variables from marc2bibtex(),
but it only returns one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-11 06:14:38 -04:00
a6d6be8958 quell 'non-initialized variable defaulttab' warning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:57:41 -04:00
d407c9cb7c fix malformed call of XSLTParse4Display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:05:23 -04:00
Donovan Jones
91c7bb791f Bug 2505 - Add commented use warnings where missing in the opac/ directory 2010-04-21 20:24:59 +12:00
f5d641787c Fix for Bug 4250, cart missing print button
- Print button was hidden by CSS for some reason (git blame me)
- Print formatting was off because of column mismatch
- Table style modified in print view for clarity
- Redirect from print view corrected by adding missing bib_list
  and verbose parameters

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 00:00:51 -04:00
Henri-Damien LAURENT
c3e808baf6 Bug Fixing opac/opac-readingrecord.pl
There was some rebase issues on this script
Fixing Error 500
two calls to $issues as an array ref where it is now a hash ref

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:58:50 -04:00
Henri-Damien LAURENT
a2eb5852d3 Followup (MT #2920) fix reading record scripts:members/readingrec.pl
Fixing Merge problem on opac/opac-readingrecord.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:43 -04:00
Nahuel ANGELINETTI
c5c83ed8d7 (MT #2920) fix reading record scripts
This patch fix some perl ugly code to be more readable and lesser complex.
And it allow in intranet to order by issues.timestamp.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 09:56:33 -04:00
Chris Cormack
7de93a4093 Fixes for syndetics, some variables needed by the template were not being set
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 21:08:34 -04:00
Jean-André Santoni
d4260af339 Fixed an encoding bug in the documentation
Moved the binmode pragma to the end of the file, so it won't affect documentation templates. So no more double encoding.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:54:45 -04:00
Henri-Damien LAURENT
9428e750f0 Fixed an encoding bug in the documentation
Moved the binmode pragma to the end of the file, so it won't affect documentation templates. So no more double encoding.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:54:43 -04:00
Henri-Damien LAURENT
f3581a594e ILS-DI Messages uniformization
[MT2306_2271] ILS-DI Message codes consistence

The services now returns ILSDI error codes in a <code> tag, plus details in a <message> tag.

Exemple:

<LookupPatron>
<code>MissingParameter</code>
<message>The required parameter patron_id is missing.</message>
</LookupPatron>

[MT2306_2271] Minor changes in HTML

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:39:31 -04:00
Jean-André Santoni
09221f7006 ILS-DI Code cleaning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:39:26 -04:00
Jean-André Santoni
aa17eef42f Fixes access permissions to ILS-DI
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:39:24 -04:00
Lars Wirzenius
873a3cb9bc Fix FSF address in directory opac/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:54 -04:00
21c7f786bf bug 1532: various code cleanup
* export C4::Reserves::CancelExpiredReserves
* rename  misc/cronjobs/cancel_expired_reserves.pl
  to misc/cronjobs/holds/cancel_expired_holds.pl
* added cancel_expired_holds.pl to example crontab
* fix staff crash if AllowHoldDateInFuture is on
* expirationdate is now nullable instead of relying
  on 0000-00-00

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 22:49:48 -05:00
Kyle M Hall
3502810346 (bug 1532) Reserves Updates Ported From Dev_Week
This is a much improved re-implementation of the reserves updates from dev_week.
Less new code has been added, and more existing functions are used instead of adding new ones.

The 'Lock Hold' function has been removed due to it not working as intended.

[RM note for documentation: this adds the following features:

* ability to specify an expiration date for a hold request
  when placing it via the staff interface or OPAC
* daily batch job to cancel expired holds
* nice interface to change the priority of hold
  requests for a bib in the staff interface]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 22:49:47 -05:00
Garry Collum
b0c0840d99 Bug 2505: Enabled warnings in opac-userdetails.pl.
No warnings generated.

The only files left in koha/opac are changelanguage.pl and opac-user.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 21:17:28 -05:00
Garry Collum
39dd21f926 Bug 4227: Removes unused opac-logout.pl.
Performed a recursive grep on the entire file structure to confirm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 21:17:27 -05:00
a066cae6c5 bug 3651 followup: updated for new GetMember() parameter style
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:59:46 -05:00
Nahuel ANGELINETTI
96e7c92583 (bug #3651) sending baskets and shelves
this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.
(cherry picked from commit f87b755228)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:58:08 -05:00
Jane Wagner
5b33873c21 Bug 4215 OPAC "Search for title in" can fail with trailing slashes in title
While configuring Search for Title In links, I found that some target sites
can't process an incoming title search if the title being sent has a trailing
slash.  If the same search is sent without the trailing slash, it works fine.  I
modified opac-detail.pl to strip off the trailing slash (and space) for titles
being sent to other sites.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 12:09:11 -05:00
Garry Collum
999e78ac30 Bug 3070: Fixes RSS feed for single result search.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:10:33 -05:00
Garry Collum
92bca53408 Bug 2505: Add warnings to opac/maintenance.pl
Added a FIXME for warning generated from C4/Context.pm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:10:30 -05:00
Garry Collum
88a4648b15 Bug 4212: Adds license statement to opac-search.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 11:10:29 -05:00
821cfebad6 OAI server fixes
- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref
  and not in DB. It's enough. It's not an end-user preference. Without
  this pref, OAI server operates as previously. And preferences editor
  allow to add a new value to the DB if necessary.
- Fix response to ListMetadataFormats which was empty in extended mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-18 09:45:26 -05:00
Matthias Meusburger
3bbbc15ccf MT 2116: Addons to the CSV export
Fix encoding selection

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:54:11 -05:00
Matthias Meusburger
0268a58e16 MT2116: Addons to the CSV export
Adds the ability to customize CSV exports through the use of a YAML file.

The following customizations are available :
  - Preprocessing
  - Postprocessing
  - Field-by-field processing

The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b94)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 07:51:33 -05:00
Nicole Engard
8594f3f141 bug 4197 fix opac patron update
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 06:27:47 -05:00
419e307f49 bug 4151: replace dep on YAML::XS with YAML::Syck
YAML::Syck is also fast, and dropped YAML::XS means
we don't have to add a formal dependency on it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 05:04:02 -05:00
Nahuel ANGELINETTI
e905106642 (bug #4195) fix OAI repository
this fix the OAI repository, to don't return resumptionToken if there is no more record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-17 04:52:53 -05:00
959c0cb0d8 bug 2505: fix warnings in opac-MARCdetail.pl
Also indulged in a little code cleanup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:32:21 -05:00
Garry Collum
886368370d Bug 2505: Enables warnings in opac-MARCdetail.pl and opac-authoritiesdetail.pl
No resulting warnings after warnings were turned on.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:40 -05:00
Garry Collum
90fc2ef1e8 Bug 4192: Fixes warnings generated by opac-account.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-16 06:12:38 -05:00
Sébastien Hinderer
de94e449cd Bugfix in errors/*.pl and opac/errors/*.pl
The scripts did not define the status printed on the first line of
HTTP headers correctly: they were sending 200 OK,
which was confusing for browsers.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 20:04:40 -05:00
625021ada7 Changes to further work on Bug 3550, Use GetRecordValue to get the subtitle
- Adding subtitle display to OPAC Cart, lists, and reading record
- Minor tweaks to some displays

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-14 14:39:42 -05:00
Chris Cormack
434ab8162f Bug 3797 output 404 error page with a 404 header
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 14:11:44 -05:00
13ab69ae08 bug 4122: make WebBasedSelfCheck functional
The WebBasedSelfCheck preference is now functional - if a user
tries to use /cgi-bin/koha/sco/sco-main.pl if the preference
is not on, they get redirected to the OPAC home page.

Also, the patron image web service now returns HTTP 403 (forbidden) unless
both WebBasedSelfCheck and ShowPatronImageInWebBasedSelfCheck are on.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-10 08:41:50 -05:00