Enables warnings and fixes the resulting warnings in opac-readingrecord.pl. The "description" variable in opac-readingrecord.tmpl was pulling a value from another source, probably an included template. Change the name to 'itypedescription' to resolve the conflict.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds the missing 402.tmpl.
Fixes the <h4> element in 400, 401, 403, and 500, all of which displayed 404.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Also adds some missing conditionals for including javascript
- Also Removes an instance of TMPL_IF EXPR
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
There is a </td> tag which is outside of the block of code which defines checks to see if SMS is enabled. If SMS is disabled it causes several extra </td> tags.
- Formatting links to different subscription views as tabs like the links to MARC view, ISBD, etc.
- Styling display of brief subscription view for better clarity
- Moving filter form on full subscription view to sidebar
- jQuery-fying some full subscription view scripts
- Adding branch name to output of full subscription information
- Styling year links for visibility and clarity (I'm not styling them as standard tabs because
they wouldn't wrap well with many many years' worth of subscriptions)
- Markup corrections
- Removing TMPL EXPR
- Converting delete link to FORM ("destructive" actions shouldn't be links)
- Adding "search history" link to logged-in user's sidebar menu
The "search history" link and the "delete history" link are now correctly displayed after the first search.
Moreover, an additional "delete history" link as been added on the "search history" page itself.
- improving behavior for users with no javascript
- style improvements to list "toolbar"
- adding new toolbar icons
- adding display of subtitle to lists
Bug 4009: New list w/out title fails silently
Fixed so Title is required when adding a list
Bug 4010: Purchase Suggestions Should Require Title
Fixed text so that it indicates that title is required
Added check to make sure Title is filled in
For both bugs I added a required style to the CSS
White space in table cells can often break the javascript tablesorter.
The previous patch to tie the js tablesorter to the shelf sort
parameters should work now.
This patch adds a description of the itype next to the image that i suppose to appear in the selection list.
Fixed the path of the image in opac-suggestions.pl, but I'm not sure if you can actually display an image in a <SELECT> list option.
Also removed an extra </label> closing tag.
In Opac :
Print lists
Carts looks more like lists
Carts "More Details" And "Brief Display" toolbar looks more alike
In Admin :
Search results toolbar now have a "Add To" button for adding to a selected list with a confirmation pop-up, like in OPAC
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Added a syspref to decide what should be displayed by default (holdings
or serial collections)
Added filters for full subscription history (by branchcode and by
subscription)
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Tag cloud fixes :
* ordering cloud by tag name, not by weight
* improve behaviour : either display everyone cloud or my cloud only. When clicquing on "Tag cloud" on the top, will display by default everyone cloud. when clicquing on "My tag" (left tab when logged in), the page will display only my tags and my tags only
This fix the user ability to cancel holds in OPAC.
At the moment, a user can cancel all his holds, but in fact, only items that are not in transfert or waiting to be checked out can be cancelled by the user.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Enhancing C4::SearchSuggestion
And changing its API
Changing C4::Suggestions API taking a hashref for NewSuggestion and ModSuggestion
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Enables ppl to store their search history and delete the whole history
Adding Storable required by Opac-Search-History
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch implements the suggestions about the new and old message system made by Owen Leonard.
Includes type fix pointed out by Owen.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Improved the error messages displayed to users
by web-based self-checkout when a problem with
a loan occurs.
This changed was sponsored by the Plano Independent
School District.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
[1] Change the default sort order of checked out
items to have the most recent loans displayed
first.
[2] Add the ability (via jQuery tablesorter) for
the user to sort the list of loans.
Also fixed the formatting of the due date.
This change was sponsored by the Plano Independent School
District.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds a new system preference, ShowPatronImageInWebBasedSelfCheck;
if this preference is ON, a patron's image is displayed
if available when using web-based self-check.
Note: a patch for updatedatabase.pl will be made when this
change is ready to push.
This change is sponsored by the Plano Independent School
District.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This system is indended to replace the old opacnotes
and borrowernotes fields in the borrowers table.
This system allows an unlimited number of Libraran and OPAC notes to be
attached to a borrower. Each note has a message, a message type,
the data it was created, and which library created it.
Each message can only be deleted by the library that created it unless the syspref
AllowAllMessageDeletion has been set.
This system may be used simultaneously with the old notes system and does not affect it in any way.
A new database table (messages) was added for this feature.
The System also allows for pre-defined notes for Borrower records
To use these, just create authorised values with the category BOR_NOTES
where the Authorized Value is the short description shown in the pulldown,
and the description is the text that should be in the note.
Original Author: PTFS Contractor <dbavousett@ptfs.com>
This work co-sponsered by Middletown Township Public Library, Middletown, NJ, USA
and East Brunswick Public Library, East Brunswick, NJ, USA
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.
It also removed the messaging options from the patron
details and leaves them on the messaging tab.
Finally it adds in address fields that were missing
previously on the update patron form.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page. The same goes if virtualshelves
is turned OFF.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- added altcontactcountry and B_address2 to tables borrowers and deletedborrowers so that all addresses offer the same fields
- changed B_country and country to work with syspref BorrowerMandatoryField
- changed display of Alternate Address on borrower detail page, added labels, lines and edit button to match the other sections
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This preference allows librarians to control which links appear
in the 'More Searches' box on the opac detail page. If the
preference is left blank the 'More Searches' menu will not apear
on the opac detail page at all.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.
This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box. It would not retain its value on subsequent pages if 'no Limit' was selected as an option.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This adds to the interface and code the ability to set the reserve date when
requesting a hold.
Resubmit. Sorry, I formatted it from the wrong branch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl. Also enables zebra striping in opac-serial-issues.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Addendum to bug 3466. opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Displays the Branch name and Category description along with their codes in Suggestion Management.
Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed
Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Reimplemented using jquery, added OSS plugin to both interfaces. This is
another case where having a /common directory used by both OPAC and STAFF
would increase runtime efficiency and cut development time.
Removed unused variables.
I changed the OPAC .term color to match the staff interface, rather than being a
second shade of blue. The highlight/unhighlight link is currently a bit bolder
than its neighbors, but my styling choices are provisional. I expect the final
tweaking of CSS to come from another more capable designer, like Owen.
Note this patch may rely on previously submitted "Search.pm minor cleanup" patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Changed the logic in the html form to have the login prompt only appear if a user is not logged in. Separated the hidemylist functionality from the "show tags from other users" option. Created a link for "hide my tags" or "show my tags" depending on context.
The user can now choose how many tags of other users to show, and can also choose whether to show their own tags or not.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The only reason the TMPL_VAR works where it does is because it is part
of the TMPL_LOOP. It doesn't mean anything outside the loops, since
*everything* would be selected with the same variable, indiscriminantly.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Adds the author and added author fields to the email that is sent from the shopping cart. This makes the data sent via email consistent with the data that is viewed in the basket.
There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch moves the creation of some js-based function links to the script so that non-functioning links will not display when javascript is turned off. Other links which require TMPL processing are hidden with CSS and shown with JS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Resubmitted. My proposed fix eliminates the OpacNav column on this page. It puts the "search for this title in..." links into a drop-down menu, and it moves the "similar items" display into a tab along with Holdings, Reviews, etc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch adds some variables for the sortfield that are passed through the URL so that the sort-by feature works when the jquery tablesorter is used for a list of titles in opac-shelves.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Adds a login message, instead of a "New List" link, to the public list table, if a non-logged in user views the table.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fixes inconsistencies with the public and private list tables in opac-shelves.tmpl. It adds a "new list" link to the public list view, and it adds a "sort by" column.
This patch also removes the toggle variables from the tables in opac-shelves.tmpl and Page.pm, and uses the template __odd__ variable for table highlighting if javascript is turned off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Pending a system for displaying the correct currency symbol based on the system's default currency all dollar-specific symbols should be removed in favor of no symbol.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Cleaned up toggle variable in opac-readingrecord.pl and tmpl. Used __odd__ variable instead.
Missed </TMPL_UNLESS> in previous patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Revision to previous patch for bug 3317. Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.
NTS: Don't use EXPR.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fixes the author and added author fields for the 'More Details' view of opac-basket.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
~ vestigial broken scripts and templates removed
~ meaningless dependencies removed
~ Focus handling issues resolved for cross-browsers
~ Timeout only invoked for non-first screen. This keeps the refresh from
flooding the logs continuously for no purpose.
~ two halves of "validuser" conditional linked in TMPL
~ elsif's used for $op conditionals
The focus should now appear on the "Return to Account Summary" button during errors.
The user can scan anything (w/ carriage return) and get back to the first screen.
Also, special functionality is added for the magic barcode "__KOHA_NEW_CIRC__".
This effectively ends the patron session and logs them out so the next patron can begin.
The purpose is for patrons to avoid having to use a keyboard at all, if libraries
print and have this special barcode available for patrons at the SCO station.
Enhancement was requested by Plano Independent School District.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This change adds a check for the XSLTDetailsDisplay preference since different MARC view tabs display on the detail page if that pref is on or off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Improves Koha's unAPI support as follows:
* The implementation no longer depends on there being
an accessible Zebra or SRW server. Instead, responses
are created by running the bib MARCXML through local
stylesheets.
* unAPI now works for all bibs, not just ones that have
an ISBN. The ID format is changed from koha:isbn:ISBN
to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
http://validator.unapi.info/ .
* MODS3 support now works correctly. As a consequence, this
patch fixes bug 2432 (Zotero support when using the XSLT
OPAC stylesheets).
TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files. According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.
Also removed C4::Search::findseealso(), which was used
only by the two scripts.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
* turn on warnings
* fix problem where the top level of the classification
hiearchy wasn't displayed, instead pointing to
the link to the Wiki page with instructions on
how to set up the feature.
* fix XHTML validation errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
this patch do a lot of things :
* Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
This will be usefull for OpenURL support.
* Replace the span in opac-detail, and put the var get from GetCOinSBiblio
* Fix an <img> tag that wasn't autoclosed
* Add the COinS in search result
* Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If the syspref RequestOnOpac is turned off, the link to place a hold does not
show in the detail page. However, the link is still present in the results
list as well as in the basket and in lists. Modified templates to check
for the syspref and to obey it.
NOTE: This does not turn off the display of the Holds tab in the OPAC
user account. I think there are situations where library staff may be
allowed to place holds but users are not allowed to do so through the
OPAC. Leaving the Holds tab visible shows users what they have on hold,
but does not allow them to place holds. It does allow users to cancel
holds. If there is a need to hide this tab, that would probably be
best accomplished by a separate syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If the items.location field was NULL, then the current
SQL query would produce no results. I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.
In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open. This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.
Added Publication Date Range search to advanced search screen
Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).
Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Added support for the Syndetics AV summary and AV profile
data elements. The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
If a Syndetics title profile (AKA fiction notes page) exists
and is avaailable to the user, add a link to to in the OPAC
detail page.
TODO: add a system preference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
LTFL content needs to appear in div rather than span elements. This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC. Most libraries will want
to leave this turned off!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.
In addition I have made it so that the Date Received
only shows if the item is 'Available'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The patch adds link to "send list" and the text "Log in to place holds or add tags" (with link, similar to the log in message users see in the global lists menu).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch modify the way to transfer the different args, don't use the form arrays.
And use a GET form instead of POST(we are getting datas, sending nothing).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>