Commit graph

4076 commits

Author SHA1 Message Date
105df865ca Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:14 -06:00
Galen Charlton
a74d196f35 bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:22:06 -06:00
Ryan Higgins
761a589fc0 bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:01 -06:00
Galen Charlton
1e248dbc58 bug 2779: fix template syntax error in OPAC home page
Fixes cause of following message in Apache log:

[Wed Nov 12 14:33:36 2008] [error] [client xxxxx] HTML::Template::Pro:in
TMPL_IF at pos 2860:end tag:found e instead of > at pos 2886

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:04:58 -06:00
9cb231a63e Removing some unused stuff from print stylesheet, hiding Koha logo from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 16:31:12 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
John Beppu
9f782076db bug 2563: could not input into marc 008, fields 7-10 and 11-14
You actually *could* input data into those fields, but it wasn't
immediately obvious, because the field size was "4" and the
value was "    ".  You couldn't type anything in until you
backspaced over the spaces that were there by default.

UPDATE 2008-11-05:  Make absolutely sure that those values
are 4 chars long (via JavaScript)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:24 -06:00
c9a00b8b47 Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:37:46 -06:00
Allen Reinmeyer
af9945088c UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.  Javascript wasn't including basket.js on virtualshelves option.  Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.

UPDATED:  Removed EXPR in TMPL_IF conditions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:12:29 -06:00
Nahuel Angelinetti
36fe3b8c6f Some tab cleaning
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:04:26 -06:00
Nahuel Angelinetti
a79a977ee2 fix the private shelf deletion in opac
this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:48:14 -06:00
36e384adc7 Adding javascript to let user click table cell to check containing checkbox.
This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:31:08 -06:00
f58319d4e2 This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:48 -06:00
7045b67a50 Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:47:42 -06:00
Joe Atzberger
83dedaebc2 Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:14:49 -06:00
f04792b3a4 Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:58 -05:00
895b2052f2 Terminology and spelling corrections. Fixes Bug 2724.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:53 -05:00
f0fc788a28 Spelling correction: catalogue -> catalog. Fixes Bug 2730.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-29 09:20:28 -05:00
Michael Hafen
12b216c77d Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 16:29:56 -05:00
bc297e0b72 Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 16:01:09 -05:00
Joe Atzberger
143b757cfe Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 15:41:18 -05:00
Jesse Weaver
b8d8a0ec5a fix for bug 2543: report output by tabulation a bit too literal
This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 11:44:28 -05:00
Galen Charlton
c0536b1ed6 followup 5 to renewal limit override
With removal of content_hidden CSS class from
the circ templates, undoing change to staff-global.css

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:11 -05:00
Galen Charlton
2186eae294 followup 4 to renewal limit override
* use style="display: none" instead of content_hidden
* fix JavaScript so that actions that check/uncheck
  items for a renew or return do not affect
  the override renewal limit checkbox

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:04 -05:00
Galen Charlton
7fa4fd7a55 followup 3 to to renewal limit override
style="display: none" suffices to have a span
be hidden initially; content_hidden is not necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:02 -05:00
Michael Hafen
03d8521cbf Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:34:50 -05:00
755b509cd6 Steamlining javascript for cloning additem block and tweaking style.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 16:30:48 -05:00
9325b1e68f Adding some body IDs to OPAC pages to enable finer per-page control via CSS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 16:23:08 -05:00
17c4b7c17e Changing checkboxes to radio buttons (as it is in the OPAC), since you can't place a hold on more than one specific item. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:59:00 -05:00
8e8f1a04cd Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:52:34 -05:00
Allen Reinmeyer
ae83425a79 Bug #2030 z3950 search function does not filter
Entering a term in the z3950 search box does not filter the results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:35:06 -05:00
Galen Charlton
b47bdb43ae bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 15:25:13 -05:00
becbbf300d Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 14:48:57 -05:00
0a33d4554b Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 13:34:36 -05:00
Nahuel Angelinetti
16fef8ba3e Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-21 10:23:18 -05:00
Galen Charlton
977a1c68d6 followup - use &amp; in place of &
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 16:18:42 -05:00
Joe Atzberger
c9fd091c14 Bug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.
Date fields are now checked against syspref and iso regexps before attempting
to convert or insert them.  The problem characters were non-ASCII diacriticals.
Note: this may rely on improvements in the current 0.54 version of Text::CSV and
Text::CSV_XS, rather than the Koha minimum of 0.01 and 0.32, respectively.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 16:18:39 -05:00
f73da33bbe Some minor markup corrections to opac authorities pages. Some fixes to address Bug 2620.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 15:37:52 -05:00
Michael Hafen
68a6634ffd bug in 'Add/Change link to item details...' I missed Previous checkouts area
This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 15:37:49 -05:00
Michael Hafen
0da84bb4fe Adding a few columns to members/readingrec.pl
Add barcode and issues.renewals to members/readingrec.pl
Had to change the query in C4/Members, items.renewals was squashing
issues.renewals.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 14:47:21 -05:00
60e9fc3b47 Some changes to improve display on Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 10:39:27 -05:00
Galen Charlton
3c4159bed4 followup on Owen's patron attributes patch
Hide the display of the patron attributes only if
no types are defined; the patron attributes section
(and more importantly, the edit link), should still
be displayed if an attribute type is defined, even
if the patron has no attributes currently set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 10:15:11 -05:00
Nahuel Angelinetti
f620ced0b5 Add the feature to create reports with borrower's sex information(Men/Women) (bug #2671)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 10:15:06 -05:00
7ceeccc1ed Spelling correction (catalogue -> catalog)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:50:58 -05:00
cf3af15a47 Hiding patron attributes entry if not configured.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:50:55 -05:00
2cf0eeedb6 More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 09:23:33 -05:00
0d3410d072 Another correction to eliminate left column from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:44:05 -05:00
Michael Hafen
5e963f0fc3 More Consistant terminoligy in stage-marc-import.tmpl
Changes 'Notes about this file' to 'Comments about this file'.  It's
'Comments' in the manage-marc-import.tmpl file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:33:52 -05:00
9ba1baec71 Hiding minimum password hint if there is no minimum password length set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:31 -05:00
378e06dacb Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:29 -05:00
96c29c707f Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:18:17 -05:00
df13aeee3b Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:05:07 -05:00
Michael Hafen
6de2f89e97 bug: sticky due date isn't stick if there is a question about an issue
the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 20:57:35 -05:00
5c8d22924d Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:55:15 -05:00
paul
bd23670eaf BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:51:42 -05:00
Michael Hafen
5170e31ea3 bugfix: Add a message to circulation.pl if item is restricted
Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:29:20 -05:00
cf56684c68 Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:08:20 -05:00
13fca44836 Adding progress bar and some other visual enhancements to file upload interactions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 11:58:21 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Galen Charlton
c7a3b4ede9 bug 2608: let offline circ processing work in background
If an offline circulation file is large, process_koc.pl
could time out before processing all of the transactions.

To prevent this, the processing can now be run in the
background, with an AJAX loop to check the job's
status.

As a consequence of the patch, the UI for uploading offline circ files has
changed slightly.  One must select a file, click the "upload file" button, then
click the "process offline circulation file" button.

Also removed the now-superfluous upload_koc.pl, added the warnings pragma,
and fixed a typo in the template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:22 -05:00
Ryan Higgins
efad22fd4d Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:13 -05:00
Jesse Weaver
852f75bba6 fix for bug 2556: Overlaying records sometimes creates new record
This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:35:44 -05:00
db7daf7586 Corrections to fix javascript error in Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:31:59 -05:00
1d54a98aa8 Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:25:38 -05:00
e3fe31b50b Change missing from previous commit re:Bug 2600.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:12:37 -05:00
e71028b354 Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:11:55 -05:00
4ed113b230 Refining keyboard shortcuts javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:08:06 -05:00
62b550a0be Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:03:39 -05:00
Galen Charlton
6133a06e96 bug 2596: remove URL escaping added by previous patch
If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:59:08 -05:00
ebc305bddf Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:50:19 -05:00
Danny Bouman
738ac4b492 bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:42:28 -05:00
58deb4ed0c Can't escape title variable as HTML because of search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:36:16 -05:00
0dcd876e6a Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:23:54 -05:00
Galen Charlton
82f1cb2761 fix extra <td> introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:17:42 -05:00
5e64df73f0 Correction to previous commit, removing debugging.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:01:28 -05:00
093a7b424a Formatting itemtype icon section with tabs to match authorized value interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 11:01:21 -05:00
Joe Atzberger
c70165ca6c Remove double conditional, fix one FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:08 -05:00
7b2e4ebce2 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:02 -05:00
Galen Charlton
f05a732195 bug 2585: fix search links for names (XSLT OPAC display)
Fix malformed OPAC search syntax that caused this bug:

When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work.  When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:52:55 -05:00
Jesse Weaver
5d8a285b81 fix for bug 2577: Cannot delete patron in IE
Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:45 -05:00
Joe Atzberger
37a33c5041 Remove unnecessary EXPR.
There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:42 -05:00
Galen Charlton
13f858bdc2 HTML fixes for matching-rules.tmpl
* maxnorms, maxoffset => maxlength
* no escape attribute in <input> elements

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:39 -05:00
Joe Atzberger
691b400bc9 HTML validation adjustments to about.pl
Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-04 20:42:34 -05:00
Joe Atzberger
3a2f776875 Validation fix, include required "type" in link tag.
This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 18:19:06 -05:00
05c5500e4f Fixing markup errors, tweaking show/hide javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:07 -05:00
b43c829027 More markup corrections for better validation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:05 -05:00
5714dc3fb5 Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:21:03 -05:00
Danny Bouman
83b8cfb1ad bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:48:22 -05:00
Galen Charlton
85a883ef28 fixing permission 2008-09-02 16:34:41 -05:00
Michael Hafen
cc2cffdee9 change link to moredetail.pl. In other places it's called with itemnumber=
Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:34:14 -05:00
Michael Hafen
9891a955e0 Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:53 -05:00
Michael Hafen
0e3302e78b Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:51 -05:00
Henri-Damien LAURENT
365520159f modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:24:29 -05:00
8a6125532c Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:00:30 -05:00
ba4c13a559 Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:55:54 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
Michael Hafen
0543a9633c If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:38:16 -05:00
79819e0b24 Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:35:35 -05:00
fe04cf015e Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:39:03 -05:00
61e8d4f1c8 Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:30:48 -05:00
d42a2a86a8 Spelling correction. Fixes Bug 2501.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:29:26 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Jesse Weaver
a4ee974e04 fix for bug 1101: Renew All for the OPAC
This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:50:04 -05:00
Joe Atzberger
225e115a85 issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:43 -05:00
Jesse Weaver
e957b3d3c7 fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
This patch changes the template slighly so that these two system preferences do not conflict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:23 -05:00
Jesse Weaver
c77969022b fix for bug 2477: Improve Speed of the Shelf Browser
This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:49:49 -05:00
Vincent Danjean
5879ead901 Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:54 -05:00
Galen Charlton
98dc396b9b bug 2503: fix minor XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 19:27:48 -05:00
Kyle Hall
38cf1fd318 Integrated version of the Koha Offline Circulation file uploader. It needs some testing and cleanup, but it works.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 17:05:24 -05:00
Ryan Higgins
19781ab1b3 bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 16:56:25 -05:00
Joe Atzberger
6e53a31357 Bug #2429, bad HTML from unclosed <head>.
Also some cleanup of opac-showmarc script including removing bogus
dependencies (DBI, CGI methods).  Should consider using C4::XSLT if
applicable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-19 13:40:18 -05:00
092e474389 Fixing a couple of minor markup issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-19 13:40:11 -05:00
Galen Charlton
dee5f4945b bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title

As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.

This patch includes the final component of the fix
for bug 2331.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:58 -05:00
Jesse Weaver
c6e2bcf67d Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:43 -05:00
Galen Charlton
26469d87a2 bug 2520: don't change item-level requests to bib-level
Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.

As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.

Documentation note: new screenshot of list of requests for
a bib in the staff interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:28 -05:00
Chris Nighswonger
6eac5c7b1b kohabug 2507 Fixing labels search to indicate keyword rather than title search
Documentation may require an updated screen shot

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-13 16:35:21 -05:00
Joe Atzberger
18ced6629d masthead - realign terminology for Tag Cloud
Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...".  AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-13 16:09:37 -05:00
Joshua Ferraro
cee096edba Adding some missing folks to the About page 2008-08-10 15:52:49 -05:00
Joshua Ferraro
e219c6c4cf Reverting an earlier change to overdue.pl (still broken) and
fixing a translation problem with borrowers_stats.ptmpl:

xgettext.pl: Warning: borrowers_stats.tmpl: line 28: SGML "closed start tag" notation: <p<!-- TMPL_IF NAME="debug"--> class="debug"<
2008-08-10 06:45:50 -05:00
Ryan Higgins
29d0c646f7 Final cleanup of labels for 3.0
This patch adds the callnum_split and text_justify options to the templates,
fixes bad javascript to switch between 'formatstring' and fixed-field means of specifying labels content,
fixes csv output when fixed-fields specifiers are used, and adds some help text for the formatstring case.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-10 06:19:00 -05:00
Ryan Higgins
e3fa9f2d5f Prevent borrower import from overwriting data that it shouldn't, and polish off a couple error conditions.
When an imported patron matches an existing one, keep data in the original record unless our import file
includes that column.  Also, check for branch & categorycodes, and produce error if invalid.  Finally,
auto-calculate expiry date if not given.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-09 19:07:07 -05:00
Joshua Ferraro
8f4f59a5bb 2433: Cannot apply manual credits with an item number
This patch changes the behavior so that you can enter in
a barcode instead of an itemnumber for the manual credit
and invoice screens. Also, the borrower's account page now
displays a link back to the item record if an item was
linked to the charge
2008-08-09 12:56:04 -05:00
Joshua Ferraro
13789969b0 2482: Default Letter on Notice Triggers Causes Error
Changing 'Default' to 'No notice' as per solution
suggested in bug report
2008-08-09 08:08:11 -05:00
Chris Nighswonger
386aefb44c kohabug 2463 & 2464 Removing unlinked fields from label-edit-layout.pl
This patch removes unlinked fields from the 'Choose Order Of Text Fields to Print'
option on label-edit-layout.pl

It also adds code to make the 'Itemtype' field respect the item-level_itypes syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-09 08:04:57 -05:00
Joshua Ferraro
4673e1cc9b Resolves problem where duplicate blank barcodes threw errors
form now only checks for duplication when the barcode is non-empty
2008-08-08 15:15:23 -05:00
Galen Charlton
bddafff54a bug 2496: add 'edit' link to authority search results
When search for an authority record from the bib
record editor, a new link is added to each
authority result to edit the authority record.  This
allows a cataloger to do the following:

1. Start editing a bib record
2. Click on the '...' to select an authorized heading
   for an authority-controlled field.
3. Look at the results in the pop-up window and
   see that an authority record needs correction.
4. Click on the 'edit authority' link.  This allows
   the authority to be revised.  Note that this
   takes place in the popup window, not the originally
   bib editing window.
5. Save the authority record, then close the popup
   window and redo the heading search.

For various reasons, this not a perfect workflow; this
patch is designed to satisfy an immediate requirement
but needs to be reworked in 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:35:09 -05:00
72622336a3 Link correction (affected only non-js users).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:11:53 -05:00
Ryan Higgins
133fcbd1c1 Add help text indicating that one should not use stopwords with Zebra.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 14:11:52 -05:00
d4ca58e80a Adding "New Item" menu option. Jumps to anchor for Add Item form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 11:56:51 -05:00
8a7a709fb3 Changing tabindex="-1" to tabindex="0". Fixes 2493.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:37 -05:00
476137841e Minor markup correction.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:36 -05:00
Chris Nighswonger
860f1f70e5 kohabug 2458 Disallowing non-SELECT SQL in reports module
This patch enforces SELECT-only SQL in the reports module.
It introduces code to check SQL in two places. The first is
when a save is attempted on a user constructed SQL statement.
If a non-SELECT SQL statement is entered, the user will be
presented with an error message and a button giving the
option of editing the SQL. The second is when any SQL is
executed. If execution of a non-SELECT SQL statement is
attempted, the user is presented with an error message and
instructed to delete that report as the SQL is invalid.

The second check is intended as a safety net as no non-SELECT
SQL should ever be saved.

It may be well to document the proper usage of the direct SQL
entry type report.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:34 -05:00
Joe Atzberger
ecb43a165c addbiblio - HTML validation fix, add type to link
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:30 -05:00
Joe Atzberger
adbb25b52b auth_finder - HTML validation fixes
Missing </tr> and extra </select>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:28 -05:00
Chris Nighswonger
885b2337a1 kohabug 2448 Correcting Alignment of Column Headers
This patch corrects the alignment of the column headers in the overdues list
on the 'Overdue' tab on opac-user.pl It also corrects the template to display
the item type rather than the Koha collection type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 17:01:43 -05:00
Joe Atzberger
428faf41d6 Add missing </td> to opac-user.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:59:00 -05:00
3f39392413 Minor change to correct offset problem for Cart popup. Libraries with opacheader markup specified were finding their Cart popup appearing out of place.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:58 -05:00
Andrew Moore
b77f9da08b Bug 2084 [1/2]: adding warning to overdues report
This patch adds a warning to the staff interface on the circulation page
to indicate that the overdues report is resource intensive on large installations.

This is considered a stopgap solution. Ideally, this report should be changed in order
to make it usable even for large installations.

Documentation note: Although no functionality has changed, any screenshots of the
circulation page on the staff interface should be updated.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:55 -05:00
5794bde204 Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:49:06 -05:00
Galen Charlton
b8fe6d7a1b bug 1433: use same bib when adding new subscription from details page
When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.

Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:15:16 -05:00
Joe Atzberger
49e4e7020d Patron import reform - bug 2287 - expanded error catching and feedback
This incorporates and extends the patch from MJ Ray attached to bug 2287.
Added feedback of up to 25 lines, including for errors at the Text::CSV
parsing level.  This allows feedback for problems than involve encoding.
Added link to download "starter" CSV file (with all the columns).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 09:37:03 -05:00
Paul POULAIN
80c8b5c149 bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.

This manage multiple errors on barcode and displays them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 08:15:29 -05:00
Galen Charlton
3ddf6172b8 bug 2411: fix adding new tag to authority framework
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:34:42 -05:00
Ryan Higgins
0c66ac6702 Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously  was reporting nothing since the js was broken).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:31:24 -05:00
4b115bac26 Correcting markup for validity.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 15:27:23 -05:00
Chris Nighswonger
953a46a088 kohabug 2417 Removing hardcoded query limit from reports
This patch removes a hardcoded 'LIMIT 20' which was added to all report queries
thus limiting all reports to only the first twenty rows of applicable data. In
its place this patch introduces code to paginate through all applicable data,
regardless of how many rows are available. The code will also honor any user
defined 'LIMIT' in reports based on SQL entered directly by the user.

This patch also adds column labels to 'tab' and 'csv' files generated by reports.
NOTE: Only user defined 'LIMIT's apply to 'tab,' 'csv,' and 'text' files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 15:26:50 -05:00
Chris Nighswonger
35b3df2e95 kohabug 1679 & 1680 Fixes date formatting in guided reports wizard
This patch corrects date formatting when defining dictionary definitions in the
guided reports wizard so that dates display according to syspref.

Date formating is also corrected in the report creation section of the guided
reports wizard.

It also corrects a javascript bug which caused some of the calander widgets not
to function properly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 15:26:49 -05:00
Nicole Engard
e9b0fb8b1c Help file updates
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:40:28 -05:00
Paul POULAIN
e3b24f3734 unimarc plugin fix, suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:12:28 -05:00
Ryan Higgins
8393fb0a3a Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )
Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction.  This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time).  Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:49 -05:00
Ryan Higgins
db87e7d738 Update serials planning javascript to properly deal with 3-level periodicity. ( Serials patch 2/3 )
Minor changes to dom object names and id's to allow for proper calculation of the
base planning table from the simplified table.
Prior to this patch, the base table was populated with the incorrect value, so patterns like
Vol{X} No{Y} Issue{Z} incremented the Vol value incorrectly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:39 -05:00
Ryan Higgins
44d1aa5eb0 Serials planning updates patch 1/3
This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible.  A 'show advanced pattern' button will display/hide the
base prediction table at any time.  A 'reset pattern' button is added.  The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 07:59:06 -05:00
d4c7de2a90 Fixing markup error in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 15:29:08 -05:00
Danny Bouman
1396a91b2b bug 2450: expanded size of cardnumber input field
Expanded the size of the cardnumber input field to 20 instead of 10. This allows the full 14-digit barcode to be viewed at a glance without having to
scroll.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 15:29:07 -05:00
19a745d8cc Bugfix #2414
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 15:03:22 -05:00
ff14b726ee Correcting structure and markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 14:34:17 -05:00
16f20864b0 Complete sweep of help files in order to correct invalid markup and fix Bug 2444(break up long lines in templates).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-01 14:33:28 -05:00
Paul POULAIN
0204569353 small typo/html fixes as suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:18:12 -05:00
212e433920 Cleaning up tags display a little bit, adding tablesorter to user tags table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:57 -05:00
70bf88542d Minor markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:54 -05:00
b2e3865e79 Display publicationdate if available, else copyrightdate.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:48 -05:00
30efc33dba Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:47 -05:00
cee7483d52 Partial fix for Bug 2420 ("OPAC shows broken image for some Google Jackets"). This fix only corrects for undefined img src, not for well-formed but broken img src.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:31 -05:00
77b3a204f5 Tweak to results display to correct punctuation and add ISBN.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:16 -05:00
Darrell Ulm
f0da737c25 Removing Billing.pl link, will not even slightly work with InnoDB tables as there is no fast count, will work on later
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:55:40 -05:00
Joe Atzberger
4b47782b6e Tag cloud implementation in jquery.
Initial implementation of "cloud" display on opac-tags.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:45:25 -05:00
Chris Nighswonger
1baf6348cc kohabug 2404 This patch removes Image::Magick and adds GD
This patch removes Image::Magick as a dependency and replaces it with
the (much) lighter GD. Functionality of patronimage code has not changed with
this conversion.

Adding errorhandling for corrupted image file and link to return to moremember.pl when called from there

Added notes about supported image mime types.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:38:18 -05:00
85832f8524 A couple more corrections that should have been in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:40 -05:00
d73b577fa6 Fix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription-add.pl") and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:38 -05:00
Nicole Engard
480f329c96 Update to help file
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:54:35 -05:00
root
a75ffcede8 Small patch again to fix repeated col in reserveratios.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:50:40 -05:00
Chris Nighswonger
f6a3f83ca2 kohabug 2224 Third installment: Further corrections for NULL fields
This patch adds code to clean out any NULL fields in rows returned
since NULL fields do not truly meet the filter criteria

It also corrects a bad db field reference.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:10:21 -05:00
Ryan Higgins
fa28afba18 BUG 2351 : Add duplicate barcode check prior to receiving multiple items. This patch adds a javascript form check for duplicates in-form, and returns an error if there are duplicates in the catalog.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:05:18 -05:00
82d0920ec0 Spelling corrections (Fixes Bug 2381).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 05:57:25 -05:00
Joshua Ferraro
5c2ba65541 This patch fixes the OPAC view and holdability of items:
1. restores a check to itemtype.notforloan to set the norequests flag
2. changes improper boolean OR with AND for checking conditions of setting norequests
3. displays 'Not for loan' for item-level itypes when the itemtype is set to notforloan
4. restores items.notforloan values < 0 allowing holds (ordered items for instance)

We still need a notforhold flag set at the itemtype, and items level
2008-07-25 11:32:06 -05:00
Chris Nighswonger
af288205f5 kohabug 2154 Modifying form input controls to accomodate translations
Due to the logic of the underlying picture-upload.pl depending upon the "value" of the
form input controls and this value being translated, the script then failed to function.
This patch changes the input controls so that this should not be an issue.

This issue should be kept in mind, though, so that it can be avoided in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-25 08:56:10 -05:00
Chris Nighswonger
d8ea5fc339 kohabug 2224 Second installment: Correcting NULL field display
Query references to the unused aqorderdelivery table caused a NULL field to be
displayed in the report results. This patch removes those references.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:11 -05:00
909a548e15 Adding a couple of IDs to the markup to enable more flexibility in custom styling.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:06 -05:00
58d3a0fe84 Styling tabs on virtual shelves page. Did I forget this, or did it get removed at some point?
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:04 -05:00
Chris Nighswonger
880c1335f6 kohabug 2224 Corrects display descrepancies when applying filters
This patch corrects display descrepancies when filters are applied to the
acquisitions report. It also corrects a number of other issues with this
report.

Some documentation changes may be in order based on report filters that
were only partially implimented, but are now available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:37 -05:00
b71cab54cf Minor tweak to tags display.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:22 -05:00
e348a70e45 Adding js table sorter for holdings.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:19 -05:00
Ryan Higgins
eeef609466 Remove 'Cash Refund' from manual invoice, as it calls a deprecated function. Change the code for 'forgiven' from 'F' to 'FOR', since 'F' is used for 'Fine' elsewhere in the code. Mark other subroutines as deprecated that utilize the accountoffsets table, since that functionality was lost somewhere in the 2.2 series, and half-using it breaks things.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:07 -05:00
Ryan Higgins
1dcf4c5e9e Combine 'publication details' and volume columns in display to work with mixed serial data (i.e. some issues linked to serials module, some not). Cleans up display after patch to update sorting with enumchron based on biblio.serial.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:04 -05:00
Chris Nighswonger
9971756a24 kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves
Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:48:13 -05:00
Chris Nighswonger
39d2d593c6 Allow anyone with superlibrarian permission to edit/delete public patron lists
Edit functions here are limited to renaming and changing the type. No one can view
a list except the list owner unless it is public.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:47:58 -05:00
Joe Atzberger
64ba3ffe83 Refine "Patrons statistics" report, fix highlight, remove CGI::scrolling_lists.
At client request, I added code for a rowtitle_display and coltitle_display.  This
allows the script to substitute human-readable lables into the table instead of just
the literal hashkeys.  For this client with dozens of numerical patron categorycodes
having a row titled "29" was not very useful.

I cleaned up the templates and a lot of the report code.  It is of the same style as
the other copy/paste reports and still need further cleanup.  Added sql and debug
feedback (default styled to hidden), as I have for other reports.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:44:58 -05:00
fd2ee6411e Fix for Bug 2373 ("Tags missing from the left menu"). Also doing some cleanup and reformatting on review.tmpl. Fixing some capitalization--I hope that's not a translation problem.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:53 -05:00
16c8171564 Adding new patron form for non-javascript users (Fixes Bug 2344, No "New Member" button w/o js).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:51 -05:00
f2779f6dd7 Removing duplicate column (Bug 2364, "Library column repeated")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:37 -05:00
Chris Nighswonger
1bbfc4fd1c Correcting markup in intranet-main.tmpl to display "Lists" properly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-22 15:43:23 -05:00
Joshua Ferraro
a711cbc224 Updates to the subtype limits for Audience to match the MARC21
standard:

a - Preschool
b - Primary
c - Pre-adolescent
d - Adolescent
e - Adult
f - Specialized
g - General
j - Juvenile

For documentation team: please update the screenshot for
this drop-down as the options have changed.

No re-indexing should be necessary.
2008-07-22 13:44:45 -05:00
Joshua Ferraro
4c4f815a34 Adds a stylesheet for Zebra to do an on-the-fly conversion of the
Koha 952 item fields to the MARC21 standard 852 location fields:

Please add the following to the documentation in a section explaining
the setup of a SRU/Z39.50 server. You can also pull info from:

http://wiki.koha.org/doku.php?id=en:development:z3950sru

Modifying Output of Your Records On-the-fly

Koha supports modifying the output of your MARC records for public-facing
Z39.50 and SRU servers. You can set up custom mappings to convert fields such
as 952 (Koha items) to 852 (MARC21 location fields). For example here would
be a popular mapping:
Name:		Koha Field		Mapping in MARC21
---------------------------
Location: 	952 $b => 		852 $b
Barcode: 	952 $p => 		852 $p
Price: 		952 $v => 		852 $r
Item type: 	952 $y => 		852 $w
Notes:		952 $z => 		852 $z

This would make the output from the SRU server suitable for a
resource sharing network that used the above convention for location
information. To add this configuration to your Zebra, add the following
block of code in the koha-conf.xml in the <retrievalinfo> area:

<retrieval syntax="xml" name="marc21location">
         <backend syntax="usmarc" name="F">
           <marc inputformat="marc" outputformat="marcxml"
                 inputcharset="utf-8"/>
           <xslt stylesheet="/path/to/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim9522852.xsl"/>
         </backend>
 </retrieval>

The retrieval set name (in this case, marc21location) is arbitrary and
should be set as required by your resource sharing network, so long as it won't
conflict with internal usage within Koha itself. It's the retrieval set name
that is used to trigger the server to respond and parse the record through the
stylesheet and apply the mappings.

In SRU, this is set as follows:

http://example.com:210/biblios?version=1.1&operation=searchRetrieve&query=it&startRecord=1&maximumRecords=20&recordSchema=marc21location

In Z39.50 it's the elementset name construct.
2008-07-21 18:09:27 -05:00
Joshua Ferraro
72143ef63e Final fix for 2335: Printers has never worked, so it's removed for 3.0
Someone who has the time to generalize it can add it back
2008-07-20 10:51:03 -05:00
Joshua Ferraro
71e436504b Removes the Libraries facet if singleBranchMode is ON 2008-07-18 17:54:11 -05:00
Joshua Ferraro
dd70b27305 Hide location selection when singleBranchMode is ON 2008-07-18 17:46:58 -05:00
Joshua Ferraro
bc408475f8 This patch resolves a few MARC21 Framework issues for
a default installation:

1. Re-names several of the item fields to make more sense to catalogers and patrons
2. Remove links Non-public note from items.paidfor
3. Changes Non-public note to be hidden in the OPAC view

Fixes issues with the 'hidden' field in the framework, specifically:

1. the editor obeys the rules of possible values for hidden (>4, or <-4)
2. the OPAC MARC display obeys the rules of positive values meaning 'hidden in OPAC'
3. the staff MARC display now obeys the rules specified in the hidden values description
2008-07-18 17:39:08 -05:00
Joshua Ferraro
d753635a95 Fix for 2372: Breadcrumbs on Tags Wrong 2008-07-18 13:47:04 -05:00
Joe Atzberger
322fd538d0 Refine lateorders - error feedback, filter independence
Added error catching for bad user input on number of days.  I.E., if you
try to filter by "bAd", you now get an error message prompting for valid
digits.  Also I updated highlighting to use loop_context_vars.

Fixed filtering to work on either days, vendor or both.  Previously, if
you selected a number of days, you had to select a vendor or else got
empty results.  DOCUMENTATION NOTE: this supplies the expected behavior,
so specifying vendor is no longer required.

Changed filters form to GET method.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:23:51 -05:00
Ryan Higgins
5353d35b7a Correct misspelling of 'recieve'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:26 -05:00