Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Grace Smyth	3ded637bc5	Bug 20010: use Modern::Perl in Patroncards perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; create-pdf.pl edit-batch.pl edit-layout.pl edit-profile.pl edit-template.pl home.pl image-manage.pl manage.pl print.pl Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Marc Véron	45aea7ae1d	Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. To test: - Apply on top of patch 18465 - Go to Home > Tools > Patron card creator - Edit or create a layout - Turn on new choice 'Guide grid' in section 'General settings' - Leave 'Units' unchanged - Crate a PDF using 'Card batches' - Notice that card is printed with a layout grid that reflects selected unit with each 5th and 10th line in different color, unit description displayed bottom left, card dimensions displayed top right in small print inside the layout grid - Print PDF. Set printer settings in Adobe Reader or other PDF printing software to 'Actual size' to prevent scaling to printer's printable region - Mesure out printed PDF and verify that grid corresponds to selecte unit. - Go back to layout definition and choose an other unit, repeat steps to verify that grid respects selected unit. - Go back to layout definition, turn grid off, create PDF, verify that grid does not display in PDF Note for testers / QAers: Position of card elements (text, image...) do not respect the unit, this will be fixed in Bug 18550 Followed test plan and it worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Marc Véron	37da40b323	Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>	7 years ago
Marc Véron	20ad341eef	Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>	7 years ago
Aleisha	d989615c32	Bug 15414: Silencing warns triggered by creating a new layout in patron card creator This patch assigns $field and $image values in the for loops To test: 1) Go to Tools -> Patron Card Creator -> New layout 2) Notice warns 3) Apply patch and refresh page 4) Notice warns are gone and page still works as expected Sponsored-by: Catalyst IT NOTE: Trivial initialization in a loop issue. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Marc Véron	3b23fb8b21	Bug 14107: Patron cards: Make barcode width and height scaling editable The size of the barcode in patron card creator was hardcoded to 1% of the card height and 80% of the card width. This patch exposes both values in the layout editor. If no values are given, the previousely hard coded values (0.01 / 0.8) are used in order to work with existing card definitions. To test: - Go to Home > Tools > Patron card creator - Export a patron card (PDF) from en existing definition - Apply patch - Export patron card again, compare results (should be the same) - Go to Home > Tools > Patron card creator > Manage card layouts - Edit the layout you use for testing and set barcode scaling values e.g. to 0.03 for height and 0.4 for widht - Export patron card again, verify that barcode size changed Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
David Cook	f573a15597	Bug 14366: Units doesn't get saved usefully for patroncards This patch causes the "Units" to be saved and displayed correctly for the "Edit layout" screen in Patroncards. _TEST PLAN_ Before applying: 0) Create a new layout 1) Edit the layout, change the units, and click Save 2) Edit the layout again, and notice the units are still "PostScript Points" Apply the patch: 3) Edit the layout again, change the units, and click Save 4) Edit the layout again, note that the units have changed to your selection 5) Rejoice Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Dobrica Pavlinusic	130e3d9c10	Bug 8315 - remove use C4::* version This patch touches a lot of code, but basically it removes version information from use C4::* in our code. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> All script still compiles after the patch (confirmed by pre-applypatch hook)	12 years ago
Lars Wirzenius	c165df96c0	Fix FSF address in directory patroncards/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Chris Nighswonger	d91ebf445f	Bugfix: Enabling guide box configuration parameter This patch enables turning the guide boxes on/off in the patron cards layout editor. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Chris Nighswonger	84d5b28f12	Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Chris Nighswonger	7edf6810e6	[12/30] Patron Card Creator layout editor interface and code	15 years ago

15 Commits (856425db1e156ee4faf1aae70b0a78845711ba43)