Commit graph

10550 commits

Author SHA1 Message Date
Chris Nighswonger
1c39484c4b [2/40] Work on C4::Labels::Template and associated tests
This commit also contains some work on C4::Labels::Layout as well
2009-09-01 15:47:32 -04:00
Chris Nighswonger
f4d46222e8 [1/40] Work on C4::Labels::Layout module and tests
NOTE: This patch is the first of 40 which almost completely re-factor the
label creator code into a hopefully more scalable form. The new format is
a move in direction of OO handling labels, batches, templates, layouts, and
profiles as objects thus permitting easier implementation of features and
enhancements. It should be possible to export label data in any format one
might choose with the simple addition of a script similar to those included
which produce pdf, csv, and xml format.

One of the larger improvements is a change in workflow that results in template,
layout, and start label selection occurring just before export.

There are also various bugfixes and smaller interface improvements woven into it.

It should be noted that this patch series removes the patron card creator feature
for the present. This feature was only partially completed. A completed variation
will be submitted as a separate patch series to follow in the near future.

The following bugs and enhancements are fixed by this series of patches:

2944 Search to add items to a label batch broken
2061 labels_conf DB values: NULL vs. 0
2511 CSV format string is not cleared when unselected in the label layout editor
2515 Re-factor C4::Labels::DrawSpineText
2823 Label Generator not generating barcodes
3171 Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others
3180 Active settings for label settings should be set at print time only

This work was sponsored by Foundations Bible College & Seminary, Dunn, NC USA
2009-09-01 15:15:45 -04:00
de66ef5c49 bug 3564 follow: ensure NoZebra is passed to templates
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-30 22:07:09 -04:00
Michael Hafen
051477fbfe bugfix error if memcached_servers is empty in koha-conf.xml
XML::Simple returns by default an empty hash ref if it encounters an xml tag
with no attributes or content.  If memcached_servers is empty, as the installer
sets it when this feature is disabled, then we get the empty hash ref.

In checking if memcached_servers is set the empty hash ref evaluates as true.
I.E.

  $servers = C4::Context->config('memcached_servers');
  if ($servers) {

so we get a comiler error from memcached trying to resolve the nonexistant
server address.
2009-08-30 21:55:15 -04:00
84e88bd42e Hide links to stop words management if NoZebra is ON. (Bug 3564) 2009-08-30 21:55:07 -04:00
acbad4fff1 An additional icon for the Bridge set, "E Video, " contributed by John A. Graziano Memorial Library 2009-08-30 21:55:00 -04:00
Nicole Engard
53032f5114 Bug 3547: Staff client call number searches right index now
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-25 20:24:08 -04:00
Nahuel ANGELINETTI
8ef619bf74 (bug #3546) fix issues_stats
This fix the order of columns.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-25 20:23:24 -04:00
7df9800672 Adding some caching to C4::Biblio, to GetMarcStructure
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-25 20:23:22 -04:00
2aba14bdb0 Adding sponsoring libraries, will try to go back and backfill
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-24 07:56:05 -04:00
6b24ddf91c graceful degradation if memcached option is not configured in koha-conf.xml
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-24 07:53:59 -04:00
e16e9205d7 Updating the Makefile so memcached configuration can be added to the koha-conf.xml file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-24 07:33:11 -04:00
32e65e451f Failing gracefully if Memoize::Memcached is not installed
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-24 07:33:02 -04:00
2c82872dcb Starting work on memoizing expensive functions with Memoize::Memcached
A patch will follow with the changes to the koha-conf.xml and with instructions on installing memcached

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-24 07:32:58 -04:00
e4d57d80a2 bug 3481: add deleditems.permanent_location (DB rev 052)
Whenever a column is added to items, it must also be added
to deleteditems - otherwise, whenever an item is deleted,
it will not be saved to deleteditems.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 20:53:20 -04:00
c46a43098f assigned typo fixes to DBrev 051
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 20:37:05 -04:00
Nicole Engard
9970698555 Fixed minor typos in new system preferences.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 20:33:05 -04:00
9812a2ae9b added newlines back to sample_notices.sql
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 20:27:34 -04:00
c03a3a0d92 bug 2611, 1934 followup - DBrevs 049 and 050
Assigned DBrevs as follows:

049: additional correction per bug 2611
050: OPACSearchForTitleIn system preference

Also fixed syntax errors in code for 050.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 20:27:33 -04:00
Nicole Engard
86c760be2d REVISED: Fixed some typos and language in the sample notices.
Realized that we don't want to update the notices in existing installs
as this would overwrite any changes and customizations libraries
may have made.

Original commit: 10b7bab4445c92f7f647be53e4b0ea858cbb2a84

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:55:42 -04:00
Nicole Engard
8f2d9cd6ce Bug 1934: Add system preference to handle editing of 'More searches'
This preference allows librarians to control which links appear
in the 'More Searches' box on the opac detail page. If the
preference is left blank the 'More Searches' menu will not apear
on the opac detail page at all.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:55:31 -04:00
Nicole Engard
766034cfd1 Changed catlogue to catalog per the standard
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:55:18 -04:00
Nicole Engard
faa00b399a Fixed some typos and language in the sample notices.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:55:08 -04:00
Nicole Engard
98a46d9b1a BUG 2611: Changed catalogue to catalog and fixed capitalization.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:54:55 -04:00
84db6a18cc bug 2611, 2761 followup
* set DB changes as revs 047 and 048
* ensured that itemcallnumber was widened to 255 in items and
  tmp_holdsqueue
* adjusted DB update descriptions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 19:08:25 -04:00
Nicole Engard
2e483b8d1b BUG 2611: Changed catalogue to catalog and fixed capitalization.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:52:20 -04:00
Nicole Engard
de0bba99dc BUG 2761 Fix max length of itemcallnumber to 255
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:50:11 -04:00
82f4badf51 bug 3464 followup - fix glitches
* Fixed 'counry' typo
* added country and B_country to deleteborrowers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:38:56 -04:00
119a89719d bug 3464: set to DBrev 046 for new borrowers columns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:38:56 -04:00
Sébastien Hinderer
f1f833c965 bug 3464: Takes columns country and B_country of table borrowers into account in related operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:19:20 -04:00
Sébastien Hinderer
ed62c08288 Database structure modification.
Adds the country and B_country columns to the borrowers table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:17:11 -04:00
63b9b7655b bug 3539: tweaked English description of HidePatronName syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:58:25 -04:00
Chris Cormack
634df1c76c Bug 3539, Adding a systempreference to hide borrowers name on the catalogue detail page, and holds page
Squashed commit of the following:

commit e9dd6e1dee03fe3503f7995b57510f9edfe6b333
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:14:53 2009 +0000

    Version number

commit df3ee5473e79b760a91c62b96d7ce19229e0fd27
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:08:11 2009 +0000

    French systempref

commit c4b036e4e43947d7d1fb9f2e18e460788cb4e1ec
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 00:25:33 2009 +0000

    Code to update the database, and updating the sysprefs.sql

commit f74b942c24d5e9c33a4ec0e5ac706a0e347eb1a7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 02:07:22 2009 +0000

    Now hides the name on the detail screen too

commit 53c80dbef88e360a4bbb78ecff3a6ca6ec401398
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 01:35:19 2009 +0000

    Allowing the librarians to choose to hide the borrowers name on holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:52:26 -04:00
7d2562a70a bug 3485: fixed updatedatbase (also DBRev 043->044)
* Fixed case of copy-and-pastitis in DBrev descrieption
* Inserted description for new syspref

NOTE: Please do not leave the system preference description blank
in the updatedatabase entry - even for non-English users, an English
description is more useful than a blank one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:25:48 -04:00
PTFS Contractor
36ec435cd9 bug 3485: Clear Borrower record after checkout.
Button added to clear the last Borrower record after transaction is complete
To enable, turn on the syspref DisplayClearScreenButton.

This work was sponsored by Middletown Township Public Library, Middletown, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:21:21 -04:00
5ea0d6bb9b bug 3481: imporve cart_to_shelf.pl
Use revised CartToShelf() to insure that indexer
knows to reindex affected bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
d2943ebc6c bug 3481 followup - ensure permanent location is stored when updating item
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
dafb3e20da bug 3481 followup - improve CartToShelf
* added POD
* removed optional $barcode argument - in all cases,
  itemnumber is known, and we should stick with
  itemnumber when retrieving an existing item
* use ModItem to do the update so that indexer
  will know to reindex bib - otherwise, can't
  do an accurate search of items that are on
  the shelving cart.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
4b71494f19 bug 3481 followup - set temporary processing location
Ensure that the temporary processing location is always
set regardless of whether one item is added or multiple
copies are added at once.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
8219d79f5a cosmetic fix - use $itemnumber as argument to GetItems when available
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:32 -04:00
40ad4d2129 bug 3481 followup - add new sysprefs to circulation section 2009-08-23 13:07:32 -04:00
6f5797a315 bug 3481 followup - fix database update
Set items.permanent_location to the current value
of items.location - otherwise, the item shelving location
could get blanked as existing items are checked in.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:32 -04:00
Colin Campbell
e40e11ab0c bug 3481: Allow Item Temporary Locations for Processing and Shelving.
Allows temporary locations corresponding to 'in processing' and 'shelving'
so that newly-created items, and newly-returned items do not show
immediately as a available. Three new system preferences govern the usage
of these features.

NewItemsDefaultLocation. If system pref NewItemsDefaultLocation is set to a location code,
 all newly catalogued items will be set to the location set in this preference.
 Location code must be a valid LOC authorized value type.

InProcessingToShelvingCart. if the system pref InProcessingToShelvingCart is turned on,
any items run through returns.pl with a location code for 'PROC', will be modified to
have a new location code of 'CART'.

ReturnToShelvingCart.  If the syspref ReturnToShelvingCart is turned on,
all items returned other than confirmed holds will have a new location code of 'CART'.
Any item issued is automatically taken of the shelving cart.

Adds a cron script shelf_to_cart.pl which should be run hourly.
Updates all items with a location of CART to the item's permanent location.

The original location code is stored in the new items column 'permanent_location'.

Original Author: PTFS Contractor <dbavousett@ptfs.com>

This work co-sponsored by
  Middletown Township Public Library, Middletown, NJ USA  and
  East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:54:46 -04:00
b159ba8e5a fix how patron_flagged gets set for opac-user.tmpl
Remove unneeded variable and get value from $borr->{'flagged'}
directly, avoiding glitch where $borr->{'flagged'} could be
set after old $patron_flagged variable was set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:35:26 -04:00
8e40c2d017 bug 3493: DBrev 041->042 (added OPACFineNoRenewals)
Also changed default value of OPACFineNoRenewals to 99999
when upgrading existing databases so that there's no (likely)
sudden change in OPAC behavior.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:35:26 -04:00
Jesse Weaver
f8a43317b1 Prevent OPAC renewals if fines are over limit
This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.

This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:13:26 -04:00
5593a28164 implement bailing out of AddReturn if IndependantBranches is on
If IndependantBranches is ON and user attempts to return an
item at a library other than the item's home library, bail out.
This action, which was previously just a suggestion in the code,
is now required to ensure that the item doesn't get its
holdingbranch set to the library at which the attempt to return
the item was made.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
15fbaea348 bug 3409 followup - fix use of $hbr
$hbr in this context is a branch code, not an
item field.

Also added use of C4::Debug;

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
b59e016612 AddReturn now always updates holdingbranch
Prior to this patch, this was done only when returning
an item after it had been out on loan.  Even if the
item had not been on loan, the fact that it was checked
in means that it is now in fact at the new holding library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
223d1fa6e8 bug 3409 follow: fix crash if holdingbranch is undef
Make _GetCircControlBranch() default to the item's home library
in the case where it otherwise would have returned the item's
holding library but that field is null.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00