Commit graph

9705 commits

Author SHA1 Message Date
a2c071aace Fix for Bug 3095, Add to lists page doesn't redirect with no javascript
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:22 -05:00
fe75457c5d Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:20 -05:00
e183ac099a More fixes for Bug 3044
Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:17 -05:00
Nahuel ANGELINETTI
89c062c44b (bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view
this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 11:16:34 -05:00
Nahuel Angelinetti
13763623e7 add the possibility to replace, in sysprefs, the code by it's valuecode with {{code}} ex : {{995c}}
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 11:15:38 -05:00
Joe Atzberger
6a2c518efa Add warning for unrecognized sort order.
This may help elucidate problems we are having with sorts that
do not seem to work.  I.E., if the inteface is requesting
unrecognized sort orders, we need to know about it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 11:01:35 -05:00
Galen Charlton
2e08f626f5 remove incomplete bib bulk editing code
Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:53:50 -05:00
502a8cb7e2 Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:36:26 -05:00
Henri-Damien LAURENT
faf7c886f2 3040 : seriestitle mistaken as collection title
If series title was previously taken as collectiontitle
then you should launch
misc/maintenance/UNIMARC_fix_collectiontitle.pl
misc/batchRebuildBiblioTables.pl

[RM note: applies only to UNIMARC users - MARC21
users should not run the batch jobs.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 09:53:16 -05:00
c705832fa9 New styles for bulk hold and bulk tag inputs on search results page.
This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 12:00:39 -05:00
e3d787fc22 Another try at fixing Bug 2949.
This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 11:48:28 -05:00
Galen Charlton
ffe51d1c15 restored tab-delimited report download
Previous patch broke this, always providing the
guided report download in CSV format regardless of
whether CSV or tab-delimited was requested.

Also, default name of downloaded file is reportresults.csv
for CSV output and reportresults.tab for tab-delimited.

Also removed a couple subroutine prototypes that
were leading to unnecessary compile-time warnings
under use warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 11:32:28 -05:00
Joe Atzberger
14be4400d8 Bug 3066 - Overhaul guided reports
execute_query now refactored, returns reliable results, does
zero presentation-layer crap.  Arguments reduced, client scripts
adapted to new API and performance improved.  Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.

Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
    ~ security fixed
    ~ documentation improved
    ~ TODO: finish sendmail option.

Bug 3077 also fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:17:55 -05:00
Joe Atzberger
76d0e8d05b Condense inarticulate construction of TMPL structures.
Use map to replace multiple temporary hash constructions.
Also a minor POD fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:17:47 -05:00
Joe Atzberger
1caa108ef0 runreport.pl and prep work on Guided.pm
The old location of runreport.pl was under tools, leaving it exposed
to web requests.  This is a security flaw since it does NOT check any
Auth and allows the user to request any Saved Report be run.  This is
not a problem under misc/crontab/ and it suggests the more appropriate use.

Guided.pm is not fixed here (see bug 3066), but it is prepared to be fixed
and made compatible with runreport as detailed in the perldoc.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:14:32 -05:00
Joe Atzberger
104de0640b Serial IF statements on same $variable should be ELSIFs.
Small POD update also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 20:14:19 -05:00
Mason James
2fd01051fd patch for bug-3017
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:53:16 -05:00
Nahuel ANGELINETTI
4f8f297a23 (bug #2862) improve sql reports
Clear all non-alphanum chars at the end of an sql query.
Use ESCAPE=HTML to escape double quotes in csv export

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:53:06 -05:00
02b5091c1a Internationalize Amazon support
With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:38:37 -05:00
David Bavousett
71bd421f4b Updated INSTALL.debian
Modified INSTALL.debian to update install and web
configuration instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:27:42 -05:00
J. David Bavousett
d605af2d8b Changes to installed indexing.
These changes tidy up ISBN and ISSN indexing, per Michele Maenpaa.  It's being
set up manually on many new installations, and probably ought to become part of the default
Koha installation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:18:39 -05:00
J. David Bavousett
a7d1ab0041 Changes to bulkmarcimport.pl
Adds three new switches:

-idmap <filename> - optional output file of
                    map of source record ID numbers
                    to Koha biblionumber
-x                - if idmap is supplied, MARC tag
                    to get source record ID from
-y                - if idmap is supplied, MARC subfield
                    to get source record ID from

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:18:29 -05:00
J. David Bavousett
13cce1b3c5 Modifications to C4/Matcher for colon and ending punctuation
Recommended by Michele Maenpaa, this adds handling colon and end-punctuation stripping
in subroutine _normalize, and fixes length testing in subroutine _get_match_keys

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:10:49 -05:00
J. David Bavousett
5e99f59fa6 Added ISBN to RSS results.
Added ISBN tag to RSS results, right after the title.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 19:04:38 -05:00
Michael Hafen
a0a24ae25f tweek css for staff search results item type images
This add a clear:left; to the #searchresults ul li selector.  Otherwise
it's possible an item type image will be offset by an image above it and
not float all the way to the left.  This makes sure the image is clear
of the above image.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:52:50 -05:00
Joe Atzberger
657371808a DDCN callnumber splitting with test.
Similar to previous patch for LCCN splitting, this patch incorporates
changes to split_ddcn and supplies a test file for verifying proper
operation.  Note that the only previously documented example for intended
operation is included as one of the tests.

This regexps are created to be rather forgiving.  For example, the function
will not choke if two spaces were included where the "spec" (such as it is)
expects one.  Obviously this is because for CN splitting purposes, it doesn't
matter, we're not going to ever split in the middle of whitespace.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:47:48 -05:00
2b14727449 Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:31:16 -05:00
Nahuel ANGELINETTI
83dc3588de (bug #3084) in baskets, change the isbn of column
this patch add a new column and put the isbn in it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:31:05 -05:00
462dead372 Adding details to OPAC search results RSS, described in Bug 2973.
This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:22:04 -05:00
Galen Charlton
33996aab95 bug 3088: fix crash in opac-ISBDdetail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 18:18:05 -05:00
Galen Charlton
96f990f64c fix type of new serials display system preferences
OPACSerialIssueDisplayCount and StaffSerialIssueDisplayCount
should be integers, not free.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:48:17 -05:00
Daniel Sweeney
17b1412ceb Cleared a trailing warn, sorry.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:50 -05:00
Joshua Ferraro
76f03c53b0 Adds a 'New Subscription' option for selection from the detail page of a record.
NOTE TO DOCUMENTATION WRITERS: Due to the limitations in the serials module search
interface, some users may find it easier to use the standard catalog search to locate
an item on which to create a subscription record, and then use this new button to
create a subscription from the detail page.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:48 -05:00
Joshua Ferraro
5cf8fcc2cf Fix for Bug 424: Serials display: installer does not make database changes for display parameters, so can't save new subscriptions
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:42 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Galen Charlton
130ca7fb63 fix syntax error in tags JavaScript
FF will tolerate a trailing comma in an
array literal, but Internet Explorer does not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:08:43 -05:00
Stephen Edwards
6d54aa97f0 bug 3034: Tag multiple items at once.
Added a "Tag" button in the toolbar area of the results
page.  This activates an inline form that allows the user
to enter a tag that can then be applied to all currently
selected items.

In addition, a "Tag" link has been added to both the List and
Cart pages that provides the same functionality in those contexts.
In these two cases, the a per-item states appears below the
bibliographic information for each item.

Status that applies to the overall operation, such as failing to
provide a tag, will be shown in an alert dialog box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 12:30:01 -05:00
Galen Charlton
9c4a717dd5 added dependencies for new OAI-PMH server
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:50:18 -05:00
28d653dd38 Add a UNIMARC to Dublin Core XSL
This XSL transforms XML UNIMARC biblio record into
its DC representation. It is the equivalent of
MARC21slimOAIDC.xsl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:30:13 -05:00
f257730050 Add another OAI server
This OAI server has those characteristics:

   * It doesn't use C4::OAI anymore.
   * It uses HTTP::OAI library which is easily expandable.
   * XML result is not build anymore directly but using
     XML::SAX::Writer. It should solve encoding and XML related issues.
   * It returns two formats: oai_dc and marcxml.
   * DC is generated from biblioitems.marcxml by applying XSLT
     (MARC21slim2OAIDC.xsl or UNIMARCslim2OAIDC.xsl).
   * It uses the same tokens as previous OAI server (thanks Philippe
     Jaillon).
   * There is no more sets (it wasn't operational in previous version).

Add two new dependencies:

   * HTTP::OAI
   * XML::SAX::Writer
     available as a Debian package: libxml-sax-writer-perl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:30:08 -05:00
Galen Charlton
b28752346f add } that slipped out because of bad merge
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 11:03:21 -05:00
46c0706ee1 Bug #3071 - Z39.50 search result highlights are mixed
This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:53 -05:00
6542fc4216 Add Babeltheque OPAC enhanced content
www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:42 -05:00
066adc4a3e Fix Amazon cover for UNIMARC
In UNIMARC, 010 tag contains ISBN. In UNIMARC, ISBN with '-'
are valid. This patch modify ISBN normalization in order to
automaticaly suppress '-' before sending ISBN to Amazon
to get book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:39 -05:00
67bba6319d Reformatting receipt template and CSS to be more readable.
A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:37 -05:00
Mason James
81e5fdd249 BUG-1503: fixes broken matching for 'hidden' values.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:32 -05:00
Nahuel ANGELINETTI
030ed76dc7 (bug #2913) show "--" on repeated fields
This patch just transform the script to set the field title as "--" if it was already shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:31 -05:00
Mason James
eb62fd74c1 fix to ignore 600$2 'Source of heading' fields for MARC21 subject display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:28 -05:00
b70cd9f3eb Adding patron address to select patron form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:27 -05:00
Nahuel ANGELINETTI
1bb9f76e66 (bug #3057) mandatory subfield edition
modify the "name" of mandatory input field.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:17:37 -05:00