Commit graph

228 commits

Author SHA1 Message Date
Paul POULAIN
0f568a8aff fix for #2440 : acquisition recieve & item creation
It has to be reintroduced, as some (most in France) libraries don't create
items on recieve, but after "equipment" step.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 15:09:22 -05:00
Chris Nighswonger
a6c829e2bf kohabug 2390 Setting default fund for new orders
If a new order was created and no fund selected, a db error was thrown due to the
'bookfundid' field being set to NULL. This patch sets the first fund retrieved from
available funds as the default selection in the scrolling list.

A further enhancement might be to allow the library to choose which fund is the
default fund.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:10:09 -05:00
Ryan Higgins
0d7265bd73 Populate items.cn_source in acq receive. However, items.cn_sort is not calculated. See bug 2403.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:05:22 -05:00
Ryan Higgins
fa28afba18 BUG 2351 : Add duplicate barcode check prior to receiving multiple items. This patch adds a javascript form check for duplicates in-form, and returns an error if there are duplicates in the catalog.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:05:18 -05:00
Chris Nighswonger
af970db232 kohabug 2139 Fixes C4::Aquisition::NewOrder so that it saves the branchcode
&NewOrder did not save the branchcode posted with a new order. This patch adds that param.

Added code to select the branch the order is for in the branch dropdown list on
acqui/orderreceive.pl

Updating POD and tests

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 14:54:01 -05:00
Ryan Higgins
cf3ba2a822 BUGFIX 2387 : Pass vendor id to subsequent pages in neworder search from existing biblio.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-24 11:26:13 -05:00
Joe Atzberger
322fd538d0 Refine lateorders - error feedback, filter independence
Added error catching for bad user input on number of days.  I.E., if you
try to filter by "bAd", you now get an error message prompting for valid
digits.  Also I updated highlighting to use loop_context_vars.

Fixed filtering to work on either days, vendor or both.  Previously, if
you selected a number of days, you had to select a vendor or else got
empty results.  DOCUMENTATION NOTE: this supplies the expected behavior,
so specifying vendor is no longer required.

Changed filters form to GET method.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:23:51 -05:00
Ryan Higgins
0bb91c1624 Bug 2351 : Receive acqui order was not incrementing loop counter when saving multiple items.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-15 09:58:36 -05:00
Andrew Moore
b14eb8f093 bug 1980 [3/3]: remove bug workaround from pagination links
yesterday, the C4::Output::pagination_bar had a bug in it that I was crudely working around.
atz fixed that bug this morning. This patch removes the workaround. Thanks, atz!

I'm sending along atz's patch again with my signoff. It needs to be applied before this, as does the
other 1980 patch. I have sent that along (again), too, with a modified subject line. That makes a total of 3 patches for 1980.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 09:18:30 -05:00
Andrew Moore
66c420c3d0 bug 1980: updateing calls to SimpleSearch to limit number of things returned
C4::Search::SimpleSearch was alredy patched to let you pass in the number of results you want back.
These instances were not using the new API. This patch makes all calls to SimpleSearch specify a limit.

I improved the documentation of SimpleSearch a bit to include the third returned value.

I believe there's a bug in C4::Output::pagination_bar, in that it doesn't deal well with URLs
with only one pair of parameter=value passed to it. I'm getting around this by passing in a second
pair that does nothing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 09:11:24 -05:00
Ryan Higgins
1c29e1a621 bug 1553 - fix breadcrumbs on add by suggestion page.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 18:20:43 -05:00
Ryan Higgins
20eca1f1fa bug 1839 - add default shipment date to today.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 18:05:01 -05:00
Ryan Higgins
e483f065a3 bug 2201 - autoBarcode code in acq is old. Modified to only work with 'increment', and added FIXME
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 16:48:50 -05:00
Ryan Higgins
2f59f1c2e4 Another API call fix to get the vendor name.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 15:59:44 -05:00
Joe Atzberger
cb551fb948 Script is not an Exporter. Convert to using C4::Debug.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 15:31:16 -05:00
Ryan Higgins
0f95497ab8 Fix call to wrong API fcn resulting in missing Vendor information on two acq pages.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 15:21:13 -05:00
Ryan Higgins
59cd6cc346 Fix broken link and quick formatting of currency.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 14:52:12 -05:00
Ryan Higgins
3dc7ca5aff Bugfix bad template variable, causing no data to display on bookfund.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 14:45:22 -05:00
Ryan Higgins
f2feb68509 Bugfix 1417 : library was not being saved on order edits.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 14:34:59 -05:00
paul
2c8b6b617b various fixes for acquisition histsearch
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:53:07 -05:00
Paul POULAIN
f0deb12b78 (bugfix, CRI) Permission needed is acquisition, not acquisitionS
+ i've added 'intranet' to reach intranet error page, not OPAC one (which is the default when no type specified)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:26 -05:00
886fdce625 Fix for Bug 2086, Filter Button Misleading. This moves the filter form into the left-hand sidebar.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:11 -05:00
Joe Atzberger
7e28158855 acqui/addorder.pl - use reliable GetBookSellerFromId instead of relying on name search.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-08 11:19:27 -06:00
Joe Atzberger
3f17ad4adc acqui - fix to use GetBookSellerFromId(supplierid) instead of partial name based lookup
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-08 11:19:21 -06:00
Joe Atzberger
79c37dc8ed basket.pl and template - Many fixes including SQL injection security check,
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-08 11:19:18 -06:00
Henri-Damien LAURENT
f0bf3a5db8 BUG FIX : detailed page for supplier failed to get supplier information
GetSupplier was split into two functions.
Using GetSupplierFromId

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 15:31:15 -06:00
Chris Cormack
590551e14d Tidying up formatting
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:11 -06:00
Chris Cormack
18b8a1c659 Fix for bug 1791
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:08 -06:00
Joe Atzberger
aa5a4b92d2 basket.pl - bugfix 1714, GST pre-inclusion checked. FIXME's added.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:31:03 -06:00
Chris Cormack
804a46a9c8 Fix for bug 1539
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-14 16:48:12 -06:00
Joe Atzberger
49ba04d272 Calendar (js) tweaks: histsearch fixed, viewlog template updated
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-09 14:50:15 -06:00
Galen Charlton
c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Ryan Higgins
97b907216b fix for bug 1723. no auth on finishreceive.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 20:11:49 -06:00
Ryan Higgins
31ddb16fa2 Fix bug in ModReceiveOrder call
had been losing datereceived and replacementprice on modorder.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 18:42:48 -06:00
Ryan Higgins
52e1a15e5a Specify datereceived when receiving a new parcel.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 18:42:47 -06:00
Ryan Higgins
94036d8490 Fix for bug 1251 (blank supplier name)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 15:49:06 -06:00
Ryan Higgins
b2f5cf3ad2 Further updates to acq, merging in dev_week mods.
Splitting orders now on receipt.
Many tmpl updates to pass correct values btwn scripts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 15:07:08 -06:00
Ryan Higgins
0c2bb2ada2 add item-level location,collection fields to orderreceive
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 15:07:06 -06:00
Ryan Higgins
c9a35c1089 cleanup parcel.pl and tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 15:07:04 -06:00
Ryan Higgins
4b089e1eee updates to acqui - first of several commits
bug fixes to display and save publishercode and purchase order numbers.
use invoice number in place of parcel code
fix template apparently allowing user to modify biblio details on add/mod order
removing CGI scrolling_list

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 15:07:02 -06:00
Galen Charlton
4ad5df9655 fixed C4::Dates usage that caused crash of orderreceive.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:36 -06:00
Joe Atzberger
ca4ba92f21 basket.pl - conditionalized w/ $debug 3 warnings that would otherwise fire every time!
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-12 07:55:07 -06:00
Joshua Ferraro
d7ec5d8aaa cleanup of acqui/ for Dates, missing format_date 2007-12-04 19:06:05 -06:00
Joe Atzberger
a7d1ef6dff acqui subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:21:09 -06:00
Joe Atzberger
bfcc5b00f9 Dates.pm - ongoing integration, acqui/histsearch.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:28:17 -06:00
aee15ef86f Another fix for But 1165. All taken care of now, I hope.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 19:59:25 -06:00
1fb6279ddd A couple of changes towards fixing Bug 1165 (GST in PROG templates)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 19:49:17 -06:00
Ryan Higgins
271aa9043d Adding MARC preview to acqui screens
Also cleaning up some missing params and language.
Add another js library: greyox (jquery derivative iiuc).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 22:15:08 -06:00
Paul POULAIN
c903276aec bugfix : we need to give the booksellerid to the biblio search
(otherwise, it will be empty, and a constraint will fail, making the input fail as well)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:23:24 -06:00
Paul POULAIN
8b7085a8ab removing useless code
the 3 parameters :
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),

are filled by Auth.pm automatically, removing them in templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:38 -05:00