Commit graph

547 commits

Author SHA1 Message Date
Garry Collum
700f039384 Bug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.
Copies the logic of catalogue/search.pl to fix the expanded search option in opac. When expanded search is the default, it was impossible to go to the "fewer" options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 22:15:30 -04:00
Garry Collum
54dad0143c Bug 3428: Alphabetizes the collection codes in the Advanced Search.
If the advancedSearchTypes = CCODE, the code descriptions are not alphabetized, as opposed to itemtypes, which are alphabetized.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 21:24:54 -04:00
Garry Collum
a1f827a611 Bug 3317: Adds author and added-author to email sent from basket (Cart).
Adds the author and added author fields to the email that is sent from the shopping cart.  This makes the data sent via email consistent with the data that is viewed in the basket.

There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 22:54:04 -04:00
Joe Atzberger
af1fb6f0b4 Bug 2539. Remove unintegrated "spsuggest" code from search scripts.
The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:20:25 -04:00
Joe Atzberger
f6e1214cd6 Cleanup opac-search.pl
Use GetBranchesLoop.  Use elsif.  Use $format w/ a fallback "" value.

More to come.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:01:46 -04:00
Nahuel ANGELINETTI
79fc6d81f7 (bug #3267) show items.uri in opac and intranet
This add a column in normal view, with a link to items.uri URL if it exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 08:26:33 -04:00
5aeb6f76f1 Correction to enable sending of update emails.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:52:18 -04:00
04d2b672f6 Moving the text of an error message from the script to the template where it can be translated. Partial fix for bug 1153.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:52:11 -04:00
Nahuel ANGELINETTI
ba6c8f1dd5 (bug #3363) do not reload parent if you add a biblio in shelf
this patch make the script not reloading the parent if the user add a biblio in a already existing shelf(useless).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:19:08 -05:00
Garry Collum
9c984ccade Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.
Cleaned up toggle variable in opac-readingrecord.pl and tmpl.  Used __odd__ variable instead.

Missed </TMPL_UNLESS> in previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:56 -05:00
Jane Wagner
437188f444 Revision to my earlier patch for displaying the user name on checked-out items
My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-17 11:48:04 -05:00
Garry Collum
ee167345d7 Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.
Revision to previous patch for bug 3317.  Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.

NTS: Don't use EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-17 11:42:43 -05:00
Matthias Meusburger
0a2a13ca13 bug 3292: in opac branchcode should be replaced with name
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 11:03:46 -05:00
savitra.sirohi
6ae7b60962 Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages.
This is available only on the masthead search box in the OPAC.

User has to enter a word in english and press space or return to transliterate the word. The destination language can be selected from a drop down list. User can temporarily turn on/off the feature by using "ctrl +g".

A system preference - GoogleIndicTransliteration can be used to turn on this feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-05 18:05:47 -05:00
Galen Charlton
adaf1d9195 fix minor warning issues in SCO
* test for NO_MORE_RENEWALS now does expect
  that hash key will always exist
* removed unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 14:37:29 -05:00
Joe Atzberger
ece3a31fca Cleanup SCO - OPAC self checkout
~ vestigial broken scripts and templates removed
~ meaningless dependencies removed
~ Focus handling issues resolved for cross-browsers
~ Timeout only invoked for non-first screen.  This keeps the refresh from
flooding the logs continuously for no purpose.
~ two halves of "validuser" conditional linked in TMPL
~ elsif's used for $op conditionals

The focus should now appear on the "Return to Account Summary" button during errors.
The user can scan anything (w/ carriage return) and get back to the first screen.
Also, special functionality is added for the magic barcode "__KOHA_NEW_CIRC__".
This effectively ends the patron session and logs them out so the next patron can begin.
The purpose is for patrons to avoid having to use a keyboard at all, if libraries
print and have this special barcode available for patrons at the SCO station.

Enhancement was requested by Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 14:01:02 -05:00
Galen Charlton
3cfa84362f bug 3219: handle variation in Amazon responses
An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:20 -05:00
Galen Charlton
224a0a1bac bug 3222: new module to handle messaging preferences form
Define and use a new module, C4::Form::MessagingPreferences,
to handle displaying and processing the messaging preferences
form.  This change reduces code duplication between OPAC
and staff.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:50 -05:00
Galen Charlton
ca7db466d6 bug 3222: changes to messaging preferences form
Moved the messaging preferences form to a new
include, messaging-preference-form.inc, so that
it can be used to set messaging prefs both for a
patron and for a patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 13:20:49 -05:00
Galen Charlton
391a6d3261 bug 2001, 2432: improve unAPI implementation
Improves Koha's unAPI support as follows:

* The implementation no longer depends on there being
  an accessible Zebra or SRW server.  Instead, responses
  are created by running the bib MARCXML through local
  stylesheets.
* unAPI now works for all bibs, not just ones that have
  an ISBN.  The ID format is changed from koha:isbn:ISBN
  to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
  http://validator.unapi.info/ .
* MODS3 support now works correctly.  As a consequence, this
  patch fixes bug 2432 (Zotero support when using the XSLT
  OPAC stylesheets).

TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-22 07:31:43 -05:00
Galen Charlton
3f49ad62c8 bug 3236: remove disused scripts and a function
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files.  According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.

Also removed C4::Search::findseealso(), which was used
only by the two scripts.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-20 08:37:58 -05:00
Galen Charlton
ace9aa7248 bug 1448: improve subject classification browser
* turn on warnings
* fix problem where the top level of the classification
  hiearchy wasn't displayed, instead pointing to
  the link to the Wiki page with instructions on
  how to set up the feature.
* fix XHTML validation errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 15:52:28 -05:00
Galen Charlton
fda2f9c039 quell warning if format parameter isn't passed to opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 15:52:26 -05:00
Galen Charlton
cf0b277f55 fix undefined variable warnings when using Syndetics
Also consolidate duplicate code to a new routine,
_fetch_syndetics_content()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 15:52:25 -05:00
Pianohacker
b04f432857 New framework for AJAX services
This adds two new C4 modules, C4::Service and ::Output::JSONStream, and
makes important modifications to C4::Output. The first two are a basic
framework for JSON-based AJAX services and a simple JSON output wrapper,
respectively. C4::Output has been slightly refactored, with a new
function, output_with_http_headers, that supports different
content-types. output_html_with_http_headers still exists, and the three
pages affected by this change have been refactored to support it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-14 07:29:18 -05:00
df7c176b8d Bug 2505 adding use warnings and fixing warnings in opac-basket.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-12 05:40:30 -05:00
af32d160a5 Whoops extra } crept in when fixing a merge conflict, removing it
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-12 05:21:25 -05:00
350e8e959f Fixing more warnings
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-12 05:21:21 -05:00
Nahuel ANGELINETTI
6b8992ef0f (bug #1578) Add the (quasi)full COinS(Zotero) support
this patch do a lot of things :
 * Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
   This will be usefull for OpenURL support.

 * Replace the span in opac-detail, and put the var get from GetCOinSBiblio
 * Fix an <img> tag that wasn't autoclosed
 * Add the COinS in search result
 * Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 19:05:32 -05:00
5ef1d6ff9e Bug 3213 - UNIMARC/MARC21 selection
Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.

DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:35:53 -05:00
Galen Charlton
1428ebed51 bug 3205: fix another error in the OAI-PMH Identify response
The optional description element of an Identify response
can't just be a string.  Identify.description is a container
for one or more elements; see http://www.openarchives.org/OAI/2.0/guidelines.htm

For now, simply commenting it out.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 11:59:03 -05:00
dfaa238186 Bugfix 3205 - Fix OAI server resonse to Identify request
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 11:23:34 -05:00
David Birmingham
d5d21fe101 Bug fix to OPAC shelf browsing query statement
If the items.location field was NULL, then the current
SQL query would produce no results.  I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.

In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open.  This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:18:27 -05:00
Chris Cormack
d32d5bfb9b Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:06:53 -05:00
Jane Wagner
f5be7dc8e4 Enhancements/fixes for OPAC advanced search screen
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:11:17 -05:00
Galen Charlton
53ace84401 Syndetics: add support for AVSUMMARY and AVPROFILE
Added support for the Syndetics AV summary and AV profile
data elements.  The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:19:19 -05:00
Michael Hafen
451ab9e77e OPAC Advanced Search - have user's branch selected by default
If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 08:08:12 -05:00
Chris Cormack
0501737f1c Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:02 -05:00
Chris Cormack
2677e75bb7 bug 2505 fixing warnings, I think we have them all for opac-search.pl now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:37 -05:00
199ec1473a Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services
This patch modifies how AWS is called. AWS is now called
depending on syspref. It works completly for OPAC; it
has to be refined for intranet.

For OPAC:

  * If OPACAmazonReviews is set, AWS EditorialReview and
    Reviews (users) are grabed.
  * If OPACAmazonSimilarItems is set, AWS Similarities info
    are grabed.
  * If nothing is asked, AWS is not called anymore,
    sparing server bandwidth.

For intranet:

  It works as it used to work. AWS is called if AmazonEnabled
  is set whatever how other syspref are set.

  TODO:

    * Add a AmazonReviews syspref
    * Request Amazon content depending on AmazonSimilarities
      and AmazonReviews syspref

DOCUMENTATION:

  It should be explained that Amazon services related syspref
  have two levels:

  * AmazonEnable / OPACAmazonEnable
  * Other: OPACAmazonReviews (new), OPACAmazonSimilarProduct,
    OPACAmazonCover

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:36:14 -05:00
Galen Charlton
c101ea2379 bug 2505: fix more warnings in opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:24:38 -05:00
fccf91832e Bug 2505 Adding use warnings, and fixing the warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 09:51:03 -05:00
Galen Charlton
1e6b61cdb1 changed OAI-PMH implementation
Replaced older OAI-PMH server implementation
with new one by Frédéric Demians.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 14:01:21 -05:00
Galen Charlton
0a306bc28c bug 2505 followup: restored correct item type image display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 10:04:32 -05:00
Andrew Moore
f447f8a91f Bug 2505: adding warnings to opac-detail.pl
Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:50:57 -05:00
29ab92d261 Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:54 -05:00
Christopher Hyde
b15a74c8d7 Changes Made to further optimize and condense code, include code documentation, and fix hardcoded instead of syspref'd library thing id
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:36:49 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00
Jane Wagner
a966c51f1a Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:39:25 -05:00
Galen Charlton
696fc0ff22 bug 3141: use quoted printable encoding in cart/list emails
Ensure that emails sent from lists and the cart in the
OPAC have the correct quoted-printable encoding.  Otherwise,
if there is an equals sign followed by one or two characters
that look like hexadecimal digits in body of the email, the
results can look mangled in some email clients.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:36:14 -05:00