Koha-community/Koha - Koha - Koha: The world's first free and open source library system

39536 Commits

35 Branches

595 Tags

2.3 GiB

Tree: 8da73fe428

Commit Graph

Author	SHA1	Message	Date
Owen Leonard	aa449de6aa	Bug 21237: Clean up staff client SCSS This patch removes a redundant linter configuration, .sass-lint.yml, which was added by mistake. Some linter rules have been modified to better conform to the defacto standard set by our existing CSS. staff-global.scss has been corrected to comply with linter rules (https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md): - Comment, style: silent - TrailingSemicolon, true - Shorthand - ColorKeyword, enabled: true - PropertySortOrder Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Owen Leonard	2df87a94f5	Bug 20427: Convert OPAC LESS to SCSS This patch converts the OPAC LESS files to SCSS. In the process of converting opac.less (and other .less files) to .scss, I have improved the completeness of the nesting, reordered properties, and in general done cleanup based on rules in .scss-lint.yml. All of these changes should have no impact on the style of the OPAC. This patch modifies the commands used to compile CSS so that OPAC and staff assets can be processed separately: 'yarn build' <-- Builds the staff client assets by default 'yarn build --view opac' <-- Builds OPAC assets To test, apply the patch and compile the CSS by running the command above (or apply the follow-up patch with compiled CSS). Do a thorough review of the OPAC, taking care to cover as many pages as possible and checking responsive behavior at the same time. There should be no visual differences in the OPAC before and after applying the patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago

Author

SHA1

Message

Date

Owen Leonard

aa449de6aa

Bug 21237: Clean up staff client SCSS

This patch removes a redundant linter configuration, .sass-lint.yml,
which was added by mistake.

Some linter rules have been modified to better conform to the defacto
standard set by our existing CSS.

staff-global.scss has been corrected to comply with linter rules
(https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md):

- Comment, style: silent
- TrailingSemicolon, true
- Shorthand
- ColorKeyword, enabled: true
- PropertySortOrder

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

6 years ago

Owen Leonard

2df87a94f5

Bug 20427: Convert OPAC LESS to SCSS

This patch converts the OPAC LESS files to SCSS. In the process of
converting opac.less (and other .less files) to .scss, I have improved
the completeness of the nesting, reordered properties, and in general
done cleanup based on rules in .scss-lint.yml. All of these changes
should have no impact on the style of the OPAC.

This patch modifies the commands used to compile CSS so that OPAC and
staff assets can be processed separately:

'yarn build' <-- Builds the staff client assets by default
'yarn build --view opac' <-- Builds OPAC assets

To test, apply the patch and compile the CSS by running the command
above (or apply the follow-up patch with compiled CSS).

Do a thorough review of the OPAC, taking care to cover as many pages as
possible and checking responsive behavior at the same time. There should
be no visual differences in the OPAC before and after applying the
patch.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

6 years ago

2 Commits (8da73fe4283198ac93e2f15695f44e0cea7c490f)