Commit graph

93 commits

Author SHA1 Message Date
5794bde204 Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 10:49:06 -05:00
Paul POULAIN
80c8b5c149 bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.

This manage multiple errors on barcode and displays them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 08:15:29 -05:00
Ryan Higgins
0c66ac6702 Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously  was reporting nothing since the js was broken).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-05 07:31:24 -05:00
Ryan Higgins
8393fb0a3a Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )
Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction.  This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time).  Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:49 -05:00
Ryan Higgins
db87e7d738 Update serials planning javascript to properly deal with 3-level periodicity. ( Serials patch 2/3 )
Minor changes to dom object names and id's to allow for proper calculation of the
base planning table from the simplified table.
Prior to this patch, the base table was populated with the incorrect value, so patterns like
Vol{X} No{Y} Issue{Z} incremented the Vol value incorrectly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:04:39 -05:00
Ryan Higgins
44d1aa5eb0 Serials planning updates patch 1/3
This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible.  A 'show advanced pattern' button will display/hide the
base prediction table at any time.  A 'reset pattern' button is added.  The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 07:59:06 -05:00
30efc33dba Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:01:47 -05:00
85832f8524 A couple more corrections that should have been in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:40 -05:00
d73b577fa6 Fix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription-add.pl") and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:37:38 -05:00
Ryan Higgins
5353d35b7a Correct misspelling of 'recieve'.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:22:26 -05:00
350b9dd3af Allowing people to search on all itemtypes when adding a serial subscription, workaround for the fact you cant limit by itemtype
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-14 20:02:13 -05:00
ac7c215be3 Markup corrections. You can't embed a <!-- TMPL_IF --> inside an HTML tag because it causes problems for the translation script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 14:05:53 -05:00
Joshua Ferraro
5f6af04ee1 nomenclature cleanup: s/Branch/Library/ s/Document Type/Item Type/ 2008-05-30 11:36:04 -05:00
5d980853b0 Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:24 -05:00
ca9d876d79 A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:09 -05:00
346d8d3679 Some fixes for bug Bug 2056, No Claim Letter Note Should Stand Out, and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:56:00 -05:00
Joshua Ferraro
d3675da9de Nomenclature cleanup for supplemental issues in serials 2008-04-22 20:06:37 -05:00
Joshua Ferraro
70c5aed218 Improving dialog for linking to a vendor, allow choice between
OK and Cancel for whether to link to a vendor rather than requiring
a vendor be added.
2008-04-22 19:53:14 -05:00
Joshua Ferraro
340dcb421e Nomenclature cleanup for subscription adding page 2008-04-22 19:43:34 -05:00
1c4e41939e Fix for Bug 2015 ("subscription-renew button is disabled"), other markup corrections; Removing unused popup css declaration from doc-head-close; removing unused popup include file.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:39:44 -05:00
Paul POULAIN
7ddb9c59d9 look change for 2 radio buttons
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:34:39 -05:00
paul
7be6d1f12b IMPROVEMENT : serialsadditems at subscription level (bump 071)
The patch update the DB by adding a row in the subscription table (serialsadditems), that is filled with the value of the syspref.
then, the syspref is deleted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:34:33 -05:00
Paul POULAIN
d5aa433155 /TMPL_ELSE is invalid, should be TMPL_ELSE
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-14 23:47:04 -05:00
Paul POULAIN
f5674f953a reintroducing the limit on itemtype when searching a biblio in subscription add
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:56 -05:00
Paul POULAIN
fa4cead909 reintroducing history manual modification feature
The history start date and enddate is also useful to modify manually for the same reason : your serial collection may be older than your Koha serial management.

This commit reintroduce the feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:52:52 -05:00
Galen Charlton
3675c7d987 typo fix: "recieve" => "receive"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:22 -05:00
bab8beb59a Updates to go along with jquery tabs plugin update
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-11 06:18:50 -05:00
Paul POULAIN
f5195492a5 (cosmetic) reducing subscription renew note textarea
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:27:37 -06:00
Ryan Higgins
dd3c971aaa Date format fix for serials irregularities.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 19:30:42 -06:00
Paul POULAIN
d92f4020dc replacing ' by " in javascript translatable strings
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:08:02 -06:00
Henri-Damien LAURENT
a91a38b61a Avoid double renew button when subscription is over
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-15 15:32:35 -06:00
Ryan Higgins
f98e567b57 Populate serialitems table, bugfix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 13:45:19 -06:00
Ryan Higgins
0e864e0bf1 nomenclature changes and hide advanced numbering by default
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-10 13:45:17 -06:00
Ryan Higgins
d7821250aa Some templating for serials.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:46 -06:00
Ryan Higgins
3de59aba27 Serials updates to link item record to serial table.
This commit makes db changes to subscription, serials tables:
  allow subscriptions larger than 127 issues
  link serial to item uniquely.
MARC Framework:
  Adding MARC tag 942$s (990$s unimarc) to map biblio.serial
Udate biblio.serial on new-subscription.
Use biblio.serial to check if Items.pm should return
  pubdate and enumeration text string from serials table with items.
Update opac-detail so serial items are sorted most recent first.
Adding link from items table to serial table.

Allows sorting of serials in details pages, and removes
enum data from itemnotes field.
Also fixes  visibility in serials item editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:45 -06:00
Ryan Higgins
ccadef4372 set of serials fixes to subscriptions
fix zeroes in enddate field and backwards public v nonpublic notes
do not allow modification of free-text subscription history
changing terms from supplier to vendor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:42 -06:00
Ryan Higgins
6e876ab7cb tmpl bugfix - remove '\' in js-generated numberpattern form
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-08 11:11:40 -06:00
185fb34c11 Fix for Bug 1726 (re-selecting another 'status' value should hide the 'add serials' table again).
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:29:17 -06:00
Joshua Ferraro
554bbe1bda s/Waited/Expected/ for serials statuses reformating rebuild_nozebra.pl indexes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-01 12:59:28 -06:00
Mason James
f2c731a27d removing un-needed "yui-toolbars.inc" include
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-31 16:25:44 -06:00
Russel Garlick
4ffa8ff753 Change to breadcrumb to point Serials home to correct page
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:18:13 -06:00
Paul POULAIN
6a924eb363 reintroducing lateissues-excel
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:09:37 -06:00
Paul POULAIN
24212a3023 1514 : no results give no feedback (serials checkexpiration)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:07:49 -06:00
Joshua Ferraro
8d726bf96c nomenclature improvements for translation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:18:25 -06:00
Joshua Ferraro
8d32567210 more nomenclature / translation cleanup
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 15:58:32 -06:00
Henri-Damien LAURENT
83da74788c Adding callnumbers to serials-home
Signed-off-by: Paul POULAIN <paul@koha-fr.org>
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-17 10:48:55 -06:00
Joshua Ferraro
4489186918 nomenclature change s/Branch/Library/ 2007-11-16 07:32:05 -06:00
Henri-Damien LAURENT
dcf5097837 Adding callnumbers to serials-home
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-16 07:27:32 -06:00
Mason James
6b3baae7f3 bug 1566, changed default behaviour of manual/unexpected serial, to not receive.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:50 -06:00
Mason James
3410452b02 small text formatting change, added spaces
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-13 12:46:49 -06:00