Commit graph

3805 commits

Author SHA1 Message Date
Ryan Higgins
59cd6cc346 Fix broken link and quick formatting of currency.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 14:52:12 -05:00
Ryan Higgins
3dc7ca5aff Bugfix bad template variable, causing no data to display on bookfund.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 14:45:22 -05:00
Andrew Moore
3aafdf768d Bug 2176 (5/5): adding staff interface to patron messaging preferences
I added another tab to the "patron" area of the staff interface to let staff
edit patron messaging preferences.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 13:04:55 -05:00
Andrew Moore
4d0e0fec72 Bug 2176 (4/5): adding RSS feed for patron overdue alerts
opac-mymessages.pl and opac-mymessages.tmpl generate an RSS feed of a patron's messages from the message_queue.

Some more methods in C4::Letters to let us pluck out the right entries in the queue.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 13:04:53 -05:00
Andrew Moore
401c84cc09 Bug 2176 (2/5): adding patron interface to update messaging preferences
This patch allows patrons to update their messaging preferences. This
includes methods in C4::Members to manage patron messaging preferences.

added cgi script to allow patron to edit their messaging preferences

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 13:04:50 -05:00
Chris Nighswonger
3cb7a9ac28 kohabug 2238 This patch allows patrons to add books to public open/free lists whether they are logged in or not.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 12:48:11 -05:00
Chris Nighswonger
813f4ae9d1 kohabug 1873 Fixes shelves.pl so that the date is displayed in the 'date added' column of the virtual shelf contents
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 12:48:01 -05:00
Chris Nighswonger
3d377cd7c1 kohabug 1875 Public lists/virtualshelves are displayed and viewable whether a patron is logged in or not.
NOTE: This patch introduces code which generates an anonymous session when a patron first browses to OPAC.
This anonymous session contains a minimal amount of information including the results of a query to discover
all public lists/shevles. When the user logs in, the anonymous session is cleared and a new session created
for that user.

kohabug 1875 - fix error when editing a patron record

C4::Auth::checkauth was not distinguishing between a
'userid' input from an OPAC or staff login form and
a 'userid' input from (e.g.,) the patron editor.
Consequently, adding or editing a patron record would
result in Koha trying to log in as the new patron.

To resolve this, added a hidden input to all login
forms, 'koha_login_context', to explicitly signal
when a login is occurring.  The value of this input
can be 'opac', 'intranet', or 'sco' - the value is
not used at present, but may be of use later.

C4::Auth - added debug flag to two warns

kohabug 1875 - create anonymous sessions only for OPAC

No need to create an anonymous session for the intranet.

set yuipath correct for login pages

When preparing the template parameters for a login form,
C4::Auth was overriding the value of yuipath set
by C4::Output::gettemplate(), thus causing 404 errors
if the 'yuipath' syspref was set to 'local'.

kohabug 1875 - avoid warns viewing lists anonymously

During an anonymous OPAC session, the $loggedinuser variable
is not set.  As the undefined value causes warns in
C4::VirtualShelves::Page::shelfpage, for the purpose of the
shelfpage call the loggedinuser is set to -1, which should
not correspond to any real borrower number.

This is admittedly a hack to avoid digging through all
of C4::VirtualShelves to deal with lists viewed anonymously.

kohabug 1875 Refactoring of &ModShelf to avoid overwriting list owner needlessly

kohabug 1875 Avoid warning if can't find owner of shelf

Since virtualshelves.owner is not a true FK of borrowersnumber.number,
set ownername to '' if can't find the patron

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 12:44:27 -05:00
Galen Charlton
7ac682c859 bug 2265: fix problem when cloning MARC field
Correctly set indicators when cloning a field
in the MARC editor.  Prior this fix, a cloned
field would not be saved.  Bug introduced in
patch for bug 2207.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 09:41:00 -05:00
Joshua Ferraro
71c7afd90d Darrel's patch to fix sorting by size of order 2008-06-20 09:14:17 -05:00
Galen Charlton
375f62bdb1 bug 2000 - remove admin/issuingrules.pl
Patch to remove issuingrules.pl in favor of
using smart-rules.pl to manage loan and fine
rules.  Several reasons for this:

* issuingrules.pl's matrix could grow rather large
  if the library has a large number of item types
  and patron categories
* successfully entering rules via issuingrules.pl
  requires placing commas within input fields
* a sparse circulation policy matrix takes the
  same amount of screen space as one that uses
  rules for a lot of specific patron category/item type
  combinations.
* having two administrative interfaces to the same
  policy settings could be confusing.
* UI design of smart-rules.pl better lends itself
  to adding more policy setting attributes to the
  rules matrix.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:10 -05:00
Galen Charlton
5a7905f440 bug 2000 - removed finesrules.pl
Removed the separate admin/finesrules.pl script
to set the fines policy matrix: since admin/finesrules.pl
and admin/issuingrules.pl both touch issuingrules.pl, creating
a specific fine rule could silently override a default issuing
rule and prevent items from being checked out.

Circulation policy matrix settings for fines are now
handled in admin/smart-rules.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:09 -05:00
Galen Charlton
376c130153 bug 2000: addition changes to rules editor
* Added ability to specify total loans allowed at a library
  for the default patron category.  If set, the default
  limit is applied if no rule for the specific library
  and patron category is set.
* Added ability to specify default total loans allowed
  for the default library; this is applied if no rule
  for the specify library is set.
* Form now indicates if the number of current checkouts
  allowed is unlimited.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:05 -05:00
Galen Charlton
c9a7dd5520 bug 2000 - add total loan limit to alt. issuing rules
The alternate issuing rules editor can now allow
defining the maximum number of loans that a borrower
of a given category can take out per branch, regardless
of item type.

The form for entering this limit now appears below
the form for setting loan rules per patron category
and item type.  The form only appears if a specific
branch is chosen, not if the default branch is used.

Also, some terminology changes:

* "Amount Loanable" => "Current Checkouts Allowed"
* "Amount" => "Fine Amount"
* "Grace Period" => "Fine Grace Period"
* "Charging Interval" => "Fine Charging Interval"
* "Loan time" => "Loan Period"

Documentation change: new screenshots for the alternate
loan rules form.

squashme terminology

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:04 -05:00
Galen Charlton
9f2c77a686 bug 2000 - fix order of issuingrule lookup
Extended help on the alternate circulation rules
form to list the order of issuingrules lookup as
follows:

same library, same patron type, same item type</li>
same library, same patron type, default item type</li>
same library, default patron type, same item type</li>
same library, default patron type, default item type</li>
default library, same patron type, same item type</li>
default library, same patron type, default item type</li>
default library, default patron type, same item type</li>
default library, default patron type, default item type</li>

This includes modifying two routines in C4::Circulation to
follow this order: GetLoanLength() and GetIssuingRule().

The reason for this change is to have Koha exhaust all issuingrules
possibilities for a branch before checking the rules for
the default branch - this is consistent with what an admin
might expect from looking at the issuingrules forms, which display
settings a branch at a time, and is more consistent with how
circulation rules should work for indepdendent branches.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:03 -05:00
Galen Charlton
3e9a94c546 bug 2000 - alternate issuing rules - set sorting of rules
Issuing rules are now explicitly sorted by patron category,
then item type.  The default patron category sorts last; within
a list of item types for a given patron category, the default
item type sorts last.  This follows the order in which
the issuing rules are applied.

Since the primary sort is patron category, also moved that
to be the first column in the issuing rules table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:03 -05:00
Galen Charlton
d6934ca397 bug 2000 - alternate issuing rules - some form cleanup
Improvements to smart-rules.pl to allow it to
replace issuingrules.pl.

* standardized "borrower type" to "patron category"
* made default item type and patron category ('Any')
  translatable
* regularized construction of parameters for rule
  deletion operatrion

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 08:19:00 -05:00
paul
5314a32914 adding string for translator
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 06:12:56 -05:00
paul
827203132c movin patron flags to template to have translatable strings
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 06:12:50 -05:00
paul
867788e8cf escaping field to deal with quotes in shelf name
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 06:12:49 -05:00
Galen Charlton
fff5631fc7 bug 2262 - fix delete guarantor button
Added an ID attribute so that the JavaScript
for the 'delete guarantor' button could
clear the guarantorid field.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-19 20:45:44 -05:00
22654a5977 Redesigning and bugfixing language-picker. Switching from fixed footer positioning to one with flows with page length. Fixing major unreported bug which prevented any but the first sublanguage menu from displaying.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-19 13:09:42 -05:00
Andrew Moore
6e52709824 Bug: 2259: eliminate lines too long for git to use.
This patch modifies 13 HTML templates and includes that have lines in them longer than 998 characters. Lines this long are known to break git.

I believe that none of these change behaviour at all, but I'm concerned about one of them. It adds whitespace (carraige returns) inside a <title> tag. I'm not certain that all browsers will deal with this OK.

No documentation changes necessary here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 19:25:52 -05:00
Joshua Ferraro
6c9b83fbdc Resolves bug 2250: RFC: New System Preference to Determine which 'Types' and associated icons to display in advanced Search
For documentation, please indicate that as part of profiling,
staff can refer to the AdvancedSearchTypes system preference to
choose where to draw the advanced search 'Types' from. Currently
this is implemented as a choice, between itemtypes and ccodes,
but it's been designed to work with any authorised value so long
as an index exists for searching by that authorised value.

By default, and if this syspref doesn't exist, it will pull from
itemtypes as before.
2008-06-18 13:01:20 -05:00
89d34a7c48 A better fix for Bug 2229, I think. Text inside basket.js can be translated fine, this instance simply lacked the call to the dummy function for gettext. It's important /not/ to have the "Cart" text in masthead.inc because there should be no Cart link for users with javascript turned off.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 11:41:47 -05:00
d900b2a63d Adding required jquery files for update Cart notification popup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 11:19:58 -05:00
be1ab41d2f Position of cart details popup needs to be specified numerically since jquery can't seem to accurately calculate the dimensions of the cart button.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:58:40 -05:00
4128725f69 Continuing work on Cart popup
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:58:40 -05:00
a0dfa0e5a6 Testing change to cart popup display system. Attempting to fix display flakiness associated with YUI method.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:58:39 -05:00
d8c60f6bdf Fix for Bug 2240, "opac-search.pl masthead does not include 'cart' and 'list' buttons, " and other minor markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:36:04 -05:00
9821a11537 Fix for Bug 2097, "Extra bar after subject headings in OPAC."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 10:36:01 -05:00
374a07a5d2 Adding missing menu item for Stop Words. Fixes Bug 1995, "Link Missing from Admin Menu."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:53:20 -05:00
64d65d838a Restructuring guarantor display to address Bug 2220 ("Guarantor needs two fields to be labeled"). This change probably means an updated screenshot is necessary.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:52:52 -05:00
39576cd44c Whitespace was causing table sorting problem. Fixes Bug 2215, "In page JavaScript sort not working for title on holds tab for my summary."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:52:22 -05:00
37e4866b5b Correction to allow pop-up window to scroll. fixes Bug 2209, "Editing records in the inventory."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 15:51:49 -05:00
ac7c215be3 Markup corrections. You can't embed a <!-- TMPL_IF --> inside an HTML tag because it causes problems for the translation script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 14:05:53 -05:00
904a148509 Markup correction. You can't embed a <!-- TMPL_IF --> inside an HTML tag because it causes problems for the translation script.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 14:05:50 -05:00
6c9eeabc71 Corrrecting layout for opacuserlogin = 0. Fixes Bug 2228, "Wrong page design on opac-main.pl when no login section."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:32:37 -05:00
5697bef959 Removing redundant column. Fixes Bug 2202, "No need for View Column on Authority Search"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:58 -05:00
6729244bb5 Terminology correction (fixes Bug 2200, "Mislabeled Column on Overdues Report")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:37 -05:00
691bcc631c Markup corrections to cataloging pages; Fixes for Bugs 2166 (" Book Jackets Not Showing on My Summary"), 2194 ("No results for Authority Search Shows blank record"), and 2196 ("Extra comma being added to record display")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:09 -05:00
Daniel Kahn Gillmor
04a8fb567d fix coins/openurl breakage when search terms include author names. (thanks, chris on #koha@irc.katipo.nz!)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 06:26:41 -05:00
7cf8284078 In OPAC, verticaly align on top biblio records and book cover image
Without this patch, on OPAC result page, depending whether book cover
image is available or not, biblio records and book cover are badly
verticaly aligned. The information is in the middle of the cell.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-16 11:31:51 -05:00
Ryan Higgins
6b6dd30170 Spelling correction in template.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-16 10:24:25 -05:00
Galen Charlton
ee49d6d372 kohabug 2207 - improve indicator input in MARC editor
Instead of having one input field for both indicators
of a variable field, the bib and authority MARC editor
now has an input field for each indicator.  This has
two main advantages:

* it is easier to tell what the indicator values are,
  even when the first indicator is a space
* it is easier to set the first indicator to blank
  and the second indicator to non-blank.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-12 11:17:35 -05:00
Ryan Higgins
0f2eb979cb Fix column misalignment in opac-reserve .
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 12:59:45 -05:00
6716f31333 Fixes bug #2229
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 08:25:35 -05:00
51fbaf8f5b Fixes bug #2231
In OPAC, when cart is sent by email, the email contains an attachement:
an ISO2709 file with cart biblio records. Most users don't have a clue
what to do with this file.

This patch modifies opac-sendbasket.tmpl to clarify what the attachment is.
It also fix a bug in opac-sendbasket.pl which wasn't reading the template
section containing information about the basket:

  Here is your cart, sent from the Koha Online Catalog... foo

It may be necessary to verify that template text is in 'valid' English...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 08:22:22 -05:00
Joe Atzberger
fc24df29d2 Bugfix: show (cleaned) comment back on detail page.
Also added minor debug feedback to review page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-10 08:22:19 -05:00
4013d37634 Add | separator between authors repetitions in OPAC detail page
Without this patch authors display on OPAC is weird.
You get for example:
  Author: Freud--Sigmund Lacan--Jacques
And you finish to read an author 'Simund Lacan'

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:47:13 -05:00
Joe Atzberger
0694499c94 Display only approved tags, change simple form to GET, supply "strata" for eventual cloud building.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:38:04 -05:00
Galen Charlton
d351753d4e kohabug 1993 - task scheduler improvements
[1] Removed hardcoded path to original developer's
    Koha configuration file; now checks KOHA_CONF.
[2] Now attempts to figure out if a task was successfully
    added to the task queue; if it wasn't, the failure
    is now reported in the  task scheduler page.
[3] When traveling to the task scheduler page from a
    saved report, the report in question is now
    selected by default.
[4] Removed the button to edit a queued task; this is
    not supported.

This patch is essentially a bandage; I've added a BUGS
section and some FIXMEs to the POD for C4::Scheduler
detailing some issues - a refactoring of the task
scheduler is in order at some point.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:38:03 -05:00
Chris Nighswonger
105b70e502 Correcting "Open" to read "Free" on shelves.pl in order to match pull-down selections
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-09 06:37:58 -05:00
Galen Charlton
f08401d7ad kohabug 2205 - fix 404 when traversing pagination link in OPAC authorities search
Currently, the heading sort order is a required parameter, but was
not supplied to the template or used in the search results.  As
a result of this patch, clicking a link to view another page
of the authority search results will now work.

Outstanding issue not addressed by this patch: when searching
authorities in both the staff interface and the OPAC, choosing
sort order "none" results in a crash.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:37 -05:00
Ryan Higgins
5dd5b0be33 Remove vestigial checkbox for label-batch creation on MARC import
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:35 -05:00
Ryan Higgins
d4dd393e20 Update issues_stats to use authorised_values instead of distinct(sortn); add col/row headers as Descriptions instead of codes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:34 -05:00
Ryan Higgins
0e31981100 Update issues_stats to show auth_vals as row & column headers
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:33 -05:00
Ryan Higgins
98bc024609 Add Collection code limit to issues_stats report.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:30 -05:00
Ryan Higgins
fc99bfcbb1 Update issues_stats: add shelving location limit, replace cgi::scrolling_list, update terminology.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:47:29 -05:00
Galen Charlton
68d89cf3e1 bugfix - HTML escape syspref explanation
This applies to the list of system preferences in
the syspref editor - the OPACUserCSS syspref had
angle brackets in its description.

Used template change to accomplish this.  Note that
syspref value is escaped by the script, note the template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:46:15 -05:00
Paul POULAIN
20c4430952 fix to display itemcallnumber on opac brief display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:46:14 -05:00
Joe Atzberger
1bb1d04f3f Convert to using loop_context_vars for rows instead of highlight/toggle/whatever.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:21 -05:00
Joe Atzberger
0855e8ef29 Show copy/volume info on STAFF detail page.
This change helps the staff side catch up w/ the OPAC display and be
more useful to librarians dealing with serials.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:43:17 -05:00
Joe Atzberger
797c1d5502 Bugfix is_approved() to handle the 3-state nature of approval.
That is, a term is either approved, or rejected, or neither.
Without an external dictionary, most terms will fall into the
latter category.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-05 22:41:40 -05:00
Paul POULAIN
40c67eef33 re fixing opac-suggestion < misplaced
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:21 -05:00
Paul POULAIN
11a61ee6df html fix (detected by translator)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:20 -05:00
Paul POULAIN
f3458d9577 fix to have the branch search on OPAC being really a branch search, not kw
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:15 -05:00
Paul POULAIN
6fc3c7cd9d display itemnote on check-out (added, was not here) & check-in (red-ed, was already here)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:04:14 -05:00
Ryan Higgins
938f053cbb Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:51 -05:00
Joe Atzberger
1d6078adea Correction to: Comment out confirmation popups (on successful events).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:46 -05:00
Joe Atzberger
47fa74d68f Comment out confirmation popups (on successful events).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:45 -05:00
Galen Charlton
1a41d12a96 kohabug 2078 - removed ersatz ESCAPE="html" added in prior patch
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:50 -05:00
Galen Charlton
765c645536 kohabug 2078 - fixed channel links in Atom and RSS
query_cgi already includes the "q=" bit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 05:59:48 -05:00
Galen Charlton
d177975239 kohabug 2078 - fix feed validation errors
Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:10 -05:00
Galen Charlton
5e5ce6b7f9 calculate OPACBaseURL instead of using syspref
Calculate OPACBaseURL from the
CGI environment variables instead of using the
system preference.  As a result of this patch,
it should be possible to change the hostname,
protocol, or port of the OPAC without having to
reset a system preference.

Also added a FIXME to opac/unapi - the URL of
the SRU/W server has no necessary relationship
to the URL of the OPAC.

Once this patch is confirmed, the syspref can
be removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:51:08 -05:00
Galen Charlton
28fb7a6c19 kohabug 2180 - improve display when fines block checkouts
If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:37 -05:00
Ryan Higgins
34b4e77507 Independent-branchify MARC export. Add option to remove all holdings except your own, and force that behavior for independent branches. Also add accession date limit to export.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:35 -05:00
Ryan Higgins
fc98d228c2 Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-02 00:50:33 -05:00
3cb28152bb Items from Bug 2167 ("URL handling in staff client inconsistent"): Removing display of URL from moredetail.pl. URLs are now displayed on detail.pl just as they are in the OPAC. Also removing display of biblio-level call number. Item level call number is displayed already.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:53 -05:00
Joe Atzberger
b7baaaa3ab Bugfix 1979 - display hold numbers. Note that hold priorities are still buggy.
But that is a separate bug from whether they display or not.
Also added basic error handling if biblionumber is not received, or
if biblionumber is bad, since that otherwise crashes the page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:50 -05:00
Joe Atzberger
b5c584993f Addresses Bug 2073, clarifying OpacCloud's limitations.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:48 -05:00
Joe Atzberger
ff604d4a8a Printers code paring, related to bug 2045. This does not resolve the bug,
but it converts the template to using loop_context_var, and removes unused
variables from the script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:46 -05:00
Joe Atzberger
4073b27c50 Wrap up Tags integration - add sysprefs for new installs.
Note that when the user is not logged in, the Tags input box/button will not display.
The user will see a message telling them to log in to add tags.  However, in order to
keep the results display clean, the message will display only once, utilizing the loop
context variable "__first__".  Useful stuff!

I also threw OPACShelfBrowser sysprefs.sql, but it still needs added to updatedatabase.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:12 -05:00
Galen Charlton
57fb7e45b7 kohabug 2186 - improve display of empty import batches
[1] Display the "No records have been staged" message only
    if no import batches exist.
[2] When displaying a batch that has no bibs in it, display
    a "There are no records in this batch to import".  Also,
    do not display the "import record into catalogue" button
    for an empty batch.
[3] Add CSS class "problem" to both messages.

Documentation changes: minor; only required if screenshots
exist of the manage staged MARC records page that has no
import batches on it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-31 21:59:03 -05:00
Paul POULAIN
7979f28cc0 add borrower note to check-in
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 12:00:16 -05:00
Paul POULAIN
df050c4c58 enhance the patron note on check-out (was not enough visible, now is red)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 12:00:07 -05:00
Paul POULAIN
39eb269d01 Displaying branchcode and notes fields in full serials issue table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:57:35 -05:00
Paul POULAIN
6600ea28bb change in button description to explain that we will import into catalogue
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:49:35 -05:00
Joshua Ferraro
5f6af04ee1 nomenclature cleanup: s/Branch/Library/ s/Document Type/Item Type/ 2008-05-30 11:36:04 -05:00
Henri-Damien LAURENT
60ef32ed87 Adding branchcode to opac-full-serial-issues
Suggestion : We may add some jquery ordering on those tables
Can we owen ?

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 11:23:55 -05:00
Joe Atzberger
a5f90c7d68 Repair Labels code to accomodate patroncards. Purged EXPR.
Major FIXME's still remain, like the use of GET instead of POST.
The code is also a bit too INCLUDE-happy to net good performance.
The entire mechanism of adding to a batch should probably be proper
AJAX instead of the GET-centric opener.location approach.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 10:01:08 -05:00
c4072c8fe9 Fixing some typos, including, I believe, Bug 2174 ("spelling error in web installer")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-30 10:01:07 -05:00
Galen Charlton
94d3d63f3a kohabug 2164 - display of guarantor relationship
When editing a child or professional patron, display
the drop-down of relationship types only if at least
one relationship type is defined by the borrowerRelationship
syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:06:44 -05:00
Joe Atzberger
a101cd2d82 Tags AJAX integration on OPAC details page, so it behaves like results.
Also, prevent duplicate tags (same user, biblio and term).  Strip
leading/trailing whitespace from term.  Block whitespace terms.
The CSS for details could be enhanced to emphasize tagstatus more.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:54 -05:00
Joe Atzberger
d6a92d6dc0 Make printslip and printpage buttons use popup.
This bug was reported by existing users.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:46 -05:00
Joe Atzberger
8ff0dc1a65 Correct typo "printslilp" to "printslip"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 07:04:44 -05:00
Joe Atzberger
70829660c2 Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients.  Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback.  Other popups are likely
to exhibit this same defective behavior.

Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:51:58 -05:00
Joe Atzberger
1ebc373d18 Unescape Comment, now that we trust Scrubber to block bad markup.
Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
	br b i em big small strong

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:30:51 -05:00
Joe Atzberger
7ca4d31e82 Tags AJAX and JSON for OPAC side.
Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples.  The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:25:17 -05:00
Joe Atzberger
0626e743ec Add error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:47 -05:00
Joe Atzberger
bbb3f00955 Initial commit for Tags back-end moderation. Requires AJAX functions from Output.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:44 -05:00
Paul POULAIN
895153cfd8 fixing the css property for tablesorter js
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:21 -05:00
Ryan Higgins
dc7a542deb Update Catalog Stats report: / Remove lccn/loc filter, which seems to conflate marc21 010 and 050. / Update labels to reflect 3.0 terminology.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:32 -05:00
Ryan Higgins
302da68ce5 Fill statistics table properly for renewals; and issue->checkout, return->checkin
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:30 -05:00
21255a2416 Translatable facets in librarian interface
Pushes modified facets display from OPAC to librarian interface.
Corrects also OPAC version which were omitting Titles facet.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:26:33 -05:00
1bf93a36db Facets (current) translatable via template
This patch allows to translate facets label with standart
templates / PO files. Facets are still hard coded in Koha.pm.
Template wait those hard coded facets: Topics, Places, Titles,
Autors and Libraries.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:26:31 -05:00
b853e6bd10 Adding bookfund search to aqbudget.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:30 -05:00
5d980853b0 Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:24 -05:00
dcd12da0e0 Fix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow proper tab highlighting when viewing patron log.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:23 -05:00
922e8fc061 Fix for Bug 2120, "
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:56 -05:00
eb09aac059 Authorities detail page was missing toolbar, breadcrumbs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:53 -05:00
795d9d5605 Markup error caused layout problems.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:52 -05:00
dec7a7115d Structural changes to staff client main page to better handle layout changes with addition/subtraction of news and intranetmainuserblock markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:47 -05:00
bcca5c9584 Terminology correction: cancelled -> withdrawn. Also adding dateformat variable to new holds queue script to allow correct table sorting with metric dates.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:46 -05:00
5675b8d5e4 Adding breadcrumbs to advanced search screen to get us a Home link.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:45 -05:00
97becad914 Adding table sorter to holds queue report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:42 -05:00
bcc56e6827 Tweak to OPAC search bar to help prevent wrapping.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:10 -05:00
db2f86c61f Minor change to improve layout at lower resolutions.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:48 -05:00
bfcdfb7f45 Interface improvements to Holds Queue report and changes to the script provided by jmf
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:44 -05:00
ff96846978 Fix for Bug 2147, "Search Results aligned top on staff side."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:43 -05:00
Galen Charlton
171f7ed912 various bugfixes for MARC21 Z39.50 targets
[1] Added MARC-8 as an encoding choice on the target
    administration page.
[2] Fixed TMPL coding errors.
[3] Set the correct encoding (as it happens, 'MARC-8')
    for all of the English sample Z39.50 targets.

Documentation note: due to this patch and the ones from
Frederic, screenshots of the page for editing a Z39.50
target should be redone.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:05 -05:00
709619013d Allowing delete-biblio menu item to trigger javascript warning. Style now mimicsa disabled menu item. Addresses Bug 2135, "Cannot Delete MARC Records."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:52:04 -05:00
Joshua Ferraro
2ee27fb1cc Final update to holds queue work: adds link to holds queue
from circulation dashboard, creates new sysprefs, assigns
the sysprefs to the proper tab in sysprefs (Circulation),
updatedatabase changes to do the previous, and fixing one
redundent limit in the query for build_holds_queue.pl

Note: still need to address item-level holds
2008-05-20 12:36:40 -05:00
Joe Atzberger
775c74f566 BUGFIX - pagination bar was not in template, so only the first 20 hits were
pagination bar was not in template, so only the first 20 hits were
 visible.  Probably it wasn't included because the script referenced a bogus base URL.
 Also debugified warn statement in script.  Note FIXME for bogus template reference.
 We probably don't need that template or the related selector lines for it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 16:00:39 -05:00
a53aa294f7 CSS fix for Internet Explorer display problem caused by previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:12 -05:00
4662f0f3f9 Template restructuring to allow option of styling OPAC with fixed-width layout. This commit doesn't change the default OPAC appearance.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:11 -05:00
1ba0a05af6 Adding padding to <p> to improve some readability issues; Correcting terminology in the cart (shelf -> list); Minor punctuation change in results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:10 -05:00
ca9d876d79 A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:09 -05:00
c58f6e0077 Trying again to fix tab issues in Internet Explorer.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:24:08 -05:00
Joshua Ferraro
9758c7fc47 Minor updates to XSL display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:12:29 -05:00
Joshua Ferraro
50eec07c80 Enhancement Jacket Covers in Shelf Browser should link to bib record, not to source of image
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-19 13:12:24 -05:00
Joshua Ferraro
7c871821e1 Don't display Acquisitions and Serials links if the user
doesn't have permission to view them
2008-05-19 13:01:04 -05:00
Koha Production
5bc5fcbbbb Fix links for web resources to display a 'Click here to access online' when no label is specified (XSLT only). Note that on the results screen, the links now show up in place of the Availability: section
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 22:41:25 -05:00
Koha Production
a60c83d55d Fixing Literary Form: display for Sound records
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 22:41:12 -05:00
hcpl test
95c897bf55 Removing bib-level Call Number from display -- can be added to XSL based on library preferences if desired
Signed-off-by: Koha Production <koha-pro@koha-01.hclibrary.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 22:41:01 -05:00
Joshua Ferraro
13bddb5818 Fixing Amazon.com Similar Items and Editions features
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 20:37:18 -05:00
Joshua Ferraro
738cdbad89 Adding wrapping container around OpacMainUserBlock syspref 2008-05-17 18:49:26 -05:00
a3d111ae97 Fix bug in /admin/z3950servers.pl
Third attempt to correct a bug affecting this page.
Combo lists wasn't reflecting DB content in modification.
To Joshua: You have to apply patch 2 first (patch 1 isn't required)
since I applied this quick fix without rolling back to original state!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 18:45:38 -05:00
987c4e94b1 Fix bug in /admin/z3950servers.pl
Improve previous patch which was badly coded as pointed out by
Henri-Damien. <TMPL_IF> clauses were included in HTML tags:
it fails translator tool.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 18:45:37 -05:00
d2595211c8 Fix a bug in /admin/z3950servers.pl page
On /admin/z3950servers.pl page, modifying a z3950 host wasn't working
properly. Selected values in Syntax and Encoding combo boxes were hard
coded rather than selected based on record values.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-17 18:45:33 -05:00
Henri-Damien LAURENT
89fa713124 Bug Fixing : ModMember and memberentrygen.tmpl
Problem with ModMember : parameters were not passed safely
memberentrygen.tmpl deleted guarantorid for a children if step2 or step3 used fore edition.
Changeing TMPL_IF EXPR into TMPL_IF Name

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:21:09 -05:00
1740f374ee Altering CSS to make holding table on opac MARC view more compact. Adding "new" link to opac suggestions screen for display when there are no suggestions (Bug 2110 Can't place suggestion from my suggestions tab in OPAC)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:18:27 -05:00
d1fdb97122 Fix for problem introduced by previous attempt to fix Internet Explorer issues. Previous fix caused drop-down menu to appear behind circ search form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-16 08:18:27 -05:00
Galen Charlton
c1ae207d54 kohabug 1621 - add subtitle to main results and details pages
Including the subtitle in search results and OPAC and staff
details templates.  The subtitle is expected to be in the
MARC subfield that is mapped to the (now nonexistant) column
bibliosubtitle.subtitle.

This is a fairly hackish patch that is meant to be minimally
disruptive while allowing subtitles to be displayed for those
not using the experimental XSLT bib display feature.  It
does *not* cover all cases where you have a MARC
record and want to display its subtitle.

UNIMARC notes: at the moment, none of the fr-FR UNIMARC
frameworks appear to be map any subfields to bibliosubtitle.subtitle.
This could be changed, but caveat programmer: the UNIMARC 200$e
is repeatable (meaning that get_koha_field_from_marc will put in ' | '
between multiple subtitles) and one may want to also include the
200$d (parallel title).  A GetMarcSubtitle routine may be in order
if absolutely necessary.

This points to a long-term need to make display of MARC (and later, hopefully,
non-MARC) bib records more flexible - the XSLT feature is one approach;
there may be others.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:34 -05:00
0c50bb12b3 Recent changes to YUI path preference require local OPAC copies of YUI library files.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:31 -05:00
45fab923ac Adding COinS markup to shelves and results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:29 -05:00
756cdc15ac Swapping tablesorter version. GZipped version may have been responsible for errors in Internet Explorer. Change to usermenu.inc is whitespace only, for proper display in IE.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:28 -05:00
Galen Charlton
f6af1bea59 fixed typo in MARC framework test: "Codek" => "Code"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:22:35 -05:00
Paul POULAIN
62ae9fa3ee bugfix : librarian name was libxxx, not lib.xxx
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:07:57 -05:00
Paul POULAIN
4613c8f701 (bugfix) focusing on barcode for returns
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:07:54 -05:00
9717926644 Hiding empty results table when there are no results (prevents js error from tablesorter). Now links back to search form. Also includes minor CSS tweak for IE/Opera general layout problems.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:34 -05:00
d3b72dc919 Adding check all/none controls to opac suggestions, following opac shelves interface.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:33 -05:00
157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
Henri-Damien LAURENT
ac1aec445c Bug fixing on overdues.tmpl : branchnames were not displayed
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:28 -05:00
Henri-Damien LAURENT
9fb4a72122 Bug Fixing 1782 patch
Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:42:25 -05:00
Ryan Higgins
977f4bd795 show correct effective checkin date in dropbox mode.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:29:11 -05:00
Paul POULAIN
bc11a3bce2 BUGFIX (bloquing) moredetail & item edition
this patch introduce the same behaviour as for additem.pl, ie : edit only own homebranch items, except for superlibrarians

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:24:48 -05:00
Galen Charlton
5cafd551be patron attributes - batch import
When ExtendedPatronAttributes is ON, the batch
patron import tool's behavior changes as follows:

[1] A new (required) column is added to the input CSV
    format.  This column should contain a list of
    attributes to set for the record, each value
    preceded by its type code.  For example, if
    the superlibrarian has defined two types,
    a unique identifier INSTID and a repeatable
    BASEBALL, this field could contain:

    "INSTID:12345,BASEBALL:Cubs"

    This field must be wrapped in quotes if multiple
    values are defined.  Since values can contain
    spaces, additional doubled-quotes may be required:

    "INSTID:12345,BASEBALL:Cubs,""BASEBALL:White Sox"""

    When replacing a patron record, any attributes specified
    in the input file replace all of the attribute values
    of any type that were previously assigned to the patron
    record.

[2] It is possible to specify a field other than the
    cardnumber to use for looking for matching patrons.
    Specifically, any attribute marked as a unique ID
    can be used.  The operator is asked to specify
    which ID type to use; if an input record has an
    attribute value of that type, and exactly one patron
    record in the database has that value, then the
    record will be overlaid or ignored according to the
    overlay setting.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:10 -05:00
Galen Charlton
944063b247 patron attributes - staff search and display
If ExtendedPatronAttributes is ON, patron attributes
can be displayed and edited by staff members.

The patron attributes are displayed and edited
in a new section (step 4) of the patron details page.  Each
attribute is identified by its type (including type code
and type description) and value (included value description
if the attribute is controlled by an authorised value category).

Note: if, for a repeatable attribute type, the staff member
enters multiple copies of that type with the same value, duplicates
are removed when the patron record is saved.  Also, if the type
is repeatable, a JavaScript link allows the staff member to
create new attributes of that type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:09 -05:00
Galen Charlton
477bbe4d15 template changes for OPAC display of patron attributes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:08 -05:00
Galen Charlton
e30c9d00dd new editor for patron attribute types
Added new script under the Administration menu
to create, update, and delete patron attribute types.

Some things to note:

- once an attribute is created, its code cannot be changed
- the repeatibility and unique_id settings of an
  attribute type cannot be changed after creation -
  this is to avoid having to deal with changing
  constraints if an attribute type is already in use
  by patron records
- an attribute type cannot be deleted if it is
  used by any patron records
- this administration page is always displayed regardless
  of the value of the ExtendedPatronAttributes syspref.  If
  the syspref is off, the page will prompt the superlibrarian
  to turn it on if desired.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 09:03:03 -05:00
fc03a2510c Finishing adding additional markup for increased flexibility in stylesheet customization. Patch also includes some markup corrections, but shouldn't result in any visual changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:50:23 -05:00
34da7fce23 Changes to enable more flexibility in template customization. Container divs allow for graphical deliniation of logical screen areas.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:50:12 -05:00
Andrew Moore
c006950355 Bug 2094: implementing ability to select particular lost status in the lost items report
This patch adds a drop-down to the lost items report to let the user select a
particular lost status to display. Only items with that particluar lost status
will be dispolayed.

The documentation for the lost items report on the staff client will need to be slightly adjusted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:48:45 -05:00
df0fccdcbf Tweaking display of "action" links in search results
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:20 -05:00
6b889334fb Fixing a couple of bugs, including Bug 2080, OPAC Lists : No way to remove biblios from list.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:15 -05:00
886fdce625 Fix for Bug 2086, Filter Button Misleading. This moves the filter form into the left-hand sidebar.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:11 -05:00
1942e430b2 Adding RSS icon to search results (Fix for Bug 2078, RSS Icon on OPAC)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:10 -05:00
460477ae1b Removing table sorting pending change to this page to allow paged display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:45:08 -05:00
Galen Charlton
4c8a9e14a8 guided reports: make it possible to delete saved reports
Fixed JavaScript error that prevented user from deleting
a saved SQL.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 06:43:36 -05:00
Henri-Damien LAURENT
d08d9e3fb7 Addressing bug 1782
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-11 05:49:27 -05:00
NCE
b369a84ec4 Fixing RSS <link>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-06 06:31:10 -05:00
Joshua Ferraro
09df0de35f Removing obsolete RSS <link> tags and the scripts 2008-05-06 06:24:50 -05:00
06a58cdcfd Tab fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:51 -05:00
Paul POULAIN
40e6ec2f08 synch'ing opac display with staff for scanIndexes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:49 -05:00
Henri-Damien LAURENT
366432e18f Bug fixing : loading page macles would not load existing values for macles
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:47 -05:00
Henri-Damien LAURENT
472787bf17 Debugging Macles
say you want to edit 6 fields 630:
Provided you have those in your catalogue frameworks, you just selet 6 values and it puts values into that.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:43 -05:00
Paul POULAIN
25b7f1b56d reserve at itemlevel was displayed only if item-level_itype
This patch just moves the checkbox out of the <tmpl_if item-level_itypes>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:38 -05:00
Paul POULAIN
182bd0f1b3 bugfix : html mistake
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:29 -05:00
Darrell Ulm
e840742685 Intranet callnumber search link simple fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:39:15 -05:00
Darrell Ulm
f125e16400 Link to Intranet Similar Items Fixed (simple), pointed to OPAC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:39:14 -05:00
c27139156b Some minor markup changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-01 18:59:21 -05:00
85777e4ea1 Adding more details to cart's verbose view. Adding auto-print to cart print view (Addresses Bug 2070)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-01 18:59:19 -05:00
Joshua Ferraro
f093a84974 Fixing bug 1629: RSS Feeds of Search Results in OPAC 2008-05-01 18:55:13 -05:00
Joshua Ferraro
9e97a44417 Changing label from Overlay? to Match? since overlay is no longer
the only operation
2008-04-30 22:04:27 -05:00
Galen Charlton
60983cfeee kohabug 2026 - HTML-escape comments
This is a partial, perhaps temporary fix.  "<", ">",
and "&" characters in patron comments (AKA reviews)
are converted to "&lt;", "&gt;", and "&amp;" to avoid
certain attacks, e.g., a user entering a <script> tag
in a comment.

A more permanent fix should scrub all (or perhaps just
unsafe) tags from submitted comments entirely.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 21:59:01 -05:00
Galen Charlton
438ed23337 staging import - enhance record overlay behavior
Enhanced the ability of catalogers to specify how
bib and item records should be added, replaced, or
ignored during a staging import.

When an import batch of bib records is staged and commit,
the user can now explicitly specify what should occur
when an incoming bib record has, or does not have, a match
with a record already in the database.  The options are:

if match found (overlay_action):
  create_new (just add the incoming record)
  replace (replace the matched record with the incoming one)
  use_template (option not implemented)
  ignore (do nothing with the incoming bib; however, the
          items attached to it may still be processed
           based on the item action)

if no match is found (nomatch_action):
  create_new (just add the incoming record)
  ignore (do nothing with the incoming bib; in this
          case, any items attached to it will be
          ignored since there will be nothing to
          attach them to)

The following options for handling items embedded in the
bib record are now available:

  always_add (add the items to the new or replaced bib)
  add_only_if_match (add the items only if the incoming bib
                     matches an existing bib)
  add_only_if_add (add the items only if the incoming bib
                   does *not* match an existing bib)
  ignore (ignore the items entirely)

With these changes, it is now possible to support the following use cases:

[1] A library joining an existing Koha database wishes to add their
    items to existing bib records if they match, but does not want
    to overlay the bib records themselves.
[2] A library wants to load a file of records, but only handle
    the new ones, not ones that are already in the database.
[3] A library wants to load a file of records, but only
    handle the ones that match existing records (e.g., if
    the records are coming back from an authority control vendor).

Documentation changes:

* See description above; also, screenshots of the 'stage MARC records
for import' and 'manage staged MARC records' should be updated.

Test cases:

* Added test cases to exercise staging and committing import batches.

UI changes:

* The pages for staging and managing import batches now have
  controls for setting the overlay action, action if no match,
  and item action separately.
* in the manage import batch tool, user is notified when they
  change overlay action, no-match action, and item action
* HTML for manage import batch tool now uses fieldsets

Database changes (DB rev 076):

* added import_batches.item_action
* added import_batches.nomatch_action
* added 'ignore' as a valid value for import_batches.overlay_action
* added 'ignored' as a valid value for import_records.status
* added 'status' as a valid value for import_items.status

API changes:

* new accessor routines for C4::ImportBatch

    GetImportBatchNoMatchAction
    SetImportBatchNoMatchAction
    GetImportBatchItemAction
    SetImportBatchItemAction

* new internal functions for C4::ImportBatch to
  determine how a given bib and item are to be
  processed, based on overlay_action, nomatch_action,
  and item_action:

    _get_commit_action
    _get_revert_action

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 21:58:46 -05:00
Joshua Ferraro
d83a055504 Adding authorised value icons display in the search results
pages.
2008-04-30 21:07:29 -05:00
Andrew Moore
57b3b951c1 Bug 2047: adding images to arbitrary authorized values
I've refactored the subs I added in the previous commit so that they make a little
more sense and are in better places in the code base. I was really hoping to make use
of existing subs, but they all seemed so specific to particular uses.

The icons now show up on the OPAC item details page.

TODO: The icons still don't show up in the OPAC search results page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:43 -05:00
Andrew Moore
5b5596a69d bug 2047: adding icons to authorized values
This patch adds the ability to associate icon images with authorized values.
They're not displayed anywhere yet, though. There's also a database update
in here. I took version "3.00.00.075", but I can change that later if it gets
taken before I commit these patches.

DOCUMENTATION CHANGES: When you add or edit authorized values, you can now
associate image icons with them. These icons come from the same icon sets
that you can have with your itemtypes, such as media type. They don't show
up anywhere yet, but that's coming. Keep an eye on
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2047
for more updates.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:31 -05:00
Andrew Moore
aef807a937 bug 2047: refactoring icon manipulation logic
I'm extracting some of the icon manipulation logic so that I can get to it from the authorized values pages.

There should be no functionality or documentation changes with this commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 20:10:09 -05:00
ecd05d3da1 Re-structuring shelf browser markup for improved robustness; Including GoogleJackets js only if pref is turned on.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:10:06 -05:00
0b399239e2 Fixes for Bug 2067 (terminology consistency)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:26 -05:00
5e8671477f Making label toolbars more consistent
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:24 -05:00
Joe Atzberger
e5cd4004b5 BUGFIX labels - Adding labels was failing because of faulty "type" selection.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:05 -05:00
a7b8359a45 Fixes for interface bugs 2064, 2065, 2066
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:09:03 -05:00
e1e50db557 Add a new Debian package and GoogleJacket on OPAC detail page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:08:46 -05:00
Marc Chantreux
ca7dec79f5 fixed langauge typo
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:08:39 -05:00
Marc Chantreux
9daa5ffe84 fixed langauge typo
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 06:06:40 -05:00
a126170a27 Minor change to improve compatibility with IE7
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-28 05:56:02 -05:00