Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	08c03af2ae	Bug 18984: Remove NORMARC support Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Jonathan Druart	f1f9c6dc74	Bug 26384: Fix executable flags .pm must not have -x .t must have -x .pl must have -x Test plan: Apply only the first patch, run the tests and confirm that the failures make sense Apply this patch and confirm that the test now returns green Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	ed066caf58	Bug 26015: Terminology: Fix tons more staff clients to staff interfaces This takes care of more occurences of staff client and changes it to staff interface, including in code comments. To test: - I think in this case careful code review is what we look for. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	7d8b96803f	Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Olli-Antti Kivilahti	163404d9c7	Bug 19483: Fix test plan in t/db_dependent/www/* t/db_dependent/www/* crashes test harness due to misconfigured test plan prove t/db_dependent/www/ without defining KOHA_INTRANET_URL bails out and marks the whole test suite as failed. Test suite should not be failed if this optional WWW::Mechanize test suite is not activated. After this patch, the tests are properly skipped without failing the whole tests. This is important when running all tests under t, as this needlessly fails the test suite. Also handling of 'skip_all' is inconsistent in t/db_dependent/www -tests, so this normalizes it to skip_all instead of bail_out Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	b1ba7fac2c	Bug 18292: Remove return 1 statements in tests The test files do not need to return 1 Patch generated with: perl -p -i -e "s/^1;\n//xsm" t/*/.t Test plan: git grep '^1;$' t/*/.t should not return any results NOTE: does not fix C4/SIP/t, nor xt tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Mark Tompsett	da10c3169b	Bug 18807: t/db_dependent/www/batch.t fails get() does not take two parameters. fixed. prove and run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	768c5758a2	Bug 18807: Fix tests www/batch.t Several things are wrong here: 1. It assumes that import_record_id is the biblionumber => Wrong, it is only true when the DB is empty and that the 2 AI equal 1 2. The encoding in the template is 'UTF-8', not 'utf8', it leaded to "stage-marc-import.pl: marc21record.mrc: Unexpected charset UTF-8, expecting utf8" 3. We did not test that the biblio was correctly imported Test plan: Make sure the tests now pass. For the www tests you need to set the following env vars: KOHA_USER, KOHA_PASS, KOHA_INTRANET_URL and KOHA_OPAC_URL Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Marcel de Rooy	3c67f1d9a5	Bug 16423: [QA Follow-up] Remove $opac It is not used. And even may raise an uninitialized warnings. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Test still passes :) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Tomás Cohen Arazi	05bab15841	Bug 16423: (followup) Add more tests On fixing this tests, we retrieved the JSON data for the datatable used on the 'Manage staged records' page. It would be cool to check the data it carries makes sense. To test: - Run t/db_dependent/www/batch.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All test pass prove t/db_dependent/www/batch.t t/db_dependent/www/batch.t .. ok All tests successful. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Tomás Cohen Arazi	635961dcdb	Bug 16423: Fix t/db_dependent/www/batch.t so it matches new layout This patch adjusts batch.t so it matches the use of datatables on the 'Manage staged records' page, and small layout changes already fixed on search_utf8.t. The tests are slightly modified so they actually test interesting stuff. Some were passing only because an undefined value was passed. To test: - On master, run $ prove t/db_dependent/www/batch.t => FAIL: Tests fail notably - Apply the patch - Run: $ prove t/db_dependent/www/batch.t => SUCCESS: Notice tests now pass. - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jared Camins-Esakov	bc2ab3b588	Bug 8300: Add mechanized unit test for batch import This new unit test confirms that importing records via the Stage MARC import tool still works by connecting to a Koha instance and importing a record then reverting the import, checking at each step of the way that everything is as it should be. To test: 1. Install Test::WWW::Mechanize > sudo apt-get install libtest-www-mechanize-perl 2. Set environment variables to reflect your Koha instance: > export KOHA_USER=kohaadmin > export KOHA_PASS=katikoan > export KOHA_INTRANET_URL=http://localhost:8080 > export KOHA_OPAC_URL=http://localhost 3. Run the test: > prove t/db_dependent/www/batch.t This updated patch now handles both MARC21 and UNIMARC installations. Signed-off-by: Magnus Enger <magnus@enger.priv.no> All tests pass with marcflavour = MARC21 and NORMARC. Test #15 fails when marcflavour = UNIMARC, but from what I can see, that is because I'm testing on a MARC21 setup, missing the UNIMARC frameworks etc. I'm signing off - QA folks, please ask for a proper UNIMARC signoff if you feel it is needed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Load the POSIX module (for the floor routine). Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago

12 Commits (9032c41575597ef7870f0af7a7afd1f40f4e2bfb)