Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	0b7bd6ee28	Bug 26562: Removes 'searches' from localStorage on logout A user recently logged in will inherit the "searches" item stored in localStorage. To recreate: Log in with user A, do some searches Note that the "searches" item is filled in with the search queries Logout and log in with user B Note that the "searches" item is still there Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	7fb705696f	Bug 24958: Remember last selected tab in SQL reports This patch modifies the saved reports page so that it remembers, for the duration of the browser session, the last active tab. To test you should have multiple reports in multiple report groups. Apply the patch and go to Reports -> Saved reports. - Select a tab to filter the table of saved reports to a particular report group. - Navigate away from the page - Return to the save reports page. The tab you previously selected should be selected again. - Restart your browser and return to the saved reports page. The tab should no longer be preselected. Update: The tabs filtering JavaScript has been moved to a separate function so that the function can be triggered by both the "create" event (when the tabs are initialized) and the "activate" event (when a tab is selected). Update II: Persistence is now enable through localStorage instead of Cookies. The localStorage item is now cleared during the logOut function. Update III: The logOut() function in staff-global.js is now called by auth.tt to ensure that tabs are not remembered across sessions. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Nick Clemens	5d5a49a7ef	Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	a512ae01fc	Bug 24625: Store showLastPatron information using localStorage This patch removes the use of jquery.cookie to store "last patron" information, using localStorage instead. jquery.cookie.js is obsolete. See Bug 24624. localStorage has been chosen as an alternative in this situation because it does not require transmission between the client and the server. See Bug 12410. Because there is no "session only" option with localStorage, additional handling of the showLastPatron data is added to the login page. That takes care of "stale" last patron information if user didn't log out but the session expired for some reason. To test apply the patch and enable the showLastPatron system preference. 1. Load a patron's account for checkout 2. Navigate away from patron-related pages: Perform a catalog search from the search header form and open the detail page from the search results. Confirm that the correct last patron information still shows. 3. Load another patron's account for checkout - There should now be a "Last patron" link in the breadcrumbs bar which links to the patron in step 1. Hovering your mouse over the link should display a tooltip containing the patron's name and card number. - Click the "X" to clear the last patron information. The last patron link should go away. 4. Log out and log back in. The last patron information should be gone. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	814a7ecf47	Bug 25363: Merge common.js with staff-global.js This patch merges the contents of common.js with staff-global.js. Both are included globally in the staff interface, and there doesn't seem to be any reason to require that the user downloads two different JavaScript files. To test, apply the patch and perform a catalog search in the staff client. View the detail page for a title in the search results. On the detail page you should see navigation controls in the sidebar for browsing through search results. Confirm they work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Tomás Cohen Arazi	8771232293	Bug 25279: (QA follow-up) Use .escapeHtml Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Martin Renvoize	0ae7c6a343	Bug 21245: Move 'Last patron' button into 'breadcrumb' bar This patch moved the 'Last patron' button introduced in bug 20312 inline with the breadcrumb bar from floating above it. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Owen Leonard	bb3a0e5dbc	Bug 22768: Global search form keyboard navigation broken Bug 22045 made changes to the global staff client JavaScript which broken keyboard navigation for the most common forms in the resident search form("Check out, Check in, Renew, Search). This patch reimplements the tab selection code on the basic MARC editor page so that the keyboard shortcut behavior can be restored. To test, apply the patch go to Cataloging. - Search for an existing record and edit it in the basic MARC editor. - Test that the numbered tabs (0-9) at the top work correctly. - Select a tab other than 0 and choose Save -> Save and continue editing. When the page reloads you should be returned to the tab you were on when you saved. - Go to the Circulation home page. Test the keyboard shortcuts for switching tabs in header area: - Alt-u (Check out) - Alt-r (Check in) - Alt-w (Renew) - Alt-q (Search) Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Owen Leonard	2aa868bad2	Bug 15911: (follow-up) Allow enter to submit using the submit button This patch modifies the checkEnter function so that it is possible to submit a form by tabbing to the submit button and hitting ENTER to submit. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Owen Leonard	4d3144310c	Bug 22045: (follow-up) Fix tab-switching when some tab numbers are missing This patch changes the way tab-switching is done so that it switching tabs based on tab id rather than tab index. Using tab index doesn't work when the tab number doesn't match the tab index. To test, apply the patch and load a record or blank editor using a MARC framework which doesn't include one or more tabs (for instance, by deleting the entries in the framework for one tab: DELETE FROM marc_subfield_structure WHERE frameworkcode = 'KT' AND tab = 4; ...backup first). In the MARC editor the numbered tabs should exclude that number. Tab-switching should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Owen Leonard	4b82ed3549	Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Pierre-Luc Lapointe	587e12100f	Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 4- Go to another page 4- Verify that the link "Last patron" appears on the top-right corner of the screen 5- Click on the link 6- Verify that you are at the patron's checkout page 7- Click on the "X" button next to the "Last patron" link 8- The link should be gone 9- Go to another page 10- The link shouldn't appear (until the next patron detail's page) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Owen Leonard	8671ea1195	Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	ac07a5074f	Bug 19817: Open the manual in a new window, not a popup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	8ee92112e4	Bug 13618: Add the escapeHtml JS prototype to String Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Owen Leonard	0254b4e87d	Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on This patch reorganizes the way sidebar menus get highlighted based on the current page. A global function is added to handle most cases. Individual menu-handling scripts have been modified to handle only the edge cases which aren't covered by the global one. A new class is added to the global CSS file so that highlighted menu links can be custom-styled. To test, apply the patch and clear your cache if necessary. View various pages to confirm that current-page-highlighting in the sidebar menu is working correctly and that there are no JS errors in the browser console. For example: - Administration -> Currencies and exchange rates. - Acquisitions -> Invoices - Tools -> Patron lists - Tools -> Export And with CircSidebar turned on test various circulation pages, e.g. - Circulation -> Set library Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Alex Buckley	971591d4ee	Bug 19029: Add JavaScript security question for cloning circ rules This patch introduces a Javascript security question which is displayed to the user when they try to clone a circulation rule to a specific branch when the rule is a 'Standard rule for all libraries" The rationale for this patch is when the cloning takes place it overwrites the existing rules of the destination branch and there is no notification of this to the user. Therefore by implementing this patch the user is asked if they want to clone the rule (if the rule is standard accross all libraries) and are told that it will overwrite the rules in the destination branch. Test plan: 1. Create a circulation rule for all libraries 2. Make sure the 'select a library' option is set to 'Standard rules for all libraries" 3. Click the 'Clone' button and notice that the cloning takes place without any warning that it will overwrite the rules of the destination branch 4. Apply patch 5. Return to the circulation and fine rules page 6. Repeat step 2 7. Click the clone button and notice a alert box appears asking if you are sure you want to clone the standard rule to the destination branch. Note: The name of the destination branch is included in the alert. Also note that the user is informed of the consequences of performing the action, i.e. that it will overwrite the existing rules in the destination branch 8. Click 'Cancel' and notice that no cloning occurs 9. Click the clone button again and this time click 'OK' and notice that the cloning takes place 10. Return to the Circulation and fine rules page and set the 'Select a library' option to the name of an individual branch 11. Click the clone button and notice that the clone action takes place Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Tim McMahon	fc676f4130	Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Owen Leonard	0c476f1508	Bug 16557 - Remove the use of "onclick" from several include files This patch modifies several include files, removing "onclick" attributes in favor of defining events in JavaScript. A reusable "toggle" function has been added to the global JS file so that clicking elements with the class "toggle_element" will toggle the display of elements as defined in the click target's "data-element" attribute. Also changed: In subtypes_unimarc.inc some capitalization errors have been fixed and label/id pairs corrected. To test, apply the patch and clear your browser cache if necessary. - On the Acquisitions home page, click the "Orders search" header search tab. Clicking the [+] link should expand and collapse the additional search fields. - On the checkout or patron detail page, view the "Restrictions" tab. Click to add a restriction and use the datepicker to select a date. Clicking the "Clear date" link should clear the date. - Trigger the help window on any page. Clicking the "close window" button should work correctly. - Go to Administration -> Patron categories -> Edit. Checking and unchecking messaging preference options should work correctly. The "do not notify" checkbox should clear other checkboxes in that row and vice versa. - In Serials, from a subscription detail page, clicking the "Renew" button should trigger the renew popup. - Go to Acquisitions -> Vendor -> Add to basket -> From a subscription. Clicking the "Advanced search" link in the left hand sidebar should toggle the sidebar search form. - In a UNIMARC system, view the advanced search page. Clicking the "Show coded information filters" link should show additional search fields. (I tested in my MARC21 system by temporarily moving line 174 of advsearch.tt to line 172). Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Owen Leonard	6524e6d957	Bug 16549 - Remove the use of "onclick" from header search forms This patch removes the use of "onclick" from all header search forms for the purpose of triggering the "keep_text" function. This behavior is now handled in the globally-included JS file. To test, apply the patch and clear your cache if necessary. - Enter text in any header search form field. Click to each other tab in the header and confirm that your text is copied to each. - Test the behavior of the header search form on at least one page where each is included: - The staff client home page - The advanced search page - The authorities home page - The administration home page - The cataloging home page - The checkin page - The circulation home page - The patrons home page - Acquisitions -> Vendor -> Contracts - Administration -> Cities - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Printers (why is this page still around?) - Administration -> System preferences - Administration -> Z39.50/SRU servers - Tools -> Notices & slips This patch modifies does not fix the existing (unreported) bug which prevents the keep text function from working in the include file used on these pages: - Acquisitions -> Vendor -> Basket -> New order from suggestion - Administration -> Budgets - The serials home page Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Owen Leonard	5e1bcc4aa7	Bug 16242 - Move staff client JavaScript out of language directory This patch moves the JavaScript files in prog/en/js to prog/js. JavaScript files do not need to be in the directory which is processed by the translator. To test, apply the patch and visit various pages in the staff client to confirm that JavaScript files are still loading correctly. Revised: I intended for this to be built on top of Bug 15883 as well as Bug 16242. Now it is. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 15883 and 16241 All seems to work, js files pulled from new dir. No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Jonathan Druart	70eedf2217	Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Owen Leonard	3d2646938c	Bug 15910 - Move header search keep text JavaScript into staff-global.js Bug 14189 added some global JavaScript to a new include file which is included in doc-head-close.inc. Since it's included globally, there is no reason not to move it to staff-global.js. This patch does so. To test, apply the patch and clear your browser cache if necessary. - Navigate to any page in the staff client which has multiple header search tabs. - Type something in one of the tabs. - Switch tabs. Verify that your text was copied to the newly-displayed form field. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Owen Leonard	9a7c6f695c	Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No errors with JSHint CLI (6 errors fixed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Aleisha	e93ffac3f1	Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com	8 years ago
Kyle Hall	f73fdc9ebb	Bug 11431: (QA followup) Fix js error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	9 years ago
Kyle Hall	b8dd899738	Bug 11431: (QA followup) Allow https in sound URLs Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	9 years ago
Kyle Hall	220ff161e9	Bug 11431: Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>	10 years ago
Lari Taskula	d8c0b836d6	Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try" The issue is that CircAutocompl loads a script element under #header_search element. When this element is missing, it also messes up the indexing, because we were calculating the indexing of the found element by subtracting one from the found element's index (to eliminate the <script> element). Thats why the shortcut key problem in this bug takes you one too to the left, because we are still subtracting one from the index even though there is no <script> element anymore. This patches selects only the div elements and gets the index from them. No subtractions needed. To test keys: 1. Set CircAutocompl system preference to Don't try. 2. Try the shortcut keys. They will work incorrectly like this: Alt+U = Search catalogue Alt+R = Check out Alt+Q = Check in 3. Set CircAutocompl system preference to Try. 4. Try the shortcut keys. They will work correctly like this: Alt+U = Check out Alt+R = Check in ALt+Q = Search catalogue 5. Apply patch 6. Repeat step 1 and 4. 7. Repeat step 3 and 4. 8. Observe that regardless of CircAutocompl, shortcut keys worked correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	04f5e7d4e7	Bug 12320: Remove deprecated construct to delete cookie holdfor $.cookie('foo', null); is deprecated and should be replaced with $.removeCookie('foo'); This patch replaces the occurrences for the "holdfor" cookie. Test plan: 1/ Search for a patron 2/ On the patron detail page, click on "search to hold" 3/ Search for records 4/ On the results page, click on "Place hold" > "Forget PATRON" 5/ Reload the page. 6/ The "Place hold" button should not contain the patron anymore Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Owen Leonard	f9e3891050	Bug 13089 - Tab key triggers JavaScript error in the checkEnter function Tabbing through fields in the patron add form or MARC editor triggers a JavaScript error for each tab. The cause seems to be some JS which was designed to accommodate differences between Mozilla browsers and Internet Explorer. A slight modification seems to work just as well in Firefox and IE. To test, apply the patch and clear your browser cache if necessary. To look for JavaScript errors, open the Developer Tools console in Firefox, Chrome, or Internet Explorer (or in Firefox's Firebug console). Create a new patron and use the tab key to move between inputs. No error should be reported in the console. Test typing in fields and pressing enter. The form should not be submitted. Test in all available browsers, including at least IE11, IE10, and IE9. Reproduced with FF 32 Tested with FF 32, Chrome 38, IE 11 and IE Emulations 8,9,10 No JavaScript errors found. Enter does not submit. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested in Chromium, confirmed the problem and that the patch fixes it. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
David Cook	7f8c59edaa	Bug 12708 - Unexpected behaviour in IE 9 and lower when using openWindow This patch removes the whitespace from arguments to the "name" parameter in "window.open". It also adds a trap for the "openWindow" helper function, which will use a "null" instead of a "name" if window.open isn't able to handle a name with whitespace (i.e. if it's IE <= 9). _TEST PLAN_ 1) Switch to an emulated or authentic Internet Explorer version E 9 or lower 2) Click "Help" 3) Note that it opens the page in the current window rather than as a popup 4) Apply the patch 5) Shift refresh your page 6) Click "Help" 7) Note that it now opens (correctly) as a pop-up (If you want to be more thorough, you can test in other browsers as well to make sure that it still works.) Tested with IE 10 developer tools: IE7, IE 8, IE 9 Window pops up as expected. No regression found with IE 10 / FF31.0 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested for regressions in Firefox and Chromium. I checked the help and the duplicate authorities windows still work correctly. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Pasi Kallinen	9e9088049c	Bug 12138 - Use placeholders in translatable Javascript strings Currently translating Javascript strings with variables in them is hard, because the strings are created from separate parts. For example: _("Are you sure you want to delete the") + " " + count + " " + _("attached items?") This is translated in two different parts, and the translator cannot affect the place where the count-variable is. Now, if the javascript strings allowed placeholders, similar to how the template strings do, the above could be written as: _("Are you sure you want to delete the %s attached items?").format(count) This would make translation much easier. Attached patch adds a Javascript string formatter, and changes all the concatenated translatable JS strings used in intranet to use that. To test: 1) cd misc/translator 2) perl translate update xx-YY 3) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po \| sort \| uniq > xx-YY-pre 4) apply patch 5) perl translate update xx-YY 6) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po \| sort \| uniq > xx-YY-post 7) compare the files: diff -Nurd xx-YY-pre xx-yy-post \| less should show the javascript strings that changed. 8) Test the UIs where the formatted js strings are used. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested most of the changed files. There were some instances where it wasn't clear to me how to trigger the warnings which were modified, especially tags/review.tt, admin/manage-marc-import.tt, and holidays.tt. Everything I was able to test worked correctly. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no regressions found. Thx! Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	dcca71f0be	Bug 12075: fix keyboard shortcuts broken by jQueryUI upgrade The recent jQueryUI upgrade broke keyboard shortcuts in the staff client because of changes to the jQueryUI API. This patch fixes the problem. To test, apply the patch and clear your browser cache if necessary. - View any page in the staff which includes header search tabs for check out, check in, or catalog search (staff client home page or circulation page for instance). - Test the keyboard shortcuts: Alt-q for catalog search, Alt-u for check out, Alt-r for check in. - Each keyboard shortcut should select the correct tab. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Confirmed that the shortcuts were broken before the patch and now work again after applying it. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Galen Charlton	c16cadf216	Bug 11563: (follow-up) remove some tabs Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Kyle Hall	1226f901ce	Bug 11563: (follow-up) change .live() to .on() The jquery event handler .live() has been deprecated. It is recommended that .on() be used instead. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Fridolin Somers	e5ab220374	Bug 11563: restore preventing the enter key from submitting several forms Several forms that take patron or item barcodes as input stopped preventing the enter key (which is often sent by barcode scanners) from submitting the form. The code binding the CSS class noEnterSubmit to the handler preventing submission when hitting the enter key was no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event handlers for HTML generated with JavaScript. Also sets noEnterSubmit to use the checkEnter(e) function, as that has broader browser compatibility. Also corrects a small bug, for IE, window.event must be used, not event alone. Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tested in Firefox and Chromium. Passes tests and QA script. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	aa722ab694	Bug 11570 - Upgrade jQueryUI to latest version in the staff client This patch upgrades the version of jQueryUI included in the Koha staff client from v1.8.23 to v.1.10.4. The upgrade introduces a few minor API changes which require the updates in this patch: - In CSS, the term "active" is used instead of "selected" - Autocomplete functions use slightly changed parameters Changes to the default jQueryUI CSS allows us to remove some instances of "!important" from jQueryUI-related CSS in the staff client's main CSS file. To test: Testing changes to autocomplete: - Enable the CircAutocompl system preference. Try searching in the header's "Check out" tab. Autocomplete should look correct and function correctly. - In Circulation -> Overdues: The patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Course reserves -> Course -> Edit: Searching for an instructor - In the unimarc_field_210c_bis.pl plugin: 1. Link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. 2. Open a MARC record for editing and click the "tag editor" link to launch the plugin. 3. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. 4. Select one and click the "choose" button to fill the field in the MARC editor. - Tools -> Patron lists: Add a list or choose an existing list and add patrons. Perform a search for a patron. - Placing a hold: After choose a title and clicking "Place hold," search for a patron. - Tags management: The sidebar filter for "reviewer" should let you search by patron name. Other jQueryUI widget changes: - Check tabs appearance in header search, biblio detail, cataloging, and circulation patron fines pages. To confirm other jQueryUI widgets still function correctly: - Check accordion (collapsing sections) in Patrons -> Patrons requesting modifications and the MARC subfield structure edit screen. - Check datepickers, especially in Circulation with the added timepicker. Test a linked datepicker, for example in Reports -> Stats wizards -> Circulation where the value in one date field affects what dates are available in the matching field. - Check the calendar interface in Tools -> Calendar To confirm that the new jQueryUI default CSS is more flexible (fixing Bug 11042), add the following CSS to your IntranetUserCSS system preference and confirm that the header search active tab border color changes (hash mark escaped so that it will appear in commit msg): \#header_search ul.ui-tabs-nav li.ui-tabs-active { background-color: #FFFFF1; border: 1px solid #800000; border-top: 0 !important; top: -2px; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Bernardo Gonzalez Kriegel	5da480b61b	Bug 11993: fix untranslatable confirm popup in request.tt This patch makes confirm popup text translatable. It implements a similar function as used on OPAC deleteConfirm() and a JS var message. This function, or variants, can also be found on other files on intranet, I think that the only valid places are staff-global.js and help-top.inc Redefinitions of this function: prog/en/modules/serials/subscription-frequencies.tt:6 prog/en/modules/tools/marc_modification_templates.tt:158 prog/en/modules/virtualshelves/shelves.tt:92 Last case is a little different To test: 1) Confirm that the "cancel hold" link correctly prompts for confirmation: a) Place an item-level hold on a title. b) Check in the item and confirm the hold. c) Return to the place hold screen for that title and submit another patron to place a hold for. d) On the place hold screen for that patron, look at the table of items. There should be a "cancel hold" link next to the item for which the hold was confirmed in step (b). e) Click "cancel hold." You should see a confirmation message. Cancelling this dialog should cancel the operation. Confirming it should cancel the hold. 2) Check the string is not present on staff PO file 3) Apply the patch 4) Update translation files (cd misc/translator; perl translate update xx-YY) 5) Verify the string is now present Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	3c7edd1cbe	Bug 11764 - Move repeatedly redefined function toUC() into staff-global.js toUC() is repeatedly declared on many administration templates. This function, used to transform user input to uppercase, can be added to staff-global.js to prevent repetition. To test, confirm that transformation to uppercase is working on the following Administration pages when text is entered in a form field and focus is moved to the next field: - Authority types -> New: Test the "Authority type" field. - MARC bibliographic framework -> New framework: Test the "Framework code" field. - Patron types and categories -> New category: Test the "Category code" field. - Currencies and exchange rates -> New currency: Test the "Currency" field. - Item types -> New item type: Test the "Item type" field. - Z39.50 client targets -> New Z39.50 server: Test the "Z39.50 server" field. The following pages do not call the toUC function despite the fact that they included it: auth_tag_structure.tt printers.tt roadtype.tt stopwords.tt systempreferences.tt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> tools/letter.tt declares this js function and don't use it. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Galen Charlton	31a3fe1537	Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools \| CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed some tabs, works nicely and as described. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Blou	39830ac023	Bug 11035: Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested existing shortcuts for the search bar tabs on various circulation related pages. This uses a Javascript under BSD license, I wonder if it should be listed in the About>licenses section that we are using it. As Yui is also BSD I assume the license is compatible. +/** + * http://www.openjs.com/scripts/events/keyboard_shortcuts/ + * Version : 2.01.B + * By Binny V A + * License : BSD + */ Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	a5161d8fce	Bug 10493: (follow-up) fix various QA issues Adds a new Template Toolkit filter EncodeUTF8 to encode strings to utf8 for correct display of diactritics. Adds the new JavaScript function removeFocus() to staff-global.js Use this function to remove the focus from any element for repeated scanning actions on errors so the librarian doesn't continue scanning and miss the error. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> This works as described - you have to actually look at the error and pick what you want to do or confirm it. I think maybe tying the action to a shortcut (c = confirm or similar) would be nice, so you can get away with only using the keyboard. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	25e6c2885d	Bug 9424: Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	1940d4871c	Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>	11 years ago
Kyle Hall	be869ab279	Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=8125	12 years ago
David Cook	c061790f97	Bug 9783 - can hit submit twice when adding patrons Currently, clicking twice or more on the Save button will generate duplicate patrons when adding patrons in the Patron module. Of course, there is handling that detects this, so you can choose to either edit the original record (i.e. throw away the duplicate) or create a duplicate record. However, it shouldn't get to that point by clicking on the Save button. That handling seems to be there to handle cases where you go through the whole process of trying to add a new patron only to find out that they already exist in the system (or at least their username/password do). -- This patch uses the "preventDoubleFormSubmit" function (which is also used in holds and fines to prevent double form submits). It was also necessary to edit members.js, since "check_form_borrowers" was forcing form submits despite the "preventDoubleFormSubmit" function. I've changed it from forcing a document.form.submit to return true, which the browser will still submit the form if it's a unique borrower, but the "preventDoubleFormSubmit" function will still prevent multiple submits. I've also added a "waiting" class to staff-global.js which changes the cursor to "wait" (i.e. loading circle graphic). I've included an "AddClass" call in "preventDoubleFormSubmit", so that the cursor graphic will change to show users that the page is loading so that they don't click Save again. Of course, even if they do click save again, there will only be one submit. However, this way - as Chris Cormack mentioned - the user knows that "something" is happening and that the form isn't broken. ------- Test Plan Before applying patch... 1) Fill out the form for a new patron in the Patron module 2) Click "Save" several times 3) Once the page loads, you'll be shown a prompt that says that this borrower already exists. You will have the option to view the original record, edit the original record, or create a new patron anyway 4) Click on edit the existing record, and delete the patron Apply the patch 5) Repeat steps 1 and 2 6) Notice that your cursor has changed into a little "loading" circle graphic when you hover over the "body" of the page, as well as any links or any inputs/buttons of the type "submit" within that form 7) Notice that no matter how many times you press the button, the form is not re-submitted. Eventually you will be taken to the new patron's record (no mention of duplication will occur) Ta da! Multiple form submits are prevented and the loading graphic signals to users that the form was submitted and that Koha is processing their data -- I understand that some people might want to change which elements are given the "waiting" class. I'm happy to renegotiate this as necessary. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Looks good and works nicely. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Owen Leonard	c28f7d7de5	Bug 6209 [Revised] Standardize on one plugin for client-side form validation This patch adds the jQuery "Validation" plugin (http://docs.jquery.com/Plugins/Validation) and includes it by default in the staff client along with an include file containing translatable strings for all of the plugin's possible messages. The staff client's main JavaScript file has been modified to perform automatic validation of any form with the class "validated." For a simple example I have modified the library entry form to mark required fields as required (something which had not been done before). Each required field has been given a class, "required" and the HTML5 attribute "required." The former adds the hook for the plugin, the latter adds browser-based validation in recent browsers (and which will be superceded by the plugin if JavaScript is enabled). This will check for inputs classed "required" without any additional configuration. More complex forms (with specific data types, for instance) will require more inline JavaScript configuration. $("#FormID").validate({ /* configuration details */ }); Also added to the library entry form are checks on the email and URL fields via classes ("email" and "url", respectively). This demonstrates validation of content without forcing the field to be required. To test, go to Administration -> Libraries and Groups and choose "New library." Submit the form without entering a library code or name. You should be prevented from submitting the form and be shown an error message by each field. Perform the same check with an existing entry. To test browser-based validation, disable JavaScript and follow the same procedure. Revision rebases the patch against current master and adds missing "//<![CDATA[" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described with new or existing library. No errors. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Owen Leonard	ecf42ffbd0	Bug 9420 [Revised] Work on Bootstrap for Koha YUI JS is deprecated as far as Koha is concerned, and jQueryUI menus don't seem to be as robust as they should be. This makes Twitter Bootstrap very attrative for its menus features as well as other aspects. This patch revises the staff client header menu to include features from Bootstrap, including replacement of the YUI-driven "More..." menu with a Bootstrap version, and a new user menu taken from Corey Fuimaono's similar patch. To test, be sure to clear your cache after applying the patch. Load any page in the staff client and confirm that the menu at the top of the screen looks correct and works as normal, including functionality of the "more" menu. Confirm that the username/logged-in branch triggers a menu with "set library" and "log out" options. Confirm that Cart operations trigger the correct confirmation popup. Revision moves the Bootstrap assets out of the prog template into koha-tmpl/intranet-tmpl/lib. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works great. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Owen Leonard	2b74492d7d	Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> QA Comment: rebased on current master; minor merge conflicts with other patches pushed Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago