Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Kyle Hall	09b8ce2a5f	Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	0bf14c2d3a	Bug 10853: Add DB field export_format.type ('marc' or 'sql'). This patch: - adds a new column 'type' to the export_format table. - renames the field name export_format.marcfields with export_format.content. Test plan: - Check that existing profiles have the type "marc" selected by default - Create a new profile with a type "sql" - Save and verify the profile is correctly displayed when you select it. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. koha-qa reports Small tabs errors, corrected in followup Test: 1) go to Tools > CSV profiles, Create profile, current 2) Apply patch, run updatedatabase 3) Go to Tools > CSV profiles, new option present old profile with type MARC 4) Create new profile MARC, save and show correct 5) Create new profile SQL, save and show correct Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass with all 3 patches applied. Works as described. Functionality for SQL profiles will be added by another patch. For now it's possible to add/edit/delete them. Existing CSV profiles can still be exported correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	e273e11b08	Bug 10602: Set default value for authority fields via the framework This patch allows to define default values in the authorities framework. Some code already existed but the feature did not work. Test plan: 1/ Choose a framework, field and subfields. 2/ Define a default value. 3/ Create a new authority and check that the subfield is automatically filled with the default value. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. koha-qa reports some tabs, fixed in followup Test 1) Apply patch, run updatedatabase.pl 2) Edit auth framework, put default value someware, save 3) Add new auth, default value present Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Verified database update is done correctly. Controlfields 0xx - Edited an existing field (001) - Set a default value for subfield @ - Edited subfield again, checking default was saved correctly - Verified the default shows up correctly when creating a new authority using this authority type Fields - Edited an existing field (100) - Set a default value for subfield e - Edited subfield again, checking default was saved correctly - Verified the default shows up correctly when creating a new authority using this authority type Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mirko Tietgen	8369aa8431	Bug 9295: Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. In OAI set mappings, the value "is equal to" is hardcoded. This enhancement changes it to a dropdown menu to choose between "is equal to" and "not equal to". To test: * define a set * define a mapping for said set with "is equal to" * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; * change mapping to 'not equal to', save * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Fix bug id in updatedb.pl Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
David Cook	1e0b890b0c	Bug 10096 - Add a Z39.50 interface for authority searching This patch introduces a new Z39.50 interface for searching Z39.50 compliant databases for MARC authority records. These databases aren't as common as their bibliographic equivalents, but they're out there and very useful. I have included info at the bottom of this messsage for sample authority databases you can try. To test this patch: 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authority search targets from the list. 5) Do a search for an authority you would like using either the "Raw" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Name (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- Here is the info for the LibrariesAustralia test Z39.50 authority database: Z39.50 server: LibrariesAustralia Authorities Hostname: z3950-test.librariesaustralia.nla.gov.au Port: 210 Database: AuthTraining Userid: ANLEZ Password: z39.50 Syntax: MARC21/USMARC Encoding: utf8 - The U.S.A. Library of Congress also provides Z39.50 access to its Name and Subject Authorities (http://www.loc.gov/z3950/lcserver.html). Name Authority: Z39.50 server: Library of Congress Name Authority File Hostname: lx2.loc.gov Port: 210 Database: NAF Syntax: MARC21/USMARC Encoding: utf8 Subject Authority: Z39.50 server: Library of Congress Subject Authority File Hostname: lx2.loc.gov Port: 210 Database: SAF Syntax: MARC21/USMARC Encoding: utf8 (N.B. Both of these databases also include title authorities.) - For testing purposes, you can also set up a Z39.50 client target, which points at your own Koha instance's Z39.50 authority server. To find the hostname, go to /etc/koha-conf.xml and find the value for the <listen id="authorityserver"> element. Depending on your configuration, this could be something like the following: unix:/zebra/koha/var/run/zebradb/authoritysocket (N.B. You might be using a different scheme than unix sockets...) To find the database, scroll down to the bottom of koha-conf.xml until you reach the <config> element. Within this, look for the value of the element <authorityserver>. It should probably be "authorities". To set up this Z39.50 client target in Koha... Z39.50 server: my koha authorities Hostname: unix:/zebra/koha/var/run/zebradb/authoritysocket Port: Database: authorities Userid: Password: Syntax: MARC21/USMARC (or whichever flavour you need) Encoding: utf8 Signed-off-by: Mason James <mtj@kohaaloha.com> Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. Signed-off-by: Mason James <mtj@kohaaloha.com> Bug 10096 [FOLLOW-UP] - fix tabs/whitespace errors to pass QA Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Chris Cormack	4159e55a1a	Bug 9611: Database update, changing password from varchar(30) to varchar(60) This is necessary because Bcrypt hashes are longer than MD5 hashes. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Magnus Enger	9dca7096c8	Bug 10513: display a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. The type of message can also be chosen, affecting how the message is displayed. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Repeat the steps above, but select "Alert" instead of the default "Message" as the "Check in message type". Check that the message is displayed in a yellow alert box, not a blue message box. - Check in an item with an item type that does not have a check in message, and make sure no false messages are displayed - Create a new item type from scratch and check that it works the way it is supposed to - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql UPDATE 2013-07-22 - Rebased on current master (no changes) - Added "AFTER summary" to the SQL statement in updatedatabase.pl - Added another placeholder on line 170 of admin/itemtypes.pl Thanks Katrin! UPDATE 2013-07-29 - Make this message independent of all other messages - thanks Owen! - Make it possible to choose the type of message ("alert" or "message") Sponsored-by: Kultur i Halland - Regionbibliotek Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed some tabs to make the QA script happy. All old and new tests pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Julian Maurice	905306efb1	Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Julian Maurice	12f62ba1db	Bug 5349: add ability to transfer order lines from one basket to another On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link leads to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pick a basket and the transfer will be done. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: sonia <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Kyle Hall	dbaefb626c	Bug 10550: Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Nicole C. Engard	09e802c793	Bug 10703: Document borrower_files table Add db documentation to borrower_files table. To test: apply review kohastructure.sql to be sure documentation is there Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No errors. Tested loading on new database. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Nicole C. Engard	6823c74537	Bug 10703: Document quotes table Add db documentation for the quotes table To test: apply patch review kohastructure.sql to be sure documentation is there Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Nicole C. Engard	801d8237d8	Bug 10703: Add db documentation for biblioimages table This patch adds db documentation to the biblioimages table. To test: Apply patch Review kohastructure.sql to be sure that the documentation is there Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	3793bfe9ed	Bug 10604: increase width of two columns in the courses table The department and term columns in the courses table started as varchar(20), but since they refer to authorized values, need to be varchar(80) to match authorised_values.authorised_value. This patch increases the width of those columns. To test: [1] Create two DEPARTMENT authorised values, one whose code is shorter than 20 characters and one whose code is longer than 20 characters. [2] Create two courses; give one course the short department and the other the long department. [3] Go to the courses list. Observe that the department column is displays the department name only for the short course. [4] Apply the patch. [5] Edit the course with the long department and assign that long department to it again. [6] Go back to the courses list. Observe that both of the courses now display their assigned department. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified changes are consistent for new installations and updated installations. Passes all tests. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Katrin Fischer	16c5794044	Bug 10490: Overdue fines cap can't store decimal values When overduefinescap was added to the issuingrules the datatype given was decimal. This translates in MySQL to decimal(10,0). This doesn't allow you to store decimal values and therefore values like 4.5 are saved as 5 in the database. To test: On a current installation: 1) Try to enter 4.5 as Overdue fines cap. Verify that the value is not correctly saved. 2) Apply patch and run database update. 3) Try adding/changing an issuing rule setting Overdue fines cap to 4.5 again. 4) Verify the value is saved correctly. Create a new Koha installation from scratch: 1) Verify that the issuingrules table has been created correctly and that you can add/mofidy issuingrules correctly. Because this bug can create data loss, the old database update has also been changed to avoid this problem for people updating at a later point in time. Checkout an older version of Koha pre 3.09.00.027. 1) Run the database updates. 2) Verify again, that adding/modifying issuingrules works correctly. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	da0337b374	Bug 9987: Remove DB field aqorders.biblioitemnunmber The DB field aqorders.biblioitemnumber seems to be unused except to get the itype on the spent.pl page. This information can be retrieved uising another SQL join. Test plan: Try a complete workflow in the acquisition module: create an order, receive it, play with the syspref AcqCreateItem. Check that no regression is found and that the data for existing orders don't change. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	43b17feed6	Bug 10443: (follow-up) make sure borrower_files has FK constraint This follows the example of the DBrev that introduced this table. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Juan Romay Sieira	2e86612a15	Bug 10443 - Table borrower_files does not exists in kohastructure.sql file As a consequence, the borrower_files table would not exist in Koha databases that were installed starting at 3.10.0 or later. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	67fb83d525	Bug 7718 - Remove itemnumber column from serials table Remove the column 'itemnumber' from the table 'serial'. This is a 1 to many relationship, and this reference does not make sense. The 'serialitems' table handles the relationship between the 'items' table and the 'serial' table. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify serial.itemnumber has been removed from the database Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Column removed. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Kyle Hall	be869ab279	Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=8125	12 years ago
Paul Poulain	68ff49bb7d	Bug 9681: Add some indexes in database Some table columns should have an index to speed SQL queries : - statistics table has only one index (used to make heavy queries for reports) - itemtype should have an index in items and biblioitems (this is used in circulation to check the number of existing issues of a specific item type) - issue.branchcode and issue.issuingbranch Test plan : - Create a new database using kohastructure.pl => check there is no SQL error and that new indexes are present (mysql> show create table) Apply update database on a master version => check there is no SQL error and that new indexes are present (mysql> show create table) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Indexes created as described. No errors. Fixing small merge conflict. Test presence of new indexes on all affected tables. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Kristina D.C. Hoeppner	7a5dc6eef5	Bug 2046 - Suggestions: Title Field too small Increase both on staff and OPAC interface from 80 to 255 characters to be saved in the database. Shown will be 80 characters. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Clean patch, workes as described. To test: - Apply patch and run database update - Check that the column in the database is now varchar(255) - Enter a new suggestion in the OPAC - Edit this suggestion in staff - Confirm form has the new max value set Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Marcel de Rooy	c134a3c5c3	Bug 7368: Typo in kohastructure.sql documentation line Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Peter Crellan Kelly	07228e5080	Bug 9919: Correct syntax error caused by missing comma. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Simple fix for a bad problem. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Jared Camins-Esakov	b9db6ae0f7	Revert "Merge branch 'bug_7688' into 3.12-master" This reverts commit `60508cb03d`, reversing changes made to `8579d07f14`. The patches for bug 7688 caused a failure in t/db_dependent/Serials.t: not ok 8 - test getting history from sub-scription Conflicts: installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl kohaversion.pl	11 years ago
Jonathan Druart	ed63c13957	Bug 5343: Link serial and acqui modules DB changements: - Adds 2 fields: subscription.reneweddate and aqorders.subscriptionid. - Removes 2 unused fields: aqorders.serialid and aqorders.subscription. Main test plan: 1) Create a subscription 2) Create a bookseller and a basket 3) Add a new order 'from a subscription' 4) Search your subscription and check if results are correct 5) Click on the "order" link 6) Check the biblio information are filled in the form 7) Select a budget and fill some price information. 8) retry steps 3 and 4. Verify you cannot order the same subscription. Message:Outstanding order (only one order per subscription is allowed). 9) click on your subscription (already added) and check you have a new table "Acquisition details" with your price information in the "Ordered amount" line. 10) receive this order 11) On your subscription detail page, the "Spent amount" line must be filled with your price information. 12) Re order the same subscription. Now you are allowed to. Prices information have to be filled with the previous information. 13) Retry some orders and click on a maximum of links in order to find a bug :) Signed-off-by: Leila Arkab <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on last patch. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	dc9ff3c53d	Bug 7688: Change subscription numbering pattern and frequencies Serials numbering pattern and frequencies are no more hard-coded. Now it's possible to create, edit and delete numbering patterns (and frequencies). This implies new sql tables (subscription_numberpatterns and subscription_frequencies) Numbering patterns behave almost as before, there are still the same values to configure (addX, everyX, settoX, whenmorethanX). lastvalueX and innerloopX remain in subscription tables. There is a new value in numbering patterns: numberingX. For each "column" (X, Y or Z) you can tell how to format the number. Actually numberingX can be set to: - 'dayname' (name of the day) (0-6 or 1-7 depending on which day is the first of the week) - 'monthname' (name of the month) (0-11) - 'season' (name of the season) (0-3) (0 is Spring) These names are localized by using POSIX::setlocale and POSIX::strftime and setting a 'locale' value to the subscription. Locale have to be installed on the system. Note that season names are not localized using POSIX::strftime (it can't do this), so names are hardcoded into the code (available languages: en, fr). This could be fixed in the future by using a Perl localization framework. Frequencies can be configured using 3 parameters: - 'unit': one of 'day', 'week', 'month', 'year' - 'issuesperunit': integer >= 1, the number of received issues per 'unit' - 'unitsperissue': integer >= 1, the number of 'unit' between two issues One of 'issuesperunit' and 'unitsperissue' must be equal to 1. Examples: unit = 'day', issuesperunit=3, unitsperissue=1 => 3 issues per day unit = 'week', issuesperunit=1, unitsperissue=3 => 1 issue each 3 weeks Prediction pattern is now computed server-side and is more consistent with what Koha will do. The publication date is displayed alongside the serial number. Irregularities can now be checked one by one, in the prediction pattern table, or if frequency is 'day-based' (unit is 'day'), there is the possibility to check all issues for a week day at once. When an irregularity is found, there is the possibility to keep the serial number unchanged, or to skip it. It is configured at subscription creation or modification. For instance, with a daily subscription you can have: skip serial number \| keep serial number ----------------------+---------------------- 2012-01-01 ¦ No 1 \| 2012-01-01 ¦ No 1 2012-01-03 ¦ No 3 \| 2012-01-03 ¦ No 2 To lighten the subscription modification page, manual history has been moved in its own page subscription-history.pl which is accessible on subscription-detail.pl, tab 'Planning'. Important note: updatedatabase.pl script takes into account existing subscriptions and create appropriate numbering patterns for them (it tries to create as few patterns as possible). Frequency is mapped to the correct entry in subscription_frequencies table. This patch includes kohastructure.sql and updatedatabase.pl changes + sample frequencies data and sample numberpatterns data for fresh installs (sample data is included in updatedatabase.pl) === TEST PLAN: === Create a new subscription: - Go to Serials module and click "New subscription" button - On the first page, choose a biblio and click next to go to the second page - Pick a first issue publication date - Choose frequency '1/day' - Choose a subscription length of 15 issues - Choose a subscription start date - Choose numbering pattern 'Volume, Number' - A table appears, fill 'Begins with' cells with '1' - Click on 'Test prediction pattern' button The prediction pattern is displayed at the right of the page. You can see in it the serial number, the publication date and a checkbox to allow you to choose which serials will not be received (irregularities). You can see that serial number start from "Vol 1, No 1" continue to "Vol 1, No 12" and then restart with "Vol 2, No 1". Frequency is '1/day' so you can see that publication date is incremented by one day line after line. - Now you can play a little with frequencies and numbering patterns, change one of them (or both) and click again on 'Test prediction pattern' - For example, choose frequency '3/weeks' and click on 'Test prediction pattern' button'. There is a little behaviour change compared with current master. Publication date will not be guessed within the week. Koha can't know when you will receive issues. So the publication date stay the same (monday of each week) for 3 consecutive issues and then jump to the next week. - Now choose frequency '1/3 months' and numbering pattern 'Seasonal' - Fill 'Begins with' cells with '2012' for Year and '0' for Season - Click on 'Test prediction pattern' - You should have something like 'Spring 2012', 'Summer 2012', ..., 'Winter 2012', 'Spring 2013' - Note that you can have seasons for south hemisphere by entering '2' in 'Year/Inner counter' - 2nd note: if you have some locales installed on your system, you can type its name in the 'Locale' field (actually it does not work for seasons name, only for month names and day names) If you want to modify the numbering pattern you can still do it here: - Click on 'Show/Hide advanced pattern' link. The advanced pattern table is shown but all fields are readonly - Click on 'Modify pattern' button. All readonly fields are now editable. Note that 'Begins with' and 'Inner counter' line are repeated here and any modifications in the small table will be replicated in the big table, and vice versa. - Pattern name is emptied, if you type a new name, a new pattern will be created, and if you type the same name as an existing numbering pattern, this one will be modified (with a confirmation message) - There is two new lines in this table: - Label: it's what is displayed in the smaller table headers above - Numbering: used to format numbers in different ways. can be 'seasons', 'monthname' or 'dayname'. Month name and day name can be localized using the 'Locale' field. Seasons can't (values for english and french are hard-coded in Serials.pm) - You can modify what you want in the table and click on 'Test prediction pattern' button each time you want to see your modifications. (Note that checkboxes for irregularities aren't displayed in this mode, and you can't save the subscription until you have saved or cancelled your changes). - To cancel your modifications, just click on 'Cancel modifications' button. - To save them, click on 'Save as new pattern'. If the pattern name is already existing, a confirmation box will ask you if you want to modify the existing numbering pattern. Otherwise a new pattern will be created and automatically selected. Once you have finished modifying numbering pattern. You can click again on 'Test prediction pattern' to define irregularities, and then click on 'Save subscription'. Now you can check the serials module still works correctly: - Check the subscription detail page to confirm that nothing is missing. Especially the 'Frequency' and 'Number pattern' infos - Try to receive some issues. Check that the serial number is correctly generated and if irregularities you have defined are taken into account (if you have defined some). - Check that receiving is blocked once you have reached the number of issues you have defined in subscription length (or once you have reached the subscription end date) In serials menu (to the left of almost each page of serials menu) you have two new links: 'Manage frequencies' and 'Manage numbering patterns'. 'Manage numbering patterns' lead to a page which list all numbering patterns and allow you to create, edit or delete them. The interface is almost the same as numbering pattern modification in subscription-add.pl 'Manage frequencies' lead to a page which list all frequencies and allow you to create, edit or delete them. Try to create a new frequency: - Click on 'Manage frequencies' link in the serials menu and then click on 'New frequency': - Fill in the description (mandatory). - Unit is one of 'day', 'week', 'month', year' or 'None' ('None' is for an irregular subscription) - If unit is different from 'None' you have to fill the two following fields (Issues per unit, and Units per issue) - Note that at least one of those must be equal to 1 - Issues per unit is the number of received issues by 'unit' and Units per issue is the number of 'unit' between two issues - Display order is used to build the drop-down list. Leave empty and it will be set to 0 (top of the list) - Then click on 'Save' - Check that this new frequency appears in the frequencies table and in the drop-down list in subscription-add.pl Subscription history has been moved in its own page. To test if it still works, choose a subscription with manual history enabled (or modify an existing subscription to turn on manual history). - On the detail page, tab 'Planning', you should have a link 'Edit history'. - Click on it - Modify history and click on Save - In tab 'Summary' you should have the infos you just entered And finally, you can check that old subscriptions (by old I mean subscriptions that existed before the update) are correctly linked to an existing numbering pattern and an existing frequency. Numbering patterns should be named 'Backup pattern X' where X is a number. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Great development! Work as described. No koha-qa errors (with all patches applied). Please QA this fast. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	719044f771	Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu Signed-off-by: Liz Rea <liz@catalyst.net.nz> Yes! Now this works, and well. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	8ad00bc02f	Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test comments on second patch. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	7224e47dfe	Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. Signed-off-by: Bob Birchall <bob@calyx.net.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Adrien Saurat	a252e417fb	Bug 7241 follow-up: DB changes Reset timestamp modification on update after patch application. Give more information about the log history fix. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Adrien Saurat	7ceb9988e9	Bug 7241: circulation action logs record biblionumber instead of item number Issue log and and circulation logs are incorrectly recording biblionumber instead of item number, creating incorrect logs. This patch corrects this, and modifies the action_logs table in two ways: - the timestamp is not updated anymore with UPDATES (but still automatically filled when INSERTing) - to partially correct the broken logs, the log history is filled with the first found item for each biblio Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle M Hall	5eabc672fd	Bug 7804 - Add Koha Plugin System Adds support for custom plugins. At the moment the Plugins feature supports two types of plugins, reports and tools. Plugins are installed by uploading KPZ ( Koha Plugin Zip ) packages. A KPZ file is just a zip file containing the perl files, template files, and any other files neccessary to make the plugin work. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Create the directory /var/lib/koha/plugins 4) Add the lines <pluginsdir>/var/lib/koha/plugins</pluginsdir> <enable_plugins>1</enable_plugins>" to your koha-conf.xml file 5) Add the line Alias /plugin/ "/var/lib/koha/plugins/" to your koha-httpd.conf file 6) Restart your webserver 7) Access the plugins system from the "More" pulldown 8) Upload the example plugin file provided here 9) Try it out! Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	15 years ago
Tomás Cohen Arazi	4dcee58a4d	Bug 7440 - Remove NoZebra vestiges Removed NoZebra vestiges. This comprises several code blocks that depend on the NoZebra syspref and NZ related functions/methods. C4::Biblio-> GetNoZebraIndexes _DelBiblioNoZebra _AddBiblioNoZebra C4::Search-> NZgetRecords NZanalyse NZoperatorAND NZoperatorOR NZoperatorNOT NZorder C4::Installer-> set_indexing_engine Sponsored-by: Universidad Nacional de CÃ³rdoba Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Kyle Hall	72f1b94a09	Bug 9207 - Improve z39.50 speed slowdowns for sites with many records Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Chris Cormack	9c01d7c7a2	Bug 8917 : Creating tables and system pref, no functional changes at all Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jared Camins-Esakov	7535f2bfa3	Revert "Bug 7167: New version for updatedatabase" This reverts commit `c9cb55ef47`.	12 years ago
Jonathan Druart	c9cb55ef47	Bug 7167: New version for updatedatabase This patch use DataTable, see BUG\|BZ 6836 - css/datatables.css - lib/jquery/plugins/jquery.dataTables.min.js - js/datatables.js http://bugs.koha-community.org/show_bug.cgi?id=7167 Bug 7167 follow-up Major changes: * creating database tables for update on the fly, the 1st time the update script is called * version is checked on mainpage.pl (and here only). If syspref Version differ from kohaversion.pl, the old updatedatabase is launched. If there are updates missing from new mechanism, the updatedatabase page is reached * kohaversion check on each page is now useless in Auth.pm, removed dead code * Updated installer: at the end of the process, retrieve all updates and automatically mark them "OK", as they're included in installer Minor changes: * adding copyright * adding poddoc * updating a warning, for better clarity * switching from $$var to $var-> * small TT glitch fixed in updatedatabase.tt * about.pl now returns the Version systempreference PLUS all the patches that have been applied Bug 7167 follow-up perlcritic & numbers display & partial apply depending on DEBUG * add use strict to updatedatabase, that is now perlcritic compliant * partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0, the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user know has the option to apply DBrevs one by one Display: * in updatedatabase, small spelling changes * in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1) * improve the display of applied numbers on about.pl - before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied, about was displaying : , N+1 / N+2 / N+3 / N+10 - after this patch you have N......N+3 / N+10 * add ORDER BY into list_versions_already_knows to have number retrieved in the same order whatever the order they are applied http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Improve the update.pl script * Added CLI options to update.pl * Call update.pl from the installer. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Now, we check versions on mainpage.pl and after login Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Reimplementing Marcel's suggestions & fixes * Fixing the bugguy old version check (that was made against 3.0900000 instead of 3.0900027 -the last current kohaversion number * in the CLI script, if there is nothing to report, just say it Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 7167: Remove check_coherency As suggested by Katrin, we've removed the call to check_coherency. It intended to provide readable comments when some SQL was wrong. Removing this sub result in the SQL error being displayed. That's OK because the sysadmin or the developer can google the error, understand it, then fix it. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Changing in .sql parsing We first split on delimiter and then extract comments. You can now put \n for delimiter comments. ex: DELIMITER ; -- this is a comment SELECT * FROM my_table; -- another comment Before this patch, we had to write: DELIMITER ; -- this is a comment; SELECT * FROM my_table; -- another comment; Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Add .pl and .sql examples Those files are in version directory, so will never be executed by the updater If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version) Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Improve display + factorize get_queries Despite it's size, this patch is dealing with display questions only: * The text "comments" and "queries" was hardcoded in ajax-updatedb-getinfo.pl script. It has been replaced by a JSON call, returning 2 separate values, "comments:" and "queries:" is now in the template, making it translatable * Some minor tweak in the display (like putting things in bold, displaying OK in green, warnings in yellow and KO in red) * Reordering the column headers for more readability: * Status column is merged with availability, column is after status * Status/availability terms more clear: "Not applied" instead of "unknown", "Applied and OK", "Applied and failed", "Applied and forced" are the 3 other statuses * Removed one click to display comments on DBREv not yet applied: before the patch, one had to click "Show details", then "Get comments", now, "Get comments" is enough Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: FIX typos & moving a script to a proper place * renamed availables to available * renamed already_knows to already_applied * fixed FSF & copyright headers * removing a "use strict" because we already had use Modern::Perl * fixed a tiny typo in about.tt * moving update.pl to misc/bin because it's a CLI script Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Add dependency File::Find::Rule Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: We want to execute non-numeric version with the -all option Dealing with Marcel comment 100: > Note that the current code around line 52/53 does not > handle that correctly: > Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at > installer/data/mysql/update.pl line 52. Now, a non-numeric DBRev will be applied if you provide the --all parameter, without throwing the error Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167 reindentation & removing dead code * The if (! defined $ENV{PERL5LIB}... block was wrongly intented * The 3 lines running update.pl are useless: the update (new mechanism) is run from admin/updatedatabase.pl script. This part of install.pl is run only when you have "old style" DB revisions. Summary: * old mechanism = it's run as previously, by reaching the installer/install.pl?step=3 page, that applies all revisions * new mechanism = when you log-in or reach mainpage.pl, you reach admin/updatedatabase.pl, where you can see what will be run, and run it Tiny side effect = the check for old mechanism is now done after authentification (thus it's not done on each page call). It means that the user will have to enter login/password twice : * first to log-in to Koha * second to run installer/updatedatabase.pl?step=3 As the old mechanism is deprecated, we can expect this will happend only a few time in the history of a setup, it's not a big deal. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Don't raise an error in routine TableExists Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: FIX merge Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167: Add .pl and .sql examples Those files are in version directory, so will never be executed by the updater If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version) Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Bug 7167 follow-up fix POD syntax to please koha-qa.pl Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	92782d3832	Bug 7067 - OPAC Borrower Self Registration This development will add the ability for a new patron to register himself or herself. The self-registration will attempt to match this newly inputted data to any existing patrons and if any possible matches are found, ask if the patron is sure he or she doesn't already have an account at the library. A system preference may be set to prevent patron self-registration if the system detects the possibility that the person may already have an account. Once the patron has registered, passing a captcha (or similar bot-stopper), the patron will then be optionally verified a second time via email. At this point, the patron will be able to print a temporary library card (optional by system preference), and will be provided any details necessary to access electronic resources (this body of text would be a template in the slips and notices system). At the library's choice, this new patron would either be set to a temporary patron status (patron type set via system preference), or a fully-fledged patron (allow patron type to be determined by age and/or other attributes). Assuming the library uses temporary patron types for OPAC registrations, this patron will next enter a queue and would need to physically enter the library to verify himself and become a fully-fledged patron (most likely by bringing in physical proof of address, etc.). The librarian would look up the patron record and modify the patron type. If a temporary patron has not been verified within a certain time frame (defined by a system preference), the patron record will be deleted from the system via a cron job. For registered patrons, the system will allow each person to also update his or her personal data via the OPAC. When a patron updates his or her information, the changes will be entered into a queue to be verified by a librarian (preventing a patron from inputting obviously bogus data). The staff client home page will display the number of patron records with changes awaiting approval. A librarian would then be able to click through a list of modification requests, and approve or deny each (with approval and denial alerts being sent to the patron via the standard messaging system). NEW SYSTEM PREFERENCES * PatronSelfRegistration * PatronSelfRegistrationDetectDuplicates * PatronSelfRegistrationVerifyByEmail * PatronSelfRegistrationPrintTemporaryCard * PatronSelfRegistrationUseTemporaryStatus * PatronSelfRegistrationExpireTemporaryAccountsDelay NEW NOTICE * Verify by email notice NEW SLIP * Temporary card slip NEW CRON JOB * delete_expired_opac_registrations.pl - Deletes patrons that have not been upgraded from the temporary status within the specified delay * delete_unverified_opac_registrations.pl - Deletes the unverified patrons based on the length of time specified in the PatronSelfRegistrationExpireTemporaryAccountsDelay The patron will register from self_registration.pl, linked off opac-main.pl if enabled. The registration page will be translatable to other languages in the same way that existing templates are. Test Plan: 1) Enable PatronSelfRegistration 2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number of days 3) Create a self-registered borrower category 4) Set PatronSelfRegistrationUseTemporaryStatus 5) Set PatronSelfRegistrationVerifyByEmail to "Don't require" 6) Go to OPAC, log out if logged in. 7) You should see the "Register here" link below the login box 8) Attempt to register yourself 9) Verify you can log in with your temporary password. 10) Set PatronSelfRegistrationVerifyByEmail to "Require" 11) Attempt another self-registration 12) Check the messages table, you should see a new message with a verification link. 13) Copy and paste the link into a web browser to verify the registration 14) Log in with the given credentials to verify the account was created. Test Plan - Part 2 - Borrower Modifications 1) Log in to OPAC, go to "my personal details" tab. 2) Make some modifications to your details. 3) Repeat steps 1 and 2 for two more borrowers. 4) Log in to Koha intranet with a user that can modify borrowers. 5) At the bottom of mainpage.pl, you should see: Patrons requesting modifications: 3 6) Click the link 7) Approve one change, deny a different one, and ignore the third, then submit. 8) Check the records, you should see the changes take affect on the approved one, and no changes to the other two. You should also see "Patrons requesting modifications: 1" at the bottom of mainpage.pl now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts * Add required fields check for editing exiting patrons * Don't force require email address for existing patrons when PatronSelfRegistrationVerifyByEmail is enabled. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Marc Veron	ca47d7c31c	Bug 9246: Koha installer crash with mysql error The Koha installer reports "Error 1166 at line 1871: Incorrect column name 'closed'." Reason: line 1923 in kohastructure.sql had whitespace between back tick on Column name "closed". Patch removes white space on given line. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	acbfe26c9e	Bug 7919 : Display of values depending on the connexion library In a librairies network, we would like to declare specific values just for one (or more) library. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a library not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/modborrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	c39380ed4e	Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the "closed" tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status "stopped" everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the "Include expired subscriptions" checkbox. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of "disabled" serials Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	550ac77bfd	Bug 9030: Add constraint on aqorders_items.ordernumber Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Paul Poulain	b5474b7f95	Bug 9064: fix statistics.ccode column From updatedatabase.pl: $dbh->do("ALTER TABLE statistics ADD COLUMN ccode VARCHAR ( 10 ) NULL AFTER associatedborrower"); From kohastructure.sql: `ccode` int(11) default NULL, -- foreign key from the items table, links transaction to a specific collection code The variant in updatedatabase.pl is probably what was wanted. This patch fixes the kohastructure and add another updatedatabase.pl, in case someone has a broken install. This should not happen, because 3.10.0 still not released, but just in case... Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Nuño López Ansótegui	57239bd345	Bug 6428 [Follow-up] refered column 'items.coded_location_qualifier' does not exist Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>	12 years ago
Nuño López Ansótegui	6b14cd71f6	Bug 6428 - refered column 'items.coded_location_qualifier' does not exist Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Nicole C. Engard	b0b927f4f2	Bug 4118: Follow up: Add ccode to kohastructure for stats CCode was added to the statistics table in this bug, but was not added to kohastructure.sql. This patch adds it with comment to the kohastructure. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Nicole C. Engard	c21fd2a983	Bug 6716: Update biblioitems tables This patch documents the cn_sort and agerestriction fields in the biblioitems and deletedbiblioitems tables. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Nicole C. Engard	9ad0006c3e	Bug 6716 - Fix alt contact field documentation The borrowers table has the wrong documentation for the alternate address3 and city fields. This fixes that. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Jonathan Druart	1b4b78a136	Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested together with patches for bug 7302.	12 years ago

... 3 4 5 6 7 ...

516 Commits (95429af6855e8ed37945b681dc466bf360deffb2)