Commit graph

248 commits

Author SHA1 Message Date
Galen Charlton
960db4e458 Biblio.pm bugfixes
- uses new C4::Dates instead of C4::Date
- start work on TransformMarcToKoha
  * handle ambiguities in certain column names
  * part of patch inspired by Chris Cormack
- fix bugs preventing biblioitems and items
  from being properly updated
- ensure that biblionumber and biblioitemnumber
  always get mapped to MARC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:00:00 -05:00
Galen Charlton
af9dfd9cda bib and item editing bugfixes
- bugfix: update items.cn_sort upon edit of item
- bugfix: make failure of a value_builder plugin non-fatal
- bugfix: remove references to non-existent plugins
          from optional MARC21 frameworks
             bookseller.pl
             marc21_callnumber.pl
             marc21_classcodes.pl
             marc21_locationqualifier.pl
- bugfix: corrected trying to enter 'u*' fields twice in the 'CF'
          format in the optional MARC21 frameworks; resulted in
          most of the framework not being loaded

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:56:53 -05:00
Paul POULAIN
10eb85455b bugfix (security flaw) : the additem template was open AFTER doing actions
when Logguing was ON, this resulted in an internal server error, thus the discovery of this bug.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:24:49 -05:00
Paul POULAIN
b25ace0be4 bugfix : handling biblionumber in a field < 010
the bug occur only if we have a malformed biblio, so it should "never" happend, but i've seen it once ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:20:22 -05:00
Galen Charlton
fc8b44a967 call number work part 3 -- now using new routines to generate call number sort keys
C4/Biblio.pm - removed following functions:

_biblioitem_cn_sort
_items_cn_sort

TODO: add a new call number filing routine to emulate logic of
_biblioitem_cn_sort for compatibility purposes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 22:11:40 -05:00
Galen Charlton
af466ca41a start of reworking call number handling and other Biblio changes
Most of this commit by Joshua Ferraro.
updatedatabase changes by Galen Charlton.

Major changes:

This commit includes a lot of fairly major changes
to Koha's Biblio handling, largest is the addition
and deletion of several columns in the biblioitems,
items tables, as well as cleanup of deletedbiblioitems,
deleteditems tables. Some of the changes are simple
cleanup, but most have to do with improvements to
storage of call numbers in Koha.

Also, I had to clean up the _koha_* routines quite a
lot to make them work -- there was lots of data just
being lost because columns weren't being updated.

I'm still not completely convinced that the items
table is being treated as authoritative for items
data, investigating further.

DB Changes (updated in kohastructure.sql and in
updatedatabases):

ADDED:
biblioitems.cn_source   ( auth value, CN_SOURCE, stores the source of the
                          call number: DDC, LCC, NLM, etc.)
biblioitems.cn_class    ( plugin, marc21_callnumber.pl, helps fill in
                          the rest of the biblio-level fields)
biblioitems.cn_item
biblioitems.cn_suffix
biblioitems.cn_sort     ( for zebra sorting, stored as a decimal number)
biblioitems.totalissues ( for counting the total times issued )

items.cn_source         ( auth value, CN_SOURCE, stores DDC, LCC, NLM, etc.)
items.itemcallnumber    ( plugin, marc21_itemcallnumber.pl, helps fill in
                          the itemcallnumber based on the record data )
items.cn_sort           ( for zebra sorting, stored as a decimal number)
items.ccode             ( auth value, CCODE, stores the Collection Code
                          of the item, can be used as call number prefix
                          by some libraries )
items.uri
items.materials
items.damaged

DELETED:
items.itype
items.cutterextra
biblioitems.classification
biblioitems.subclass
biblioitems.dewey
biblioitems.lcsort
biblioitems.lccn
biblioitems.ccode

DB version now 3.00.00.009.

Minor changes:

* Drop revision history from C4/Biblio.pm
* GetMarcAuthors now returns additional authors (7XX), not
  main authors (1XX)
* Debug warnings in C4/Search.pm commented out

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:19:56 -05:00
Paul POULAIN
b426ecb4f2 BUGfixes in availability management
- the availability status was not available on result list. This patch reintroduces that
- notforloan as itemtype was not properly managed : an itemtype that was notforloan resulted in nothing in detail. Not, the user can't place a reserve anymore, and the status is correctly displayed

the fix is for OPAC as well as staff

(owen, pls, validate cat-toolbar.inc & catalogue/detail.tmpl)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-14 19:10:53 -05:00
Ryan Higgins
1c2adfe7ff adding GetMarcUrls() fcn to display 856's - adding also output to opac-detail.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:24:53 -05:00
Chris Cormack
e8528be8cb Delbiblio no longer deletes items.
It will only delete biblios that have no items attached.
You must delete the items first then delete the biblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:23:45 -05:00
Chris Cormack
eb8878b854 Working on a fix for 1176
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:22:59 -05:00
Paul POULAIN
e378fb11e6 Bumping to 3.00.00.008 : adding biblio.datecreated
The top issue was based on a timestamp field, that was updated everytime a biblio is modified

This commit add a datecreated field, that is filled only when a biblio is ADDED
it is used by opac-topissues & can be useful at other places i'm sure

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 19:09:42 -05:00
Joshua Ferraro
e494fadf0a partial 1481: adding to templates, fixing non-display of data
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 16:34:56 -05:00
Joshua Ferraro
3dcc72ad91 removing multivolume,multivolumepart,binding
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-06 01:38:27 -05:00
Henri-Damien LAURENT
04a108482d BUG FIXING : Using LEFT JOIN in replacement of implicit inner joins. WARN NOT FULLY TESTED
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:35 -05:00
Chris Cormack
b989b83264 Fix for bug 1437, items not showing on moredetail.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 17:58:02 -05:00
Ryan Higgins
cdb0b859fe fix column spelling errors and inconsistency btwn kohastructure and Biblio.pm (editionreponsability).
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 16:03:49 -05:00
Joshua Ferraro
6a3f4bf219 missing ) caused install to fail! We need to test changes before
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-29 16:00:51 -05:00
Henri-Damien LAURENT
b0e77eb844 Bug Fixing: verifying that biblionumber is not already stored in marcrecord before storing it
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-28 16:42:33 -05:00
Paul POULAIN
0d7a4aafd0 BUGFIX : NoZebra indexing was wrong for accented words
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-26 05:28:37 -05:00
Paul POULAIN
b67d77e211 BUGFIX : repeated fields where merged on biblio update
When updating a biblio, all repeated fields had the same input name.
Thus, when retrieving them through cgi->param resulted in a single line
Thus all subfields where merged in a single MARC field.
Adding a random() part to the name solves the problem

+ removing some warn lines

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:31 -05:00
Paul POULAIN
14301333cc BUGFIX : adding management of the 5 new biblioitems columns for biblio adding
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:18 -05:00
Paul POULAIN
7ed10cb920 BUGFIX & improvement : new biblioitems fields saving and GetMarcAuthors improvement
hdl defined 5 new fields in biblioitems, to handle collections.
The _koha_modify_biblioitem didn't deal with those fields. it's fixed now.

GetMarcAuthor in UNIMARC have a $4 field that is related to the responsability the author has
it is connected to an authorised value.
The improvement expand the numeric value to the expanded one.

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:13 -05:00
Paul POULAIN
a201aac3c8 BUGFIX (major) : when editing an existing biblio, biblionumber was lost
In Koha 2.2 the biblionumber was an hidden field in the form,
exactly as any other subfield.
As we also stored biblionumber as specific field, it was useless to have it
twice.

with this commit, we restore the biblionumber in the MARC:Record in TransformHtml2Marc

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-04 16:35:22 -05:00
Henri-Damien LAURENT
56e38fa2f9 Modifying AddBiblio in order to fix some encoding bugs we had when modifying or adding a biblio.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-20 15:16:40 -05:00
Paul POULAIN
92f2909d57 reintroducing an important line in TransformeMarcToKoha
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-14 21:32:52 -05:00
Paul POULAIN
7612dacc6f show username instead of cardnumber
Signed-off-by: Chris Cormack <crc@liblime.com>

Note from Chris, this should probably be a system preference, some libraries want the cardnumber there.
2007-08-14 21:30:38 -05:00
Paul POULAIN
9a32fe85c2 This commit fixes a bug in biblio encoding. things were mixed up when reporting item(s) into the biblio, to UPDATE biblioitems.marcxml, after a biblio modif (in MARC editor).
So, deal carefully with this commit pls, and check it for your setups, because the patch works for me, but I'm not sure to understand well why :\

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-08-14 21:28:28 -05:00
toins
7f3265ccae Some new functions.
TransformHTMLtoMarc rewrited.
2007-07-31 16:01:11 +00:00
hdl
92adf782de Bug Fixing GetMarcSubjects.
Links parameters were mixed.
2007-07-20 15:43:16 +00:00
hdl
046f54eab5 Adding biblio.biblionumber to GetItemsfor Inventory 2007-07-20 14:02:57 +00:00
hdl
fbec734d57 Adding selection by location for inventory 2007-07-19 07:40:08 +00:00
tipaul
96386e6568 fixing some display bugs (itemtype not properly returned and a html table bug that makes items appear strangely 2007-07-03 13:47:44 +00:00
tipaul
83545f8449 return itemtype description properly 2007-07-03 09:40:58 +00:00
tipaul
a9403a8bba if you just replace su by a space in subjects, you'll replace jesus by je s, which is strange for users. this fix solves the problem and introduces authoritysep systempref as separator of subfields, for a better identification of where the authority starts and end 2007-07-03 09:33:05 +00:00
tipaul
43e23a2ca9 unimarc bugfix : the encoding is in field 100 in UNIMARC. when TransformHTMLtoXML on an item, you must not automatically add a 100 field in items, otherwise there will be 2 100 fields in the biblio, which is wrong 2007-07-02 09:13:22 +00:00
tipaul
014350b476 bugfixes on unimarc 100 handling (the field used for encoding) 2007-06-25 15:01:45 +00:00
tipaul
23427c51b9 some fixes (and only fixes) 2007-06-15 13:44:44 +00:00
toins
95f4785d58 do not get $3 $4 and $5 on GetMarcSubjects GetMarcAuthors on unimarc flavour. 2007-06-15 09:40:06 +00:00
toins
38f7d2148a removing warn compilation. 2007-06-13 13:03:34 +00:00
tipaul
67d1dcf1f7 various bugfixes (minor) and french translation updated 2007-05-23 16:19:40 +00:00
tipaul
5ff7fcffa4 Bugfixes & improvements (various and minor) :
- updating templates to have tmpl_process3.pl running without any errors
- adding a drupal-like css for prog templates (with 3 small images)
- fixing some bugs in circulation & other scripts
- updating french translation
- fixing some typos in templates
2007-05-22 09:13:54 +00:00
hdl
286930bdc7 Changing GetMarcStructure signature.
Deleting first parameter $dbh
2007-05-22 08:50:47 +00:00
btoumi
1e21ba6968 add security when u delete biblio :
u must delete linked items before delete biblio
2007-05-21 08:44:17 +00:00
btoumi
100385ab29 bug fix:
problem in  displayed label link  with subject in detail.tmpl
ex: label random => rdom
2007-05-11 16:04:03 +00:00
tipaul
ca201e36af Koha NoZebra :
- support for authorities
- some bugfixes in ordering and "CCL" parsing
- support for authorities <=> biblios walking

Seems I can do what I want now, so I consider its done, except for bugfixes that will be needed i m sure !
2007-05-10 14:45:15 +00:00
tipaul
03e2d1f969 BUGFIX for : NoZebra
- NoZebra features : seems they work fine now (adding, modifying, deleting)
- Biblio edition major bugfix : before this commit editing a biblio resulted in an item removal in marcxml field
2007-05-03 15:16:02 +00:00
tipaul
3e85c9e97f NoZebra SQL index management :
* adding 3 subs in Biblio.pm
- GetNoZebraIndexes, that get the index structure in a new systempreference (added with this commit)
- _DelBiblioNoZebra, that retrieve all index entries for a biblio and remove in a variable the biblio reference
- _AddBiblioNoZebra, that add index entries for a biblio.
Note that the 2 _Add and _Del subs work only in a hash variable, to speed up things in case of a modif (ie : delete+add). The effective SQL update is done in the ModZebra sub (that existed before, and dealed with zebra index).
I think the code has to be more deeply tested, but it works at least partially.
2007-05-02 16:44:31 +00:00
hdl
097fef712a Removing $dbh from GetMarcFromKohaField (dbh is not used in this function.) 2007-04-27 14:00:48 +00:00
tipaul
b53be9cdaf Koha 3.0 nozebra 1st commit : the script misc/migration_tools/rebuild_nozebra.pl build the nozebra table, and, if you set NoZebra to Yes, queries will be done through zebra. TODO :
- add nozebra table management on biblio editing
- the index table content is hardcoded. I still have to add some specific systempref to let the library update it
- manage pagination (next/previous)
- manage facets
WHAT works :
- NZgetRecords : has exactly the same API & returns as zebra getQuery, except that some parameters are unused
- search & sort works quite good
- CQL parser is better that what I thought I could do : title="harry and sally" and publicationyear>2000 not itemtype=LIVR should work fine
2007-04-25 16:26:42 +00:00
tipaul
4dea4d29b3 moving dotransfer to Biblio.pm::ModItemTransfer + some CheckReserves fixes 2007-04-24 09:07:53 +00:00