Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	08c03af2ae	Bug 18984: Remove NORMARC support Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Owen Leonard	7a10caccf8	Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Julian Maurice	3cfc2ec7bd	Bug 25067: Move PO file manipulation code into gulp tasks misc/translator/translate was doing three different things: - extract translatable strings - create or update PO files - install translated templates This patch separates responsibilities by moving the string extraction code into several 'xgettext-like' scripts and adds gulp tasks to automate string extraction and PO files update This has several benefits: - gulp runs tasks in parallel, so it's a lot faster (updating all PO files is at least 10 times faster with my 4-cores CPU) - there is no need for $KOHA_CONF to be defined LangInstaller.pm relied on $KOHA_CONF to get the different paths needed. I'm not sure why, since string extraction and PO update should work on source files, not installed files - string extraction code can be more easily tested This patch also brings a couple of fixes and improvements: - TT string extraction (strings wrapped in [% t(...) %]) was done with Template::Parser and PPI, which was extremely slow, and had some problems (see bug 24797). This is now done with Locale::XGettext::TT2 (new dependency) which is a lot faster, and fixes bug 24797 - Fix header in 4 PO files For backward compatibility, 'create' and 'update' commands of misc/translator/translate can still be used and will execute the corresponding gulp task Test plan: 1. Run `yarn install` and install Locale::XGettext::TT2 2. Run `gulp po:update` 3. Verify the contents of updated PO files 4. Run `cd misc/translator && ./translate install <lang>` 5. Verify that all (templates, sysprefs, xslt, installer files) is correctly translated 6. Run `gulp po:create --lang <lang>` and verify that it created all PO files for that language 7. Run `prove t/misc/translator` Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Need to install yarn & gulp, no errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	00b1bf3c2c	Bug 20168: (follow-up) Add automatic creation of RTL CSS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Tomás Cohen Arazi	a7e3c12e61	Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. It also replaces the use of 'gulp-util' (deprecated) by 'minimist' as recommended on their site. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	4b82ed3549	Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Owen Leonard	2df87a94f5	Bug 20427: Convert OPAC LESS to SCSS This patch converts the OPAC LESS files to SCSS. In the process of converting opac.less (and other .less files) to .scss, I have improved the completeness of the nesting, reordered properties, and in general done cleanup based on rules in .scss-lint.yml. All of these changes should have no impact on the style of the OPAC. This patch modifies the commands used to compile CSS so that OPAC and staff assets can be processed separately: 'yarn build' <-- Builds the staff client assets by default 'yarn build --view opac' <-- Builds OPAC assets To test, apply the patch and compile the CSS by running the command above (or apply the follow-up patch with compiled CSS). Do a thorough review of the OPAC, taking care to cover as many pages as possible and checking responsive behavior at the same time. There should be no visual differences in the OPAC before and after applying the patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Owen Leonard	5b35c97a84	Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago