Commit graph

228 commits

Author SHA1 Message Date
Kyle M Hall
879d7f0e6b Bug 1248 - Add a "quick spine label" print to the bib item page in cataloging
Turn on the system preference SpineLabelShowPrintOnBibDetails and a link for the spinelabel printer will appear for each item on catalogue/detail.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 07:36:09 -05:00
Matthias Meusburger
9f41fe64be MT 2050, Follow-up, Fast Cataloging
Adds granular permissions for cataloging
Also adds a link from the circulation home to fast cataloging when fast cataloging is active
2009-11-24 10:05:10 +01:00
Paul Poulain
ed047fead8 adding XSLT for intranet (UNIMARC only, MARC21 will be done by kf)
- the XSLTParse4Display sub now has a new parameter : the interface (intranet or opac)
- the XSLTdisplay sysprefs is common to staff & opac (Auth.pm)
- added UNIMARC xslt in intranet templates (modified to deal with staff/opac differences)
2009-11-10 22:23:50 +01:00
Matthias Meusburger
4a119ecb41 MT 2134 : Adds a tab for subscriptions in intranet's record detail 2009-11-04 09:19:36 +01:00
Matthias Meusburger
790b7cc1b9 MT 2037 : Update ISBD 2009-10-22 11:45:38 +02:00
Matthias Meusburger
f00a4a7cfb MT 1976 : Lists are directly displayed through VirtualShelves.pm
(and not through the session, like in opac)
2009-10-02 11:15:16 +02:00
Matthias Meusburger
2a81f0778e Ticket 1110 : Balance carts and lists
In Opac :
Print lists
Carts looks more like lists
Carts "More Details" And "Brief Display" toolbar looks more alike
In Admin :
Search results toolbar now have a "Add To" button for adding to a selected list with a confirmation pop-up, like in OPAC

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-30 11:30:41 +02:00
Matthias Meusburger
374c898122 Fix broken moredetail.pl 2009-09-30 11:30:30 +02:00
Paul Poulain
9ec04d23c4 catalogue/moredetail, removing & reindenting (not new_acq specific) 2009-09-30 11:30:16 +02:00
Jean-André Santoni
f7d5759a0d (bug #3555) This sets the default branch to the logged user branch when IndependantBranches is active
In the advanced search form, when IndependantBranches is activated, the default
branch should be set to the logged user branch.
2009-09-30 11:30:12 +02:00
Nahuel ANGELINETTI
1b5e2e83ed (bug #3550) use GetRecordValue to retrieve subtitle
This patch, is the first use of GetRecordValue, that use the Field mapping.
It retrieve the subtitle in Intranet using it, instead of the use an old function that doesn't work anymore.
This is a way to made koha more generic with each framework.
2009-09-30 11:30:11 +02:00
Henri-Damien LAURENT
6e55d55f06 C4::Search :Enhancements
Stemming is now available for more languages

Adding also getDistinctValues which gets distinct values for a zebra index or for a Mysql field

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:24 +02:00
Nahuel ANGELINETTI
17c831399f Delete unused function
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-29 19:53:04 -04:00
Nicole Engard
b9f4fa6260 Bug 1003 Added lists to bib details pages
This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page.  The same goes if virtualshelves
is turned OFF.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 12:58:36 -04:00
Chris Cormack
634df1c76c Bug 3539, Adding a systempreference to hide borrowers name on the catalogue detail page, and holds page
Squashed commit of the following:

commit e9dd6e1dee03fe3503f7995b57510f9edfe6b333
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:14:53 2009 +0000

    Version number

commit df3ee5473e79b760a91c62b96d7ce19229e0fd27
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:08:11 2009 +0000

    French systempref

commit c4b036e4e43947d7d1fb9f2e18e460788cb4e1ec
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 00:25:33 2009 +0000

    Code to update the database, and updating the sysprefs.sql

commit f74b942c24d5e9c33a4ec0e5ac706a0e347eb1a7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 02:07:22 2009 +0000

    Now hides the name on the detail screen too

commit 53c80dbef88e360a4bbb78ecff3a6ca6ec401398
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 01:35:19 2009 +0000

    Allowing the librarians to choose to hide the borrowers name on holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:52:26 -04:00
Nicole Engard
baa0b08149 ENH: 3525 - Link to OPAC View from Staff Bib
This patch adds a link to the OPAC view for a bib
record from the staff client so catalogers can
preview changes as the patrons see them.

This patch only shows the link is the OPACBaseURL
system preference has a value.

[RM note re bug 2152: this is probably enough to keep
 OPACBaseURL after all - the staff interface has
 no other way of reliably knowing where the OPAC
 is.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:50:16 -04:00
Garry Collum
54dad0143c Bug 3428: Alphabetizes the collection codes in the Advanced Search.
If the advancedSearchTypes = CCODE, the code descriptions are not alphabetized, as opposed to itemtypes, which are alphabetized.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 21:24:54 -04:00
Joe Atzberger
af1fb6f0b4 Bug 2539. Remove unintegrated "spsuggest" code from search scripts.
The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:20:25 -04:00
Nahuel ANGELINETTI
79fc6d81f7 (bug #3267) show items.uri in opac and intranet
This add a column in normal view, with a link to items.uri URL if it exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 08:26:33 -04:00
Galen Charlton
38b3eacde0 bug 2641, 3263: minor fixes to labeled MARC view
* fixed to XHTML validation errors
* corrected copyright statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:35 -05:00
Rick Welykochy
7504a1bb5a bug 2641, 3263: Staff Search Results Interface Changes
New detail view: labeled MARC

New bib record view in the staff interface that
displays the MARC record in a single page.

Featured sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:27 -05:00
Galen Charlton
17ab0a7532 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:20 -05:00
Galen Charlton
3cfa84362f bug 3219: handle variation in Amazon responses
An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:20 -05:00
Galen Charlton
3f49ad62c8 bug 3236: remove disused scripts and a function
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files.  According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.

Also removed C4::Search::findseealso(), which was used
only by the two scripts.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-20 08:37:58 -05:00
33fffbcfd6 Bug 2920 Fixes Amazon content use in pro interface
This patch fixes Amazon content use in pro interface :

* Control Amazon Editorial Review by a new syspref:
  AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
  It displays only Editorial review in Description tab.
  This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
  Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:53:34 -05:00
199ec1473a Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services
This patch modifies how AWS is called. AWS is now called
depending on syspref. It works completly for OPAC; it
has to be refined for intranet.

For OPAC:

  * If OPACAmazonReviews is set, AWS EditorialReview and
    Reviews (users) are grabed.
  * If OPACAmazonSimilarItems is set, AWS Similarities info
    are grabed.
  * If nothing is asked, AWS is not called anymore,
    sparing server bandwidth.

For intranet:

  It works as it used to work. AWS is called if AmazonEnabled
  is set whatever how other syspref are set.

  TODO:

    * Add a AmazonReviews syspref
    * Request Amazon content depending on AmazonSimilarities
      and AmazonReviews syspref

DOCUMENTATION:

  It should be explained that Amazon services related syspref
  have two levels:

  * AmazonEnable / OPACAmazonEnable
  * Other: OPACAmazonReviews (new), OPACAmazonSimilarProduct,
    OPACAmazonCover

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:36:14 -05:00
Joe Atzberger
28a7b360be Block warning on detail.pl.
If Amazon doesn't have an avg. rating number defined, then we cannot multiply it
by 20 without the following warning:

    detail.pl: Use of uninitialized value in multiplication (*)
    at /home/user/kohaclone/catalogue/detail.pl line 228.

So the important part of this patch is || 0 on the $average_rating assignment.

[RM note: applying for whitespace cleanup]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:02:34 -05:00
Paul Poulain
444601a4d1 fix for #1731
The "place hold" button is hidden in detail.pl when there are no items or the
items are not for loan. MARC detail should do the same.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 18:38:45 -05:00
Galen Charlton
6a2a4e146e fix various warnings
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
  (displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
  (attemping to calculate average Amazon rating if no Amazon info
   is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
  (attempting to calculate length of $isbn if it happens to be undef)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 15:54:19 -05:00
Galen Charlton
684cea4309 bug 3049: display correct due date of renewed loans
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:32 -05:00
Nahuel ANGELINETTI
89c062c44b (bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view
this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 11:16:34 -05:00
Galen Charlton
2e08f626f5 remove incomplete bib bulk editing code
Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-06 10:53:50 -05:00
Joshua Ferraro
65ddce02f2 Serials Display Enhancement
Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-03 16:41:38 -05:00
Mason James
81e5fdd249 BUG-1503: fixes broken matching for 'hidden' values.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:32 -05:00
Joshua Ferraro
3d65e44d5c Syndetics and Amazon bugfix enhancements
This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
69c74c06ae Move Amazon.pm to External/ directory
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
Galen Charlton
d97ba8cecc bug 2747: avoid warning if items.itype is NULL
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-07 15:33:21 -06:00
Joe Atzberger
458b0ed510 GetAuthValCode calls were positioned inside the loop,
despite the same values being supplied each time.  Then
the conditional assignments would repeat the same calls again!
That means execution was liable to query the DB at least once
and as many as four times per item.  With a large number of items
this is an unnecessary burden.  By moving the calls outside
the loop, we can guarantee that we never have to call the DB for
that info more than twice (once for lost, once for damaged).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-07 15:11:17 -06:00
Andrew Moore
17d0f7d4ec REFACTOR: correcting indirect object method syntax
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:26:41 -06:00
Andrew Moore
a5ca358d04 Bug 2505: turning on "warnings" in catalogue/detail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 19:26:39 -06:00
Mason James
990e315471 The current searching in labels is a bit minimal, and current only does keyword searching.
there is some old 2.2 code for more complete labels-searching, thats been commented out

ive logged a 'bug' for this - 2777

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2777

this fix...
  - enables the index-searching functionality
  - adds date-ranges
  - uses the numSearchResults syspref, not a hardcoded '20'
  - rewrote old 2.2 page-num code, (didnt work for 3.x)
  - some indent and whitepages tidys.
  - unused 2.2 search-code removed.

Mason

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 11:15:44 -06:00
Nahuel ANGELINETTI
31c6cd032b (bug #2881) preselect default sorting
This patch just set a variable with the name of default sorting, and value 1

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-31 11:10:31 -06:00
John Beppu
c15e1206fd bug 2874 [3/3] flagsrequired => { circulate => "circulate_remaining_permissions" }
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:04 -06:00
Galen Charlton
083e8d9a06 remove superfluous retrieval of $ENV{'REMOTE_USER'}
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:03:43 -06:00
Danny Bouman
cd2bf6e70a bug 2817: Added support to pull Amazon information based on UPC, EAN, and 13-digit ISBN
By adding support for UPC,EAN and 13-digit ISBN we are able to pull much more content from Amazon, especially on most music and dvd content which
does not have an ISBN.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:05:30 -06:00
Galen Charlton
4bf76c2d77 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:05:08 -05:00
Joe Atzberger
126920f470 moredetail.pl is not an Exporter.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:21:55 -05:00
Ryan Higgins
5b1f566497 Remove acquisitions permission requirement on catalogue/showmarc.pl
This script is linked to from z39.50 search as well as acquisitions.
cataloguing/z3950_search.pl requires only the 'catalogue' flag, so
requiring only that permission here.  A user without acquisitions permissions
would get a login instead of the record display without this change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:19:37 -05:00
ebc305bddf Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:50:19 -05:00
6f1ce35d6c Fix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation of subfield descriptions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:46:20 -05:00