Commit graph

821 commits

Author SHA1 Message Date
Emily Lamancusa
d683e6fc2c
Bug 35925: Adjust default purchase suggestion notices to use TT
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Set syspref EmailPurchaseSuggestions to "email address of library"
4. Under Administration > Libraries, enter an email address for at least
   one library
5. Go to "my account", and enter a Primary email and Phone number
6. Go to the Acquisitions module > Suggestions page
7. Click "New purchase suggestion", and fill in values for, at minimum:
    Bibliographic information:
        Title
        Author
        Copyright date
        ISBN/ISSN
        Publisher
        Publication place
        Collection title
        Document type
        Reason for suggestion
        Notes
    Acquisition information:
        Library (set to the library you entered an email for in step 4)
        Copies
8. Submit the suggestion
9. Set the suggestion status to "Rejected"
    a. Check the checkbox next to the suggestion
    b. Set the "Mark selected as" drop-down (below the table) to Rejected
    c. Select a value for the "Reason" drop-down
    d. Click the Submit button
10. Set the suggestion status to "Accepted" (as above)
11. Set the suggestion status to "Ordered" (as above)
12. Return to "my account" and open the Notices tab
--> There should be notices suggestion declined, suggestion accepted,
    suggestion ordered, and (depending on settings) new suggestion*
13. Open each notice, and confirm the all information was filled in
    correctly

* New suggestion will be there if you're using default KTD settings/data
and logged in as the root user. If it is not there, query the database
(by command line or SQL report) to see the generated notice text:
SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:05 +02:00
Emily Lamancusa
e9540c6a1f
Bug 36106: Adjust DUE and PREDUE notices to use TT
To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable SMS Notices
    a) Find the system preference SMSSendDriver
    b) Enter "Email" as the value for SMSSendDriver and save
4. Go to a patron account, and set the following messaging preferences:
    Item due:
        - Check SMS
        - Check Email
        - Leave Digests only unchecked
    Advance notice
        - Select 1 day in advance
        - Check SMS
        - Check Email
        - Leave Digests only unchecked
5. Go to the checkout tab for that patron
6. Set a custom due date for today and check out an item
7. Set a custom due date for tomorrow and check out another item
8. Run the cron job to generate notices:
   misc/cronjobs/advance_notices.pl -v -c
9. Open the Notices tab on that patron's account
--> The patron should have four notices:
    Item due reminder (one for SMS and one for email)
    Advance notice of item due (one for SMS and one for email)
10. Open each notice and confirm that all information is correct

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:04 +02:00
Emily Lamancusa
6af529879c
Bug 36126: Adjust default HOLD notices to use TT
To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable SMS Notices
    a) Find the system preference SMSSendDriver
    b) Enter "Email" as the value for SMSSendDriver and save
4. Go to a patron account, and set the following messaging preferences:
    Hold filled:
        - Check SMS
        - Check Email
        - Leave Digests only unchecked
5. Leave SMS number and all email address fields blank for that patron
6. Place a hold for that patron
7. Check in an item to fill the hold
8. Open the Notices tab on that patron's account
--> The patron should have a Print "hold filled" notice, since they
don't have an email address or SMS number in the system
9. Add a Primary email and SMS number to the patron account
10. Place another hold for that patron
11. Check in an item to fill the hold
12. Go back to the Notices tab on that patron's account
--> The patron should now have Email and SMS "hold filled" notices as well
13. Open each notice and confirm that all information is correct

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:04 +02:00
Emily Lamancusa
8026d8b24c
Bug 36113: Adjust default RENEWAL notice template to use TT
Test plan:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable the system preference RenewalSendNotice
4. Check an item out to a patron
5. Edit that patron:
    a. Enter a value for Primary email
    b. Set messaging preference to enable email notices for Item
       checkout and renewal
6. Renew the checked-out item
7. Check the patron's Notices tab for the Item renewal notice, and
   confirm that the notice is correct

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:03 +02:00
Emily Lamancusa
4b2716c86c
Bug 36125: (follow-up) Use $KohaDates
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:03 +02:00
Emily Lamancusa
296b4c11e5
Bug 36125: Adjust default HOLD_SLIP to use TT
To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Find a patron and make sure their account contains values for
   all of the following fields:
   First name
   Surname
   Card number
   Phone
   Address
   Address 2
   City
   Zipcode
   Email
4. Place a hold for this patron, specifying a hold note
5. Check in an item to fill the hold and click "Confirm and print slip"
6. Confirm that all information on the hold slip is correct

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:02 +02:00
Emily Lamancusa
4380508ece
Bug 36608: Adjust TO_PROCESS and AVAILABLE to use TT
To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Go to "my account", and enter a Primary email
4. Under Administration > Libraries, enter an email address for at least
   one library
5. Add the demo user (koha) as the owner of the Main Fund
    a) Go to the Acquisitions module
    b) Click on Main Fund
    c) Click the Actions button at the end of Main Fund row > click Edit
    d) Click "Select owner"
    e) Search for "koha"
    f) Click the Select button
    g) Click Submit
6. Click "Suggestions" on the left side of the page, and click "New
   purchase suggestion"
7. Fill in values for, at minimum:
    Bibliographic information:
        Title
        Author
    Acquisition information:
        Library (set to the library you entered an email for in step 4)
        Fund (set to Main Fund)
9. Submit the suggestion
10. Run the cron job to generate TO_PROCESS notification email:
misc/cronjobs/notice_unprocessed_suggestions.pl -v -c --days=0
11. Set the new suggestion to "Accepted"
    a) Check the checkbox next to the new suggestion
    b) Below the table, set "Mark selected as" drop-down to "Accepted"
    c) Click Submit
12. Create an order from the purchase suggestion
    a) Return to the Acquisitions homepage
    b) Leave the Vendor field blank and click Search
    c) Next to the sample basket (My Basket), click "Add to basket"
    d) Click "From a suggestion"
    e) Click "+ Order" next to the suggestion
    f) Make sure there are values for all required item fields
    g) Click "Add item"
    h) Click Save
13. Close the basket and receive the order
    a) Click "Close basket" and click "Yes, close"
    b) Click "Receive shipments"
    c) Enter a number in "Vendor invoice" and click Next
    d) Check the checkbox next to "My Basket" and click "Receive
       selected" button
    e) Check the checkbox under "Receive?" in the Items table
    f) Click Confirm
14. Return to "my account" and open the Notices tab
--> There should be (among others) notices for "A suggestion is ready to
    be processed" and "Suggested purchase available"
15. Open each of the above two notices, and confirm all the information
    was filled in correctly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-10 15:19:02 +02:00
9e996fc466
Bug 31097: Update restriction type display text
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-08 18:23:50 +02:00
Caroline Cyr La Rose
356efc42b8
Bug 36247: MARC21 Addition to relator terms in technical notice 2024-02-27
This patch adds the relator code gdv (Game developer) in the list of
MARC21 relator terms in Koha.

To test:
1. Apply patch and reset_all
2. Go to Administration > Authorized values > RELTERMS
3. Search for gdv
   --> The new relator code should be there with its corresponding term
       "Game developer"

Note: this is added in the installer files. It will not affect existing
installations. For existing installations, add the new relator code in
Administration > Authorized values > RELTERMS.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-06 11:18:11 +02:00
Caroline Cyr La Rose
77aa7722e1
Bug 36108: Update MARC21 default framework to Update 37 (December 2023)
This patch updates the default MARC21 framework to reflect the changes
brought by Update 37 (December 2023).

To test:
1. Apply patch and reset_all
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/bibliographic/bdapndxg.html

- Two subfields of 022 should be marked as obsolete
  - l ISSN-L [OBSOLETE]
  - m Canceled ISSN-L [OBSOLETE]

- There should be a new field 023, named CLUSTER ISSN
  - This field should be repeatable
  - Subfields:
    - 0 Authority record control number or standard number (NR)
    - 1 Real World Object URI (R)
    - 2 Source (NR)
    - 6 Linkage (NR)
    - 8 Field link and sequence number (R)
    - a Cluster ISSN (NR)
    - y Incorrect Cluster ISSN (R)
    - z Canceled Cluster ISSN (R)

- There should be one new subfield in field 532
  - 3 Materials specified (NR)

5. Optional: run the framework test in Administration > MARC
   bibliographic framework test
   --> All should be OK

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-05-06 11:18:11 +02:00
5a03a66453
Bug 34793: (QA follow-up): forgotten 'Cookie consents'=>'Cookies policy'
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-26 11:21:17 +01:00
71a41086ef
Bug 34793: (follow-up) Add table classes to popup
This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-26 11:21:16 +01:00
Aude Charillon
df8540cadf
Bug 34793: Add default HTML Customisations for cookie information
This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-26 11:21:15 +01:00
Caroline Cyr La Rose
49a7950f38
Bug 34663: Errors in UNIMARC default framework
This patch corrects the default UNIMARC bibliographic framework to
place all the 4XX subfields in tab 4.

To test:
1. Go to Administration > MARC Bibliographic framework test
   --> There should be errors indicating subfields from 4XX fields
       are in tabs 3 and 4
2. Apply patch and reset_all
3. Redo step 1
   --> It should now say that all subfields for each tag are in the
       same tab (or ignored)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-03-25 09:53:17 +01:00
Aleisha Amohia
b62699dff0
Bug 17617: Add HOLDPLACED_PATRON notice
A HOLDPLACED notice exists and is used by the emailLibrarianWhenHoldIsPlaced function, but libraries may want to use different wording when emailing patrons.

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-11-08 11:41:25 -03:00
19dd4c0f42
Bug 35187: (follow-up) Use <br> consistently over <br />
The first patch highlighted a minor inconsistency to me and this patch
just brings us closer to html5 consistency throughout the notices by
replacing any existing occurences of `<br />` and `<br/>` with the
recommended `<br>`.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-11-06 11:34:42 -03:00
Katrin Fischer
7ed41b65a4
Bug 35187: Make sure HTML notices use explicit line breaks
When a notices is marked as HTML, we need to use block elements
(p, div, li, etc.) or explicit line breaks.
This adds the line breaks where required.

Affects:

* ISSUEQSLIP
* ISSUESLIP
* TRANSFERSLIP
* CHECKINSLIP
* HOLD_SLIP
* WELCOME

The biggest change is the WELCOME notices. With this patch
it appears no longer on only one line, but properly formatted.

To test:

WELCOME
* Without patch
* Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress)
* Make sure your patron has an email set
* In patron account, use "More > Welcome email"
* Verify all text is on one line
* Apply patch
* reset_all to install new sample notice templates
* Repeat test, verify welcome notice is now nice

ISSUESLIP, ISSUEQSLIP
* Checkout at least 2 items
* Print > Print slip
* Print > Print quick slip
* Verify both look nice!

CHECKINSLIP
* Return both items
* Print checkin slip (button in list of checkouts)
* Verfiy... you know, that it looks nice!

TRANSFERSLIP
* Checkin an item from another library
* "Print transfer slip"
* Verify again.

HOLD_SLIP
* Place a hold on a record
* Return an item that can fill the hold
* "Print slip and confirm"
* Verify.
* Note: if you compare to before, this also removes a <> appearing instead
  of the city.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-11-06 11:34:41 -03:00
Katrin Fischer
c6284eed81
Bug 35185: Remove is_html flag from sample notices that are plain text
Some notices had the is_html flag for new installations, but actually
didn't include any HTML formatting. These should be plain text
to have the line breaks behave as expected.

This updates:
* 2FA_OTP_TOKEN
* OPAC_REG_VERIFY

We cannot do a database update here, as libraries will
have changed and updated these. So this is only for new
installations.

To test:
* Apply patch
* reset_all (create a new sample database)
* Verify that the HTML checkbox is not set for these notices
* Verify they appear as plain text notices, not including HTML tags

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-11-03 12:04:36 -03:00
b02c7bd00b
Bug 34587: Copy authorised value categories and authorised values to new installs
(cherry picked from commit 338ae09e692420fe783da1699386b14891af62ab)

Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-31 16:46:05 -03:00
Katrin Fischer
e772b96cac
Bug 35186: Remove unnecessary html tags from PASSWORD notices
In HTML notices we don't need to explicitly use <html></html>.

This removes them from the 2 notices using them:
* PASSWORD_RESET
* STAFF_PASSWORD_RESET

To test:
* Apply patch
* Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress)
* Make sure your patron has an email set
* In patron account, use "More > Send password reset"
* Log out
* In the OPAC, request password reset ("forgot your password?")
* Verify both notices appear nicely formatted (line breaks, bold, etc.)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-31 11:02:49 -03:00
5fea2e431a
Bug 34924: Adjust auto renewal email to reflect success for final renewals
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-31 11:02:48 -03:00
cc0a8bf423
Bug 34924: Handle final renewal errors
This patch updates Koha::Checkout->attempt_auto_renew to renew when the 'final' errors are passed, and to pass the error value back to the cronjob for processing

The sample notice for AUTO_RENEW and AUTO_RENEW_DGST are both updated to handle the new error

On the next cron the error will be updated to too_many or too_unseen, but a notice will not be sent.

To test:
 0 - Run reset_all to install the updated sample notices or copy the text
 1 - Set system preference UnseenRenewals to 'Allow'
 2 - Setup a circ rule to allow 2 renewals, 2 unseen renewals
 3 - Checkout an item to a patron who has an email defined and auto renewals selected in messaging preferences
 4 - Update the issue to be due/overdue:
    UPDATE issues SET date_due=DATE_SUB(NOW(), INTERVAL 1 DAYS);
 5 - perl misc/cronjobs/automatic_renewals.pl -v -c
 6 - Confirm patron notified and issue renewed
 7 - Set issue due/overdue again
 8 - perl misc/cronjobs/automatic_renewals.pl -v -c
 9 - Confirm patron notified of final unseen renewal
10 - perl misc/cronjobs/automatic_renewals.pl -v -c
11 - Confirm issue not renewed, patron not notified
12 - Update circ rules t all 4 renewals total
13 - Force renewal on staff side to clear unseen
14 - perl misc/cronjobs/automatic_renewals.pl -v -c
15 - Confirm patron notified of final renewal (allowed 4, 2 unseen from cron, 1 manual, this unseen from cron)
16 - perl misc/cronjobs/automatic_renewals.pl -v -c
17 - Confirm patron not notified, issue not renewed

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-31 11:02:47 -03:00
de63f6eb75
Bug 8838: Add SMS default/sample notices
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-25 11:07:50 -03:00
358272ebbc
Bug 8838: (follow-up) Rebase, fix typos, and tidy.
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-25 11:07:49 -03:00
fde91e178d
Bug 8838: Add digest option for HOLD notice
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new digest option for "Hold filled" messages
5) Trap multiple holds for a patron
6) Note a single notices is generated for all the trapped holds!

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Laura ONeil <laura@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-25 11:07:48 -03:00
ddca40a5d4
Bug 33547: Display AV descriptions instead of codes
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: BULAC - http://www.bulac.fr/
Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov>
Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-23 11:33:52 -03:00
10649d4921
Bug 33547: Add print slip
Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: BULAC - http://www.bulac.fr/
Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov>
Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-23 11:33:51 -03:00
aaae302382
Bug 31383: DB changes
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-20 14:43:58 -03:00
fc83fb3ebb
Bug 30719: (QA follow-up) Squash:
This is a squash of 25 QA patches located at:
    https://github.com/PTFS-Europe/koha/commits/new_30719

Bug 30719: (QA follow-up) Batch column should be hidden by default
Bug 30719: (QA follow-up) Fix wrong tt filter type
Bug 30719: (QA follow-up) Make atomicupdate idempotent
Bug 30719: (QA follow-up) Use COMMENT syntax in database files
Bug 30719: (QA follow-up) Fix tiny boolean is_system
Bug 30719: (QA follow-up) Add missing CONSTRAINT entries from kohastructure.sql to the atomicupdate file
Bug 30719: (QA follow-up) Add missing koha_object_class and
koha_objects_class methods
Bug 30719: (QA follow-up) Swap search to find
Bug 30719: (QA follow-up) Fix tests
Bug 30719: (QA follow-up) API terminology - id -> batch_id
Bug 30719: (QA follow-up) API terminology - borrowernumber -> patron_id
Bug 30719: (QA follow-up) API terminology - branchcode -> library_id
Bug 30719: (QA follow-up) Make mandatory illbatch_statuses translatable
Bug 30719: (QA follow-up) Improve translatability
Bug 30719: (QA follow-up) Fix capitalization of Interlibrary Loan
Bug 30719: (QA follow-up) Change Branch to Library in ILL batches table
Bug 30719: (QA follow-up) Add template WRAPPER to batch statuses breadrcrumbs
Bug 30719: (QA follow-up) Utilize patron_to_html function to display patron info in batches table
Bug 30719: (QA follow-up) Add mandatory batch statuses to the atomicupdate
Bug 30719: (QA follow-up) Add page-section to the batch statuses list page
Bug 30719: (QA follow-up) Style Save button on batch status edit page
Bug 30719: (QA follow-up) Add question mark to label string, rephrase new ILL batch button
Bug 30719: (QA follow-up) Add noExport class to action columns in batch list table and batch modal table
Bug 30719: (QA follow-up) Add page-section and headers to ILL batch table
Bug 30719: (QA follow-up) Perltidy

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-17 14:45:18 -03:00
a912709898
Bug 28688: Add new notice MEMBERSHIP_RENEWED
Test plan:
Run new install or upgrade.
Check for this notice under Tools/Notices.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Enrollment fee via object instead of substitute hash.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-10 09:22:29 -03:00
Caroline Cyr La Rose
c92f23901e
Bug 34667: Update MARC21 default framework to Update 36 (June 2023)
This patch updates the default MARC21 framework to reflect the changes brought by Update 36 (June 2023).

To test:
1. Apply patch and restart
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update https://www.loc.gov/marc/bibliographic/bdapndxg.html

- There should be one new subfield in field 041
  - 3 Materials specified (NR)

- There should be a new field 361, named STRUCTURED OWNERSHIP AND CUSTODIAL HISTORY
  - This field should be repeatable
  - Subfields:
    - 0 Authority record control number or standard number (R)
    - 1 Real World Object URI (R)
    - 3 Materials specified (NR)
    - 5 Institution to which field applies (NR)
    - 6 Linkage (NR)
    - 7 Data provenance (R)
    - 8 Field link and sequence number (R)
    - a Name (NR)
    - f Ownership and custodial history evidence term (R)
    - k Formatted date (NR)
    - l Date (NR)
    - o Type of ownership and custodial history information (R)
    - s Shelf mark of copy described (NR)
    - u Uniform Resource Identifier (R)
    - x Nonpublic note (R) **This should not be visible in the OPAC
    - y Identifier of the copy described (NR)
    - z Public note (R)

- There should be three new subfields in field 653
  - 0 Authority record control number or standard number (R)
  - 1 Real World Object URI (R)
  - 5 Institution to which field applies (NR)

- There should be two new subfields in field 658
  - 0 Authority record control number or standard number (R)
  - 1 Real World Object URI (R)

- There should be four new subfields in field 720
  - 0 Authority record control number or standard number (R)
  - 1 Real World Object URI (R)
  - 5 Institution to which field applies (NR)
  - 7 Data provenance (R)

- There should be a new field 857, named ELECTRONIC ARCHIVE LOCATION AND ACCESS
  - This field should be repeatable
  - Subfields
    - 2 Access method (NR)
    - 3 Materials specified (NR)
    - 5 Institution to which field applies (NR)
    - 6 Linkage (NR)
    - 7 Access status (NR)
    - 8 Field link and sequence number (R)
    - b Name of archiving agency (NR)
    - c Name of Web archive or digital archive repository (NR)
    - d Date range of archived material (NR)
    - e Data provenance (R)
    - f Archive completeness (NR)
    - g Persistent identifier (R)
    - h Non-functioning Uniform Resource Identifier (R)
    - l Standardized information governing access (R)
    - m Contact for access assistance (R)
    - n Terms governing access (R)
    - q Electronic format type (R)
    - r Standardized information governing use and reproduction (R)
    - s File size (R)
    - t Terms governing use and reproduction (R)
    - u Uniform Resource Identifier (R)
    - x Nonpublic note (R)
    - y Link text (R)
    - z Public note (R)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:39 -03:00
Caroline Cyr La Rose
abd249d1ee
Bug 34665: Update MARC21 default framework to Update 35 (Dec. 2022)
This patch updates the default MARC21 framework to reflect the changes brought by Update 35 (December 2022).

To test:
1. Apply patch and restart
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update https://www.loc.gov/marc/up35bibliographic/bdapndxg.html

- There should be one new subfield in field 856
  - g Persistent identifier (R)
  - Subfield h should now be named Non-functioning Uniform Resource Identifier
  - Subfield q should now be repeatable

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:39 -03:00
Caroline Cyr La Rose
a969ca1472
Bug 34659: Update MARC21 default framework to Update 34 (July 2022)
This patch updates the default MARC21 framework to reflect the changes brought by Update 34 (July 2022).

To test:
1. Apply patch and restart
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update https://www.loc.gov/marc/up34bibliographic/bdapndxg.html

- There should be one new subfield in field 041
  - 7 Data provenance (R)

- There should be one new subfield in field 082
  - 7 Data provenance (R)

- There should be one new subfield in field 083
  - 7 Data provenance (R)

- There should be one new subfield in field 084
  - 7 Data provenance (R)

- There should be one new subfield in field 100
  - 7 Data provenance (R)

- There should be one new subfield in field 110
  - 7 Data provenance (R)

- There should be one new subfield in field 111
  - 7 Data provenance (R)

- There should be one new subfield in field 130
  - 7 Data provenance (R)

- There should be one new subfield in field 210
  - 7 Data provenance (R)

- There should be one new subfield in field 240
  - 7 Data provenance (R)

- There should be one new subfield in field 245
  - 7 Data provenance (R)

- There should be one new subfield in field 246
  - 7 Data provenance (R)

- There should be one new subfield in field 247
  - 7 Data provenance (R)

- There should be one new subfield in field 250
  - 7 Data provenance (R)

- There should be one new subfield in field 255
  - 7 Data provenance (R)

- There should be one new subfield in field 256
  - 7 Data provenance (R)

- There should be one new subfield in field 264
  - 7 Data provenance (R)

- There should be one new subfield in field 300
  - 7 Data provenance (R)

- There should be one new subfield in field 335
  - 7 Data provenance (R)

- There should be one new subfield in field 336
  - 7 Data provenance (R)

- There should be one new subfield in field 340
  - q Reduction ratio designator (R)
  - Subfield f should now be named Reduction ratio value

- There should be one new subfield in field 348
  - 7 Data provenance (R)

- There should be one new subfield in field 370
  - 7 Data provenance (R)

- There should be one new subfield in field 377
  - 7 Data provenance (R)

- There should be one new subfield in field 380
  - 7 Data provenance (R)

- There should be one new subfield in field 381
  - 7 Data provenance (R)

- There should be one new subfield in field 382
  - 7 Data provenance (R)

- There should be one new subfield in field 383
  - 7 Data provenance (R)

- There should be one new subfield in field 384
  - 7 Data provenance (R)

- There should be one new subfield in field 385
  - 7 Data provenance (R)

- There should be one new subfield in field 386
  - 7 Data provenance (R)

- There should be a new field 387, named REPRESENTATIVE EXPRESSION CHARACTERISTICS
  - This field should be repeatable
  - Subfields:
    - 0 Authority record control number or standard number (R)
    - 1 Real World Object URI (R)
    - 2 Source of term (NR)
    - 3 Materials specified (NR)
    - 6 Linkage (NR)
    - 7 Data provenance (R)
    - 8 Field link and sequence number (R)
    - a Aspect ratio of representative expression (R)
    - b Color content of representative expression (R)
    - c Content type of representative expression (R)
    - d Date of capture of representative expression (R)
    - e Date of representative expression (R)
    - f Duration of representative expression (R)
    - g Intended audience of representative expression (R)
    - h Language of representative expression (R)
    - i Place of capture of representative expression (R)
    - j Projection of cartographic content of representative expression (R)
    - k Scale of representative expression (R)
    - l Script of representative expression (R)
    - m Sound content of representative expression (R)

- There should be one new subfield in field 388
  - 7 Data provenance (R)

- There should be one new subfield in field 490
  - 7 Data provenance (R)

- There should be one new subfield in field 500
  - 7 Data provenance (R)

- There should be one new subfield in field 501
  - 7 Data provenance (R)

- There should be one new subfield in field 502
  - 7 Data provenance (R)

- There should be one new subfield in field 505
  - 7 Data provenance (R)

- Field 507 should now be named SCALE NOTE FOR VISUAL MATERIALS

- There should be one new subfield in field 508
  - 7 Data provenance (R)

- There should be one new subfield in field 510
  - 7 Data provenance (R)

- There should be one new subfield in field 515
  - 7 Data provenance (R)

- There should be one new subfield in field 518
  - 7 Data provenance (R)

- There should be one new subfield in field 520
  - 7 Data provenance (R)

- There should be one new subfield in field 533
  - y Data provenance (R)

- There should be one new subfield in field 546
  - 7 Data provenance (R)

- There should be one new subfield in field 550
  - 7 Data provenance (R)

- There should be one new subfield in field 555
  - 7 Data provenance (R)

- There should be one new subfield in field 583
  - 7 Data provenance (R)

- There should be one new subfield in field 600
  - 7 Data provenance (R)

- There should be one new subfield in field 610
  - 7 Data provenance (R)

- There should be one new subfield in field 611
  - 7 Data provenance (R)

- There should be one new subfield in field 630
  - 7 Data provenance (R)

- There should be one new subfield in field 648
  - 7 Data provenance (R)

- There should be one new subfield in field 650
  - 7 Data provenance (R)

- There should be one new subfield in field 651
  - 7 Data provenance (R)

- There should be one new subfield in field 653
  - 7 Data provenance (R)

- There should be one new subfield in field 655
  - 7 Data provenance (R)

- There should be one new subfield in field 700
  - 7 Data provenance (R)

- There should be one new subfield in field 710
  - 7 Data provenance (R)

- There should be one new subfield in field 711
  - 7 Data provenance (R)

- There should be one new subfield in field 751
  - 7 Data provenance (R)

- There should be one new subfield in field 760
  - l Data provenance (R)

- There should be one new subfield in field 762
  - l Data provenance (R)

- There should be one new subfield in field 765
  - l Data provenance (R)

- There should be one new subfield in field 767
  - l Data provenance (R)

- There should be one new subfield in field 770
  - l Data provenance (R)

- There should be one new subfield in field 772
  - l Data provenance (R)

- There should be one new subfield in field 773
  - l Data provenance (R)

- There should be one new subfield in field 774
  - l Data provenance (R)

- There should be one new subfield in field 775
  - l Data provenance (R)

- There should be one new subfield in field 776
  - l Data provenance (R)

- There should be one new subfield in field 777
  - l Data provenance (R)

- There should be one new subfield in field 780
  - l Data provenance (R)

- There should be one new subfield in field 785
  - l Data provenance (R)

- There should be one new subfield in field 786
  - l Data provenance (R)

- There should be one new subfield in field 787
  - l Data provenance (R)

- There should be a new field 788, named PARALLEL DESCRIPTION IN ANOTHER LANGUAGE OF CATALOGING
  - This field should be repeatable
  - Subfields:
    - 4 Relationship (R)
    - 5 Institution to which field applies (NR)
    - 6 Linkage (NR)
    - 8 Field link and sequence number (R)
    - a Main entry heading (NR)
    - b Edition (NR)
    - d Place, publisher, and date of publication (NR)
    - e Language of cataloging (NR)
    - i Relationship information (R)
    - l Data provenance (R)
    - n Note (R)
    - s Uniform title (NR)
    - t Title (NR)
    - w Record control number (R)
    - x International Standard Serial Number (NR)

- There should be one new subfield in field 800
  - y Data provenance (R)

- There should be one new subfield in field 810
  - y Data provenance (R)

- There should be one new subfield in field 811
  - y Data provenance (R)

- There should be one new subfield in field 830
  - y Data provenance (R)

- There should be one new subfield in field 856
  - e Data provenance (R)
  - Subfield l is renamed Standardized information governing access (R)
  - Subfield n is renamed Terms governing access (R)
  - Subfield r is renamed Standardized information governing use and reproduction (R)
  - Subfield t is renamed Terms governing use and reproduction (R)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:38 -03:00
Caroline Cyr La Rose
50be9447d7
Bug 34658: Update MARC21 default framework to Update 33 (Nov. 2021)
iThis patch updates the default MARC21 framework to reflect the changes brought by Update 33 (November 2021).

To test:
1. Apply patch and restart
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update https://www.loc.gov/marc/up33bibliographic/bdapndxg.html

- There should be a new subfield in field 340
  - l Binding (R)

- There should be a new subfield in field 344
  - j Original capture and storage technique (R)

- There should be two new subfields in field 490
  - y Incorrect ISSN (R)
  - z Canceled ISSN (R)
  **Note that subfield 7 was added in a later update and is therefore not included in this patch

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:37 -03:00
Caroline Cyr La Rose
7ddf859367
Bug 34649: (fixup) Update MARC21 default framework to Update 32 (June 2021)
Fixes a small typo that prevented the yaml from loading correctly

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:36 -03:00
Caroline Cyr La Rose
1e47e7da94
Bug 34649: Update MARC21 default framework to Update 32 (June 2021)
This patch updates the default MARC21 framework to reflect the changes brought by Update 32 (June 2021).

To test:
1. Apply patch and restart
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update https://www.loc.gov/marc/up32bibliographic/bdapndxg.html

- There should be two new subfields in field 022
  - 0 Authority record control number or standard number (NR)
  - 1 Real World Object URI (R)

- There should be three new subfields in field 046
  - 3 Materials specified (NR)
  - x Nonpublic note (R) (this one should be hidden from the OPAC)
  - z Public note (R)
  **Note that subfield 7 was added in a later update and is therefore not included in this patch

- Subfield 082$2 should now be named Edition information

- Subfield 083$2 should now be named Edition information

- There should be a new field 334, named MODE OF ISSUANCE
  - This field should be repeatable
  - Subfields:
    - 0 Authority record control number or standard number (R)
    - 1 Real World Object URI (R)
    - 2 Source (NR)
    - 6 Linkage (NR)
    - 8 Field link and sequence number (R)
    - a Mode of issuance term (NR)
    - b Mode of issuance code (NR)

- There should be one new subfield in field 344
  - i Sound content (R)
  **Note that subfield j was added in a later update and is therefore not included in this patch

- Field 348 should now be named NOTATED MUSIC CHARACTERISTICS
  - There should be two new subfields
    - c Form of musical notation term (R)
    - d Form of musical notation code (R)
    **Note that subfield 7 was added in a later update and is therefore not included in this patch

- There should be a new field 353, named SUPPLEMENTARY CONTENT CHARACTERISTICS
  - This field should be repeatable
  - Subfields:
    - 0 Authority record control number or standard number (R)
    - 1 Real World Object URI (R)
    - 2 Source (NR)
    - 3 Materials specified (NR)
    - 6 Linkage (NR)
    - 8 Field link and sequence number (R)
    - a Supplementary content term (NR)
    - b Supplementary content code (NR)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:35 -03:00
Caroline Cyr La Rose
2a71efa0e4
Bug 34648: (fixup) Update MARC21 frameworks to Update 31 (December 2020)
Added missing 881$a subfield.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:34 -03:00
Caroline Cyr La Rose
a6bde4534a
Bug 34648: (follow up) updated comment
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:34 -03:00
Caroline Cyr La Rose
3fdee6e8dc
Bug 34648: Update MARC21 frameworks to Update 31 (December 2020)
This patch updates the default MARC21 framework to reflect the changes brought by Update 30 (Dec. 2020).

To test:
1. Apply patch and restart
2. Go to Administration > MARC bibliographic framework
3. Click "Actions" next to the default framework and choose "MARC structure"
4. Check for the changes detailed in the update https://www.loc.gov/marc/up31bibliographic/bdapndxg.html

- Field 043 should now be repeatable

- There should be a new field 335, named EXTENSION PLAN
  - This field should be repeatable
  - Subfields:
    - 0 Authority record control number or standard number (R)
    - 1 Real World Object URI (R)
    - 2 Source (NR)
    - 3 Materials specified (NR)
    - 6 Linkage (NR)
    - 8 Field link and sequence number (R)
    - a Extension plan term (NR)
    - b Extension plan code (NR)
    **Note that subfield 7 was added in a later update and is therefore not included in this patch

- Field 345 should now be named MOVING IMAGE CHARACTERISTICS
  - There should be two new subfields
    - c Aspect ratio value (R)
    - d Aspect ratio designator (R)

- There should be two new subfields in field 384
  - 0 Authority record control number or standard number (R)
  - 1 Real World Object URI (R)

- The following subfields of field 856 should have an [OBSOLETE] mention and be hidden (shown in OPAC and intranet, but not editor)
  - b Access number [OBSOLETE]
  - h Processor of Request [OBSOLETE]
  - i Instruction [OBSOLETE]
  - j Bits per second [OBSOLETE]
  - k Password [OBSOLETE]
  - l Logon [OBSOLETE]
  - n Name of location of host [OBSOLETE]
  - r Settings [OBSOLETE]
  - t Terminal emulation [OBSOLETE]

- There should be a new field 881, named MANIFESTATION STATEMENTS
  - This field should be repeatable
  - Subfields:
    - 3 Materials specified (NR)
    - 6 Linkage (NR)
    - 8 Field link and sequence number (R)
    - a Manifestation statement, high-level/general (R)
    - b Manifestation identifier statement (R)
    - c Manifestation title and responsibility statement (R)
    - d Manifestation edition statement (R)
    - e Manifestation production statement (R)
    - f Manifestation publication statement (R)
    - g Manifestation distribution statement (R)
    - h Manifestation manufacture statement (R)
    - i Manifestation copyright statement (R)
    - j Manifestation frequency statement (R)
    - k Manifestation designation of sequence statement (R)
    - l Manifestation series statement (R)
    - m Manifestation dissertation statement (R)
    - n Manifestation regional encoding statement (R)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:33 -03:00
David Nind
39cbe567f0
Bug 34677: (follow-up) Additional updates to match the LOC list
This patch makes additional updates to the RELTERMS authorized
value list to make it match the MARC Code List for Relators
at https://www.loc.gov/marc/relators/relaterm.html and
https://www.loc.gov/marc/relators/relacode.html

It also updates the description displayed in the
authorized values list.

Test plan:
1. Apply the patch.
2. Reload the values (reset_all if using KTD).
3. Go to Administration > Authorized values.
4. Note that the description for RELTERMS is changed
   (now says 'MARC Code List for Relators
    (https://www.loc.gov/marc/relators/).' instead of
    'French terms of relations').
5. Check that the changes listed are incorporated
   into the RELTERMS authorized values list.

Additions:
prv - Provider
rcd - Recordist
stg - Setting

Changes:
aui - Author of introduction -> Author of introduction, etc.
aus - Author of screenplay -> Screenwriter
coe - Contestant -appellee -> Contestant-appellee
cot - Contestant -appellant -> Contestant-appellant
cou - Court-governed -> Court governed
dpb -> dbp - Distribution place
dgg - Degree grantor -> Degree granting institution
osp - On-screen presenter -> Onscreen presenter
pte - Plaintiff -appellee -> Plaintiff-appellee
rcp - Recipient -> Addressee
red - Redactor -> Redaktor
wde - Wood-engraver -> Wood engraver

Removals:
-grt - Graphic technician

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:29 -03:00
David Nind
936939f04a
Bug 34677: (follow-up) Update transposed value
Update sdg Stage director to sgd (May 31, 2013 technical notice).

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:28 -03:00
Caroline Cyr La Rose
808714b3b4
Bug 34677: Update to MARC21 relator terms list (August 8, 2023 technical notice)
This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the August 8, 2023 technical notice.

https://www.loc.gov/marc/relators/tn230808rel.html

To test:
1. Apply patch and restart
2. Go to Administration > Authorized values > RELTERMS
   --> New terms should be there

anc - Announcer
aue - Audio engineer
aup - Audio producer
bka - Book artist
cad - Casting director
cop - Camera operator
dbd - Dubbing director
djo - DJ
edd - Editorial director
fon - Founder
mka - Makeup artist
mup - Music programmer
mxe - Mixing engineer
nan - News anchor
onp - Onscreen participant
rap - Rapporteur
rxa - Remix artist
sde - Sound engineer
sfx - Special effects provider
swd - Software developer
tau - Television writer
tlg - Television guest
tlh - Television host
vfx - Visual effects provider

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:28 -03:00
Caroline Cyr La Rose
fff344940c
Bug 34677: Update to MARC21 relator terms list (Apr. 26, 2021 technical notice)
This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the April 26, 2021 technical notice.

https://www.loc.gov/marc/relators/tn210426rel.html

To test:
1. Apply patch and restart
2. Go to Administration > Authorized values > RELTERMS
   --> New term should be there

Addition:
pad - Place of address

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:27 -03:00
Caroline Cyr La Rose
68671cdf09
Bug 34677: Update to MARC21 relator terms list (Dec. 14, 2020 technical notice)
This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the December 21, 2020 technical notice.

https://www.loc.gov/marc/relators/tn201214src.html

To test:
1. Apply patch and restart
2. Go to Administration > Authorized values > RELTERMS
   --> New term should be there

Addition:
dgc - Degree committee member

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:26 -03:00
Caroline Cyr La Rose
72c65d188b
Bug 34677: Update to MARC21 relator terms list (Feb 21, 2014 technical notice)
This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the February 21, 2014 technical notice.

https://www.loc.gov/marc/relators/tn140221rel.html

To test:
1. Apply patch and restart
2. Go to Administration > Authorized values > RELTERMS
   --> New terms should be there and modified terms should be changed

Additions:
dgs - Degree supervisor
med - Medium
mtk - Minute taker
vac - Voice actor
wst - Writer of supplementary textual content
win - Writer of introduction
wpr - Writer of preface

Changes:
orm - Organizer

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:26 -03:00
Caroline Cyr La Rose
bc7d55d9ba
Bug 34677: Update to MARC21 relator terms list (May 31, 2013 technical notice)
This patch adds missing relator codes/terms to the marc21_relatorterms.yaml file in accordance with the May 31, 2013 technical notice.

https://www.loc.gov/marc/relators/tn130531rel.html

To test:
1. Apply patch and restart
2. Go to Administration > Authorized values > RELTERMS
   --> New terms should be there and deprecated terms should have been removed

Additions:
abr - Abridger
apl - Appellant
ape - Appellee
adi - Art director
ato - Autographer
brl - Braille embosser
brd - Broadcaster
cas - Caster
cor - Collection registrar
cou - Court-governed
crt - Court reporter
edc - Editor of compilation
edm - Editor of moving image work
enj - Enacting jurisdiction
fds - Film distributor
fmk - Filmmaker
fmd - Film director
fmp - Film producer
his - Host institution
isb - Issuing body
jud - Judge
jug - Jurisdiction governed
osp - On-screen presenter
pan - Panelist
pra - Praeses
pre - Presenter
prn - Production company
prs - Production designer
rdd - Radio director
rpc - Radio producer
rsr - Restorationist
sll - Seller
sgd - Stage director
tld - Television director
tlp - Television producer
wac - Writer of added commentary
wat - Writer of added text
wal - Writer of added lyrics

Deprecated relators:
clb - Collaborator
voc - Vocalist

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:25 -03:00
Katrin Fischer
f6cce74736
Bug 34657: (QA follow-up) Fix plugin link in UNIMARC default framework
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-09 11:41:19 -03:00
Laura Escamilla
f2ecb1e9be
Bug 34340: Changed "Tendered" to the correct input id which is "Collected"
Must also apply bug 34332 - fixed a syntax error for the pos email template

To test:
1. Configure your Koha to enable the point of sale system (i.e. enable syspref,
   set up a register, set up an item to sell).
2. Complete a transaction in the POS system.
3. Click on the “Email receipt” button next to the “Print receipt” option and
   enter an email address and confirm that the email is sent.
4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the
   actual amount that was tendered.
5. Apply patch
6. Repeat steps 2 & 3
7. The emailed receipt is now showing the correct tendered amount.
8. Sign off!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-08-30 09:02:44 -03:00
004bde7950
Bug 33759: Fix typo 'Thankyou' in sample notices
This fixes the typo 'Thankyou' in some of the sample notices.

To test:
* With the sample data
* Create and run a report:
  SELECT code,content FROM letter where content LIKE "%Thankyou%";
* Verify 3 notices contain 'Thankyou'
* Apply patch
* Drop your database
* Run the web installer
* Run report again, you should no longer get any results

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-08-29 14:37:15 -03:00
Laura Escamilla
eb84c45da4
Bug 34332: Removed extra parenthesis that was causing an error
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-07-21 17:14:40 -03:00