Before the grace period was not included in the number of days overdue when
calculating the fine. My librarians seem to think the number of days overdue
should include the grace period.
Fine is not assessed before the grace period is up though.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Remove some superfluous variables
Simplify some loops over lists
Fix generated warnings
Strip whitespace from line endings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
If a staff member clicked on 'Show all items' in a patron's reading record, and
then clicked on 'show last 50 items only,' all of the records would still be
shown. The link for the 'last 50' items contains a switch for 'limit=full'
instead of 'limit=50'.
Also fixes some XHTML errors.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Auth, after verifying the session/logging in the user, calls to the database
to get the users borrowernumber. This call is probably unnecessary because
borrowernumber is part of userenv. Check userenv before going to the database.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.
It also removed the messaging options from the patron
details and leaves them on the messaging tab.
Finally it adds in address fields that were missing
previously on the update patron form.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
When rebuild_zebra.pl is run from cron, there is an occasional error
of the form:
Use of uninitialized value $str in substitution (s///) at /home/ebpl/kohaclone/C4/Charset.pm line 304.
This error is occuring when the string that is fed to Charset::StripNonXmlChars
is null or undefined, for some reason.
This fix will handle the null-or-empty condition, and thus suppress the error.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This preference allows library staff to decide whether to show
the fines tab in the OPAC for logged in patrons.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
* correct POD - returns *public* lists that bib
belongs to
* use fetchall_arrayref to return results in
one fell swoop
* corrected indentation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page. The same goes if virtualshelves
is turned OFF.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
These were added in the labels rework, but do not belong here, since
gb_styles.css should references only CSS classes responsible for
displaying the greybox itself, not the content inside it. In particular,
the generic table styles were causing the icons added by tablesorter
to be tiled in the opac-detail template.
To finish this work, the styles should be taken out entirely and
moved to whichever lables template they were supposed to affect
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- added altcontactcountry and B_address2 to tables borrowers and deletedborrowers so that all addresses offer the same fields
- changed B_country and country to work with syspref BorrowerMandatoryField
- changed display of Alternate Address on borrower detail page, added labels, lines and edit button to match the other sections
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds selection by row and by column, all/none/toggle for individual ccode/itype sets, and a tabbed interface for a more compact display.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
