Commit graph

5264 commits

Author SHA1 Message Date
3c4b709fff bug 4018: remove duplicate unAPI link when XSLT bib details display on
The unAPI link is now added only in opac-detail.tmpl.  More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-26 16:30:25 +12:00
52b00b7589 Correct position of non-sorted table column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:44 +12:00
4a628c4265 Revert "(bug #3798) fix changing request branch"
This reverts commit ad01b57bcc.

This commit had introduced bug 4526.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:44 +12:00
ef97c46604 Corrected: Fix for Bug 4529, columns on circ history all screwy
- fix formatting of last renew date
- Add table zebra striping
- Other markup structure changes
- Revised template assumes that issues.branchcode == checkout library and displays
  that value instead of issues.issuingbranch (which is always empty, see Bug 2806)
  issues.branchcode seems to reflect the item's holding branch *after* having
  been updated as part of the checkout transaction.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:44 +12:00
Colin Campbell
7cd47b0e84 Bug 4510 Script processes single supplier not an array
Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable

replaced the C-style currency loop with a simpler perl-style one
we only need 1 loop not multiples
Changed variable name $GST to $tax_rate it's not magical and not a constant
and we all know what tax is
Fetch Contract data once rather than twice from two different modules
Correct size of discount data on display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:43 +12:00
Nahuel ANGELINETTI
2b86da48a4 (bug #4522) fix plugin unimarc 210$c
This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:43 +12:00
40818ef9d8 Fix for Bug 4534, Box for SQL not visible in "Create Report from SQL"
Changed style of SQL box and altered markup for a somewhat
cleaner layout

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:42 +12:00
cc424b4f65 bug 4464: properly check if a subfield is populated if it is in a textarea
Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>.  The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:41 +12:00
Garry Collum
f8e27dea95 Bug 2889: Adds highlighting to serials-collection.tmpl
Also fixes inconsistencies in the capitalization in the headings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:41 +12:00
Garry Collum
c51fb551e8 Bug 3910: Removes an erroneous heading from the serials search results.
Removes the 'Search for Serial Routing' heading from the serials search result screen.

There is no code in the template that performs a routing search, and links to the routing tables are provided in the serials search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:41 +12:00
Nicole Engard
0006c325be bug 4802 - fix swapped files in acq help
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:40 +12:00
Nicole Engard
309a9305e2 bug 4802 add missing order search help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:40 +12:00
Nicole Engard
1200455a60 bug 4802 add new acq help files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:40 +12:00
Nicole Engard
481af2fded update main page help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:39 +12:00
43d3007bfb fix XHTML error in bib details print page
"&nbsp;" is not subtitutable for a table row

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:39 +12:00
Nahuel ANGELINETTI
3dfc75da19 (bug #4519) fix record printing
this add a js that print a record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:39 +12:00
Garry Collum
b96bd87bb6 Bug 4525: Invalid XHTML in currency.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-25 06:55:39 +12:00
692243b547 Bug 4516 (Character shift in MARC21 Field 008)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 16:55:37 +12:00
Chris Nighswonger
4c072a153d Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
Porting about.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 16:55:37 +12:00
Chris Nighswonger
60ba97219f Enhancement Bug 4444: Centralize Code Handling Perl Dependencies
Porting install.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 16:55:37 +12:00
451b4cfb04 bug 4509: remove references to PINESISBN system preference
This system preference never worked; also, as far as I can tell,
the PINES oISBN service was experimental, not meant for production
use, and is not currently advertised.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-19 16:55:36 +12:00
Jane Wagner
fde1abd82e Bug 4394 REVISED Allow opaccolorstylesheet syspref to use an external URL
Previous code would only allow for an auxiliary stylesheet on the same server.  This checks for
http in the opaccolorstylesheet syspref.  If it's found, sets a different variable pointing to the
remote server location.  If not found, retains the previous css directory path.

Also modifies the description of opaccolorstylesheet in the installer files to reflect current
usage as an auxiliary stylesheet.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-05-17 12:32:46 +12:00
74e2e63fd2 fix XHTML error in about.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 08:36:26 +12:00
Katrin Fischer
205e0c3245 BUG 4499: Javascript error messages not translatable
- Administration > Patron categories > New Category (category.tmpl)
- Circulation > Checkouts > Toolbar (all tabs except Check out) (members-toolbar.inc)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 08:36:26 +12:00
Katrin Fischer
a633245864 BUG 4499: Javascript error messages not translatable
- Cataloging > New Record (addbiblio.tmpl)
- Administration > Currencies > New Currency (currency.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:34 +12:00
Paul Poulain
52645af2d6 (MT3318) RSS OPAC: Adding CDATA term in title and description tags.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:33 +12:00
b9ed528ab4 Fix for Bug 4485, System preferences page uses non-standard warning style
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:33 +12:00
fb4c61f0df A couple of CSS and markup corrections
- moving inline style declaration to the default stylesheet
- correcting markup structure on advanced search screen to allow
  consistent custom styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:33 +12:00
Jane Wagner
b1cf302ac8 Bug 4300 Display 866z summary holdings public note in OPAC
Added the 866z to the MARC21slim2OPACDetail.xsl file so that it displays
just above the 780 and 785 fields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:33 +12:00
Matthias Meusburger
5db10480f8 MT2582: Fix user deletion without permission
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:32 +12:00
J. David Bavousett
aacf00e94b Bug 3928: Modification of date for serials.
When a serial status is changed to "Arrived" or "Claimed", the "Expected on"
date is changed to the current date.

A bit of rewriting to get it to apply on master - chris@bigballowax.co.nz

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:32 +12:00
Matthew Hunt
cca397e8d1 Display current selected category when editing lists.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:32 +12:00
ae66e3a0ba Fix for Bug 4475, AmazonLocale not used consistently
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:32 +12:00
5058112a60 Markup corrections for validity and to eliminate horizontal scrollbar
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:31 +12:00
Chris Cormack
f80257330a Reserve and onloan were reporting the same cardnumber, due to a little bug in detail.pl fixed by this patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:31 +12:00
f23f442415 Fix template errors introduced in my last patch for Bug 4208
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-14 07:22:30 +12:00
Chris Cormack
a78576c31a Follow up to bug3093 patch 2010-05-11 17:12:40 +12:00
Jane Wagner
2894555f5c Bug 3093 add syspref to turn off multiholds button
Having the place multiple holds button at the top of the OPAC and staff search results has caused problems for some sites with tight holds policies; this syspref allows those sites to turn off the button.
2010-05-11 17:09:49 +12:00
Jane Wagner
8a1cb959c6 Bug 3671 Workaround for font display problem
If there is no 007 field, parts of the OPAC results data display in a
much smaller font than normal.  Adding a blank space in the span section
fixes it.
(cherry picked from commit 2ff55ef2a2443933881186323f5dec3fe40842dd)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-10 16:40:31 -04:00
3d8e99e5ec fix disappearance of language chooser introduced in recent patch
Note that xt/author/valid-templates.t did *not* catch the
missing /TMPL_IF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:58:36 -04:00
841da504e8 Further corrections for Bug 4244, Use "checkouts" instead of "issues"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 13:26:29 -04:00
1127878bdc Style changes to cart popup window more compact display: - compact holdings list - adds list bullet image from the staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 13:18:02 -04:00
Chris Cormack
5e2fcfd0b6 Adding new developers to the about page, need to do libraries next
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 19:58:27 -04:00
5f7946e4d8 Further fixes for Bug 4208, Many submit buttons are not translatable in 3.2
Again, not a fix for a submit button problem, but for a problem with
TMPL_IFs nested inside tags, a practice which will break the
translation script.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 11:50:52 -04:00
37e9cbc042 Fix for Bug 4416, renew all and return all buttons too close together
This patch removes the "return all" button altogether. Returning all items
is a step which one wouldn't take lightly or even regularly. Since the
interface has a means of selecting all checkboxes in the "Check in" column,
removing the "Return all" button wouldn't eliminate the means of doing so, it
would just require more deliberation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:17:21 -04:00
7b11d2a281 Fix for Bug 4453, Improve formatting of batch item operations
- includes fix for Bug 4443
- includes some string changes, could resubmit without if these
  changes block inclusion in 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:14:07 -04:00
5d921cf51d Fix for Bug 2375, Serials holdings data does not display in opac-detail
- Removing markup to display serial data in the holdings table
  This functionality (if it worked) would seem to duplicate
  the data displayed under the 'Subscriptions' tab
- Revised again to merge item status display changes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:14:03 -04:00
Ian Walls
74afd1ca8e Fixes bug 4452: CircControl syspref listed as ItemHomeBranch rather than ItemHomeLibrayr
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 10:14:48 -04:00
9329c40b6b fix template translation issues
Alternative to Henri-Damien's patch that does not
require putting CSS style information in the Perl code.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 09:28:08 -04:00
6969fefe4c Use CSS3 box-shadow property for Cart tooltip
The OPAC Cart tooltip ("Your cart is empty," "1 item(s) added to your
Cart") currently uses a jQuery plugin to generate a drop shadow.
This works cross-browser, but has a high failure rate with regard
to hiding the shadow consistently, resulting in an orphan shadow
after the tooltip has been hidden. I propose to instead use the
new CSS3 property "box-shadow" (-moz-box-shadow and -webkit-box-
shadow for FireFox and Safari/Chrome). Currently Internet Explorer
does not support this property. I think this is an
acceptable tradeoff for more stable functionality.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 11:19:03 -04:00