Commit graph

195 commits

Author SHA1 Message Date
Brendan A. Gallagher
a7ccef4f90 Change typo Localisation to Localization for Bug # 3102
[RM note: I think there are a few people who wouldn't
 call "localisation" a typo - such as our UK, NZ,
 Australian, etc. contributors ;-) ].  That said,
 I'm pushing this patch to consistent with the
 general trend of the English varient used on the
 /prog/ templates.  There's no implication that en_US
 is the "correct" version of the language.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 16:16:44 -05:00
Paul Poulain
6dbe43b54a fix for #946
A member returns a book : it would be better to see the category of this member
in "information member" near his name.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 16:04:50 -05:00
e3d787fc22 Another try at fixing Bug 2949.
This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-05 11:48:28 -05:00
ebc9a26686 Fix for Bug 3015: Check-in screen displays branch name inconsistently
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:23 -05:00
Joe Atzberger
ba0ae6cd1c Branchoverdues circ report reworking.
branchoverdues.pl
~ Removed unused variables.
~ Use elsif where applicable.
~ Added many FIXMEs.
~ Added help description.
~ Changed link to more accurate description.
~ REFACTORED branchoverdues-specific function in C4 for obvious consolidation.

This report is still of questionable value, since it's dataset has such strange
hardcoded limitations.  It is not clear that "FU" type fines and notifys=0 are
reliable or useful indicators to query on, in hardcoded form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 15:01:41 -06:00
koha
9c72711a2c This patch allows the Branch Transfer Limits feature to limit transfers either by itemtype ( like the original commit ) or collection code ( new feature ).
[Note inserted by RM: this patch is by Kyle Hall]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 11:27:16 -06:00
90670970f6 Resubmitting: Change to how email link is displayed for on-hold items
Email link should only display when the on-hold item is being checked in at its destination branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 15:24:24 -06:00
d5908e57c0 Adding additional information and consolidating display of information in holds queue report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:53:15 -06:00
d4ed156eb4 Adding information that patron is restricted/address in doubt to hold notification screen
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:23:39 -06:00
Joe Atzberger
a581f7203c Bug 2842: ->regexp('syspref') failed for users of iso dateformat.
Sticky due date and patron import were the two areas affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:24:46 -06:00
John Beppu
7b683cf583 bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-23 17:02:00 -06:00
Kyle Hall
9cf0472903 Added 'Branch Transfer Limits' Feature requested by Geauga County Library System.
Added syspref to updatedatabase.

Updated kohastructure.sql with the limits table.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-17 14:49:02 -06:00
Ryan Higgins
53a0ed93db bug 2787 : Fix Global Due date
This patch also lightly refactors the conditional structure wrapping the
call to AddItem, renaming a couple variables to remove double-negatives and
abstruse logic.  If SpecifyDueDate is ON, then the input box is used to pass
GlobalDueDate, allowing modification by circ staff, resulting in a default
'sticky' due date of the global due date in that mode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 07:22:18 -06:00
c9a00b8b47 Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:37:46 -06:00
36e384adc7 Adding javascript to let user click table cell to check containing checkbox.
This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:31:08 -06:00
Joe Atzberger
83dedaebc2 Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-04 15:14:49 -06:00
Michael Hafen
12b216c77d Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 16:29:56 -05:00
Galen Charlton
7fa4fd7a55 followup 3 to to renewal limit override
style="display: none" suffices to have a span
be hidden initially; content_hidden is not necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:35:02 -05:00
Michael Hafen
03d8521cbf Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-23 10:34:50 -05:00
Galen Charlton
977a1c68d6 followup - use &amp; in place of &
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 16:18:42 -05:00
Michael Hafen
68a6634ffd bug in 'Add/Change link to item details...' I missed Previous checkouts area
This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 15:37:49 -05:00
Michael Hafen
6de2f89e97 bug: sticky due date isn't stick if there is a question about an issue
the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 20:57:35 -05:00
Michael Hafen
5170e31ea3 bugfix: Add a message to circulation.pl if item is restricted
Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:29:20 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Galen Charlton
c7a3b4ede9 bug 2608: let offline circ processing work in background
If an offline circulation file is large, process_koc.pl
could time out before processing all of the transactions.

To prevent this, the processing can now be run in the
background, with an AJAX loop to check the job's
status.

As a consequence of the patch, the UI for uploading offline circ files has
changed slightly.  One must select a file, click the "upload file" button, then
click the "process offline circulation file" button.

Also removed the now-superfluous upload_koc.pl, added the warnings pragma,
and fixed a typo in the template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:22 -05:00
e3fe31b50b Change missing from previous commit re:Bug 2600.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:12:37 -05:00
e71028b354 Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:11:55 -05:00
62b550a0be Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:03:39 -05:00
7b2e4ebce2 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-09 10:53:02 -05:00
Galen Charlton
85a883ef28 fixing permission 2008-09-02 16:34:41 -05:00
Michael Hafen
9891a955e0 Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:53 -05:00
Michael Hafen
0e3302e78b Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:51 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Galen Charlton
98dc396b9b bug 2503: fix minor XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 19:27:48 -05:00
Kyle Hall
38cf1fd318 Integrated version of the Koha Offline Circulation file uploader. It needs some testing and cleanup, but it works.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 17:05:24 -05:00
Galen Charlton
dee5f4945b bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title

As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.

This patch includes the final component of the fix
for bug 2331.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-18 07:15:58 -05:00
Andrew Moore
b77f9da08b Bug 2084 [1/2]: adding warning to overdues report
This patch adds a warning to the staff interface on the circulation page
to indicate that the overdues report is resource intensive on large installations.

This is considered a stopgap solution. Ideally, this report should be changed in order
to make it usable even for large installations.

Documentation note: Although no functionality has changed, any screenshots of the
circulation page on the staff interface should be updated.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-06 16:58:55 -05:00
Darrell Ulm
f0da737c25 Removing Billing.pl link, will not even slightly work with InnoDB tables as there is no fast count, will work on later
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:55:40 -05:00
root
a75ffcede8 Small patch again to fix repeated col in reserveratios.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-27 06:50:40 -05:00
Jesse Weaver
b9f814e57f fix for bug 2371: Change fine block message behavior...
This adds a variable to the checkout form, debt_confirmed, that is 1 when the de
bt block message has been canceled for this session.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:13 -05:00
Jesse Weaver
fba4191412 fix for bug 1892: When checking in item on hold...
Makes the print slip and confirm button show up on an in-library hold as well as a transfer. It also adds an ignore button that hides the hold dialog.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:15:10 -05:00
Jesse Weaver
0bb715b7ed fix for disappearing dropbox mode checkbox on returns screen
This makes the 'dropbox mode' checkbox appear unconditionally.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-18 13:06:24 -05:00
4909b6d556 Template error prevented chosen branch from being preselected after form submission.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-10 15:31:26 -05:00
Joshua Ferraro
8fdd226323 Nomenclature update: s/Reserved on/Hold placed on/ and also updated translations 2008-07-10 13:31:10 -05:00
Joshua Ferraro
60105bd692 fix for 2008: Daily reconciliation report broken
Stuff that hasn't ever worked in Koha gets commented out in 3.0 ;-)
2008-07-08 20:02:34 -05:00
Galen Charlton
1aed87679d bug 2171: remove cancel transfer
The "transfers to receive" report included
unused code to delete a transfer.  Since the
"transfers to receive" report is still useful
to give a library a report of items that it should
expect to receive, I am retaining the report.  However,
since the cancel transfer functionality would not
work even if it were uncommented in the template, that
portion is removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-04 09:22:19 -05:00
Galen Charlton
fecf5c38bb bug 2171: removed "Transfers to do" report
This hold request and transfer report no longer
works now that hold requests are processed via
checking items in.

This patch removes the report; please consult
the koha-devel message re "RFC - remove circ/transferstodo.pl prior to general release"
for more details.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-04 09:22:16 -05:00
Joshua Ferraro
71c7afd90d Darrel's patch to fix sorting by size of order 2008-06-20 09:14:17 -05:00
paul
827203132c movin patron flags to template to have translatable strings
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 06:12:50 -05:00
Andrew Moore
6e52709824 Bug: 2259: eliminate lines too long for git to use.
This patch modifies 13 HTML templates and includes that have lines in them longer than 998 characters. Lines this long are known to break git.

I believe that none of these change behaviour at all, but I'm concerned about one of them. It adds whitespace (carraige returns) inside a <title> tag. I'm not certain that all browsers will deal with this OK.

No documentation changes necessary here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 19:25:52 -05:00