Commit graph

39 commits

Author SHA1 Message Date
f966c0f84c Allow UNIMARC item callnumber splitting
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 01:00:19 -04:00
Lars Wirzenius
7279f55b60 Fix FSF address in directory C4/
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-03-16 20:17:56 -04:00
Chris Nighswonger
2433a91e92 Removing depricated file from the C4::Labels module.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 20:54:40 -05:00
Chris Nighswonger
84d5b28f12 Bringing label, patroncard, and creator modules into conformity with the rest of C4 style.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 20:54:34 -05:00
Chris Nighswonger
ff13d25bb3 Bugfix: Various Label Creator bugs
This fixes:

* A bug which caused the label template editor to throw
an error when saving when no previous profile was applied.

* A typo which caused a 'fetch without execute' error in Labels.pm

It also comments out several useless warns
2010-01-19 22:27:09 -05:00
Chris Nighswonger
ed7009df42 [30/30] Removing depricated files 2010-01-11 18:21:43 -05:00
Chris Nighswonger
4a675bcaad [5/30] A rework of Label Creator code
This rework removes code held in common with the Patron Card Creator
and move is to the new C4::Creators module.
2010-01-11 18:16:52 -05:00
Chris Nighswonger
3bab38c3fc Bug 3706 Label templates/layouts do not save properly
Two issues here:

1. No radio box was selected by default in the format section of the layout editor. This actually needs some additional attention to allow the user
to establish a default method of entering the format string. As noted in comments in the code, this would probably be best implimented by adding yet
another syspref. However, I don't have time atm.

2. On saving a new template, if no profile was assigned to the new template, the script threw an error and died.

Both issues are addressed in this patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-10-14 10:17:10 -04:00
Chris Nighswonger
39f870c5f9 Bug 3649 Code39 Mod10 and Mod43 barcodes are produced with Mod9 checksums
This may not present a problem inside of Koha, but would if scanned with
software expecting mod10 or mod43.

Current code uses the 'visa' method of the Algorithm::CheckDigits module which
produces mod9 checksums.

The patch changes to using 'code_39' for mod43 and 'siret' for mod10.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-10-07 05:56:51 -04:00
Chris Nighswonger
c25dc92fd1 Bug 2500 Correcting incorrect splitting of cutter numbers
This patch does two things to improve the call number splitting algorithms:

1. It makes changes to ensure that cutter numbers are split correctly in ddcns

2. It moves custom/fiction/biography call number splitting to a separate algorithm.
    Before they were incorrectly placed in ddcns.

This patch also modifies the call number splitting tests to accept call numbers from the
command line to allow quick testing of any give call number against a particular algorithm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-15 20:29:16 -04:00
056152e142 debugify a warn
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 21:43:13 -04:00
0bbcfeda0e replace syslog with warns
As discussed with Chris Nighswonger on #koha, this patch
removes the calls to syslog and replaces them with warns
so that error messages generated by the labels code
are sent to the Apache error log.  This avoids splitting
this sort of logging across multiple files and is consistent
with current practice in most of the rest of Koha.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 21:43:12 -04:00
Chris Nighswonger
3720e0261f Fixing warns (tnx to Chris Cormack for identifying these)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-05 19:56:20 -04:00
Chris Nighswonger
e1a4e7c756 [39/40] Removeing depricated functions from label module. 2009-09-01 15:57:56 -04:00
Chris Nighswonger
9b56b1ead9 [35/40] Work on C4::Labels tests and various bugfixs resulting
This patch also moves the Labels tests into their own sub directory.

Due to a squash mistake this patch also includes the following:

Fixing up POD for C4::Labels modules

Also a minor bugfix and code refactoring.
2009-09-01 15:54:01 -04:00
Chris Nighswonger
dfca27d898 [33/40] Porting call number splitting improvements from HEAD 2009-09-01 15:53:40 -04:00
Chris Nighswonger
38817fb300 [31/40] Misc bugfixes and cosmetic cleanup. 2009-09-01 15:53:18 -04:00
Chris Nighswonger
39d227d712 [24/40] Adding single/multiple label printing to label export code and interface.
This adds single/multiple label printing by item number along with new CSV and XML export code.
2009-09-01 15:51:58 -04:00
Chris Nighswonger
51db13b8da [23/40] Initial work on label export interface. 2009-09-01 15:51:47 -04:00
Chris Nighswonger
c468a724b4 [22/40] General code cleanup of new labels module code. 2009-09-01 15:51:39 -04:00
Chris Nighswonger
4b4b161d50 [21/40] Adding de-duplicating method and associated label edit batch code. 2009-09-01 15:51:26 -04:00
Chris Nighswonger
13e894585f [20/40] Work on label printing code. 2009-09-01 15:51:16 -04:00
Chris Nighswonger
c9e6962fd4 [18/40] Work on label item search. 2009-09-01 15:50:51 -04:00
Chris Nighswonger
86a5bc80e2 [17/40] Work on C4::Labels::Lib::html_table api to add link field option 2009-09-01 15:50:38 -04:00
Chris Nighswonger
ff606c3eb1 [16/40] Improvements to label management interface code. 2009-09-01 15:50:27 -04:00
Chris Nighswonger
a192e57f00 [15/40] Initial work on label batch edit interface. 2009-09-01 15:50:14 -04:00
Chris Nighswonger
204e051dff [14/40] Work on batch management interface. 2009-09-01 15:50:05 -04:00
Chris Nighswonger
0645c95a36 [13/40] Work on profile editor interface. 2009-09-01 15:49:53 -04:00
Chris Nighswonger
d47afd597b [12/40] Work on label managment interface. 2009-09-01 15:49:39 -04:00
Chris Nighswonger
4554222629 [11/40] Work on layout editor interface. 2009-09-01 15:49:29 -04:00
Chris Nighswonger
e12ae1892c [9/40] Work on template interface. 2009-09-01 15:48:50 -04:00
Chris Nighswonger
12663796ca [8/40] Adding new layout management page
This moves the layouts off of the labels tool start page to bring it into
conformity with the other parts of this tool.
2009-09-01 15:48:38 -04:00
Chris Nighswonger
f514a1b383 [7/40] Adding C4::Labels::Lib module
Library of often used label related linear functions
2009-09-01 15:48:31 -04:00
Chris Nighswonger
1ebc471e15 [6/40] Adding C4::Labels::Label Module
Creates and manipulates Label objects
2009-09-01 15:48:17 -04:00
Chris Nighswonger
b5d78283da [5/40] Adding C4::Labels::PDF module
This module provides a very light wrapper for PDF::Reuse and PDF::Reuse::Barcode
to make them a psuedo-class and allow OO-like calls. (AKA... a hack.)
2009-09-01 15:48:10 -04:00
Chris Nighswonger
c1e34919cd [4/40] Work on C4::Labels::Batch module 2009-09-01 15:48:01 -04:00
Chris Nighswonger
537880591a [3/40] Work on C4::Labels::Profile module and tests 2009-09-01 15:47:52 -04:00
Chris Nighswonger
1c39484c4b [2/40] Work on C4::Labels::Template and associated tests
This commit also contains some work on C4::Labels::Layout as well
2009-09-01 15:47:32 -04:00
Chris Nighswonger
f4d46222e8 [1/40] Work on C4::Labels::Layout module and tests
NOTE: This patch is the first of 40 which almost completely re-factor the
label creator code into a hopefully more scalable form. The new format is
a move in direction of OO handling labels, batches, templates, layouts, and
profiles as objects thus permitting easier implementation of features and
enhancements. It should be possible to export label data in any format one
might choose with the simple addition of a script similar to those included
which produce pdf, csv, and xml format.

One of the larger improvements is a change in workflow that results in template,
layout, and start label selection occurring just before export.

There are also various bugfixes and smaller interface improvements woven into it.

It should be noted that this patch series removes the patron card creator feature
for the present. This feature was only partially completed. A completed variation
will be submitted as a separate patch series to follow in the near future.

The following bugs and enhancements are fixed by this series of patches:

2944 Search to add items to a label batch broken
2061 labels_conf DB values: NULL vs. 0
2511 CSV format string is not cleared when unselected in the label layout editor
2515 Re-factor C4::Labels::DrawSpineText
2823 Label Generator not generating barcodes
3171 Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others
3180 Active settings for label settings should be set at print time only

This work was sponsored by Foundations Bible College & Seminary, Dunn, NC USA
2009-09-01 15:15:45 -04:00