Commit graph

1969 commits

Author SHA1 Message Date
a89c3085cf Bug 1542, fixing filter by area in reports dictionary
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-14 06:59:52 -05:00
Garry Collum
478b2ce274 Bug 1440: Show a list of holidays. Second patch.
Fixed XHTML error that was introduced in the first patch. Added zebra striping to the tables. Removed an erroneous line with a date experiment that had no affect on the dates.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-13 09:01:05 -05:00
Garry Collum
dd7c7d2d78 Bug 1440: Show a list of holidays
This patch adds displays for holidays. A table for each type of holiday.  It could be improved by adding a link for a holiday listed in one of the tables to the edit panel.  The date formats could also be changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-12 05:21:19 -05:00
Galen Charlton
f9601413a4 bug 988 followup - tweak wording
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 14:26:56 -05:00
Paul Poulain
d496e3111a fix for #988
When a borrower can't issue any book (issuingrules=0), the message should be
"this user can't issue book" and not "too many books already issued"wrong message

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 14:24:47 -05:00
Nahuel Angelinetti
f4649ab6a3 Add a date field in news edition, and permit to set the "timestamp" field, that is the publication date and modify the GetNewsToDisplay to return only news that timestamp is < to current date that permit to publish news later without any action.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 14:12:59 -05:00
Michael Hafen
996e521633 bugfix stickyduedate more sticky - couple more forms in circulation.tmpl
There are a couple more forms in circulation.tmpl that need the
stickyduedate and duedatespec hidden inputs.  The 'Don't Check Out' form
of the needsconfirmation block, and the findborrower form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 11:07:38 -05:00
Michael Hafen
3e0163adb8 bugfix stickyduedate more sticky - also patron search in quick search block
Forgot about the patron search for check out form in the quick search
block

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 11:07:32 -05:00
Nahuel ANGELINETTI
b1180360a8 (bug #3196) fix itemlost.pl
This patch fix 3 things:
* fix order by
* take care of item_level-itype
* use join in sql query

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 08:34:07 -05:00
Liz Rea
99b84d69b6 Bug 1984 - added Javascript in the header to open, print, and close the slip window
This is for printing circulation slips.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 08:23:58 -05:00
Galen Charlton
2f5a28ee6a bug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'
Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it.  Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'.  Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:41 -05:00
Galen Charlton
7b3a06692c bug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.

This patch also fixes the descriptions of the Leader/09
and Leader/17.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:40 -05:00
Galen Charlton
2de58fc287 bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Also made the following updates to the MARC21 leader plugin

[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:28 -05:00
df03217b49 More fixes for Bug 2704, 440 Display Issues
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 12:20:07 -05:00
Nahuel ANGELINETTI
348d471fe0 (bug #3187) authority search pagination doesn't work
this patch just set a marclist argument value on search authority, else the pagination won't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:23:58 -05:00
Nahuel ANGELINETTI
78756abc37 (bug #3174) show the member name in reports
this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:17:30 -05:00
98650328dd Add system preference search to administration home page (Bug 3181)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:49:41 -05:00
Galen Charlton
70b7017eca fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:32:02 -05:00
Colin Campbell
e60fbf4c30 (bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:10:19 -05:00
Joe Atzberger
544b03357a Convert shelves from using "toggle" code
And one ELSIF.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:54 -05:00
Joe Atzberger
51a0e335d5 Bug 3157: IE compatibility for label display
Also fixed validation errors where label elements were "for" non-existant ids.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:53 -05:00
Garry Collum
1eb9154b73 Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"
If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element.  The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank.  Added code to check for an empty string in the first
element.

You can test this by making salutation (title) mandatory.

Also fixed some typos in some of the comments.  Why?  Because I'm a Librarian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:47:09 -05:00
Nahuel ANGELINETTI
4dbe34f231 (bug #3174) fill borrower number, and show author and creation date in saved reports
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:25:36 -05:00
root
99dd5db699 Verbiage clarification in intranet advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:30 -05:00
Liz Rea
69620d9479 Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:26 -05:00
Michael Hafen
d8fad2313f Checkout page - Check Out's table sortable on barcode
Add the barcode column of the Check Out's table to the tablesorter
setup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:59:51 -05:00
Joe Atzberger
a57b438df0 Bug 3126: remove comma for IE7
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:12 -05:00
Joe Atzberger
de38cf6df1 Bug 3130 and general cleanup
Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional.  jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.

There were several other errors addressed by this patch:
 ~ 13 unused variables deleted.
 ~ regexps run on user-supplied $var before checking $var defined
 ~ decimal ratio prohibited and silently replaced with "3"

I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click.  Hidden .sql div now contains the actual query run,
like the other wizard reports.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:10 -05:00
Galen Charlton
46037ac61a bug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)
* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
  AllowNotForLoanOverride is ON, if the operator attempts
  to check out an item that is normally not for loan due to
  its item type or because the item is explicitly marked as
  not-for-loan, the operator is given the chance to check
  out the item anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 14:44:09 -05:00
Joe Atzberger
aebdecfb35 Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:44 -05:00
Galen Charlton
786a1aa36a bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:42 -05:00
33fffbcfd6 Bug 2920 Fixes Amazon content use in pro interface
This patch fixes Amazon content use in pro interface :

* Control Amazon Editorial Review by a new syspref:
  AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
  It displays only Editorial review in Description tab.
  This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
  Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:53:34 -05:00
Galen Charlton
feead03b08 fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:36:30 -05:00
Joe Atzberger
843c5b5b2d Bug 3127 - Stub function prevents undefined reference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 19:49:08 -05:00
Joe Atzberger
ac6cfb28a3 Make js prompts translatable using _("...") and comment out unused vars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 14:01:19 -05:00
David Goldfein
17923b97f6 Modified log reporting to allow multiple modules to be selected.
Reworked ViewLog.pl and the template.  Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 13:36:16 -05:00
Andrew Moore
b15be22620 refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:48:38 -05:00
Joe Atzberger
f3b5014449 Bug 3128 - followup and correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:34 -05:00
Joe Atzberger
173556364d Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:28 -05:00
Stephen Edwards
47690dbcc4 bug 3093: Enhance placing of holds in the staff interface.
This patch allows staff users to request reserves on multiple
items at one time.

Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page.  Place-hold button will only appear if
the user has permission to place holds for others.  Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.

Patron input page now shows multiple items, if applicable.

Hold confirmation page shows results for multiple items, if
applicable.  Those which cannot be reserved are highlighted and
are excluded from the reservation.  The reservation is placed at
the biblio number (i.e. next available) level.

Fixed display of item type.

Removed side menu for multiple items; removed item-oriented button for multiple items.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 06:12:06 -05:00
Joe Atzberger
b8d6ccf845 Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed.  Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected.  Go figure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 12:05:08 -05:00
Joe Atzberger
1afa403417 IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:28 -05:00
8f95ec3dbe Fix for Bug 3119: Add due date to the patron circulation history window
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:45:11 -05:00
e6076612ba Fix for Bug 1877, Link to patron record from manage suggestions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:44:02 -05:00
Brendan A. Gallagher
a09ad1edde Bug #3101 - Changed the Print and Confirm button
Changed button to read "Print slip, Transfer and Confirm"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:22:09 -05:00
Joe Atzberger
0ad2b08c28 Visual alert (red) on overdue return.
This was requested by a Koha user at KohaCon09.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:05:01 -05:00
Cory Jaeger
bb91778b8d Bug 2847 - Added url escaping for categorie.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:00:01 -05:00
Cory Jaeger
9a1a332dbc Bug 2847 - Fix html escaping in categorie.tmpl (more needed)
Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 09:58:15 -05:00
8246da13b2 Fixing xhtml errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 09:14:53 -05:00
Nicole Engard
40bd4a508a Partial fix for Bug #3139
Standardized all references to Address and Zip/Postal Code.

Also fixed bug #3138 by making the Alt address ready City, State.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 08:55:22 -05:00