Commit graph

31 commits

Author SHA1 Message Date
Andrew Elwell
efa66f1f55 Bug 5385: POD Cleanups (part 2)
More podchecker cleanups to eliminate warnings / errors

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-12 10:06:56 +13:00
8eb7e1cbf7 further correction to the invocation of unzip
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 19:55:01 -04:00
Ian Walls
1125f4f432 Tighten system call to unzip
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 19:22:41 -04:00
Donovan Jones
44201a54e1 Bug 2505 - Add commented use warnings where missing in the tools/ directory 2010-04-21 20:26:38 +12:00
Chris Nighswonger
f86b788e3b Bugfix: Upping the byte size limit of patron images
This brings it more in line with the size limit placed on other images
uploaded for use on patron cards.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 15:11:23 -05:00
Chris Nighswonger
3b1d56ccb5 [4/30] Modifications to picture upload script to accommodate image sizes up to 200 X 300 pixel dimesions.
This also changes the storage image format to PNG which is lossless (an important factor when using these
images for patroncards).

NOTE: In the end, this script was *not* used for uploading images for patron cards. However, these changes
are left as an improvement upon this script which is used for patron image uploads.

This script could be greatly reduced in size by using Graphics::Magick and working along the same lines
as the upload code found in patroncards/image-manage.pl
2010-01-11 18:16:17 -05:00
Ryan Higgins
04c4be5b48 Bug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overly restrictive
removing requirements for parameters &  management respectively for these two tools.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-16 14:47:31 -05:00
Chris Nighswonger
1baf6348cc kohabug 2404 This patch removes Image::Magick and adds GD
This patch removes Image::Magick as a dependency and replaces it with
the (much) lighter GD. Functionality of patronimage code has not changed with
this conversion.

Adding errorhandling for corrupted image file and link to return to moremember.pl when called from there

Added notes about supported image mime types.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-30 03:38:18 -05:00
Chris Nighswonger
af288205f5 kohabug 2154 Modifying form input controls to accomodate translations
Due to the logic of the underlying picture-upload.pl depending upon the "value" of the
form input controls and this value being translated, the script then failed to function.
This patch changes the input controls so that this should not be an issue.

This issue should be kept in mind, though, so that it can be avoided in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-25 08:56:10 -05:00
Chris Nighswonger
e15e2f9118 Bugfix: Handling cases where the image is the correct pixel dimensions
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-11 16:54:54 -05:00
Galen Charlton
fc6ccb1a61 granular permissions - updated Tools
Updated all scripts appearing on the tools page
to respect a granular permission defined for
each of them.

The tools menu and home page have been changed so
that only the specific tools that a user has
access are displayed.  This is simple, but depending on
the module and circumstance, it may be better to
display functions that the user has does not have
access to, but disable the links and do some sort
of visual styling to indicate that a function exists
but requires additional privileges to access.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:30 -05:00
Chris Nighswonger
7fbcb6a784 Bugfix: Correcting misspelled variable
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:59:22 -05:00
Chris Nighswonger
a16d450555 Adding use of C4::Debug for debugging
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:59:21 -05:00
Chris Nighswonger
9a55637760 NOTE: REQUIRES INSTALLATION OF Image::Magick; Adding image scaling/resizing capability to picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-08 17:00:05 -05:00
Chris Nighswonger
b626a8bb9a Adding file size limit to picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:17 -05:00
Chris Nighswonger
55b353f79a Adding Update/Delete functions to patron image management on Details page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 12:14:44 -06:00
Chris Nighswonger
cbc5bbccdd Correction to handle errors processing image file passed in from the patron details screen.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 06:25:15 -06:00
Chris Nighswonger
6b89cda969 Completing adding patronimage upload form to patron details screen.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 06:25:13 -06:00
bfbae81162 Some changes related to recent commits to patron images: Markup and javascript changes for upload form; Enabling passing of cardnumber and filetype variable to picture upload form; changes to picture display to handle missing image; Adding link to picture upload form from missing image display in circ and moremember; Removal of English text from 'no patron image' file.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-27 09:02:37 -06:00
Chris Nighswonger
9771c038b0 Bugfix: Removing Dumper() call
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 11:08:43 -06:00
Chris Nighswonger
de1754d68d Third installment on moving patronimages into the database.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:44 -06:00
Chris Nighswonger
06575bbcb8 Fixing error trap routine in picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:43 -06:00
Chris Nighswonger
4b232a0c36 Second installment on moving patronimages into the database
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:41 -06:00
Chris Nighswonger
1c1cb10e5e First installment on moving patronimages into the database.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:37 -06:00
Chris Nighswonger
e4b90465a8 Second fix for bug 1848 correcting bad conditional
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-20 05:41:39 -06:00
Chris Nighswonger
5e90496cad Making picture-upload.pl case insensitive when looking for DATALINK.TXT or IDLINK.TXT
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 16:44:04 -06:00
Chris Nighswonger
a0b51ee25f Correcting DEBUG var
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:46 -06:00
Chris
80d4bd222f Bugfix for Bug 1618: First Installment
This corrects the major template issues once files are uploaded.
The changes need dressing up a bit still.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:41 -06:00
Joe Atzberger
2e0e56a016 tools subdir - Dates.pm integration and warnings fixes.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 18:01:30 -06:00
Joshua Ferraro
defb2eec57 adding a pre-check for patronimages/ dir, which won't be there by
default

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:27:52 -06:00
Joshua Ferraro
b6399e62c1 adding back patron images upload, no idea why it was removed
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:27:10 -06:00