Commit graph

142 commits

Author SHA1 Message Date
Joe Atzberger
aebdecfb35 Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:44 -05:00
Galen Charlton
feead03b08 fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:36:30 -05:00
Andrew Moore
b15be22620 refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:48:38 -05:00
Joe Atzberger
1afa403417 IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:28 -05:00
Jane Wagner
d4241eeeda Bug 3013 Fix for 007 value builder to include all material types
Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-18 15:25:58 -05:00
Nahuel ANGELINETTI
5cf66ad6dd (bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:51:36 -05:00
Joe Atzberger
ce760ba9e8 Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 14:00:13 -05:00
46c0706ee1 Bug #3071 - Z39.50 search result highlights are mixed
This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:53 -05:00
0a2be5e29b Changes to tabindex values to improve keyboard access.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:21 -05:00
Nahuel ANGELINETTI
04f8382d5b (bug #2978) fix differents bugs in marc editor
This patch fix two bugs:

 * tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.

 * openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:39:51 -06:00
Nahuel ANGELINETTI
72563b0449 (bug #2933) change popup names containing space chars
This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:37:30 -06:00
Henri-Damien LAURENT
1c14654c8e Using openAuth function for authorities Searching
Adding two js functions :
getSubfieldcode(tagsubfieldid)  returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)

I think those two functions are much useful when cataloguing.

openAuth now takes all the information for Heading search of authorities.

TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:34:27 -06:00
Nahuel ANGELINETTI
bda53debab (bug #2996) update unimarc 105 plugin to the actual norm
This patch add some codes which have been added to the norm:
* Religious Text
* dissertation or thesis
* booklet
(cherry picked from commit 673bd0d832)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:23:08 -06:00
Nahuel ANGELINETTI
49a39b311a (bug #2996) fix and improve 100 and 105 unimarc plugins
This plugins need some stuffs for the users to help them to choose, like show the codes, add some codes, etc...
(cherry picked from commit 75e6ac4a03)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:22:51 -06:00
Henri-Damien LAURENT
c1682628e9 Translating UNIMARC plugins in English
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 839c87a48c)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 08:53:01 -06:00
Joe Atzberger
3d2ec1607d Trivial comment typos corrected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:57:24 -06:00
Nahuel ANGELINETTI
6b4fed3b47 (bug #2956) fix another results calculation
this patch fix more about 4XX plugin, for results display and calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-12 14:47:41 -06:00
Nahuel Angelinetti
7588809b0d bug 2829: add a plugin for 010$a field and 210$c
This plugin use the 'ISBN' field(010$a) to search the "publishercode"(editor) and set it in as 210$c.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 09:52:46 -06:00
Nahuel Angelinetti
3ad66441c8 (bug #2853) fix an error in returned string
this patch delete the last char of the returned string, that is not conform to unimarc, only one blankchar must be at the end of
the leader string.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:39:50 -06:00
Nahuel Angelinetti
e0bbb9d7e7 Delete all calls to thesaurus_popup.pl, and no more used plugins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:31:46 -06:00
Michael Hafen
db73b67f03 add isbn to cataloging search results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:16 -06:00
John Beppu
9f782076db bug 2563: could not input into marc 008, fields 7-10 and 11-14
You actually *could* input data into those fields, but it wasn't
immediately obvious, because the field size was "4" and the
value was "    ".  You couldn't type anything in until you
backspaced over the spaces that were there by default.

UPDATE 2008-11-05:  Make absolutely sure that those values
are 4 chars long (via JavaScript)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:24 -06:00
becbbf300d Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-22 14:48:57 -05:00
Nahuel Angelinetti
16fef8ba3e Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-21 10:23:18 -05:00
df13aeee3b Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:05:07 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Jesse Weaver
852f75bba6 fix for bug 2556: Overlaying records sometimes creates new record
This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:35:44 -05:00
0dcd876e6a Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:23:54 -05:00
Joe Atzberger
3a2f776875 Validation fix, include required "type" in link tag.
This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 18:19:06 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
d4ca58e80a Adding "New Item" menu option. Jumps to anchor for Add Item form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 11:56:51 -05:00
8a7a709fb3 Changing tabindex="-1" to tabindex="0". Fixes 2493.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 10:52:37 -05:00
Joe Atzberger
ecb43a165c addbiblio - HTML validation fix, add type to link
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-08 06:10:30 -05:00
Paul POULAIN
e3b24f3734 unimarc plugin fix, suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-08-04 08:12:28 -05:00
Paul POULAIN
0204569353 small typo/html fixes as suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-31 23:18:12 -05:00
Joshua Ferraro
bc408475f8 This patch resolves a few MARC21 Framework issues for
a default installation:

1. Re-names several of the item fields to make more sense to catalogers and patrons
2. Remove links Non-public note from items.paidfor
3. Changes Non-public note to be hidden in the OPAC view

Fixes issues with the 'hidden' field in the framework, specifically:

1. the editor obeys the rules of possible values for hidden (>4, or <-4)
2. the OPAC MARC display obeys the rules of positive values meaning 'hidden in OPAC'
3. the staff MARC display now obeys the rules specified in the hidden values description
2008-07-18 17:39:08 -05:00
e7a2255675 Formatting additem form with nicer layout.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-11 12:22:37 -05:00
Galen Charlton
c48da8131d bug 1909: add delete field/subfield button to MARC editor
A button to delete (non-mandatory) subfields and fields
is added to the bib and authority MARC editors.  This button,
which displays as a hypen or minus sign after the plus sign
to clone a field, acts as follows:

[1] When deleting a whole MARC field, if at least
    one other repeat of that field exists, deletes
    the field from the editor page.  If the field
    to be deleted is the last instance of that tag,
    the contents of the field are cleared, not removed.
    This allows one to delete all 650 tags, then
    add a new one without having to reload the
    record in the editor.

[2] When deleting a subfield, if at least one other
    repeat of that subfield and its tag occurs
    *anywhere else in the record, not necessarily in the same tag*,
    deletes the subfield.
    Otherwise, if the subfield is the last occurrence
    of that tag/subfield combination, clears the input
    form instead.

Documentation note: new screenshots for MARC editor, plus
description of the '-' button.

Credit to MJ Ray for introducing the '-' button
and the UnCloneField JavaScript function.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-07-08 12:31:30 -05:00
Joshua Ferraro
3959f41ca0 workaround for translation script 2008-06-20 20:12:55 -05:00
Galen Charlton
7ac682c859 bug 2265: fix problem when cloning MARC field
Correctly set indicators when cloning a field
in the MARC editor.  Prior this fix, a cloned
field would not be saved.  Bug introduced in
patch for bug 2207.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-20 09:41:00 -05:00
Andrew Moore
6e52709824 Bug: 2259: eliminate lines too long for git to use.
This patch modifies 13 HTML templates and includes that have lines in them longer than 998 characters. Lines this long are known to break git.

I believe that none of these change behaviour at all, but I'm concerned about one of them. It adds whitespace (carraige returns) inside a <title> tag. I'm not certain that all browsers will deal with this OK.

No documentation changes necessary here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-18 19:25:52 -05:00
691bcc631c Markup corrections to cataloging pages; Fixes for Bugs 2166 (" Book Jackets Not Showing on My Summary"), 2194 ("No results for Authority Search Shows blank record"), and 2196 ("Extra comma being added to record display")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-17 08:31:09 -05:00
Galen Charlton
ee49d6d372 kohabug 2207 - improve indicator input in MARC editor
Instead of having one input field for both indicators
of a variable field, the bib and authority MARC editor
now has an input field for each indicator.  This has
two main advantages:

* it is easier to tell what the indicator values are,
  even when the first indicator is a space
* it is easier to set the first indicator to blank
  and the second indicator to non-blank.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-12 11:17:35 -05:00
Ryan Higgins
938f053cbb Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-06-03 06:00:51 -05:00
756cdc15ac Swapping tablesorter version. GZipped version may have been responsible for errors in Internet Explorer. Change to usermenu.inc is whitespace only, for proper display in IE.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:28 -05:00
9717926644 Hiding empty results table when there are no results (prevents js error from tablesorter). Now links back to search form. Also includes minor CSS tweak for IE/Opera general layout problems.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:34 -05:00
Henri-Damien LAURENT
366432e18f Bug fixing : loading page macles would not load existing values for macles
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:47 -05:00
Henri-Damien LAURENT
472787bf17 Debugging Macles
say you want to edit 6 fields 630:
Provided you have those in your catalogue frameworks, you just selet 6 values and it puts values into that.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-05 05:45:43 -05:00
Joshua Ferraro
affaae1247 Normalizing s/On loan/Checked out/ 2008-04-25 15:28:14 -05:00