Commit graph

10420 commits

Author SHA1 Message Date
Garry Collum
4cb2c16587 Bug 3466: Fixes xhtml errors in opac-shelves.tmpl.
Addendum to bug 3466.  opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:10 -04:00
Garry Collum
67085930ca Bug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:08 -04:00
dbd6128715 DB rev 038>039 (for real, this time)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
fabede22cc textual cleanup of new quick spine label code
* perltidy
* added license header to source files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
57be4114d8 quell warning on NULL item fields
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
5d0f29090b removed unneeded module imports
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
636bb72702 quick spoine label followup: sysprefs
* Added missed SpineLabelAutoPrint to updatedatabase;
  this preference controls whether labels generated
  by the new quick spine label tool are printed automatically
* put SpineLabelAutoPrint and SpineLabelFormat in the
  Cataloging section of the syspref editor
* set height and width for the SpineLabelFormat textarea
  in the syspref editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
97b0448eeb bumping quick spine label printing to DBrev 039
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:15 -04:00
Kyle M Hall
6860310e96 Quick Spine Label Printer
This is a small tool for quickly printing spine labels using dedicated label printers.
It is located in the Tools page as Quick Spine Label Creator.
The system preference SpineLabelFormat defines which fields will be displayed.
The pref SpineLabelAutoPrint will make the print dialog pop up automatically.
The CSS file spinelabel.css controls all presentation for the labels.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 10:47:13 -04:00
b35b727924 DB rev 038->039
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:59:35 -04:00
23b63ff978 bug 3440 followup: tweak updatedatabase.pl
[1] Removed POD: not a bad idea, but if we do it,
    there should be more substance to the messages
[2] Improved description of change
[3] Removed extra 'my' qualifier.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:59:29 -04:00
Sébastien Hinderer
7fa051d837 bug 3440: C4/Branch.pm: the branch{zip,city,country,url,notes} rows should be taken into account during Add and Mod operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:44:32 -04:00
Sébastien Hinderer
1ac250ea27 bug 3440: Modifies branches script and template so that the newly added rows are taken into account.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:44:22 -04:00
Sébastien Hinderer
9d34a4caa1 bug 3440: Database structure modification.
Adds 5 columns to the `branches` table: `branchzip`, `branchcity`,
`branchcountry`, `branchurl` and `branchnote`.
I/O operations for these fields are not included.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:43:44 -04:00
9693cb36a8 bug 2505: cleanup warnings in reserve/request.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:10:28 -04:00
Garry Collum
94abcf6d98 Bug 2889: Removed toggle variable from Serials vendor search.
Removed toggle variable from acqui-search-result.pl.  Added highlighting using __odd__ to acqui-search-result.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:42:42 -04:00
Garry Collum
e997a4a11c Bug 2553: Additional patch for the branch drop-down in Existing Holds.
Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:42:36 -04:00
Colin Campbell
77e4b2ce9d Stop generation of unnecessary warning messages to log over undef values
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:39:57 -04:00
Henri-Damien LAURENT
08f0f8cba5 Installer break utf8 for DBD::mysql
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:30:21 -04:00
45f799a7de Minor change to fix Bug 3086, Can't close circulation date-picker popup in Internet Explorer
I don't know why this edit fixes the problem, but it does. Tested in IE6, IE7, and IE8 on Windows XP.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:27:23 -04:00
3caec55fd1 removed redundant license statement
The standard license statement in the header is fine; please
don't confuse things by doing anything different.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:17:52 -04:00
Paul Poulain
6b1df98ddf script to remove authorities without biblio attached
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:10:01 -04:00
a08e269db0 Removing unused recentacquiloop markup (Bug 3439)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:09:55 -04:00
Nahuel ANGELINETTI
bc9618c669 (bug #3458) fix die and unimarc 700-4 plugin
This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:01:41 -04:00
e5d9b34dce More XHTML corrections (Bug 3211)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:18:22 -04:00
f63456b025 XHTML corrections (Bug 3211)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:18:19 -04:00
Garry Collum
b904347142 Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.
Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:05:22 -04:00
Colin Campbell
5962dee647 bug 3434 Fix SQL Syntax Error when setting claimdate
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 21:22:39 -04:00
Colin Campbell
d11c3e608a (bug 3434) Fix generation of Serials Claims
op was not being returned to claims.pl. It seems better logic
to use whether the there are ids the user has flagged for claims
to decide whether to generate the claims

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 21:22:16 -04:00
Colin Campbell
05be94ba9a User will find it useful to see the date claimed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 21:22:13 -04:00
Galen Charlton
99afd35871 bug 3435: added missing _ in _FixAccountForLostAndReturned
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 14:36:30 -04:00
Kyle M Hall
207fb1c02a Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)
Added code to opac-ISBDdetail.pl to match the changes made to the template file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:37:04 -04:00
66d9fe254f Adding missing image: Bug 3457, broken image in opac.css - new.gif
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:37:03 -04:00
Galen Charlton
d903e7531f bug 3435 followup: tweak AddReturn cleanup
We're returning issue information when available,
not just item information.  Fixes problem where
circ/returns.pl wasn't displaying the due date
and patron when returning a loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:29:45 -04:00
Joe Atzberger
d24d147831 bug 3435: SIP2 - 3M extension for SmartChute checkin.
Implement the optional fields: CR CS CT CV CY and DA.
Also silenced some outstanding debugging print statements.
Consolidated similar accesseor subs in Patron.pm to use x_items.
Adjust SIP tests to specify correct AP (location).  Add a 3rd item
to SIPtext.pm for later use.

Note CT (destination) is currently populated with destination branch code.
We can adjust that to be destination branch name, or some combination in
a subsequent patch if necessary.

This work was sponsored by the Northeast Kansas Library system.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:06:53 -04:00
Joe Atzberger
51e8fc2cb6 bug 3435: AddReturn overhaul.
Required for SIP checkin implementation, but also for internal correctness.
AddReturn had too many things going on, with no guarantee of data being
available for the later calls.  At some point we started tacking on all the
branch transfer logic without testing edge cases.  In particular, $borrower
is not checked to be sure it is defined, considering the item may not have been
checked out so no borrower would be associated.  That means that CircControl
of "PatronLibrary" would be inaccurate, Circ Alerts will be totally confused
(untargeted), and the Fix... subs would fail.

Note that *many* errors are still present in _FixAccountForLostAndReturned, including
those where comments are added, such that it might behave strangely even with $borrower.

Renamed the internal subs with leading underscore, per convention.  Changed
the arguments to be scalars when only scalars are needed, not entire objects.
Added depth to WrongBranch message that includes Rightbranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:06:50 -04:00
Joe Atzberger
08816bab07 bug 3435: SIP Checkin extension for 3M SmartChute - partial
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 11:06:47 -04:00
Garry Collum
3a058fcc9d Bug 1607: Fixes the delete checkboxes in purchase suggestions.
If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed

Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 22:34:26 -04:00
Joe Atzberger
b36269ea85 Bug 3056 - replace span hacking for terms in C4::Search
Reimplemented using jquery, added OSS plugin to both interfaces.  This is
another case where having a /common directory used by both OPAC and STAFF
would increase runtime efficiency and cut development time.

Removed unused variables.

I changed the OPAC .term color to match the staff interface, rather than being a
second shade of blue.  The highlight/unhighlight link is currently a bit bolder
than its neighbors, but my styling choices are provisional.  I expect the final
tweaking of CSS to come from another more capable designer, like Owen.

Note this patch may rely on previously submitted "Search.pm minor cleanup" patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 22:06:55 -04:00
Joe Atzberger
08c158319d Search.pm minor cleanup
Trying to move towards enabling warnings.
Add warn for unknown $query_type.
Use common $dbh.

push @array, ({key1=>value1...}); is the same as
push @array, {key1=>value1...};

if ( scalar(@$arrayref) > 0 ) is the same as
if (scalar @$arrayref)

Lines like:
    my @operators = @$operators if $operators;
are bad because we need @operators to be declared and in scope later,
even if it is undef.  Without $operators, the variable is not in scope.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:51:38 -04:00
Garry Collum
11f05061cc Bug 3452: Displays borrower category and adds links to Suggestions Management
A couple of enhancments to Suggestions Management.

Adds a display of the borrower category of the suggesting patron for each item.

Adds links to the title and author displays so that the catalog can be quickly search for an existing bib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:44 -04:00
7ad2cfac6d Change to layout of tag review interface (enhancement bug 3447)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:41 -04:00
Kyle M Hall
38b356da8b Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:15:13 -04:00
Nicole Engard
04db609d9e BUG 1255 Barred users will not see renew or renew all anymore
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 21:11:31 -04:00
Galen Charlton
3ed41a2cfc Revert "Bug 3226 - Extended characters inconsistantly displayed"
This reverts commit 7a3bdce23d.

Even though patches were submitted that fixed the breakage
that this commit caused to NoZebra searchs, it turns out
this breaks code that uses SimpleSearch - clients of that
routine currently expect ISO2709 blobs, not MARCXML.

No further patches for 3226 will be pushed until a complete,
comprehensive patchset is submitted that (a) includes a
test case for the original bug and (b) demonstrates that
it doesn't break any aspect of bibliographic and authority
searching.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:57:10 -04:00
J. David Bavousett
a5bd87735e (Bug 3402) Serials issue name not escaped when passed forward to routing slip
The issue descriptor was not being escaped before being passed on to the
routing slip, causing truncation.  It's truly impossible to know for sure
what will be there, so uri_escape-ing seemed the best way to ensure that
it gets handed forward and makes it all the way to the printable slip.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:45:11 -04:00
Garry Collum
9046a26d68 Bug 2935: Patch to fix location in routing slip.
routing-preview.pl and routing.pl were pointing to a non-existent column in the borrowers table.  This patch replaces streetaddress with branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:44:56 -04:00
Garry Collum
a9609f6e96 Bug 2889: Added highlighting to Serials Subscriptions table in serials-home.tmpl.
Added highlighting to serials subscriptions table.  Cleaned up unused toggle variable code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-27 20:44:46 -04:00
Colin Campbell
acdb93ea6f Show claimed issues as 'Claimed' not just blank space
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 11:27:41 -04:00
Joe Atzberger
232aa85009 Fix POD for GetReservesFromBiblionumber
Only one argument is needed, as the name suggests.
Also removed unused package variable, added comments.

Fix POD for GetReservesFromBiblionumber

Only one argument is needed, as the name suggests.
Also removed unused package variable, added comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-22 11:27:39 -04:00