Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	3291c8b130	Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	053ee5c955	Bug 13346: OpacExportOptions becomes multiple The list of options is limited, the interface could be more ergonomic. Test plan: - verify that you are still allowed to change (add/remove) options for the OpacExportOptions pref. - At the OPAC, verify the selected options appear correctly (check the 3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	e0122701aa	Bug 13119 - Use XSLT to display tagged titles in the OPAC This patch updates the display of a logged-in user's tagged titles to use the same XSLT stylesheet used by search results and Lists. This would make for a more consistent display of information. Unrelated change: Corrected "My tags" header to read "Your tags," consistent with sidebar navigation. To test you should have multiple titles in your catalog which you have tagged in the OPAC. - Set the OPACXSLTResultsDisplay system preference to 'default' - Log in to the OPAC and view the "your tags" page. - Confirm that title information is displayed correctly. Compare to search results. - Empty the OPACXSLTResultsDisplay system preference and reload the "your tags" page. The display should revert to the old view, showing title, subtitle (if any) and author (if any). - Set the OPACXSLTResultsDisplay to a custom path pointing to a custom XSL file and confirm that the list of your tagged titles changes accordingly. Note: A follow-up will add "action" links ("place hold," "add to cart," etc) consistent with other pages. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. opac-tag.pl page displays tagged titles the same way as result & list pages. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
David Cook	f1323e60a2	Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	1c3b98e146	Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	33f53e4dfd	Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error. I could reproduce the bug. With patch bug is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, thx for the quick fix. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	6e7192f0d7	Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no regressions found. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolin Somers	260c423be8	Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'déjà' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Bug still present on master. I note that latin characters are taken by ISO-8859-1 encoding (Perl's default) and that's why real UTF8 ones don't break (Perl notices they are UTF-8).	11 years ago
Marcel de Rooy	1993b3090c	Bug 13050: Follow-up for bug 12371 This patch simplifies the SQL query in Letters.pm for table borrower_modifications. It also addresses the only case this query is used in opac-memberentry. An unused variable in Letters.pm is removed. Test plan: Enable selfregistration on opac. Set verification by email to required in prefs too. Self-register two new users. Check the email notices generated. Verify the new users with the tokens in their notice. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Much cleaner SQL Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Cleaner and works as described, no regressions found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	6b432853f6	Bug 12701 - OPAC reading history still accessible by URL if turned OFF If the opacreadinghistory system preference is turned off it is still possible to navigate directly to the OPAC reading history page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-readingrecord.pl To test, log in to the OPAC and test the following conditions: - With opacreadinghistory, navigating directly to /cgi-bin/koha/opac-readingrecord.pl should trigger a 404 error. - With opacreadinghistory turned on there should be a working link to "your reading history" in the left-hand sidebar menu. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and passes tests. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	e472456073	Bug 12703 - OPAC privacy page still accessible when the feature is turned off If the OPACPrivacy system preference is turned off it is still possible to navigate directly to the OPAC privacy page if you know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page still accessible when system preference is turned off) for opac-privacy.pl Because the OPACPrivacy preference is irrelevant if opacreadinghistory is not turned on, the patch adds a check for both to determine whether the page should be accessible. Log in to the OPAC and test under the following conditions: - OPACPrivacy is turned off, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned off, opacreadinghistory is turned on. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned off. Navigate directly to /cgi-bin/koha/opac-privacy.pl. You should get a 404 error. - OPACPrivacy is turned on, opacreadinghistory is turned on. A link to both "your reading history" and "your privacy" should appear in the left-hand sidebar menu. Both pages should work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and qa script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolin Somers	f7463f2320	Bug 13107 - Members are restricted even if the debarment is ended - opac-user This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past. 2) Go on the OPAC and connect (opac-user.pl) 3) Note the warning message "Your account has been frozen until until XX/XX/XXXX ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. NOTE: If you set a debarment with date in the past in the GUI, there will be no entry in borrowers.debarred and you won't be able to see the problem. Set one with a date in the future and then alter the date in borrower_debarments and borrowers.debarred. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolin Somers	a317f7d62f	Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past 2) Go on the OPAC and connect 3) Try to add an hold on a record (opac-reserve.pl) 3) Note the warning message "Sorry, you cannot place holds because your account has been frozen ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Makes code cleaner, also works as described. NOTE: If you set a debarment with date in the past in the GUI, there will be no entry in borrowers.debarred and you won't be able to see the problem. Set one with a date in the future and then alter the date in borrower_debarments and borrowers.debarred. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	f7d31f3916	Bug 13234: On-site checkouts - OPAC This patch introduces the code lost in bug 10860 for the OPAC side. Test plan: Go on opac-readingrecord.pl and verify the tabs work as expected and the "show all items" and "show 50 items" links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	dddde58967	Bug 9043: The comma (,) should be kept to separate multi-valuated prefs The prefs language and opaclanguages used the comma to separate the different values. The new prefs OpacAdvSearchMoreOptions and OpacAdvSearchOptions should do the same. To reproduce the issue: update the language pref (or opaclanguages) and refresh the page. => The pref values are not checked anymore and the language selection (bottom of the page) does not appear. Test plan: 1/ Verify that the behavior described above is fixed. 2/ Verify that the original test plan of bug 9043 still passes. Note: The 2 OpacAdvSearchMoreOptions and OpacAdvSearchOptions pref values are overwritten but the feature have just been pushed recently. It should not affect a production environment. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I was able to reproduce the issue and verify that this patch corrected the problem. Langage selection and OpacAdvSearchOptions worked correctly. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	3bc14af683	Bug 13116 [QA Followup] - Remove tabs, use unless instead of if Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Olli-Antti Kivilahti	51f0a0b722	Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error messages and how they are dealt with in the templates. This change makes it possible to distinguish between different types of reservation failure. Currently only two types of errors are handled, all the way to the user, from the CanItemBeReserved(): -ageRestricted -tooManyReserves which translates to maxreserves ############# - TEST PLAN - ############# ((-- AGE RESTRICTION --)) STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16". 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You get a notification, that placing a hold on ageRestricted material is forbidden. (previously you just got a notification about maximum amount of reserves reached) ((-- MAXIMUM RESERVES REACHED --)) 0. Set the maxreserves -syspref to 3 (or any low value) STAFF CLIENT AND OPAC 1. Make a ton of reserves for one borrower. 2. Observe the notification about maximum reserves reached blocking your reservations. ((-- MULTIPLE HOLDS STAFF CLIENT --)) 3. Observe the error notification "Cannot place hold on some items" ((-- MULTIPLE HOLDS OPAC --)) 1. Make a search with many results, of which atleast one is age restricted to the current borrower. 2. Select few results and "Place hold" from to result summary header element. (Not individual results "Place hold") 3. Observe individual Biblios getting the "age restricted"-notification, where others can be reserved just fine. Updated the unit tests to match the new method return values. t/db_dependent/Holds.t & Reserves.t Followed test plan. Works as expected and displays meaningful messages for the reason why placing a hold is not possible. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	4413a1ac4a	Bug 10632 - Enable datatables for courses and course details in the OPAC We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. Test Plan: 1) Apply this patch 2) View the courses in the OPAC, try sorting and searching 3) View the course details for a course, try sorting and searching the items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signing off, but have a follow-up to address some missing stuff. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	b1174b24a1	Bug 9043: Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Jonathan Druart	8dfc4326e8	Bug 12627: Fix date management C4::Dates->today returns a string formatted depending on the dateformat syspref. Before the original patch, SQLHelper managed both format (string formatted and DateTime. Now DBIX::Class only manages DateTime, so the call to NewSuggestion and ModSuggestion should pass a DateTime object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Yohann Dufour	1c2744a83f	Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion use DBIx::Class instead of C4::SQLHelper. Moreover, the tests and the .pl have been adapted. Test plan: 1) Apply the patch. 2) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 3) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS 4) Log in the intranet, create a suggestion and verify the created suggestion. 5) Edit a suggestion from the intranet and verify the suggestion is correctly modified. 6) Log in the OPAC and verify you can add a suggestion. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, suggestion created on staff and opac, suggestion edited without problems, no koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script: Also tested: - adding suggestion from staff and OPAC - edit suggestion from staff - deleting suggestion from OPAC - changing to a normal status (email got created) - changing to a custom status (SUGGEST_STATUS) - display of custom status in OPAC No problems found. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	5a82616ab7	Bug 10582: Koha OPAC URL shows Perl error message before web installer was run This patch makes opac/maintenance.pl run smoothly when the DB hasn't been populated yet. It does so, by using C4::Templates::gettemplate instead of C4::Auth::get_user_and_template as the maintenance page doesn't need authentication checks at all, it should happen before any attempt to check credentials. To test: - Backup and DROP your database - Point your browser to the OPAC page => FAIL: An error is shown: "Cant's use an undefined value as an ARRAY..." - Apply the patch - Relad the page => SUCCESS: The maintenance page correctly shows. We should now check the rest of the script's behaviour remains untouched: - Reload your backed up DB - Change your DB version number by hand to one version lower, like in: > UPDATE systempreferences SET value="3.1700042" WHERE variable LIKE '%version%'; - Go to the OPAC => SUCCESS: Maintenance page shows as expected - Recover the right version number, like in: > UPDATE systempreferences SET value="3.1700043" WHERE variable LIKE '%version%'; - Set OpacMaintenance to Show on the staff client - Reload the OPAC => SUCCESS: Maintenance page shows as expected - Set OpacMaintenance to 'Don't show' on the staff client - Reload the OPAC => SUCCESS: Normal OPAC shows - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, fixes long existing bug. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Frédéric Demians	3cbf754702	Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details In the OPAC if you view the MARC details for a title (and have OPACXSLTDetailsDisplay enabled) there is a "view plain" link which displays the output of opac-showmarc.pl. This is broken in master: fixed by this patch. Test plan: (1) Set OPACXSLTDetailsDisplay to default (2) Do a search on OPAC, then display a specific biblio record (3) Click on MARC view tab. Then click on 'view plain' link. Nothing is displayed. (4) Apply the patch. And refresh the MARC detail page. (5) Click on 'view plain' link. Check that a plain text MARC record is displayed. Signed-off-by: Chris <chris@bigballofwax.co.nz> Note: This makes a small change to C4::Templates::themelanguage so that it works with .xsl files too (They live in the xslt dir) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	13c93259bd	Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template Since the bootstrap OPAC's place hold interface doesn't use tables there is no use for the colspan calculation being done in the script. This patch removes it. To test, place one or more holds in the OPAC and confirm that there are no display problems. The OPAC error logs should show no associated error. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No display problems, no related errors on log, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no regressions found. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	b52a24efb2	Bug 13083 - Hard-coded " by " in opac-tags.pl The OPAC's list of a logged-in user's tagged titles displays title and author, which for some reason are combined in the script into one variable. I can't see any reason to do it this way. This patch modifies the script so that title and author are passed as separate variables. In addition, subtitle is now passed as well. To test you must log into the OPAC as a user who has tagged multiple titles, at least one of which should have an author and at least one with a subtitle. View the list of tagged titles and confirm that this information is being displayed correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Chris Cormack	9a2553625e	Bug 9530 making changes to opac/opac-sendshelf.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Send a list from the public (OPAC) interface 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Chris Cormack	0c161a9a66	Bug 9530 making changes to opac/opac-sendbasket.pl To Test 1/ Edit the new systempreferences (ReplytoDefault and ReturnpathDefault) 2/ Optionally edit the branch the mail will be sent from, adding email addresses 3/ Send a cart from the public site (OPAC) 4/ Check that the mails have the correct From, Replyto and ReturnPath set The rules are If the values are set in the branch use that, else use the syspref Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Martin Renvoize	3c9004357d	BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jesse Weaver	244cfaba71	BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Matthias Meusburger	400b538078	BUG8446: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set BUG8446, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) BUG8446, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout BUG8446, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. BUG8446, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. BUG8446, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with the feide idp. - LDAP login and logout are working - local login/logout are still working - CAS login/logout are still working Instructions for setup can be found on the wiki: http://wiki.koha-community.org/wiki/Shibboleth_Configuration Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	13 years ago
Jonathan Druart	cf2eb49448	Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Rafal Kopaczka	e9eef04b95	Bug 12876 - Reserve in waiting/transfer status may be cancelled by user User may cancel his own reservation at waiting or in transit status through calling opac-modrequest.pl. Cancel button is disabled in interface but possibility to cancel should be checked also in opac-moderequest.pl, before calling CancelReserve(). Similar situation is with opac-modrequest-suspend.pl This patch provides new soubroutine to chceck if user can cancel given reserve. It's possible only when he's owner of hold and hold isn't in transfer or waiting status. Additionaly there are new test for this function in Reserves.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests, QA script and new tests. Works as described, tested with: .../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Rafal Kopaczka	6a98db50fc	Bug 12873 - Reserve can be cancelled by any logged in user It is possible to cancel reservations through simply running opac-modreserve.pl with existing reserve_id number. This may provide remove even all reservations from system. The only limitation is that user have to be logged in. Simplest solution is to check whether reserve belongs to user or not. Test plan: 1. Create reserves by 2 different users, and get their ID's 2. Before patch, hold may by cancelled by anyone who run site: http://example.com/cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX 3. After patch hold may by cancelled only by user whose reserve is. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Holger Meißner	17821c58cc	Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Robin Sheat	c8016e0a0c	Bug 12849 - fix URLs in sent lists This brings back the http(s) to the URLs in sent lists. Test plan: * make a list * send it to yourself * see that the URLs aren't clickable * apply the patch * repeat, except now the URLs are better Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> By removing this bit of code, the code in Auth.pm is used instead. The code there is not perfect, but the solution works and both list and cart use the same code. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Mark Tompsett	f5320c4bf8	Bug 12330: OpacHiddenItems not affecting Advanced Search This patch affects only the area displayed on Advanced Search by setting the AdvancedSearchTypes OPAC system preference accordingly. Prior to this patch, no filtering based on OpacHiddenItems was done. This patch determines if itemtypes, collections, or shelving locations are hidden and prevents them from being shown. TEST PLAN --------- 1) Back up your DB (always handy) 2) Set the Searching system preference AdvancedSearchTypes to: 'itemtypes\|ccode\|loc' (without the single quotes). 3) Set the OPAC system preference OpacHiddenItems to include the lines: itype: [{list of itemtype codes separated by commas}] location: [{list of comma delimited shelving location codes}] ccode: [{list of comma delimited collection codes}] Make sure to exclude one value for each, so there will be at least one known thing on each tab. 4) Open the OPAC. 5) Click on 'Advanced Search' -- three tabs appear: Itemtypes, Collection, Shelving location -- Everything is visible 6) Set the Searching system preference AdvancedSearchTypes to: 'itemtypes \| ccode \| loc' (without the single quotes). 7) Refresh the OPAC. -- There will be three tabs, but ugliness ensues. 8) Apply the patch 9) Refresh the OPAC. -- You will see: Itemtypes, Collection, Shelving location -- Only excluded values from OpacHiddenItems will be seen. 10) Run koha qa test tools Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Small rewording in comment only. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	c435ceb916	Bug 12718 - Show extended patron attributes in the OPAC At some point the patron details page in the OPAC lost the display of patron attributes. This patch returns the attributes to the update page. To test, log in to the OPAC as a patron who has data in one or more extended patron attributes. View the "your personal details" page (opac-memberentry.pl): - Confirm that the information displays correctly. - Test with OPACPatronDetails both on and off. - Test with patron who has no data in extended patron attributes. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Attributes only display when 'display in OPAC' is configured. Attribute shows correct description, when authorised value is used. Works as expected, updating is currently not yet possible. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
David Cook	6768c2874b	Bug 10542: QueryParser + OpacSuppression doesn't allow search in 'all libraries' Since we're using the $query_type variable to detect if this pre-built query is PQF, we need to use PQF syntax (rather than QueryParser syntax) when adding to the query. I've made a lot of notes of somewhat incoherent notes on Bugzilla talking about PQF, CCL, and QP syntaxes, but I'm hoping to refine these notes on a wiki page for future reference. _TEST PLAN_ 1) Set 'Suppress in Opac' (ie 942$n) to 1 for one record 2) Re-index Zebra 3) Set 'OpacSuppression' to 'Hide' 4) Set 'UseQueryParser' to 'Do not try' 5) In the staff client, do a search that will return that suppressed record as well as a few records that are NOT suppressed 6) Note that you can return that suppressed record in the staff client 7) Do the same search in the OPAC 8) Note that the suppressed record doesn't appear 9) Set 'UseQueryParser' to 'Try' && re-run the OPAC search 10) Note that no results appear (the logs will probably mention a ZOOM error) 11) Apply patch 12) Re-run the OPAC search 13) Note that the suppressed record doesn't appear, and that the not suppressed records are showing (it's important that you are getting some results...as ZOOM errors are silent in the UI). 14) Set 'UseQueryParser' to 'Do not try' 15) Re-run the search 16) Note that the suppressed record doesn't appear, and that the not suppressed records are showing Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described following test plan. No koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described - hidden records are hidden. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Martin Renvoize	449b365a48	Bug 10542: Fix QueryParser with OpacSupression OpacSupressions manipulates the query string after the buildQuery call and so breaks with queryParser enabled. This patch adds checks for queryParser and manipulates the query before passing it to buildQuery if it is enabled, but leaves the post buildQuery manipultation when queryParser is disabled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Adding a sing after test Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	bbfc908fd8	Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Set maxreserves to 3, set opactheme to bootstrap 4) Log into the opac as a patron 5) Place 3 holds 6) Attempt to place a 4th hold 7) Note you get an error message and cannot place a forth hold 8) Delete two of those holds 9) Attempt to place 3 or more holds as a multi-hold 10) You should see a warning that you cannot place this many holds 11) Try to anyway 12) You should see an alert to tell you to reduce the number of holds you are placing. 13) Reduce the number for holds you are placing to 2 14) Your holds should now be placed Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Olli-Antti Kivilahti	2db8ba555d	Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying to place a reservation when one has "too_much_oweing" or too much fines. Removing the dollar sign so we just get <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja 9.50."> instead of <"Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on maksamattomia maksuja $9.50."> Patch removes hard coded $ sign. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The dollar sign is gone and the message still displays correctly. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Zeno Tajoli	7123eeccf8	Bug 12174 follow-up of the patch (a missing print statement) http://bugs.koha-community.org/show_bug.cgi?id=12174 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Zeno Tajoli	ec44d407d5	Bug 12174 - Zotero connection with Koha: problem with UTF-8 This patch solves the bug for UTF-8 output. MARC-8 works only if you save it as a file. In fact the standard Internet stack (browser, web server, etc.) doesn't know anything about MARC-8 or it's ISO base (ISO 2022). To test the bug: -- without the patch use Zotero on a recent Koha install with Apache. You can use PTFS sandboxes. You can't use Biblibre sandboxes, they use Ngix. -- Test a record with special chars. -- Install the patch -- Catch (using Zotero) the same record. -- Test all directly download from Opac. -- To check MARC-8, use a tool that support it. For example MarcEdit. http://bugs.koha-community.org/show_bug.cgi?id=12174 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described Tested with zotero add-on for firefox. Before patch bad diacritics, after patch ok Record exported as MARC-8, transformed using yaz-iconv -f marc8 -t utf-8 bib.marc8 > bib.utf8 yaz-marcdump -i marc -o line bib.utf8, checking accents, also comparing with direct utf-8 export No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with Zotero in Firefox and with yaz-iconv as suggested by Bernardo, no problems found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	f804aecaab	Bug 12568 [QA Followup] - Use ':' as separator instead of '\|' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	ae81b7c473	Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins@ci.arcadia.ca.us> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Makes successful renewals more visible to the user in the OPAC. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	e185aaf19b	Bug 12519 - Convert OPAC list download pop-up to modal dialog This patch changes the OPAC list download process so that the download link triggers a modal dialog instead of a pop-up window. This streamlines the process a little bit and makes it work better on mobile devices. The download list page has been altered so that it works better as a standalone page, as it might be seen if JavaScript is disabled. Simple form validation has been added to help prevent submission of the form without choosing a format. To test the virtualshelves system preference must be enabled. - View an existing list in the OPAC and click the "download list" link. - A modal dialog should be displayed with the download form. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute. - Choosing a download format and submitting the form should close the dialog and trigger the correct download. - Clicking the "Cancel" link should close the dialog. Test with JavaScript disabled: - Clicking the "download list" link should take you to a page which contains the same form which appeared in the modal dialog. - Submitting the form without selecting a format should trigger either a browser-based form validation error (in HTML5-supporting browsers) or a JavaScript alert (if your browser doesn't support the "required" attribute.. - Choosing a download format and submitting the form should result in the corect download. - Clicking the "Cancel" link should return you to the correct list. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests, works as described. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	c53520d58d	Bug 12062: Follow up to fix more untraslatable cases This patch modifies staff printslip.tt to take into account caller. Also fixes similar problem on opac printslip.tt To test: staff 1. Print hold transfer slip 2. Print transfer slip 3. Print member slip opac 4. Print self checkout slip 5. Update translation files, check new strings are present Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	091a74de4c	Bug 12151: Remove uses of smartmatch operator in Search.pm and opac-search.pl This patch removes the use of smartmatch operators in the search code. Regards To+ Edit: this revision uses 'grep' instead of Lists::MoreUtils::any Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested search, no problems found. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago

... 3 4 5 6 7 ...

1394 Commits (b64e6be1c4f3dbdcde41ac8f4766b4d1f962610d)