Commit graph

6872 commits

Author SHA1 Message Date
Paul POULAIN
a553ea88b1 fix to handle notforloan authorised values (we now handle wthdrawn, itemlost, damaged AND notforloan fields)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 14:32:59 -06:00
Paul POULAIN
6686dda761 mapping items.onloan to 995$n (to handle biblio status from zebra)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 14:32:58 -06:00
Galen Charlton
d202aac596 fix typo: "Ok" => "OK"
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 14:27:54 -06:00
Galen Charlton
230df085c7 removed unmatched /TMPL_IFs
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 14:27:54 -06:00
Joshua Ferraro
9b8201328d prefixing all holdings auth values with HINGS 2007-12-26 10:40:58 -06:00
Joshua Ferraro
3b7029f4ed modrequest.pl did not previously have auth checking, security bug!
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 13:58:01 -06:00
Joshua Ferraro
ab8a6af819 removing unused ReadingHistory syspref
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 13:57:44 -06:00
Joshua Ferraro
58d425cf7b fix for bug 1696: Reading record page fails
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 12:28:55 -06:00
Joshua Ferraro
11005a5236 removing postgres sql from main installaer dir, it exists in data/Pg/, though in a different form, Chris, please double-check that I haven't removed the latest one and if so, git revert and git mv it into the right slot.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 12:28:44 -06:00
Joshua Ferraro
4e8f822f6e fix to bug 1569
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 11:46:31 -06:00
Joshua Ferraro
200e44c1ce WARNING: BIGFIXING 670
670 is primarily about the status of a biblio or item that's got a
hold on it ... specifically the 'in transit' and 'waiting' status.
It applies to the following pages.

* request.pl - tested
* detail.pl - tested
* circulation.pl - tested
* moremember.pl - tested
* opac-user.pl - doesn't show transit status, but only shows waiting
when item has arrived at the pickup library
* opac-detail.pl - doesn't show hold statuses

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 11:07:38 -06:00
Galen Charlton
c87df4e334 bug 1368 - remove FOREIGN_KEY_CHECKS = 0 from installer
[1] Web installer no longer sets FOREIGN_KEY_CHECKS = 0
    when loading frameworks and sample SQL.
[2] Removed FOREIGN_KEY_CHECKS = 0 from SQL scripts
[3] Fixed FK issues in en/optional/sample_patrons.sql

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:44 -06:00
Galen Charlton
89e38b5d5f fixed typo in directory name
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:42 -06:00
Chris Nighswonger
d3dc1ad99c Updating README.debian
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:41 -06:00
Galen Charlton
0456e457dc IMPORTANT - replaced TransformMarcToKoha
Replaced with FasterTransformMarcToKoha
from a previous commit.  Main differences are:

[1] At least twice as fast because of improvement
    in algorithm for processing the MARC record --
    each tag is processed only once.
[2] Fixed bug where biblio.notes would end up with
    an extra ' | ' at the end.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:39 -06:00
Galen Charlton
3508933c66 bulkmarcimport: enable MARC-8 to UTF-8 conversion
Enabled automatic conversion of MARC-8 records to
UTF-8.  Record is converted if its Leader/09 contains
a blank and the -s (skip) option hasn't been supplied
on the command-line.  Any record that cannot be converted
to UTF-8 is skipped.

Also now use Unicode Normalization Form C (NFC) for
records converted from MARC-8.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:38 -06:00
Galen Charlton
4ad5df9655 fixed C4::Dates usage that caused crash of orderreceive.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:36 -06:00
Galen Charlton
d426a91d0e removed extraneous comments
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:35 -06:00
Galen Charlton
cb6cf680bc improved error detection in AddBiblioAndItems
Introduced new C4::Biblio function CheckItemPreSave,
which checks for duplicate barcodes and invalid
branch codes.  Not yet sure whether this function
needs to be exported or whether it will just be
used internally to C4::Bibli.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:34 -06:00
Galen Charlton
eeafadc598 fixed error message when branch cannot be saved
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:33 -06:00
Galen Charlton
6b49df4c3f removed superfluous comments
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:31 -06:00
Galen Charlton
f60f4987a3 C4::Biblio::AddBiblioAndItems - added duplicate barcode check
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:30 -06:00
Galen Charlton
7d47666f7e bulk MARC record import - speed improved
Changes to improve speed of MARC bib and item
imports:

[1] Turn off autocommit and commit database
    transactions in larger batches.
[2] Introduce a new C4::Biblio function (AddBiblioAndItems)
    to combine AddBiblio and AddItems -- this is faster
    because we are not parsing the MARC XML of the biblio
    every time we add an item.
[3] Introduce FasterTransformMarcToKoha, which is much
    faster than TransformMarcToKoha.  The new version,
    which will replace the old one once it has been
    fully tested, scans through each field in the
    MARC record just once, instead of potentially
    dozens of times.
[4] Remove code in bulkmarcexport that moved the
    item tags to separate MARC::Record objects.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-25 09:08:28 -06:00
Joshua Ferraro
2143002750 IMPORTANT: BUGFIXING STATUSES
Major bugfixes:
* Circulation status in moredetail.pl now correctly displays On loan
status and Date due
* Bugfixes on Status column in detail.pl
   * Removed hard-coded English strings from status column in detail.pl
      * Added missing auth values for lost and damaged statuses, sane
defaults if those auth
     values don't exist
        * Added missing 'On hold' status and 'Hold waiting' status
display

Medium bugfixes:
* Now correctly shows itemtype at level specified in systempreference
* Uses itemtypeimage for display, image title is full itemtype
description

* Fixed Location column concatenation between branchname location and
itemcallnumber
  * broke out Location (branch), Collection (items.location)
      Call Number (itemcallnumber) into their own columns
        * Added auth value display for items.location

	Minor fixes:
	* detail.pl didn't show dates correctly
	* nomenclature s/Checked out/On loan/ in opac-detail.tmpl
	* s/Book/Item/ in my $desc="Item Returned
".$iteminfo->{'barcode'}; in Circulation.pm
* request.tmpl: s/date_due/onloan/ to display date due
* Fixed SimilarItems, XISBNSimilarItems

NOTE: Needs to be ported to OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 13:34:44 -06:00
Joshua Ferraro
ec86f2bd77 forgot to add imageurl to OPAC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 02:03:57 -06:00
Joshua Ferraro
a8ba013e1e Synching opac with fixes to reserves adding back dev_week opac reserve cancel feature that was removed Could use some style improvements
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 02:01:04 -06:00
Joshua Ferraro
80a37880ac improvements for translation, switch to use same views as rest of biblio
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 02:00:33 -06:00
Joshua Ferraro
43334b8cec bugfixing request.pl
Major Fix:
Fixing bug where 'expected' label existed for items that
were 'waiting'

Minor Cleanup:
Show correct statuses
Show itemtypes at correct levels depending on
global system preference
Display branch names, not branch codes
Adding in visibility option for 'canreservefromotherbranches' syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 00:43:26 -06:00
Joshua Ferraro
61d8942a20 show itemtypes at level specified in syspref for holds
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-24 00:43:14 -06:00
Joshua Ferraro
8a9e6801df fixing requests.tmpl, adding side-tabs (views)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 21:55:16 -06:00
Joshua Ferraro
e4799032d2 Warning: big commit Fixing moredetail.pl
Previously, about 50% of the data on this page was either incorrect or missing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:32:34 -06:00
Joshua Ferraro
94387a73ee adding auth value for 'Missing in Holdqueue'
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:32:24 -06:00
Chris Cormack
c3f1a079d1 Doh, typo, fixed
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:17 -06:00
Chris Cormack
04fd34d948 Reserves not made at priority 0 if ReservesNeedReturns is switched on
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:16 -06:00
Chris Cormack
5e1921e6af Missed one priority == 0
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:15 -06:00
Chris Cormack
883edf9391 Priority = 0 does not equal reserve found, only found='W' equals reserve found
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:14 -06:00
Chris Cormack
618ae1855b An item is only waiting if found is set to W in the reserves table
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 20:27:11 -06:00
Chris Cormack
55a525cb3a Fix for bug 1703
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 17:53:43 -06:00
Joshua Ferraro
ba7287c03a nomenclature cleanup in the OPAC detail and user pages
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 15:48:04 -06:00
Joshua Ferraro
8903f62102 fix for bug 1688
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 15:01:06 -06:00
Joshua Ferraro
d17f7e8ab0 expandtab, retab, tabstop=4
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 15:00:57 -06:00
Joshua Ferraro
1647ab1874 Revert "Merging hdl's Search.pm changes"
This reverts commit 51ec728f7b.

That commit basically reverted 95% of the status handling I'd done
last week ...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 14:50:37 -06:00
Joshua Ferraro
24c47ce90d retab with tabstop=4 and expandtab on
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 14:50:28 -06:00
Joshua Ferraro
85092daa56 Warning: Big Commit. Fixing Virtual Shelves
* prior to this commit, virtual shelvesn't did not function in
    the OPAC! Now they do, except for deletion from virtual shelves
    in list form
  * I've re-named 'Virtual Shelves' to 'Lists' as per our agreed
    upon convention

  * while vshelves aren't perfect yet, they're in enough of a working
    state for the RC1 now

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 14:31:14 -06:00
Joshua Ferraro
9b14c385cc adding ports information
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 14:31:04 -06:00
5b2f5dd3f4 Minor correction to template markup and change to script to allow for more clickable <label>s.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-23 14:26:40 -06:00
Galen Charlton
4609608ccc allow use of older version of File::Temp
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-22 22:58:12 -06:00
Joshua Ferraro
9441380f60 more updates to README.debain
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-22 20:09:37 -06:00
Galen Charlton
4c72d109ce fixed invocation of zebraqueue_daemon.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-22 20:09:34 -06:00
Galen Charlton
875f4552be circ: do not crash when 'returning' item that was not issued
When attempting to return an item that was not actually
on loan, would crash because GetItemIssue did not return
biblionumber in hash.  Add call to get biblionumber
directly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-22 20:09:29 -06:00