Commit graph

1391 commits

Author SHA1 Message Date
Galen Charlton
5fabddfe38 made several PKs be auto_increment columns
* biblio.biblionumber
* biblioitems.biblioitemnumber
* items.itemnumber

These IDs are no longer increment by the Perl code, thus
allowing better concurrency during bib/item editing.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-01 17:31:33 -05:00
Joshua Ferraro
af21bbd65a fix to rightANDlefttruncation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-01 17:29:58 -05:00
Mason James
9893fa198b bug-1494, fixed bookfund modify code
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-01 17:27:55 -05:00
Mason James
98683262ca Modbookfund() now correctly updating all aqbudget.branchcode's linked to mod-ed bookfund
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-01 17:26:28 -05:00
Mason James
8e76a806bc Working on fixing bug for acquisition bookfund modifying, work in progress
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-01 17:26:18 -05:00
Galen Charlton
74d3d6e8e3 comment out version check warn
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:44:23 -05:00
Galen Charlton
e90115293a bugfix: deletedbiblioitems row now added upon delete of a biblio
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:44:00 -05:00
Henri-Damien LAURENT
2584597369 BugFixing: Suivi.paulpoulain.com Bug 275
Miscalculation of innerloop bounds
caused a numbering pattern error.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:40:37 -05:00
Henri-Damien LAURENT
d2b15eeb9a Adding titles to claimissues letter.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:40:16 -05:00
Paul POULAIN
973adba104 dealing with empty XML : return an empty string, and not an empty MARC::Record
(Useful for zebraque_start)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 19:39:21 -05:00
Joshua Ferraro
4f29dcb57a fixing fielded truncation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:57:06 -05:00
Galen Charlton
01c19a265a batch import rework: added suport for loading and dropping items
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:56:51 -05:00
Galen Charlton
5f972e33ab quelled perl -w variable masking warnings
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:56:31 -05:00
Galen Charlton
b5e18fe431 Biblio.pm - restored after duplicate application of
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:54:38 -05:00
Paul POULAIN
1cd11f4d54 fixes in NoZebra search & indexing
- the quotemeta was wrong (and introduced some bugs in diacritics)
- fixing some bugs that appear only sometimes : the union was done including weight, which is wrong & resulted in missing some results (when various weighting)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-31 05:53:36 -05:00
Paul POULAIN
317736360b fix related #1340 (z3950 search for quick cataloguing)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-30 17:44:21 -05:00
Chris Cormack
a188b6a512 Fix for bug 1527, removing Smart::Comments
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-30 17:39:19 -05:00
Chris Cormack
7273e0f0da Removing windows linefeeds \r
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 21:24:27 -05:00
Joshua Ferraro
76064f4623 adding SMS stuff so we don't forget about it
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 21:21:20 -05:00
Joshua Ferraro
f3fac7a562 patch to sysprefs and minor fix to Search.pm that
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 21:21:17 -05:00
Joshua Ferraro
a1e9d9055a fixes to enable truncation to play nicely with
field weighting, stemming, fuzzy, etc.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:45:21 -05:00
Joshua Ferraro
66b2cb4e38 major cleanup of buildQuery, creating some internal functions
to handle stemming, field weighting, truncation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:45:20 -05:00
Joshua Ferraro
026a3349d9 fixing re-sorting in staff client
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:45:18 -05:00
Joshua Ferraro
558fc5dd83 fixing branch limits and searchdomain limits
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:45:18 -05:00
Joshua Ferraro
dbabdce3e0 fixes to searching:
* bringing back facets
* bringing back stemming (syspref controlled)
* bringing back field weighting (syspref controlled)
* bringing back language limits
* bringing back year limits
* fixing 'expanded view'
* improvements to template

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:45:17 -05:00
Joshua Ferraro
4559e0e0e0 Searching Patch 1: fixing searching in 3.0
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:45:14 -05:00
Chris Cormack
0483e34162 Fix for broken Biblio.pm
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 17:11:42 -05:00
Galen Charlton
853aa657ba batch import rework -- implement stage-commit-undo for batch import
Revamps the import options on the tools menu to have two parts:

[1] Staging (load file into reservoir)
[2] Managing (review the list of staged batches, then
    choose to commit or undo a given batch.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:47:59 -05:00
Galen Charlton
2e07983367 more work on batch import
* Completely removed old marc_breeding table
* Started updated Tools import function to stage records

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:47:58 -05:00
Galen Charlton
b49bf59589 more work on the import changes; introduced C4::Matcher
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:47:56 -05:00
Joshua Ferraro
edd54d9fad fixing itemtype image, sample data, improving
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:47:54 -05:00
Chris Cormack
131ca67f2d Catching up changes in reports
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:48 -05:00
Chris Cormack
71d41c0a9b Can now view sql, and reports run page shows name
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:38 -05:00
Chris Cormack
ce0b4276f6 Getting stored results working
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:34 -05:00
Chris Cormack
0f315a2cd5 Storing xml now
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:32 -05:00
Chris Cormack
6ac79ef1e0 Can now delete reports
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:31 -05:00
Chris Cormack
031dc49098 Tidying up TransformMarctoKoha
Still some work to do, but people can see the idea and decide if its good

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:21 -05:00
Chris Cormack
762a8e1129 Fixing mess in Auth.pm
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:17 -05:00
Chris Cormack
92c1c00e4a Revert "Commenting out some noisy warns"
This reverts commit f4df886c707a97da9296be9dbd59f5c74244d5d1.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:13 -05:00
Chris Cormack
beb1baf686 Fixing merge error
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:09 -05:00
Chris Cormack
ea899bc559 More work on the scheduler
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:12:07 -05:00
Chris Cormack
51ad3c371a Files needed by the scheduler
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:11:33 -05:00
Chris Cormack
83433f61b6 Pretty close to finished the dictionary now
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:11:29 -05:00
Chris Cormack
3122d1fdbf Can now add definitions to reports
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:11:27 -05:00
Chris Cormack
31597c6762 Dictionary now working
Have to integrate with the rest of guided reports

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:11:26 -05:00
Chris Cormack
b347ff51a6 Adding reports code
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:11:22 -05:00
Mason James
77826791d7 adding missing 'routingnotes' cols to sql
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:06:10 -05:00
Galen Charlton
d37919eab9 improved import batches part 2 -- replace use of marc_breeding
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-29 16:05:25 -05:00
Paul POULAIN
6cfc26f856 defaut search on kw,wrdl
without this, the search is done on kw, and truncation is not possible.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:03:22 -05:00
Paul POULAIN
6f5a9ee480 IndependantBranches behaviour fix
if IndependantBranches is set, then the user can't choose it's branch, it's automatically affected to it's own branch.

This fix removes the branch list & choose the branch automatically from the login

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:02:24 -05:00
Galen Charlton
960db4e458 Biblio.pm bugfixes
- uses new C4::Dates instead of C4::Date
- start work on TransformMarcToKoha
  * handle ambiguities in certain column names
  * part of patch inspired by Chris Cormack
- fix bugs preventing biblioitems and items
  from being properly updated
- ensure that biblionumber and biblioitemnumber
  always get mapped to MARC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 17:00:00 -05:00
Joshua Ferraro
38cab4d72c fixing date display for koha-news
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-24 16:54:18 -05:00
Galen Charlton
7e044751ef ignore "/" when sorting Dewey call numbers
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-23 18:24:29 -05:00
Joe Atzberger
539974308c Context.pm: Trivial adjustment for clarity.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-23 18:23:14 -05:00
Chris Cormack
53be8065d1 Fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:58:14 -05:00
Galen Charlton
af9dfd9cda bib and item editing bugfixes
- bugfix: update items.cn_sort upon edit of item
- bugfix: make failure of a value_builder plugin non-fatal
- bugfix: remove references to non-existent plugins
          from optional MARC21 frameworks
             bookseller.pl
             marc21_callnumber.pl
             marc21_classcodes.pl
             marc21_locationqualifier.pl
- bugfix: corrected trying to enter 'u*' fields twice in the 'CF'
          format in the optional MARC21 frameworks; resulted in
          most of the framework not being loaded

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 19:56:53 -05:00
Chris Cormack
1f5e1606e8 Fixing a little bug with Context, USER_AGENT changed to HTTP_USER_AGENT
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 16:45:55 -05:00
Galen Charlton
d7d4f699a3 quell warning about C4::Context::DIR being used only once
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 15:42:43 -05:00
Henri-Damien LAURENT
789eab7d43 Bug Fix : kohanews was broken when nodate or bad formatted supplied.
+ minor change in Languages in order not to have problems with eq

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 15:40:39 -05:00
Paul POULAIN
bfe81b6844 removing [ and ] in query hilighting
otherwise, we have a regexp error 4 lines later

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:24:55 -05:00
Paul POULAIN
10eb85455b bugfix (security flaw) : the additem template was open AFTER doing actions
when Logguing was ON, this resulted in an internal server error, thus the discovery of this bug.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:24:49 -05:00
Paul POULAIN
b25ace0be4 bugfix : handling biblionumber in a field < 010
the bug occur only if we have a malformed biblio, so it should "never" happend, but i've seen it once ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:20:22 -05:00
Paul POULAIN
1e3e69fe99 Overdues fixes (unfinished)
- reindenting
- upcasing SQL
- the script at least compiles...

... but it does seem not work yet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:15:41 -05:00
Joshua Ferraro
a6f1915422 fixes to moredetail.pl to allow status editing using updateitem.pl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-22 07:13:43 -05:00
Galen Charlton
fc8b44a967 call number work part 3 -- now using new routines to generate call number sort keys
C4/Biblio.pm - removed following functions:

_biblioitem_cn_sort
_items_cn_sort

TODO: add a new call number filing routine to emulate logic of
_biblioitem_cn_sort for compatibility purposes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 22:11:40 -05:00
Galen Charlton
a2c245c77d call number work part 2 -- added framework for call number filing routines
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 22:11:37 -05:00
Galen Charlton
43d3efe391 classification sources part 1 - system preferences
Database schema definitions and system preferences support
for defining classification sources and filing rules.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 22:11:32 -05:00
Chris Cormack
c3c520b385 Working on a fix for bug 1456
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 21:55:57 -05:00
Ryan Higgins
3d04be488e adding branch groups search in intranet.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 19:18:39 -05:00
Ryan Higgins
70f46147a6 Extending branch categories : adding search domains. partial commit.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 19:18:36 -05:00
Joshua Ferraro
56e102e20e moving localfiles to tmp
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-21 19:14:28 -05:00
Chris Cormack
e911586f23 Changing searchmember to do an exact search on cardnumber first.
To speed up circulations

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 17:06:13 -05:00
Henri-Damien LAURENT
0cd51e08b7 Improving Search : Adding truncation management (right, left, rightleft,not inside)
Bug Fixing : Do Not delete stopwords when phrase search.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 21:08:10 -05:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Galen Charlton
af466ca41a start of reworking call number handling and other Biblio changes
Most of this commit by Joshua Ferraro.
updatedatabase changes by Galen Charlton.

Major changes:

This commit includes a lot of fairly major changes
to Koha's Biblio handling, largest is the addition
and deletion of several columns in the biblioitems,
items tables, as well as cleanup of deletedbiblioitems,
deleteditems tables. Some of the changes are simple
cleanup, but most have to do with improvements to
storage of call numbers in Koha.

Also, I had to clean up the _koha_* routines quite a
lot to make them work -- there was lots of data just
being lost because columns weren't being updated.

I'm still not completely convinced that the items
table is being treated as authoritative for items
data, investigating further.

DB Changes (updated in kohastructure.sql and in
updatedatabases):

ADDED:
biblioitems.cn_source   ( auth value, CN_SOURCE, stores the source of the
                          call number: DDC, LCC, NLM, etc.)
biblioitems.cn_class    ( plugin, marc21_callnumber.pl, helps fill in
                          the rest of the biblio-level fields)
biblioitems.cn_item
biblioitems.cn_suffix
biblioitems.cn_sort     ( for zebra sorting, stored as a decimal number)
biblioitems.totalissues ( for counting the total times issued )

items.cn_source         ( auth value, CN_SOURCE, stores DDC, LCC, NLM, etc.)
items.itemcallnumber    ( plugin, marc21_itemcallnumber.pl, helps fill in
                          the itemcallnumber based on the record data )
items.cn_sort           ( for zebra sorting, stored as a decimal number)
items.ccode             ( auth value, CCODE, stores the Collection Code
                          of the item, can be used as call number prefix
                          by some libraries )
items.uri
items.materials
items.damaged

DELETED:
items.itype
items.cutterextra
biblioitems.classification
biblioitems.subclass
biblioitems.dewey
biblioitems.lcsort
biblioitems.lccn
biblioitems.ccode

DB version now 3.00.00.009.

Minor changes:

* Drop revision history from C4/Biblio.pm
* GetMarcAuthors now returns additional authors (7XX), not
  main authors (1XX)
* Debug warnings in C4/Search.pm commented out

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:19:56 -05:00
Henri-Damien LAURENT
95d6452462 Adding some more information on issuehistory.
Adding itemnumber to issuehistory.pl API
so that one could search for issuehistory of a specific item.
(Useful for IndependantBranches)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 19:41:37 -05:00
Henri-Damien LAURENT
aa38c487e9 Minor Bug Fix : Using IntranetBiblioDefaultView in Intranet
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 19:40:59 -05:00
Henri-Damien LAURENT
8f6033ee92 Minor : Adding item count to result lists.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:27:56 -05:00
Joe Atzberger
a1fe32d2f8 Total Test Overhaul! Most of these were stubs, and still are.
Input.t was replaced because it tested a now obsolete function.
Input.pm has that function commented out.
Several files were renamed to match their counterparts or
correct misspellingz.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:26:44 -05:00
Henri-Damien LAURENT
b243d9f4f2 Bug-Fix : Display ISBN was not correct for ISBN-13
Copy/Pasting formulas errors.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:25:18 -05:00
Paul POULAIN
917c1ab46c fines management (bugfixes & minor improvement)
- pay.pl fixed, the librarian can see patron fines & mark them paid
- fines2.pl fixed, the script now calculate the fines correctly from the finerules :
  * itemtype / patron category if it exist
  * itemtype / default if needed
- renamed misc/fines.pl as fines-sanop.pl
- added 2 systempreferences:
  * MaxFine: the max amount a patron can be charged for an item
  * NoReturnSetLost: how many days of late before a non returned item is marked lost & the patron charged for the full cost of replacement
(those values where hardcoded in fines2.pl
- C4/Circulation/Fines.pm has been removed (unused duplicate of C4/Overdues)

Note that SANOP feature about notify levels have NOT been ported here. I think they are too specific now, and the code is poorly written
I've renammed fines.pl to fines-sanop.pl to point that it is specific.
Thus, all notify_id related features are not used by anything (and always 0)
Can be interesting to reintroduce them, but that will probably be a large work...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:25:00 -05:00
Paul POULAIN
847bf18dad SearchMyLibraryFirst : reintroducing behaviour (from 2.2)
If the SearchMyLibraryFirst is set, then a logged user will automatically limit the search
to it's own library.

I also did some code cleaning

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:15:06 -05:00
Paul POULAIN
154e383a1d BUGfixing authorities editor
With the YUI tabs, the SINGLETAB feature (that hides tabs when there is only 1) was bugguy
This commit fixes the problem, and solve some other ones :
- order the fields
- resize the input size (see previous commit in addbiblio.pl)
- remove some unused code
- reindent

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:11:00 -05:00
Galen Charlton
afe642bc52 fix for bug 1499 - normalize ISBN before dupe check
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:10:07 -05:00
Henri-Damien LAURENT
e6e4395553 patches for members and resultlists.
--
Henri Damien LAURENT et Paul POULAIN
Consultants indépendants
en logiciels libres et bibliothéconomie (http://www.koha-fr.org)

>From 616f0a385848b9a1fee7c76ff7b1f3be090ccb66 Mon Sep 17 00:00:00 2001
From: Henri-Damien LAURENT <henridamien@koha-fr.org>
Date: Tue, 16 Oct 2007 15:20:45 +0200
Subject: [PATCH] Bug Fixing : userid was blanked out in partial edit.
Adding some checks on branch presence for independant branches

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:05:39 -05:00
Joe Atzberger
b73e4e924e Dates.pm: Added functions format_date and format_date_in_iso as possible drop-in replacements for
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:00:47 -05:00
Henri-Damien LAURENT
8f67beb26d Bug Fixing : Memberentry was broken.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-15 23:54:20 -05:00
Paul POULAIN
b426ecb4f2 BUGfixes in availability management
- the availability status was not available on result list. This patch reintroduces that
- notforloan as itemtype was not properly managed : an itemtype that was notforloan resulted in nothing in detail. Not, the user can't place a reserve anymore, and the status is correctly displayed

the fix is for OPAC as well as staff

(owen, pls, validate cat-toolbar.inc & catalogue/detail.tmpl)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-14 19:10:53 -05:00
Paul POULAIN
ef27099d90 #1485 (issuing rules improvement) continued
issuing rules are working as expeced with this commit.
working on finesrules now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:37 -05:00
Paul POULAIN
345eaeb725 Bugfix for empty words
The \b consider only ASCCI as letter. So diacritics are considered as non word.
and a word like leçon is splitted in 2, "le" is empty word, and the search is done
on çon (which is not french [1], so has no result)

[1] con (without the cedilla) is a french word, but I won't tell you what it means...
anyway, there are probably no "con" in most catalogues ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:21:07 -05:00
Joe Atzberger
bd76a1fb0f Context.pm fatalsToBrowser now dependent on $ENV{USER_AGENT}.
Minor adjustments to Dates.pm and associated test.  You should be able to run a
perl test that uses Context w/o getting fatalsToBrowser output.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:19:42 -05:00
Ryan Higgins
1c2adfe7ff adding GetMarcUrls() fcn to display 856's - adding also output to opac-detail.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:24:53 -05:00
Chris Cormack
e8528be8cb Delbiblio no longer deletes items.
It will only delete biblios that have no items attached.
You must delete the items first then delete the biblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:23:45 -05:00
Chris Cormack
eb8878b854 Working on a fix for 1176
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:22:59 -05:00
Henri-Damien LAURENT
8768c6476f Bug fixing 1360 : It was a bug when no authoritytype was defined.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:55:40 -05:00
Henri-Damien LAURENT
4f54ed3792 bug fixing : 1459 + fixing a jserror in basket.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:55:18 -05:00
Henri-Damien LAURENT
f8c6728d87 Filtering cancelled orders on History Search.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:54:56 -05:00
Joe Atzberger
7fecc7cd41 Unnecessary "use" statements commented out.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:45:52 -05:00
Henri-Damien LAURENT
2d746bd797 Revert "Changing innerjoin to left join for mysql5"
This reverts commit c0dbeb8a3f4f9ab99109d42ea194b53a46235c00.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:45:09 -05:00
Henri-Damien LAURENT
0da5b2099b Recommitting left join for mysql5
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:33:18 -05:00