Commit graph

10274 commits

Author SHA1 Message Date
5a93f0b806 More changes to implement jQuery upgrade.
- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:18 -04:00
John Beppu
dbbe53ac63 Upgraded from jQuery 1.2.3 to 1.3.2
http://docs.jquery.com/Release:jQuery_1.3
http://www.learningjquery.com/2009/03/3-quick-steps-for-a-painless-upgrade-to-jquery-13

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:06 -04:00
51aae63998 Fix for Bug 2713: Opac detail content overlaps when right column extends too far
Resubmitted. My proposed fix eliminates the OpacNav column on this page. It puts the "search for this title in..." links into a drop-down menu, and it moves the "similar items" display into a tab along with Holdings, Reviews, etc.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 06:58:56 -04:00
Garry Collum
e2417fb5c5 Bug 3384: Fixes invalid xhtml in advsearch.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 06:54:27 -04:00
Chris Nighswonger
d1e03bbf11 Bug 3390 Enabling ZIP compression in pdf generation to reduce file size
Enabling compression gives a ~26% *reduction* over non-compressed Type 3 font embedding.
ie. 4.5 K/pg (compressed graphic) vs. 17.5 K/pg (uncompressed Type 3 font) vs 111 K/pg
(uncompressed graphic).

It also appears that most other applications that export in pdf use compression by
default. (OO Writer, etc.) So this approach appears justified. One could always add code
to allow the user to select embedding mode and compression.

Also correcting mode parameter value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 08:19:56 -04:00
Chris Nighswonger
f779f9815c Bug 3390 Barcodes not displayed in Acro Reader >v7.0
Label pdfs containing barcodes generated by Koha do not display barcodes
properly in Adobe Reader >v7.0.

This does not appear to be a bug in Koha code nor in PDF::Reuse::Barcode code,
but rather in the backward compatibility of Adobe Reader.

This patch changes the barcode embedding method from a Type3
font to graphical embedding which appears to work around the issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 08:19:51 -04:00
Chris Cormack
a1fc4c434d Whoops Ricardo was already in the list
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 08:14:15 -04:00
Chris Cormack
d342c7437c Updating history doc
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 08:14:10 -04:00
Nahuel ANGELINETTI
a3491250a3 (bug #3395) fix unimarc plugin 225$a
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:11:19 -04:00
Garry Collum
a9ecff3d98 Bug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.
Removed toggle variable from readingrec.pl and readingrec.tmpl.  Used __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:00:02 -04:00
Garry Collum
b9a0c1644f Bug 3392: Fixes highlighting in Patrons with no Checkouts report.
Fixed class definition and moved the definition from the <td> tags to the <tr> tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:00:00 -04:00
5aeb6f76f1 Correction to enable sending of update emails.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:52:18 -04:00
04d2b672f6 Moving the text of an error message from the script to the template where it can be translated. Partial fix for bug 1153.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:52:11 -04:00
Ricardo Dias Marques
492759e5f2 Fix for Bug 2599 - Search limits not working for NoZebra
Adds the change suggested by Amer Denni to fix Bug 2599
in comment #7 at:

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2599

For UNIMARC installations, this patch only works after
updating the "NoZebraIndexes" system preference to
UNIMARC indexes (by default, NoZebraIndexes is being
wrongly set to MARC21 values in UNIMARC installations).

That has also been reported as a Bug, by me (see Bug 2178):

Bug 2178 - "NoZebraIndexes" system preference is being set
to MARC21 values in UNIMARC installations
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2178

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:46:25 -04:00
Darrell Ulm
62cf086ef1 Bug#: 3358 File 3 of 3 patch for reserve notes (show)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:33:46 -04:00
Darrell Ulm
c943c9f39c Bug#: 3358 File 2 of 3 patch for reserve notes (show)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:33:44 -04:00
Darrell Ulm
1b879d7410 Bug#: 3358 File 1 of 3 patch for reserve notes (show)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:33:38 -04:00
Galen Charlton
3b4ee9c5f1 bug 3355 followup - fix XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 23:08:21 -04:00
Nahuel ANGELINETTI
34426697c5 (bug #3355) add pagination in bib search for subscriptions
This add the support of pagination, delete a javascript call, and use now a get method(why post was used?).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-12 22:45:14 -04:00
Nahuel ANGELINETTI
86b0f37067 (bug #3284) fix superlibrarian check
This fix the superlibrarian check in the previous fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:27:22 -05:00
Nahuel ANGELINETTI
1be2c411f0 (bug #3284) fix borrower deletion in independantbranches mode
This patch fix the checks deleting a borrower in independantbranches mode.
Now, we check the user and the librarian are from the same branch, else we deny the deletion(and disable the link to delete).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:27:15 -05:00
Nahuel ANGELINETTI
ba6c8f1dd5 (bug #3363) do not reload parent if you add a biblio in shelf
this patch make the script not reloading the parent if the user add a biblio in a already existing shelf(useless).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:19:08 -05:00
Garry Collum
45069c1ca4 Bug 3229: Fixes sort-by feature for jquery tablesorter in lists.
This patch adds some variables for the sortfield that are passed through the URL so that the sort-by feature works when the jquery tablesorter is used for a list of titles in opac-shelves.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:09:28 -05:00
Garry Collum
5ca73ecbcc Bug 3347: Follow-up patch. Added logic for non-loggedin user.
Adds a login message, instead of a "New List" link, to the public list table, if a non-logged in user views the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:02:37 -05:00
Garry Collum
1a8aac38b6 Bug 3347: Inconsistencies with public and private list tables in opac-shelves.tmpl.
This patch fixes inconsistencies with the public and private list tables in opac-shelves.tmpl.  It adds a "new list" link to the public list view, and it adds a "sort by" column.

This patch also removes the toggle variables from the tables in opac-shelves.tmpl and Page.pm, and uses the template __odd__ variable for table highlighting if javascript is turned off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 14:02:28 -05:00
Garry Collum
b28fad3308 Bug 3346: Fixes invalid XHTML in opac-shelves.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:58:13 -05:00
471fe3927a Removing hard-coded $ symbols from the template, addressing Bug 2547
Pending a system for displaying the correct currency symbol based on the system's default currency all dollar-specific symbols should be removed in favor of no symbol.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:25 -05:00
0d0666ebab Tweaking CSS on z39.50 popup to improve readability (Bug 3269)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:23 -05:00
980029b93c Modifying the text of the error message for clarity and accuracy.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 13:47:21 -05:00
adde6f914d Correcting validation errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 09:34:46 -05:00
Garry Collum
25ec85cb00 Bug 3360: Fix for unclosed <ol> element in export.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 09:20:53 -05:00
Garry Collum
b082449da8 Bug 3362: Fixes invalid xhtml in stage-marc-import.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:57:16 -05:00
18abc28d62 Misplaced </tbody> breaks table sorting. Fixes Bug 3365.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:49:24 -05:00
aac1c7f8a9 Reformatting interface for Notice Triggers (Bug 3366)
Breaking up the table of options into three separate ones for first, second, and third notices, each in its own tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:36:26 -05:00
62107b5fea Putting text form field first ensures field will correctly be given focus.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:32:47 -05:00
Nahuel ANGELINETTI
ded3ff78cf (bug #3364) add itemnotes in itemslost report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:18:45 -05:00
Nahuel ANGELINETTI
d41d5066bd (bug #3368) index 464$t in unimarc
this patch add 464$t part of Title index

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:15:13 -05:00
Nahuel ANGELINETTI
dc333f07f2 (bug #3369) add 995$* unimarc fields in "item" index
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:15:11 -05:00
38a0e22d2e Spelling correction per convention: cataloguing -> cataloging (Bug 3277)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:11:24 -05:00
Garry Collum
9c984ccade Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.
Cleaned up toggle variable in opac-readingrecord.pl and tmpl.  Used __odd__ variable instead.

Missed </TMPL_UNLESS> in previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:56 -05:00
Garry Collum
653d9b7284 Bug 2889: Removed toggle variable from z3950_search.pl.
Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:53 -05:00
0d0fef6dc5 Another fix for Bug 3119 (Add date due to circ history)
Moving links (non-table data) out of table to correct persistent table border display issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:03:43 -05:00
J. David Bavousett
7468f49bd6 Modified fines.pl to not throw warning if --out not specified
It appears, in Ryan's patch, that he wants to throw a warning to the log if
the directory specified in --out is not present.  (Further messages will
be given when the open-or-die occurs a few lines later.)  However, it was
throwing the warning if --out was not specified at all, which is
undesirable.  This patch modifies that bit to check for the presence of
whatever directory is going to be used, either --out, ENV{TMPDIR}, or /tmp.
As before, if the write to the directory fails for any reason--including
its' non-existence--that is handled later, but this message will help
inform the troubleshooter.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 07:59:59 -05:00
Liz Rea
eac25405c4 bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 07:56:06 -05:00
459d732180 Bug 3301 - Speed up rebuild_zebra script
With this patch, rebuild_zebra can re-index a whole Koha DB
quickly:

  rebuild_zebra -r -b -nosanitize

Biblio (authority) records are dump directly in a file
from marcxml field without beeing transformed into
MARC::Record object and corrected.

DOCUMENTATION:

rebuild_zebra.pl new paramater:

-nosanitize  export biblio/authority records directly from DB marcxml
             field without sanitizing records. It speed up
             dump process but could fail if DB contains badly
             encoded records. Works now only with -x and -b

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 07:52:46 -05:00
Joe Atzberger
e8908c2f97 Returns reworking to handle empty GetItemIssue
Code cannot rely on issueinformation being populated.

Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels.  Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:44:39 -05:00
Joe Atzberger
5169a4cb4a checkoverdues should not require $dbh
Passing $dbh around is an ancient style that doesn't know
to use C4::Context.  C4::Context->dbh is efficient, especially
for modules that already use Context, including almost all C4.

I also internalized $today into the SQL using NOW() in the query
and removed sth->finish.  Even though I dislike the return style
that gives the count, then the array, I left it becuase I don't
have time to fix/test all the callers.  However, I did convert
it so it doesn't require a $count variable and its own loop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:35:12 -05:00
Joe Atzberger
a6890b2066 Return amount for CREDITS, POD rework.
The main change here is to get an {amount} field for CREDITS,
not just CHARGES.  I also use a fallback to default value (5)
in case noissuescharge has been deleted or set to 0.

POD is reworked to keep the salient chunks
about patronflags in the correct section and format them for
easier reference.  Deprecated display layer code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:31:45 -05:00
Joe Atzberger
c177ac05f6 Cleanup Members.pm - minor
MoveMemberToDeleted is problematic.  It has a bad name, since it
only copies, not moves.  Also the POD for it referenced a totally
different function name and was largely useless.  Sanity checks inserted.

A couple sth->finish removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:31:44 -05:00
Joe Atzberger
4017d2449d Remove unused variable and add FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:15:58 -05:00