Reverted because, as it describes itself, this was an incomplete
fix that simply commented out a feature that had been committed to HEAD
and sponsored by a library. Bug 4139 has been opened for the underlying
performance issue.
This reverts commit 943aa38564.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
updatedatebase is now setting aqorders.quantityreceived to NOT NULL
kohastructure needs bringing into line
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The return from Mail::Sendmail should always be checked
Output the error message if it fails so we have some
indication of where to start looking if it fails
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- This code was added to opac-suggestions.pl at one point by
Garry Collum and was subsequently removed. Adding it back.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch fixes two bugs:
1. Correcting the text alignment alogrithms for center and right alignment
2. Changes a reference to layout to a copy of the layout to avoid performing
operations on the layout.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
quantityreceived drives other parts of acq noticeably budget balances
ensure that a number (usually 0) is set in NewOrder
give field a valid default and set as not null
reinterpret exsting nulls in table as zero
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- "Do not delete" form was missing hidden framework code input.
- Also added details to breadcrumb navigation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Although the due date of an on loan item was being retrieved
the appropriate field in the Item object was not set
causing the due date not to be returned in the item
information response
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record. However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc. This patch turns off the other instances of
fine columns/displays if the syspref is off.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
* made AutoSelfCheckID and AUtoSelfCheckPass type free instead of textarea
* consolidated DB updates into one
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Some small, single-branch corporate and special libraries use unattended self-checkout stations, and would like to automate the staff login, so that just going to the sco/sco-main.pl URL would bring the self-check up ready for patron use. This patch create three sysprefs, AutoSelfCheckAllowed, and AutoSelfCheckID/AutoSelfCheckPass. If the site wants to allow automated login, staff would then need to create the selfcheck user record and enter that login ID and password into the sysprefs. The kohaclone/opac/sco/sco-main.pl script has been modified to check these sysprefs and pass values (if present and allowed) into the self-check URL. The URL then bypasses the staff login page and comes up ready for checkout, waiting for the first patron barcode.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Add two syspref:
- OPACXSLTResultsDisplay
- OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Changes the output of compact.xsl to XHTML for catalogue/showmarc.pl?viewas=card.
Adds <title> element in <head>.
Removes link to nonexistent css file (bug 2651).
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
I went back and updated updatedatabase so that anyone else who updates
doesn't end up with the wrong value, this does not fix those who
upgraded and have the wrong value in there already.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Also removing needless conditionals on redirects.
Thanks to Braedon Vickers for catching the incorrect conditional.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Renewal failure message should appear in renewal checkbox column just
like it does in moremember.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Adds the id back in <body>. Renames the id in <div>.
The only reference to this id was in sanop.css, to which opac-detail.tmpl does not link.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
order_by parameter should be an arrayref of hashrefs
Have made order surname, firstname asc (see bug 4067)
do not generate logged warnings by manipulating undef
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch adds AcqCreateItem, CurrencyFormat, gist, and OrderPdfFormat back into the sys prefs interface.
Still missing are acquisitions, OrderPdfTemplate, and emailPurchaseSuggestions.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
New way, correct way to use GetMember is
GetMember(field => fieldvalue[, field2 => field2value ...]);
e.g.,
GetMember(borrowernumber => $borrowernumber);
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Fixed two calls where new interface was not used
Arguably new syntax allows more options than we require but it was not catching
error cases (when 0 or undef is passed). It also can now be called in ways
which would validly return multiple hits but explicitly does not
(nor does calling code expect this)
This patch should quieten the flood of errors
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Turn on the system preference SpineLabelShowPrintOnBibDetails and a link for the spinelabel printer will appear for each item on catalogue/detail.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
