Commit graph

57 commits

Author SHA1 Message Date
Nicole C. Engard
1a870e4c23 Bug 5928 follow up remove branchcode label
Under Acq info it said 'Branchcode,' I've changed this to 'Library'
to match the style used in other places.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-23 10:35:19 +13:00
53566f09fb Fix for Bug 5722, other reason for suggestions has code in text box
Input value attributes shouldn't have _() escaping.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-14 10:27:49 +13:00
Chris Cormack
a904a9bac7 Merge remote branch 'kc/new/enh/bug_5508' into kcmaster 2010-12-16 13:47:01 +13:00
0560aa768c bug 5398: make additional pages in staff interface obey noItemTypeImages
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-16 08:49:48 +13:00
Paul POULAIN
2f9c8293c8 adding some javascript strings for translator
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2010-12-15 13:11:06 +00:00
9a15aa4514 Fix for Bug 1883, authorised list of reasons why patron requesting book
- Adding form controls to opac submission form and staf client
  edit form.
- Adding display of patron reason for suggestion on opac list
- Adding function for pulling an authorized value description
  using the category and value

TODO: Add some default authorised values

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-13 09:55:29 +13:00
Amit Gupta
f164902761 Bug 5464 Suggestions - adding more acq fields to staff interface
More acq fields in staff interface - price, quantity, currency and totals

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-13 09:22:05 +13:00
c9f3f2872f Fix for 4832 - Re-editing a suggestion changes the item type
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-12 08:00:44 +13:00
7fd45b9861 bug 5127: sample notice templates for suggestions
* supply default suggestion status change email
  templates.
* remove the deprecated mail_suggestion_*.tmpl files

There are a couple suggestion statuses referred to
in the code and suggestion management page that currently
do not have notice templates defined: ASK and CHECKED.  These
seem to be internal, so perhaps default message templates
are not needed for these.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-11-30 06:47:52 +13:00
Bernardo Gonzalez Kriegel
a2bc823707 Bug 5132 - Misspelled words: Acquistion Succesfully professionnal
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-17 13:51:33 -04:00
Alex Arnaud
b592c3a0f5 (MT #3651) Fix problems on search filters.
removing of useless value "no tabs" in organize by combo.
removing of useless value "Sort 1" in organize by combo.
Adding combodate for suggesteddate, manageddate, accepteddate.
Adding research on dates in query.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-25 05:22:05 -04:00
Alex Arnaud
70607332a1 (MT #3651) Fills "book fund" combobox with bugdets and fix some bugs of research by filter.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-25 05:22:03 -04:00
Alex Arnaud
a28677b389 (BUG #4811) suggestion.pl: display borrowers name in suggestion information filters (Suggested By, Managed by, Accepted by)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-24 20:42:38 -04:00
d346179a9b Fix for Bug 3926, inadvertantly resurrected by me.
The template-side fix for Bug 3926 was overwritten by
another template change I submitted later. My bad.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-03 20:36:33 -04:00
Henri-Damien LAURENT
c841eb0e0c MT3168 : Suggestion budget management
budget were not saved and not correctly displayed

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-23 07:00:56 -04:00
Lars Wirzenius
4523a2df0d Fix file permissions: if it is not a script, it should not be executable.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 00:40:34 -04:00
2ce51846a0 More fixes for Bug 2600, HTML tags in titles not escaped in many places
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 16:52:31 -05:00
d56db2e972 Fix for Bug 4092, suggestion date missing from manage suggestions
Date was missing because of incorrect variable name in opac-suggestions.pl
Thanks to HDL for the fix.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-02 18:42:42 -05:00
d45ee12e5c Revised for biblibre/3.2_community: Reformat of suggestions management interface (Bug 3844)
Changes and fixes include:

- Moving filters forms into left-hand sidebar
- Making filter forms collapsed by default (click to show)
- Converting "check all" to text link to match similar controls on other pages
- Correcting case of tab labels
- Fixing display of custom reason field
- Converting radio buttons to drop-down for more compact display
- Table-sorter column exclusions
- Markup corrections
2010-01-20 22:32:11 +01:00
Liz Rea
1adf196d9a Bug 3096: re-adding note field to suggestion management. 2009-12-31 10:58:04 +01:00
Nicole Engard
83f7a91fef bug 3845 fix minor capitalization and spelling errors on suggestion page 2009-12-22 19:14:52 +01:00
b6ced3b773 Fix for Bug 3926 (suggestion edit form combines data)
Breaking patron information variable into separate surname, firstname, branch, category, and borrowernumber variables and using those variables to tweak the display.
2009-12-20 14:31:39 +01:00
Henri-Damien LAURENT
73de4a2e3f Date management update Suggestions 2009-11-17 16:27:14 +01:00
Paul Poulain
f1b6fba45b fixing who and when the suggestion is done 2009-11-17 16:27:13 +01:00
Paul Poulain
8bea1fa2c4 reindenting 2009-11-17 16:27:13 +01:00
Paul Poulain
44f3f7bb94 removing useless files & fixing broken link 2009-10-28 19:21:14 +01:00
Paul Poulain
03d9a79878 suggestions changes (probably useless)
and incompatible with hdl stuff
2009-09-30 11:30:22 +02:00
Henri-Damien LAURENT
8802bbf5fe Editing C4::Suggestions.pm
Enhancing C4::SearchSuggestion
And changing its API
Changing C4::Suggestions API taking a hashref for NewSuggestion and ModSuggestion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:29:23 +02:00
Garry Collum
b904347142 Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.
Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-30 22:05:22 -04:00
Garry Collum
11f05061cc Bug 3452: Displays borrower category and adds links to Suggestions Management
A couple of enhancments to Suggestions Management.

Adds a display of the borrower category of the suggesting patron for each item.

Adds links to the title and author displays so that the catalog can be quickly search for an existing bib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-29 21:39:44 -04:00
John Beppu
2fa6b26825 Minor Fixes for jQuery 1.3.2 Upgrade
I looked through all the relevant Javascript on this site
to find spots that would break in the upgrade from jQuery 1.2
to jQuery 1.3, and I fixed them.

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 07:08:20 -04:00
Liz Rea
b99a5ca639 Adding a notes column, fixing a typo in TMPL_VAR statement that caused notes not to display.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 13:28:03 -05:00
e6076612ba Fix for Bug 1877, Link to patron record from manage suggestions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:44:02 -05:00
Joe Atzberger
4a1333c544 Factor common element out of both sides of conditional.
Add placeholder complaint about misuse of TMPL EXPR statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-08 12:30:33 -05:00
Nahuel ANGELINETTI
04cb467401 (bug #2863) add the borrowers branchcodes in suggestion list
Not a big patch, just add the borrower branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 14:19:11 -06:00
Galen Charlton
ce8e70c6c6 bug 2505: turned on warnings for suggestion/acceptorreject.pl
Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-11 08:27:55 -06:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
756cdc15ac Swapping tablesorter version. GZipped version may have been responsible for errors in Internet Explorer. Change to usermenu.inc is whitespace only, for proper display in IE.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-13 17:40:28 -05:00
Paul POULAIN
62ae9fa3ee bugfix : librarian name was libxxx, not lib.xxx
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:07:57 -05:00
157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-12 10:06:32 -05:00
9cc74e265b Revised suggestions management interface, allows setting of one reason for all suggestions in a particular category (pending/accepted/rejected).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-24 10:31:03 -05:00
Henri-Damien LAURENT
5e9465a14a Accept or reject : Bug Fix and improvements.
Improving workflow : A suggestion can be edited and status can be changed if mistaken as soon as it is not deleted or acquired.
Adding dates display.
Adding deletion of suggestions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-17 05:52:47 -05:00
b853eed5f4 Some reworking of suggestions management interface in preparation for tackling hdl's proposal of wider scope. Includes change to Suggestions.pm to enable passing of borrowernumber to the template.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:15 -05:00
a201bac619 Adding acqui-home to breadcrumbs. Hopefully that satisfies Bug 1894
(Easy back link needed on suggestion accept/reject page to Acqui).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:40:05 -05:00
395a3499a6 Two jquery changes: update to tabs plugin, with related modifications to templates; Addition of jquery hotkeys plugin for selecting tabs from global search form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-11 06:18:44 -05:00
14cae2e3a5 Typo correction in opac-ISBDdetail.tmpl, fix for But 1880, Managing Suggestions - nav disappears when no approved or rejected.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-05 08:13:55 -06:00
Paul POULAIN
6fe1c85cb2 s/waiting/pending/
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-04 18:10:36 -06:00
Joshua Ferraro
8d726bf96c nomenclature improvements for translation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-20 16:18:25 -06:00
Joshua Ferraro
20055da807 Fixing nomenclature and tmpl_process3.pl bugs
tmpl_process3.pl still throws some multi-byte warnings
but no markup errors

There are still quite a few places we could normalize
to reduce the size of the translation file

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-11 18:37:01 -06:00