Commit graph

256 commits

Author SHA1 Message Date
Liz Rea
bae21b7fd5 Removed tab indexes in additem.pl to enable tabbing to buttons in order. Previously, tabbing through this form would skip the submit buttons. 2009-12-20 14:31:37 +01:00
Henri-Damien LAURENT
aaebd7e138 Bug Fixing additem : branchcode unwilling changes
branchcode was unconditionnally changed to user branch when editing an item
2009-11-26 21:55:10 +01:00
Matthias Meusburger
9f41fe64be MT 2050, Follow-up, Fast Cataloging
Adds granular permissions for cataloging
Also adds a link from the circulation home to fast cataloging when fast cataloging is active
2009-11-24 10:05:10 +01:00
Henri-Damien LAURENT
b7270536e4 MT 2309, Follow-up : Display item location codes in item adding
Conflicts solved cataloguing/additem.pl
2009-11-19 23:47:50 +01:00
Matthias Meusburger
e549fc0a5a MT 2309 : Display item location codes in item adding 2009-11-18 19:02:24 +01:00
Matthias Meusburger
8d536b8ecf MT 1059 : Records merging
Give the user the ability to merge two records, one being kept and the other deleted.
Selection of the records to merge can be done from virtualshelves.
2009-11-17 18:03:53 +01:00
Nahuel ANGELINETTI
ac7bda678c (bug #3786) fix items edition menu
This re-allow the user to go back to normal/isbd/marc view when he's in items edition page
2009-11-17 16:27:13 +01:00
Henri-Damien LAURENT
278adf955b Editing copynumber to stocknumber
Updating updatedatabase.pl
Updating value_builder
2009-11-10 22:23:48 +01:00
Henri-Damien LAURENT
709e3be936 AddBiblio Workflow edition
When in Edit Mode, when save is clicked, get back to the MARCdetail.pl and not to additem.pl
2009-10-21 09:07:05 +02:00
Matthias Meusburger
d4f06e5023 MT 1094, Following : added a test to check if we really found the item 2009-09-30 11:30:41 +02:00
Henri-Damien LAURENT
9eba7dc594 Moving item : no need for ModOrder, as the itemnumber now stays the same
Conflicts solved cataloguing/moveitem.pl

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-30 11:30:41 +02:00
Henri-Damien LAURENT
d948e8ba42 Merge fixes and removing warnings 2009-09-30 11:30:40 +02:00
Nahuel ANGELINETTI
7e895a17a3 Fix unimarc 010 field plugin
It cleans ISBN
2009-09-30 11:30:33 +02:00
Henri-Damien LAURENT
d7d3f4f774 Moving item rather than Delete/recreate 2009-09-30 11:30:33 +02:00
Henri-Damien LAURENT
9995ff8fd1 MT 0001094, Follow-up : Enhancement : Item is moved rather than deleted and re-created 2009-09-30 11:30:33 +02:00
Nahuel ANGELINETTI
b3738d4be6 (bug #3395) fix unimarc plugin 225$a 2009-09-30 11:30:28 +02:00
John Soros
2d90fb22d4 fix for 1431 point 2: orders and orders_items also moved to new biblionumber now 2009-09-30 11:30:27 +02:00
Jean-André Santoni
b480348d9e (bug #3560) This add a filter to search by itemtype
The value builder for 4XX should be able to filter results by itemtype.
2009-09-30 11:30:13 +02:00
Jean-André Santoni
db28e105db (bug #3549) Sorted framework options in the dropdown menu
In addbook.pl, the framwork options are sorted in random order. They should be
sorted in alphabetical order of value or code.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:06 +02:00
Nahuel ANGELINETTI
50c069e822 (bug #3505) order collections by alphabetical order
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:06 +02:00
Jean-André Santoni
ec785289a4 Auto incremental inventory number plugin
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:05 +02:00
Jean-André Santoni
91c42259be This is a calatoguing plugin based on auth_finder but specific to one of our customers.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:30:05 +02:00
Henri-Damien LAURENT
5f8cab28d1 Move Item from one biblio to another
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:22:23 +02:00
Henri-Damien LAURENT
7479f93b5d Delete All items in one click
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-30 11:22:22 +02:00
Michael Hafen
a5d298ad45 bugfix breeding results of cataloging search has wrong id
The breeding id, rather than coming from the database, was set by a counter.
Not so good links in the search results that way.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:13:20 -04:00
Michael Hafen
81b1c692df cataloging search results from catalog don't show on later pages
In the cataloging search results from the catalog, the result set would
decrease by one per page.  Past page 19 there was an empty table.  The reason
is that SimpleSearch gives the result set ( 20 records here ), and
searchResults expects to trim the result set to just the 20 records we want.
This changes the call to searchResults() to have a 0 offset to the result set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-09-06 09:13:13 -04:00
4b71494f19 bug 3481 followup - set temporary processing location
Ensure that the temporary processing location is always
set regardless of whether one item is added or multiple
copies are added at once.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
Colin Campbell
e40e11ab0c bug 3481: Allow Item Temporary Locations for Processing and Shelving.
Allows temporary locations corresponding to 'in processing' and 'shelving'
so that newly-created items, and newly-returned items do not show
immediately as a available. Three new system preferences govern the usage
of these features.

NewItemsDefaultLocation. If system pref NewItemsDefaultLocation is set to a location code,
 all newly catalogued items will be set to the location set in this preference.
 Location code must be a valid LOC authorized value type.

InProcessingToShelvingCart. if the system pref InProcessingToShelvingCart is turned on,
any items run through returns.pl with a location code for 'PROC', will be modified to
have a new location code of 'CART'.

ReturnToShelvingCart.  If the syspref ReturnToShelvingCart is turned on,
all items returned other than confirmed holds will have a new location code of 'CART'.
Any item issued is automatically taken of the shelving cart.

Adds a cron script shelf_to_cart.pl which should be run hourly.
Updates all items with a location of CART to the item's permanent location.

The original location code is stored in the new items column 'permanent_location'.

Original Author: PTFS Contractor <dbavousett@ptfs.com>

This work co-sponsored by
  Middletown Township Public Library, Middletown, NJ USA  and
  East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:54:46 -04:00
Nahuel ANGELINETTI
b93b407f64 (bug #2829) fix some mistakes extracting editor segment
This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 08:17:28 -04:00
Colin Campbell
3199d032e5 Avoid numeric comparisons with leading zeroes
Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:52 -04:00
Nahuel ANGELINETTI
45761d67cb (bug #3505) fix 210c and 225a unimarc's plugins
This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-05 20:10:42 -04:00
Nahuel ANGELINETTI
bc9618c669 (bug #3458) fix die and unimarc 700-4 plugin
This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 08:01:41 -04:00
Matthias Meusburger
2e1a9d657a Bug 2593 : way to duplicate items
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-20 20:35:52 -04:00
Nahuel ANGELINETTI
3e7e8bf35e (bug #3398) fix unimarc 210c plugin
this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-15 09:09:27 -04:00
Galen Charlton
6c2b7f8ccb fix crash introduced in previous patch
In the previous patch,

-    my @subf = $field->subfields;
-    (defined @subf) or @subf = ();

is not equivalent to

+    my @subf = $field->subfields || ();

as, the results of $field->subields is interpeted in scalar
context, not list context, resutling in @subf containing
the number of subfields, not the subfield data itself, which
engenders the error

Can't use string ("1") as an ARRAY ref while "strict refs" in use

later on.  Changing the operator to 'or' instead of '||'
fixes this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 22:05:24 -04:00
Joe Atzberger
46b9ee7a93 Branch auto-selection in additem
Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-14 21:39:00 -04:00
Nahuel ANGELINETTI
a3491250a3 (bug #3395) fix unimarc plugin 225$a
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-07-13 00:11:19 -04:00
Garry Collum
653d9b7284 Bug 2889: Removed toggle variable from z3950_search.pl.
Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-29 08:06:53 -05:00
Colin Campbell
d633bd1ba1 Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-24 09:02:59 -05:00
Nahuel ANGELINETTI
0fc4a490d3 (bug #2829) allow isbn13 in sql requests
this patch add the support of the plugin to search for isbn13.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-17 11:40:25 -05:00
Nahuel ANGELINETTI
7bad9ddb79 (bug #2829) mistake un isbn field
I compare the bad part of the isbn in my first version, now fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-17 11:40:21 -05:00
Paul Poulain
6924e7d6b4 fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:06:46 -05:00
Galen Charlton
17ab0a7532 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:20 -05:00
Brian Harrington
a00f7b9568 Revisions to auto-generated authorities patch
It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl.  I
also realized I can't count. :-)

Modified per comments by Joe and Galen to keep SetMarcUnicodeFlag
and move it and the leader set to earlier in the process.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 15:39:05 -05:00
Darrell Ulm
f2c930257e BUG 1277 Enhance: Z39.50 More search criteria
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-15 09:48:20 -05:00
Galen Charlton
2f5a28ee6a bug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'
Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it.  Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'.  Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-11 07:47:41 -05:00
Joe Atzberger
7a8e256263 Remove unused $toggle code
Some trivial other cleanups also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:02:30 -05:00
Henri-Damien LAURENT
87cef586af Minor Feature : username when cataloguing
biblios can now be added librarian name automatically when cataloguing.
add "user" in the Default value of the biblio

[RM doc note: in other words, if in the MARC framework you set
 the default value of a subfield to 'user', the username of the
 cataloger will be entered into that subfield whenever you create
 or modify that bib in the Koha bib editor.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 21:38:02 -05:00
Galen Charlton
b6d67fc984 fix default authority search in bib editor
When clicking on the '...' of an headings field
in the bib editor, the authority search that
popped up did not take the default search
string from the bib field.  Fixed by making
sure that openAuth is always used to do the
popup link.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:36:28 -05:00
Brian Harrington
4c4cae22da Revisions to auto-generated authorities patch
It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl.  I
also realized I can't count. :-)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 14:01:15 -05:00