Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
13731 commits 35 branches 616 tags 1.8 GiB
Commit graph

231 commits

Author SHA1 Message Date
Jesse Weaver
1157ed9457 fix for bug 1551: Renewing doesn't move item... 
This makes C4::Circulation::AddRenewal update lastreneweddate, then has circulation.pl check today's date against issuedate or lastreneweddate. It also cl
eans up a little parenthesis spacing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-07-16 18:26:16 -05:00
Jesse Weaver
19b46abad1 fix number two for 2181: Late Items in Red 
This new patch uses faster Perl string comparison when comparing dates for overdue checking.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-07-14 20:10:08 -05:00
Joshua Ferraro
508d7643ca Revert "fix for 2181: Late Items in Red" 
This used Date::Manip which we went to great lengths to remove about a year ago.

This reverts commit 36b2897430.
 2008-07-10 21:30:03 -05:00
Jesse Weaver
36b2897430 fix for 2181: Late Items in Red 
Modified overdue check in circ/circulation.pl to use Date::Manip's Date_Cmp. This would likely be useful other places in the file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-07-10 15:03:37 -05:00
Owen Leonard
1e2ff18e95 More changes to update-child process. Many scripts missing necessary data for checking how to process an update-child request. Also cleaning up update-child.tmpl for formatting. Minor text change (translation problem?) 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-07-08 18:09:38 -05:00
Owen Leonard
52c933c413 Scripts missing check for Child category type would not correctly show 'update child patron' link in toolbar. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-07-08 18:09:36 -05:00
Joe Atzberger
579021df92 Bugfix 1978 - on circ, check date specified output is later than now. 
This resolves all remaining significant parts of the bug.
Note that this may have to be revisited for hourly or partial-day circ functionality
for 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-16 15:37:11 -05:00
Galen Charlton
28fb7a6c19 kohabug 2180 - improve display when fines block checkouts 
If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-02 00:50:37 -05:00
Joe Atzberger
74d3dc35ee Bugfix 1978 - if invalid duedate specified, return error, do not issue. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-05-29 06:40:06 -05:00
Owen Leonard
157b5a1eb6 Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery) 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-05-12 10:06:32 -05:00
Henri-Damien LAURENT
9fb4a72122 Bug Fixing 1782 patch 
Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-05-12 09:42:25 -05:00
Ryan HIggins
92ca50980f only pass needsconfirmation to template if issuing is possible 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-05-11 07:03:52 -05:00
Henri-Damien LAURENT
d08d9e3fb7 Addressing bug 1782 
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-05-11 05:49:27 -05:00
Ryan Higgins
f4f840da2c Small template cleanup: display library name and cat description instead of codes 
in circ-menu include.  Also, change 'Default' on main login page to 'My Library'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-04-22 17:54:19 -05:00
Owen Leonard
6594407b73 Formatting patron expiration date output (or was there a reason why this was commented out previously?) 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-04-10 02:59:32 -05:00
Owen Leonard
193207c614 Identifying "waiting at" branch on screen. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-04-10 02:59:29 -05:00
Galen Charlton
a2c59f25e2 various date-related cleanups in circ 
* use Date::Calc to perform date arithmetic
* use Date::Calc::Today to consistently format the current date
* format date per syspref in overdue report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-04-03 14:42:14 -05:00
Owen Leonard
200e00e347 Reformatting holds list to better match checkouts list 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-03-25 07:22:32 -05:00
Galen Charlton
2c5b25c1fc more item-level_itypes fixes 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-03-15 08:37:10 -05:00
Galen Charlton
0e0a2e74b2 removed use of TMPL_IF EXPR in circulation.tmpl 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-03-15 08:36:39 -05:00
Chris Nighswonger
c767c99051 Correcting code to display patronimage correctly 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-03-07 07:40:38 -06:00
Ryan Higgins
1cd6263dde Adding barcode_decode syspref 
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-02-19 20:22:01 -06:00
Chris Nighswonger
c6d6f60013 More fixes for patron images 
Added GetPatronImage function to Members.pm
Added code to circulation.pl, boraccount.pl, readingrec.pl, and moremember.pl to grab patron image and pass it off to the template
Corrected code in circ-menu.inc to properly display patron image.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-02-03 07:24:28 -06:00
Chris Cormack
0b4862b133 Finishing off bug 1427, if the person has ReturnBeforeExpiry set they are 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-14 16:48:32 -06:00
Chris Cormack
6fcd1a6ae3 Fix for bug 1428 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-14 16:48:08 -06:00
Chris Cormack
052861306b Fix to redirect the user ot the select branch page if they try to use 
circulation without a branch set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-01 20:03:08 -06:00
Chris Cormack
48b4d54408 Fix for bug 1515 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-30 20:51:22 -06:00
Chris Cormack
ddd0140ef1 Fix for bug 1626, whitespace stripped from barcodes 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-30 16:24:30 -06:00
Chris Cormack
bcc60a1117 Fix for bug 1552, fix ordering of issued items 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-30 16:24:27 -06:00
Chris Cormack
39fad89745 Fix for bug 1253 borrowers names sorted case sensitivly in circulation.pl 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-30 12:07:59 -06:00
Galen Charlton
26fa7bf58d use syspref date format for manual due date 
NOTE: will fail if user manages to enter date
in wrong format.  This is not a change from before
this patch, but is pointed out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-20 19:14:41 -06:00
Galen Charlton
af0b208bdf use standard template var for DHTML date format 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-20 19:13:59 -06:00
Chris Cormack
6cfe88b7b2 Fix for bug 1427 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-19 18:55:20 -06:00
Owen Leonard
0e675ef820 - Changes to the way patron renewals are handled. Circulation page now offers 'renew' link alongside warning about patron expiration (as in dev_week), using the new setstatus script. 
- Member pages now use member toolbar include instead of circ one
- setstatus.pl now uses 3.0's patron renewal function
- Adding missing item-bullet.gif (Bug 1659)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-17 19:24:49 -06:00
Chris Cormack
ea7cbfff43 Fix for bug 1648, specifying a due date resulted in a blank due date 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-17 08:19:55 -06:00
Joshua Ferraro
e428929bff adding format_date to 'use C4::Date' 2007-12-04 18:29:18 -06:00
Joe Atzberger
82b8c496fd circ subdir - Dates.pm integration and warnings fixes. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-04 18:21:12 -06:00
Owen Leonard
266b59cf65 Moving "Check Out" from the action toolbar to the view menu 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-04 17:56:22 -06:00
Owen Leonard
f46ebf69a0 Passing "adultborrower" variable to the template so that "Add Child" button can be displayed in the toolbar when appropriate. Fixes Bug 1510. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-04 15:06:29 -06:00
Galen Charlton
958b5a097c new C4::Auth::get_session for single place to get CGI::Session object 
Refactoring to provide single place to get CGI::Session ojbject;
fixes bug for DB storage method other than 'mysql'.

This refactoring is also part of the patch series for
handling large input files for staging and processing
MARC records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-25 16:43:26 -06:00
Ryan Higgins
cb1ec158c0 Adding calendar widget to circulation/stickyduedate 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-20 16:27:25 -06:00
Ryan Higgins
9c2d58a470 update item-at-wrong-branch error message to show homebranch. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-13 12:46:45 -06:00
Chris Cormack
5342904792 We were calling get biblioitemdata when we should have been calling get bibliodata 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-13 11:19:26 -06:00
Chris Cormack
5fa4703ee0 Fix for 404 error when clicking on a reserve in circulations 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-12 17:40:23 -06:00
Ryan Higgins
3967fa9c79 further mods to change from ccode to itype at item-level itypes. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-11 18:40:20 -06:00
Chris Cormack
24af640015 Rest of the fix for 1402 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-07 08:05:20 -06:00
Joshua Ferraro
58d3b163d0 merge mason's fix to circulation 2007-11-06 06:19:17 -06:00
Mason James
275e3eb8b1 undeclared @issued_itemtypes_count_loop; 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:18:15 -06:00
Joshua Ferraro
9e8dc6b021 adding back my @issued_itemtypes_count_loop; 2007-11-05 08:41:11 -06:00
Ryan Higgins
371efb047b adding item-level itypes: based on systempref: item-level_itypes, we use items.ccode as the circ code rather than biblioitems.itemtype. This is initial commit -- still requiring interface changes basic loanlength, maxissues should be by ccode now. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:37:53 -06:00
Ryan Higgins
d6eea9c622 fixed redefined itemtype_count variable . 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:37:38 -06:00
Owen Leonard
b453d173ae Standardizing information shown in sidebar when patron-related pages are displayed (making sure address, phone, email variables are available to all templates). Adding tabs to account-related pages as means of section navigation. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:31:32 -06:00
Owen Leonard
4a9745dbb0 More interface changes for circulation: Further tweaking of circ warning dialog, formatting patron selection form, adding 'focus' class to patron selection select list. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:31:02 -06:00
Ryan Higgins
dac69bc799 Couple of minor changes to staff client view on patron. 
item-level_itypes still need display changes in both opac and staff.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-04 16:27:59 -06:00
Chris Cormack
ff179bb1d4 Fix for bug 1518 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-29 16:21:46 -05:00
Frederic Demians
701d6ef020 Circulation borrower name autocompletion 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-20 16:17:08 -05:00
Joe Atzberger
6f15e48f65 circulation.pl cleaned up. I think you'll like the difference. Less 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-18 21:21:31 -05:00
Paul POULAIN
47321d0068 Adding dates for display to circulation.pl Minor bug fixes. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-10-09 18:44:46 -05:00
Chris Cormack
ee56e731ab Fix for bug 1436, changing to use issuedate, not timestamp for sorting issues 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-30 20:45:46 -05:00
Owen Leonard
34b67109d1 A couple more tweaks to member entry form. Still unfinished: inline CSS will have to be generalized and moved to external stylesheet. Trying some changes to circ page, including moving patron info into sidebar, consolidating messages and warnings. Also unfinished! 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-25 14:47:02 -05:00
Owen Leonard
a37daca905 More efforts with toolbars, nothing solved. Also corrections, and modifications to resident search to place focus on displayed form field. 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-25 14:46:56 -05:00
Paul POULAIN
c4d4b6ecf2 Bug fixing : 1396 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-24 15:31:40 -05:00
Paul POULAIN
3568e20644 bug fixing on 1396 : 
Conflicts:

	circ/circulation.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-24 15:29:42 -05:00
Paul POULAIN
e809eff05f BUGFIX : branch CPL was hardcoded 
What is the branch CPL ?

Anyway, this was buggy and reseted the branch to empty
which was a bug ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-18 15:06:47 -05:00
Chris Cormack
f12fc20e1d Fix to get selectbranchandprinter working fine with the Session 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-09-06 20:48:13 -05:00
Paul POULAIN
497bbd84b0 show the departure date if close or past 
Signed-off-by: Chris Cormack <crc@liblime.com>
 2007-08-14 21:32:22 -05:00
toins
ee5c4c303c display enhancement. 2007-07-24 14:17:07 +00:00
toins
cae655f928 removing a compilation warn. 2007-06-05 09:48:31 +00:00
alaurin
5c4a2c3e4b bugfixing for circulation. 2007-05-04 10:18:00 +00:00
hdl
a171035f1d GetBorrowerIssues is deleted from C4::Circulation 
Use GetPendingIssues from C4::Members instead.
 2007-04-25 14:07:34 +00:00
tipaul
fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
hdl
b642e687d2 Still Code Cleaning. 
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
 2007-04-24 15:41:27 +00:00
hdl
100e6a9808 functions that were in C4::Interface::CGI::Output are now in C4::Output. 
So this implies quite a change for files.
Sorry about conflicts which will be caused.
directory Interface::CGI should now be dropped.
I noticed that many scripts (reports ones, but also some circ/stats.pl or opac-topissues) still use Date::Manip.
 2007-04-24 13:54:28 +00:00
tipaul
9f42b8ad49 renaming currenttransfers to transferstoreceive 2007-04-23 15:21:17 +00:00
tipaul
3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl
0b66bd800d Code Cleaning Members. 
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
 2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
b71839d85c circulation cleaning continued: bufixing 2007-04-17 08:44:49 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation. 
some stuff to do, i'll write a mail on koha-devel NOW !
 2007-04-04 16:46:22 +00:00
tipaul
987ceb8ce7 using C4::Date instead of C4::Circulation::Date 2007-03-30 11:58:48 +00:00
kados
b4d72b977f fix for bug 1276: Cannot search for patron wtih apostrophe in their name 2007-03-18 04:13:21 +00:00
tipaul
2ffd5b7228 rel_3_0 moved to HEAD 2007-03-09 14:28:54 +00:00
tgarip1957
4843e0ee78 Resynching Savannah 2006-11-15 01:41:51 +00:00
tgarip1957
7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
toins
3c6410111b subs renamed according to coding guidelines. 2006-07-21 10:10:29 +00:00
rangi
f30b030af8 Code to allow the associated borrowers to work 2006-06-20 22:35:47 +00:00
bob_lyon
9161eba4bd merging katipo changes... 
Adding flag for being in credit vs being in debt and added checks to see if
one can renew before trying to renew
 2006-06-07 04:13:22 +00:00
alaurin
0f00577a9e bug fix : for item reservation, now the system don't keep the reserve if the document is returned, works fine !!!! 2006-06-06 12:26:57 +00:00
alaurin
795fffef13 Improvements for reserves infos in circulation.pl 
new infos displayed :

 -Waiting position of borrower on document reserve .
 -Follow the document he's in transfert 	.
 -more infos of document are displayed in a specific cell ....

N.B : the old display of reserves infos are only commented, will be removed, if new display is ok for everybody ...
 2006-06-01 10:03:08 +00:00
rangi
c1c08d65b1 Allows a person to choose an associated borrower (orgranisation) when Issuing. 
This is to allow a person who is associated with many organisations to choose the one he/she is borrowing an item for

No changes to the issuing code, or the issues table, the associated borrower number is stored in the statistics table
 2006-06-01 01:44:16 +00:00
plg
dc986ecac5 bug fixed: the issue timestamp had not the same format as the today's date 
to which it was compared. The comparison separate issues on display between
today issues and older issues.
 2006-03-31 15:31:44 +00:00
tipaul
d5938493d7 synch'ing head and rel_2_2 (from 2.2.5, including npl templates) 
Seems not to break too many things, but i'm probably wrong here.
at least, new features/bugfixes from 2.2.5 are here (tested on some features on my head local copy)

- removing useless directories (koha-html and koha-plucene)
 2006-01-06 16:39:37 +00:00
tipaul
b38997925f big commit, still breaking things... 
* synch with rel_2_2. Probably the last non manual synch, as rel_2_2 should not be modified deeply.
* code cleaning (cleaning warnings from perl -w) continued
 2005-10-26 09:11:02 +00:00
tipaul
e82eca42c9 see mail on koha-devel : code cleaning on Search.pm + normalizing API + use of biblionumber everywhere (instead of bn, biblio, ...) 2005-09-22 10:01:45 +00:00
genjimoto
f9d2fa784c modified script to enable circulation system to show picture of borrower for verification purposes. 2005-08-22 12:53:48 +00:00
oleonard
98687d85ad Synch with rel_2_2: Fixing section that was supposed to allow for alternating table row colors 2005-07-19 18:52:37 +00:00
tipaul
4dea4ae494 synch'ing 2.2 and head 2005-05-04 08:50:48 +00:00
tipaul
93ff09d081 merging 2.2 branch with head. Sorry for not making it before, many many commits done here 2005-03-01 13:40:35 +00:00
oleonard
cb2dc1d759 Adding 'flagged' variable to help control display in the template 2005-02-16 22:25:17 +00:00
oleonard
ea39d8bd8f Adding email address to list of returned variables 2005-02-10 17:27:32 +00:00